#50349 - [PATCH] packages: Add 'define-package' syntax.

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #50 received at 50349@debbugs.gnu.org (full text, mbox, reply):

Received: (at 50349) by debbugs.gnu.org; 4 Sep 2021 21:01:18 +0000
From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 04 17:01:18 2021
Received: from localhost ([127.0.0.1]:48790 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1mMcms-0003l8-Co
	for submit@debbugs.gnu.org; Sat, 04 Sep 2021 17:01:18 -0400
Received: from mail-wr1-f52.google.com ([209.85.221.52]:42668)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <taylan.kammer@gmail.com>) id 1mMcmq-0003ke-5P
 for 50349@debbugs.gnu.org; Sat, 04 Sep 2021 17:01:16 -0400
Received: by mail-wr1-f52.google.com with SMTP id q11so3730014wrr.9
 for <50349@debbugs.gnu.org>; Sat, 04 Sep 2021 14:01:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language;
 bh=5hhwHvW49lMNzh6nemUggw8XQ1Nq9kOl/tu0OfArC0w=;
 b=BH27nELAFn8BxiAxSJNLi9tK5mIKooqkRzkF42vlDPrhxT4GRPbOiAwYG6tK7b4G+I
 4PrvFBQUYWevIqBtOMvsnS2FZKFggA9vmwVqDIOqyWb5UlZ009YRI3jjocuuF1Drw5Gt
 IgfteXHvH6t4qjFFTh4MBjobjs30Doh8t2/L6DRBhsiJtKagjV595NOgxGrCghLdqbDz
 DLxj4zfudCntD8IB5FiuHOmcOg9aUFTjUzigpQ8ylt5D5lBmADQ69zB2leDOaDnXprfm
 Zo6sKV4nWSWhA2yodSV3N0Mzk6oeS/eVY3JIdV6qXMnozA9fPh/iONki2jtEWe2KvRPH
 BdkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language;
 bh=5hhwHvW49lMNzh6nemUggw8XQ1Nq9kOl/tu0OfArC0w=;
 b=DW2o0CknoZ1JaHGEalut3Y0DaTgJscWNJrBNwtEr1Imrh8OrZP043n9RNbqSe5UeLT
 iJd29CQr0NfnlWdEINWw1Em4ExgrsmAeQQY7YgAei2UoH9MqUf1yx9o37eucVAZ7CWlR
 e2ttsNSAmDPaJgflqSy1j8pNvIJ04fsGNMWI5VG/VG9SNqERbZdS1DoAwr8PjSMKUtec
 lmpJJmXmormtrltYeHidFkfE9vOfI0dVhxM17BVCTfnuV2hqRgIzMF9aixNsv3iphUoB
 1kOHkVmbYohtKSki9wcy3ZMdCjiD2otwzyeykTEGvS5gaSaCGK5kUaQUbPEH7WggGdby
 U2zw==
X-Gm-Message-State: AOAM5308Hab97Xc8AD88hWzumiLN/uj/xqpunb6t6CAfhj3rcdubMaPw
 vD/zY0ZBKvnFVKjO3mYchB0=
X-Google-Smtp-Source: ABdhPJxnPzRR7j4rQFCvrLJjwUWxKvP1V7+aGPJESO4MWVJ+xmbr+/MobprWuR3cBG2MaLWfkmTPkw==
X-Received: by 2002:adf:f889:: with SMTP id u9mr5603847wrp.67.1630789270294;
 Sat, 04 Sep 2021 14:01:10 -0700 (PDT)
Received: from [192.168.178.20] (b2b-109-90-125-150.unitymedia.biz.
 [109.90.125.150])
 by smtp.gmail.com with ESMTPSA id n1sm2972812wrp.49.2021.09.04.14.01.08
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 04 Sep 2021 14:01:09 -0700 (PDT)
Subject: Re: bug#50349: [PATCH] packages: Add 'define-package' syntax.
To: Sarah Morgensen <iskarian@mgsn.dev>
References: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@mgsn.dev>
 <757b7543b931335c3725264edfbc79c012aa10fc.camel@telenet.be>
 <87y28caazy.fsf@nckx> <95c92fc5-1fcf-b347-370e-d1943f22c2c3@gmail.com>
 <87bl58wfk7.fsf@nckx> <a93161dd-4425-f722-fa43-273ff9561916@gmail.com>
 <86v93gjhps.fsf@mgsn.dev>
From: Taylan Kammer <taylan.kammer@gmail.com>
Message-ID: <5e71792b-ac49-65db-13f0-e06fbcbdec1f@gmail.com>
Date: Sat, 4 Sep 2021 23:01:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <86v93gjhps.fsf@mgsn.dev>
Content-Type: multipart/mixed; boundary="------------D6DFB48F63378771DEA01CA8"
Content-Language: en-US
X-Debbugs-Envelope-To: 50349
Cc: Maxime Devos <maximedevos@telenet.be>, Tobias Geerinckx-Rice <me@tobias.gr>,
 50349@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>

[Message part 1 (text/plain, inline)]

On 04.09.2021 20:53, Sarah Morgensen wrote:

> 
> If you were really interested, I suppose you could test with compilation
> optimization off, but I'd be more interested in the performance impact
> with (guix packages) imported.
> 
> --
> Sarah
> 

Good questions.  Let's see.  Caching shouldn't be an issue by the way since
I always time a command several times and make sure it's consistent.

With -O0 and -O1, both files take a negligible amount of time to compile,
approximately 0.25s and 0.3s.  A difference of 0.5s for 512 packages means
about 0.001s per package, which at 100K packages would be 100s.

That's without importing (guix packages) though.  When I import it, then
at -O0 and -O1 (I think these are equivalent), the define-packages one
takes about 3.8s and the regular one about 3.5s.  So the difference has
actually shrunk down to about 0.3s now.

With (guix packages) and no special optimization flag, the define-packages
one takes about 26s, and the regular one still shows the strange behavior
where the time explodes to over a minute.

If I remember correctly though, Guix uses -O1 to compile packages anyway.

So all in all I *think* we can say that the macro induces no important
performance hit.  (And could for some reason significantly improve it if
we compile a large chunk of packages on -O2...)

One thing I should note though is that I'm using a top-of-the-line typical
consumer CPU (Ryzen 9 3900X) so on an older machine, or a CPU brand that
puts more value into freedom and security than performance, the results
may be different.  I still doubt that the impact would be big.

Attached are new scm files since I had to add some fields to make sure
the package macro from (guix packages) doesn't abort the compilation.

-- 
Taylan

[test1.scm (text/plain, attachment)]

[test2.scm (text/plain, attachment)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 16:07:29 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#50349 [PATCH] packages: Add 'define-package' syntax.