#50238 - [PATCH] build-self: Try printing nicer error messages.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #11 received at 50238@debbugs.gnu.org (full text, mbox, reply):

Received: (at 50238) by debbugs.gnu.org; 8 Mar 2022 18:58:57 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 13:58:57 2022
Received: from localhost ([127.0.0.1]:57912 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1nRf2v-0001X5-2D
	for submit@debbugs.gnu.org; Tue, 08 Mar 2022 13:58:57 -0500
Received: from baptiste.telenet-ops.be ([195.130.132.51]:53194)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@telenet.be>) id 1nRf2t-0001Wu-Cg
 for 50238@debbugs.gnu.org; Tue, 08 Mar 2022 13:58:56 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by baptiste.telenet-ops.be with bizsmtp
 id 3uyt2700C4UW6Th01uytgs; Tue, 08 Mar 2022 19:58:53 +0100
Message-ID: <89a84004d1fbc60f7d13eb91cb2d8239beb506d8.camel@telenet.be>
Subject: Re: [PATCH] build-self: Try printing nicer error messages.
From: Maxime Devos <maximedevos@telenet.be>
To: 50238@debbugs.gnu.org
Date: Tue, 08 Mar 2022 19:58:45 +0100
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-dJz+vNIFTcvwNWB0LZMw"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1646765933; bh=oGPTznt3cnM7hIHjiJFdp9c14Z3H6AE/pQh6fwP2gJs=;
 h=Subject:From:To:Cc:Date;
 b=XecpZULteh7AM9u+AGZ1KWhtB+EPzqULtAcksWIULpSV4DDnP707g+U1pEcRPFK9V
 /b6L4kK60oB8UVm0PrqZIf+TU6VAkO7Wn16FI9BxZ3ae0qJuv/pn5/RWIdX8MWaPdI
 l1GyJtM+tLV/uLMxL23GEIFSNCVaW58phlEFcs8zPMsQQw1bjd7uSDqpli2VN0MO1W
 Hg12sRiocVVzmA/TgBGGb9usKbZ6q7J1u+wR/JvVrJcQ/Rpazeol04snT+3ECgPxx6
 773j7EtMQ0F6p0HPdtxe1+xS16K/ZCybgIGkUIhLB3ERbxLqhsg8oE/N6zC7W9Iivj
 jxE7aDm9HxN5Q==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 50238
Cc: ludo@gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

[Message part 1 (text/plain, inline)]

> I sympathize with the goal but unsure about the implementation.
> 
> To me, compute-guix-derivation should remain as simple as possible
> and it shouldn't take care of UI concerns.  Having said that, I don't
> know how to address the problem above while sticking to this
> principle.
>
> WDYT?

*Something* should take care of UI concerns, and 'build-program' is in
a good position to do so.  I don't really see another way to do it
(except by serialising the exception and letting the Guix that is doing
the pulling report it, but that's even more fragile).  Where else could
the UI bits be done?

Additionally, while importing (guix ui) may seem rather daunting,
the error handling bits are only run when there's actually an error to
handle, so I expect it to be fine in practice --- it seems only
possible for this to break "guix pull" if "guix pull" would have failed
anyway.

I have one concern though: (guix ui) used with-exception-handler which
is new-ish with Guile 3.0 IIUC.  Do we need to support pulling from a
Guix of version Guile <2.2?  If so, a little compatibility code may
be necessary -- e.g., not doing the 'with-error-handling' when guile-
version=2.2.

I think the little bit of extra non-simplicity is worth the clarity
(not very much, but still useful) it brings to people on bug-guix and
people reporting the ‘guix pull: error: You found a bug: ...’ issues --
-- see the long list at
<https://issues.guix.gnu.org/search?query=%22you+found+a+bug%22>, and
compare it with the two extra lines of code.

In other terms, if we do a risk-benefit analysis, there is some risk,
but due to the large number of reports there would be much benefit.
And even though there is some risk (see e.g. the Guile 2.2/3.0 thing
above), whenever such an accident happens, it could quickly addressed
by pushing a new commit.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 16:47:13 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#50238 [PATCH] build-self: Try printing nicer error messages.