#48915 - [PATCH] gnu: polkit: Graft a replacement for CVE-2021-3560.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #13 received at 48915@debbugs.gnu.org (full text, mbox, reply):

Received: (at 48915) by debbugs.gnu.org; 8 Jun 2021 21:32:44 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 17:32:44 2021
Received: from localhost ([127.0.0.1]:59919 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1lqjL1-0007Ny-UF
	for submit@debbugs.gnu.org; Tue, 08 Jun 2021 17:32:44 -0400
Received: from eggs.gnu.org ([209.51.188.92]:39368)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1lqjL0-0007Nk-9b
 for 48915@debbugs.gnu.org; Tue, 08 Jun 2021 17:32:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:47360)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>)
 id 1lqjKu-00008B-RM; Tue, 08 Jun 2021 17:32:36 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36242 helo=ribbon)
 by fencepost.gnu.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>)
 id 1lqjKu-0003bq-Jv; Tue, 08 Jun 2021 17:32:36 -0400
From: Ludovic Courtès <ludo@gnu.org>
To: Leo Famulari <leo@famulari.name>
Subject: Re: bug#48915: [PATCH] gnu: polkit: Graft a replacement for
 CVE-2021-3560.
References: <20210608084512.29608-1-ludo@gnu.org>
 <YL+uaU2KyAfAB9+X@jasmine.lan>
Date: Tue, 08 Jun 2021 23:32:35 +0200
In-Reply-To: <YL+uaU2KyAfAB9+X@jasmine.lan> (Leo Famulari's message of "Tue, 8
 Jun 2021 13:52:41 -0400")
Message-ID: <87zgw0caa4.fsf_-_@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48915
Cc: 48915@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Leo Famulari <leo@famulari.name> skribis:

> On Tue, Jun 08, 2021 at 10:45:12AM +0200, Ludovic Courtès wrote:
>> +(define-public polkit/fixed
>> +  (package
>> +    (inherit polkit)
>> +    (version "0.11A")                             ;0.116 + patch
>> +    (source (origin
>> +              (inherit (package-source polkit))
>> +              (patches (search-patches "polkit-CVE-2021-3560.patch"))))))
>
> Typically, we don't change the version when creating replacement
> packages that apply a patch. We only change the version when the
> replacement package actually updates to a new version.

Pushed as 9178566954cc7f34d2d991d31df4565adad93508!

As discussed on IRC, I ended up making ‘polkit/fixed’ private, with the
version string unchanged (inherited from ‘polkit’).

We wondered whether Cuirass would build ‘polkit/fixed’ if it’s private.
Turns out it does, but this comment in (gnu ci) is still valid:

--8<---------------cut here---------------start------------->8---
(define (all-packages)
  "Return the list of packages to build."
  (define (adjust package result)
    (cond ((package-replacement package)
           ;; XXX: If PACKAGE and its replacement have the same name/version,
           ;; then both Cuirass jobs will have the same name, which
           ;; effectively means that the second one will be ignored.  Thus,
           ;; return the replacement first.
           (cons* (package-replacement package)   ;build both
                  package
                  result))
--8<---------------cut here---------------end--------------->8---

IOW, the replacement, and only the replacement, gets built.

The current ‘zstd’ replacement is private
<https://ci.guix.gnu.org/search?query=system%3Ax86_64-linux+spec%3Amaster+zstd>
only shows derivations for the replacement, not for the original one.
That’s okay though because the original one necessarily got built
earlier.

Thanks,
Ludo’.

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sat Dec 21 18:38:59 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#48915 [PATCH] gnu: polkit: Graft a replacement for CVE-2021-3560.