#48314 - [PATCH] Install guix system on Raspberry Pi

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #17 received at 48314@debbugs.gnu.org (full text, mbox, reply):

Received: (at 48314) by debbugs.gnu.org; 19 Jun 2021 19:04:26 +0000
From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 15:04:25 2021
Received: from localhost ([127.0.0.1]:60805 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1lugGX-0005M4-Nb
	for submit@debbugs.gnu.org; Sat, 19 Jun 2021 15:04:25 -0400
Received: from dd26836.kasserver.com ([85.13.145.193]:55500)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@scratchpost.org>) id 1lugGV-0005Lu-0h
 for 48314@debbugs.gnu.org; Sat, 19 Jun 2021 15:04:24 -0400
Received: from localhost (84-115-233-88.cable.dynamic.surfer.at
 [84.115.233.88])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id 589F13366D34;
 Sat, 19 Jun 2021 21:04:21 +0200 (CEST)
Date: Sat, 19 Jun 2021 21:04:17 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Stefan <stefan-guix@vodafonemail.de>
Subject: Re: [bug#48314] Patches to install guix system on Raspberry Pi
Message-ID: <20210619210417.67c21720@scratchpost.org>
In-Reply-To: <53799D56-08BA-401A-BC09-81BA61736AAC@vodafonemail.de>
References: <19E4796A-B0DB-444F-8773-2E8D3EF6132D@vodafonemail.de>
 <53799D56-08BA-401A-BC09-81BA61736AAC@vodafonemail.de>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/O5TIUvI4qrn+FQ=OYXBA7=3";
 protocol="application/pgp-signature"; micalg=pgp-sha512
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48314
Cc: 48314@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

[Message part 1 (text/plain, inline)]

Hi Stefan,

In 04-gnu-bootloader-add-u-boot.patch, I think that having #:name is too magical
(it still only replaces part of the package name, and then still only after
substitution).  But if made non-magical, then it has too little benefit.

Likewise for #:description.

If it's alright with you, can we just drop #:name xxx and #:description xxx
altogether and instead do:

(define-public u-boot-rpi-3-efi
  (package
    (inherit
     (make-preinstalled-u-boot-package
      "rpi_3_32b"
      "arm-linux-gnueabihf"
      #:name "rpi-3-efi"
      #:configs %u-boot-rpi-efi-configs
      #:description %u-boot-rpi-efi-description-32-bit))
    (name "u-boot-rpi-3-efi")
    (description %u-boot-rpi-efi-description-32-bit)))

And similar for all the other u-boot definitions, and for
the usage of make-u-boot-package inside make-preinstalled-u-boot-package ?

Or are there upsides to doing it like you did it?

I'm aware that the same can be said for "board" ... which is used already.
However, that parameter is also used for something else, so it needs to be there.

NAME isn't used for anything else but for doing what a regular package inherit
could do anyway.  Is there a downside when using package inherit?

[Message part 2 (application/pgp-signature, inline)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 14:33:24 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#48314 [PATCH] Install guix system on Raspberry Pi