#47188 "guix lint -c cve" does not account for language prefixes (rust-,python-,go-,..)

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Léo Le Bouter <lle-bout@zaclys.net>

To: bug-guix@gnu.org

Subject: "guix lint -c cve" does not account for language prefixes (rust-,python-,go-,..)

Date: Tue, 16 Mar 2021 10:29:43 +0100

[Message part 1 (text/plain, inline)]

./pre-inst-env guix lint -c cve python-urllib3@1.26.2
Here this should return at least CVE-2021-28363 but it does not because
the CVE database contains urllib3 and not python-urllib3 (which AFAICT
the cve linter searches for).

Annotating each and every python-, go-, and rust- package with cpe-name 
properties is going to be very annoying. I suggest we add some
heuristics that try both the full name and prefix-trimmed name. python-
urllib3's cpe name and vendor is python (vendor) urllib3 (name).

Same story for CVE-2021-28305 and rust-diesel, though it doesnt even
have a CPE entry yet.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 47188@debbugs.gnu.org (full text, mbox, reply):

From: zimoun <zimon.toutoune@gmail.com>

To: Léo Le Bouter <lle-bout@zaclys.net>

Cc: 47188@debbugs.gnu.org

Subject: Re: bug#47188: "guix lint -c cve" does not account for language prefixes (rust-, python-, go-, ..)

Date: Tue, 16 Mar 2021 14:05:13 +0100

Hi,

On Tue, 16 Mar 2021 at 10:30, Léo Le Bouter via Bug reports for GNU
Guix <bug-guix@gnu.org> wrote:

> ./pre-inst-env guix lint -c cve python-urllib3@1.26.2
> Here this should return at least CVE-2021-28363 but it does not because
> the CVE database contains urllib3 and not python-urllib3 (which AFAICT
> the cve linter searches for).

Does the CVE use the upstream name?  Or a normalized name?

I mean, in the R world, packages can have names as 'org.EcK12.eg.db'
which becomes "r-org-eck12-eg-db".  To easy the mapping for updating
and co, the package definition contains:

    (properties
     `((upstream-name . "org.EcK12.eg.db")))

Maybe, it could be worth to have similar things.  WDYT?


All the best,
simon

Message #11 received at 47188@debbugs.gnu.org (full text, mbox, reply):

From: Ludovic Courtès <ludo@gnu.org>

To: Léo Le Bouter <lle-bout@zaclys.net>

Cc: 47188@debbugs.gnu.org

Subject: Re: bug#47188: "guix lint -c cve" does not account for language prefixes (rust-,python-,go-,..)

Date: Thu, 18 Mar 2021 14:26:18 +0100

Hi,

Léo Le Bouter <lle-bout@zaclys.net> skribis:

> ./pre-inst-env guix lint -c cve python-urllib3@1.26.2
> Here this should return at least CVE-2021-28363 but it does not because
> the CVE database contains urllib3 and not python-urllib3 (which AFAICT
> the cve linter searches for).
>
> Annotating each and every python-, go-, and rust- package with cpe-name 
> properties is going to be very annoying. I suggest we add some
> heuristics that try both the full name and prefix-trimmed name. python-
> urllib3's cpe name and vendor is python (vendor) urllib3 (name).
>
> Same story for CVE-2021-28305 and rust-diesel, though it doesnt even
> have a CPE entry yet.

Yes, that’s an issue.  We can address these by adding a ‘cpe-name’
property (info "(guix) Invoking guix lint"), but that’s going to be
tedious.  We can at least add it to high-profile packages for now.

Tooling that suggests or deduces the CPE name would help a lot:

  https://issues.guix.gnu.org/42299

Ludo’.

Send a report that this bug log contains spam.