#47144 - security patching of 'patch' package

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #62 received at 47144@debbugs.gnu.org (full text, mbox, reply):

Received: (at 47144) by debbugs.gnu.org; 1 Jun 2024 15:04:11 +0000
From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 11:04:11 2024
Received: from localhost ([127.0.0.1]:57085 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1sDQHD-0002e9-8D
	for submit@debbugs.gnu.org; Sat, 01 Jun 2024 11:04:11 -0400
Received: from mail-qk1-f173.google.com ([209.85.222.173]:46453)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@gmail.com>) id 1sDQHB-0002dv-9L
 for 47144@debbugs.gnu.org; Sat, 01 Jun 2024 11:04:10 -0400
Received: by mail-qk1-f173.google.com with SMTP id
 af79cd13be357-794c3946468so218300485a.1
 for <47144@debbugs.gnu.org>; Sat, 01 Jun 2024 08:03:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1717254172; x=1717858972; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=BCw8gEREcDWX/BAFi8wHItPGSrCCpMVLSNe5av+T5sY=;
 b=U7UOoRXFhfRxjgLbS8ZzcAh2vg+QvkuxEMsKDrYDEc53YA5QRuIm3mPcZd1O5DxCNv
 VDzHBgSfvrjAXK5b413EoX2zDfheH46+gt8ggSQ7iEw2h6FJRL4az4n6JLiEY1d6wfhf
 XwPV5m9hwrjmPgjZ52193dC5OgZ4yOSoLB5qJbyHDc2TTiveVlttoP4xw4fIPs6eZXF7
 0c/Zi/R8rPYW1viMrH4M/vUldBBLzJG8/xc+XCWd6W0KAPkUOh3ik2Wp8ZbKuhkdOZmo
 VwQR/vUUNgkZzNQs3/Sk7MEIAYIddUiQIbGdE2hf3apUCk6IShoVdUUpeTY+uI09vPA4
 tHrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1717254172; x=1717858972;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=BCw8gEREcDWX/BAFi8wHItPGSrCCpMVLSNe5av+T5sY=;
 b=NwMxb5FqGisRj2AP6EiOxk7MH58zNqP/O+s308QNvfAuXqvrIyTODMO9IYmAEp9MWb
 Gmu2mVrDbPZ9nJElP091zKZGJP2M5EaA1QDWUECTbDua8fErUeGBd2BTeAo/Av1Pvdvc
 Nq9Mike2epR9PpuJ3qrEMxCSaTxi2IWeFfGQKfuw+mvZwwh4+zdi/5/IQdME5WFfhTkU
 9J1xzQXKSMLUIC8/FfTDj0GtPrJAr/TBzmedHU5rC3K1l1KjzZE8ybtSJylsfVh4FDKM
 a5blMzyJ0xJRvd4+0booDOrBKzlO+i4H6Kv3/tGQHan2AoNLmaAUQwmr/XK2F7Um0WqA
 3Q+Q==
X-Gm-Message-State: AOJu0YzU3HQf/oF0hAWE6ZF67Vqwe+2Ypa2NcLeumhK3lg4hAJ8KHi3o
 654mUTgN3ZIOva8k65swmuyJ3P25hM16i1toy26A4fMZ83giUQkS
X-Google-Smtp-Source: AGHT+IGZShCRmURx1QcdyFE1Irn23PJogCXNZjBJ2clHNs6S8UOnIyUiwyiQx4iOj291pj4LItDykQ==
X-Received: by 2002:a37:e10b:0:b0:794:f011:7a3a with SMTP id
 af79cd13be357-794f5ba9aedmr503473085a.0.1717254171605; 
 Sat, 01 Jun 2024 08:02:51 -0700 (PDT)
Received: from hurd (dsl-10-130-93.b2b2c.ca. [72.10.130.93])
 by smtp.gmail.com with ESMTPSA id
 af79cd13be357-794f2f136fbsm138695285a.53.2024.06.01.08.02.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 01 Jun 2024 08:02:51 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Ludovic Courtès <ludo@gnu.org>
Subject: Re: [PATCH 3/3] gnu: patch: Graft to latest commit [security fixes].
In-Reply-To: <87r0dgn36w.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 01 Jun 2024 16:32:55 +0200")
References: <28b457771ab0e7ad87cb65600a5898f68be5074a.1717124361.git.maxim.cournoyer@gmail.com>
 <5eda21a09360653b198f1b0d7f52cf531dc97485.1717124361.git.maxim.cournoyer@gmail.com>
 <87r0dgn36w.fsf@gnu.org>
Date: Sat, 01 Jun 2024 11:02:49 -0400
Message-ID: <875xusln8m.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 47144
Cc: Mark H Weaver <mhw@netris.org>, Leo Famulari <leo@famulari.name>,
 Vivien Kraus <vivien@planete-kraus.eu>, 47144@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>>  (define-public patch
>>    (package
>> +    (replacement patch/fixed)
>
> Unless I’m mistaken, this will have practically no effect because Patch
> is a build-time-only dependency.
>
> My recommendation would be to not add a ‘replacement’ field at all.
> Instead, you could add a new ‘patch/latest’ public variable pointing to
> that commit that you picked.  That way, users running ‘guix install
> patch’ or similar will get the latest version of Patch.

I see what you mean, but for all practical purposes, using a graft seems
a more thorough (because it affects the original 'patch' *variable* as
well) means that have the same effect for users, so I'd seems like a
slightly better option to me.

So e.g. someone using the Guix API referencing exactly to the 'patch'
package variable would get a secure version, but would otherwise need to
know to adjust their code to use 'patch/latest'.

Does that make sense?

-- 
Thanks,
Maxim

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sat Dec 21 17:16:02 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#47144 security patching of 'patch' package