GNU bug report logs

#47144 security patching of 'patch' package

PackageSource(s)Maintainer(s)
guix PTS Buildd Popcon
Full log

Message #44 received at 47144@debbugs.gnu.org (full text, mbox, reply):

Received: (at 47144) by debbugs.gnu.org; 1 Jun 2024 01:50:54 +0000
From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 21:50:53 2024
Received: from localhost ([127.0.0.1]:55515 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1sDDtV-0007wx-I8
	for submit@debbugs.gnu.org; Fri, 31 May 2024 21:50:53 -0400
Received: from mail-qv1-f50.google.com ([209.85.219.50]:45060)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@gmail.com>) id 1sDDtS-0007wi-8i
 for 47144@debbugs.gnu.org; Fri, 31 May 2024 21:50:51 -0400
Received: by mail-qv1-f50.google.com with SMTP id
 6a1803df08f44-6ae4d4abeb8so8388386d6.2
 for <47144@debbugs.gnu.org>; Fri, 31 May 2024 18:50:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1717206573; x=1717811373; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=BThhnKqg9YJAvN/B30JE8DGfQ8rydSKm/NZKoVaEUPY=;
 b=Pba3Hssqgzd5DEy6soLEBLsBA68Ue2A2kOQ2Be3hf6BmqiQtGD0Taigs9S3lwfzldm
 FRgfkIIpHO0T82DNjz7R7NFZfLN997AV2LmHdjZhQzbaRKmVo6BJo1RHvirEqbi54tud
 TeynKskgnyTmJ7DXObK77h5YyUR0jUDCZULq1V5QFzk+hd4aJy0Su8DHKT9Psbm+POHW
 cz1sZvbP6JwcR87B9V7kd7y+Z3o0Rk9iu1kpARlKJJwkON4by+X/0pXOhCmOeFFpDBJV
 cUZ1V6DUHrJLbe6Fp23r7gDaDxk8TWQpfTjmHnPxThzEQ1rZl1btjSWJq5VF1jAJbh3I
 ZoMg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1717206573; x=1717811373;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=BThhnKqg9YJAvN/B30JE8DGfQ8rydSKm/NZKoVaEUPY=;
 b=nceWnkNFRGJGSFNI9parYzf3slMgCGvlvQ01GV6wErH40FrYGuga3V7IyWrXTvkPE/
 PEfdRDwc1ZK797Gzb97sCwQ/vxqaWmkfIgCozQ08IOp0ghDB4bOIARWEwc+4Tom1p3AA
 SZLdd75XeyEeuDfix306r3sXANVXIPLDSqAsf/w/NA1mDOh9A1lyJUy7HopSRPixV946
 NPKEWlMMRSnN7sYmr4gcGLl9Ab3JcwCPVsr8h7iJo88tWN6wlxu+JyNrwVCfDl04y+G8
 uFXDyD5XbCteERcWUdsWs3BHS6v1luviQd1NOt+fOgGq2ou2Bq4Ou2tHFsV2Ox+vikGa
 MYMw==
X-Gm-Message-State: AOJu0YzZgqdd8wUzYhhE2VV3P8tjsx1KXh0AILKuzV+ksiWg2ob7VV+n
 u3B+CbRa5aPYmjtYjaAZ669mza5TSLP8v42lQ5YQyp/QKHyF9sXr
X-Google-Smtp-Source: AGHT+IGpvRm2xvG24RjHuHuHE+dLCQzfvq1ZdJuWiXm33fy0bJs9MQbip68eqankGiNxIaT+M+WwuA==
X-Received: by 2002:ad4:58ac:0:b0:6ae:ceb8:4760 with SMTP id
 6a1803df08f44-6aeceb84772mr29743886d6.2.1717206573080; 
 Fri, 31 May 2024 18:49:33 -0700 (PDT)
Received: from hurd (dsl-205-233-124-92.b2b2c.ca. [205.233.124.92])
 by smtp.gmail.com with ESMTPSA id
 6a1803df08f44-6ae4a7482b3sm11024686d6.52.2024.05.31.18.49.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 31 May 2024 18:49:32 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Subject: Re: bug#47144: [PATCH 3/3] gnu: patch: Graft to latest commit
 [security fixes].
In-Reply-To: <87zfs62c4z.fsf@gmail.com> (Simon Tournier's message of "Fri, 31
 May 2024 18:13:00 +0200")
References: <28b457771ab0e7ad87cb65600a5898f68be5074a.1717124361.git.maxim.cournoyer@gmail.com>
 <5eda21a09360653b198f1b0d7f52cf531dc97485.1717124361.git.maxim.cournoyer@gmail.com>
 <87zfs62c4z.fsf@gmail.com>
Date: Fri, 31 May 2024 21:49:31 -0400
Message-ID: <87ikytctzo.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 47144
Cc: Mark H Weaver <mhw@netris.org>,
 Ludovic Courtès <ludo@gnu.org>,
 Leo Famulari <leo@famulari.name>, Vivien Kraus <vivien@planete-kraus.eu>,
 47144@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi Maxim,
>
> On Thu, 30 May 2024 at 22:59, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> +      (source (origin
>> +                (inherit (package-source patch))
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url "https://git.savannah.gnu.org/git/patch.git")
>> +                      (commit commit)))
>> +                (file-name (git-file-name name version))
>> +                (sha256
>> +                 (base32
>> +                  "1bk38169c0xh01b0q0zmnrjqz8k9byz3arp4q7q66sn6xwf94nvz"))))
>
> If I read correctly, (package-source patch) reads:
>
>     (source (origin
>               (method url-fetch)
>               (uri (string-append "mirror://gnu/patch/patch-"
>                                   version ".tar.xz"))
>               (sha256
>                (base32
>                 "1zfqy4rdcy279vwn2z1kbv19dcfw25d2aqy9nzvdkq5bjzd0nqdc"))
>               (patches (search-patches "patch-hurd-path-max.patch"))))
>
> Therefore the only thing that is copied is the ’patches’ field.  Right?
>
> I think it would easy the readability to avoid ’inherit’ and plainly
> write ’patches’.

I preferred inheritance to avoid having to manually sync things in the
long run... (hopefully the graft gets ungrafted before 'patch' amasses
new phatces, but we never know...)

-- 
Thanks,
Maxim

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Mon Dec 30 18:02:02 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.