#46362 - got unexpected path `Backtrace:' from substituter

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #28 received at 46362-done@debbugs.gnu.org (full text, mbox, reply):

Received: (at 46362-done) by debbugs.gnu.org; 9 Apr 2021 16:11:03 +0000
From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 09 12:11:03 2021
Received: from localhost ([127.0.0.1]:50741 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1lUtik-0006Zf-27
	for submit@debbugs.gnu.org; Fri, 09 Apr 2021 12:11:03 -0400
Received: from eggs.gnu.org ([209.51.188.92]:55554)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1lUtif-0006ZL-Hu
 for 46362-done@debbugs.gnu.org; Fri, 09 Apr 2021 12:10:56 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:52746)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>) id 1lUtia-0000gI-Bw
 for 46362-done@debbugs.gnu.org; Fri, 09 Apr 2021 12:10:48 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44876 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@gnu.org>) id 1lUtia-0001jN-0W
 for 46362-done@debbugs.gnu.org; Fri, 09 Apr 2021 12:10:48 -0400
From: Ludovic Courtès <ludo@gnu.org>
To: 46362-done@debbugs.gnu.org
Subject: Re: bug#46362: got unexpected path `Backtrace:' from substituter
References: <86a6sgcan1.fsf@163.com> <87eeh41rsb.fsf@gnu.org>
 <87h7kjogt9.fsf@gnu.org>
Date: Fri, 09 Apr 2021 18:10:46 +0200
In-Reply-To: <87h7kjogt9.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 06 Apr 2021 12:20:18 +0200")
Message-ID: <87im4v4ewp.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 46362-done
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Ludovic Courtès <ludo@gnu.org> skribis:

>>From d85353dd4bfaa57a7d5803dade91d806a169295a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= <ludo@gnu.org>
> Date: Tue, 6 Apr 2021 12:10:29 +0200
> Subject: [PATCH] daemon: 'guix substitute' replies on FD 4.
>
> This avoids the situation where error messages would unintentionally go
> to stderr and be wrongfully interpreted as a reply by the daemon.
>
> Fixes <https://bugs.gnu.org/46362>.
> This is a followup to ee3226e9d54891c7e696912245e4904435be191c.
>
> * guix/scripts/substitute.scm (display-narinfo-data): Add 'port'
> parameter and honor it.
> (process-query): Likewise.
> (process-substitution): Likewise.
> (%error-to-file-descriptor-4?, with-redirected-error-port): Remove.
> (%reply-file-descriptor): New variable.
> (guix-substitute): Remove use of 'with-redirected-error-port'.  Define
> 'reply-port' and pass it to 'process-query' and 'process-substitution'.
> * nix/libstore/build.cc (SubstitutionGoal::handleChildOutput): Swap
> 'builderOut' and 'fromAgent'.
> * nix/libstore/local-store.cc (LocalStore::getLineFromSubstituter):
> Likewise.
> * tests/substitute.scm <top level>: Set '%reply-file-descriptor'
> rather than '%error-to-file-descriptor-4?'.
> ---
>  guix/scripts/substitute.scm | 183 +++++++++++++++++-------------------
>  nix/libstore/build.cc       |   4 +-
>  nix/libstore/local-store.cc |  12 +--
>  tests/substitute.scm        |   4 +-
>  4 files changed, 95 insertions(+), 108 deletions(-)

Pushed as 2d73086262e1fb33cd0f0f16f74a495fe06b38aa with the
corresponding ‘guix’ package update in
ec8d09ee672e0d357bb5bb597464c8b168f14bfb.

Ludo’.

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Fri Jan 3 00:36:47 2025; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#46362 got unexpected path `Backtrace:' from substituter