#41330 Patch to expose #:scheme-file-regexp in guile build system

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Alex Sassmannshausen <alex@komputilo.eu>

To: "guix-patches\@gnu.org" <guix-patches@gnu.org>

Subject: Patch to expose #:scheme-file-regexp in guile build system

Date: Sat, 16 May 2020 15:37:47 +0200

[Message part 1 (text/plain, inline)]

Hello,

Please see proposition below.  Exposing this argument makes it possible
to only install specific scheme files in a project using the
guile-build-system.

WDYT?

Alex

[0001-build-system-guile-Expose-scheme-file-regexp.patch (text/x-diff, inline)]

From b798fef327c86b82f336e3fec0e96b791032f470 Mon Sep 17 00:00:00 2001
From: Alex Sassmannshausen <alex@komputilo.eu>
Date: Sat, 16 May 2020 15:32:45 +0200
Subject: [PATCH] build-system/guile: Expose #:scheme-file-regexp.

* guix/build-system/guile.scm (%scheme-file-regexp): New variable.
  (guile-build): Accept #:scheme-file-regexp and pass it on to builder.
---
 guix/build-system/guile.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/guix/build-system/guile.scm b/guix/build-system/guile.scm
index 3693014694..45e735b987 100644
--- a/guix/build-system/guile.scm
+++ b/guix/build-system/guile.scm
@@ -29,6 +29,10 @@
   #:export (%guile-build-system-modules
             guile-build-system))
 
+(define %scheme-file-regexp
+  ;; Regexp to match Scheme files.
+  "\\.(scm|sls)$")
+
 (define %guile-build-system-modules
   ;; Build-side modules imported by default.
   `((guix build guile-build-system)
@@ -80,6 +84,7 @@
                       (system (%current-system))
                       (source-directory ".")
                       not-compiled-file-regexp
+                      (scheme-file-regexp %scheme-file-regexp)
                       (compile-flags %compile-flags)
                       (imported-modules %guile-build-system-modules)
                       (modules '((guix build guile-build-system)
@@ -97,6 +102,7 @@
                                 (source
                                  source))
                     #:source-directory ,source-directory
+                    #:scheme-file-regexp ,scheme-file-regexp
                     #:not-compiled-file-regexp ,not-compiled-file-regexp
                     #:compile-flags ,compile-flags
                     #:phases ,phases
-- 
2.23.0

Message #8 received at 41330@debbugs.gnu.org (full text, mbox, reply):

From: Ludovic Courtès <ludo@gnu.org>

To: Alex Sassmannshausen <alex@komputilo.eu>

Cc: 41330@debbugs.gnu.org

Subject: Re: [bug#41330] Patch to expose #:scheme-file-regexp in guile build system

Date: Mon, 18 May 2020 14:30:57 +0200

Hi Alex,

Alex Sassmannshausen <alex@komputilo.eu> skribis:

>>From b798fef327c86b82f336e3fec0e96b791032f470 Mon Sep 17 00:00:00 2001
> From: Alex Sassmannshausen <alex@komputilo.eu>
> Date: Sat, 16 May 2020 15:32:45 +0200
> Subject: [PATCH] build-system/guile: Expose #:scheme-file-regexp.
>
> * guix/build-system/guile.scm (%scheme-file-regexp): New variable.
>   (guile-build): Accept #:scheme-file-regexp and pass it on to builder.

LGTM, dankon!  :-)

Ludo’.

Message #11 received at 41330@debbugs.gnu.org (full text, mbox, reply):

From: Alex Sassmannshausen <alex@komputilo.eu>

To: Ludovic Courtès <ludo@gnu.org>

Cc: 41330@debbugs.gnu.org

Subject: Re: [bug#41330] Patch to expose #:scheme-file-regexp in guile build system

Date: Mon, 18 May 2020 15:38:47 +0200

Saluton,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Alex,
>
> Alex Sassmannshausen <alex@komputilo.eu> skribis:
>
>>>From b798fef327c86b82f336e3fec0e96b791032f470 Mon Sep 17 00:00:00 2001
>> From: Alex Sassmannshausen <alex@komputilo.eu>
>> Date: Sat, 16 May 2020 15:32:45 +0200
>> Subject: [PATCH] build-system/guile: Expose #:scheme-file-regexp.
>>
>> * guix/build-system/guile.scm (%scheme-file-regexp): New variable.
>>   (guile-build): Accept #:scheme-file-regexp and pass it on to builder.
>
> LGTM, dankon!  :-)
>
> Ludo’.

Pushed now.

Thanks for the review!

Alex

Send a report that this bug log contains spam.