GNU bug report logs

#41297 [PATCH] gnu: openctm: Correct inputs vs native-inputs

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Reported by Ekaitz Zarraga <ekaitz@elenq.tech>
Date 2020-05-15T22:59:02
Severity normal
Tags fixed patch
Done Ludovic Courtès <ludo@gnu.org>
Bug is Archived

Reply or subscribe to this bug. View this bug as an mbox, status mbox, or maintainer mbox

Report forwarded to guix-patches@gnu.org:
bug#41297; Package guix-patches. (Fri, 15 May 2020 22:59:02 GMT) (full text, mbox, link).

Acknowledgement sent to Ekaitz Zarraga <ekaitz@elenq.tech>:
New bug report received and forwarded. Copy sent to guix-patches@gnu.org. (Fri, 15 May 2020 22:59:02 GMT) (full text, mbox, link).

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From 417f64adc854e5d717351fec68872ed19a9ac3df Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sat, 16 May 2020 00:49:53 +0200
Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

    * gnu/packages/engineering.scm (openctm): Change inputs
---
 gnu/packages/engineering.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index aec692174a..aab414bf0e 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2557,11 +2557,12 @@ official SDK.")
           (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
       (build-system gnu-build-system)
       (native-inputs
+       `(("pkg-config" ,pkg-config)))
+      (inputs
        `(("mesa" ,mesa)
          ("glu" ,glu)
          ("glut" ,freeglut)
-         ("gtk" ,gtk+-2)
-         ("pkg-config" ,pkg-config)))
+         ("gtk" ,gtk+-2)))
       (arguments
        `(#:tests? #f                              ;no tests
          #:phases
--
2.26.1

Information forwarded to guix-patches@gnu.org:
bug#41297; Package guix-patches. (Fri, 15 May 2020 23:36:02 GMT) (full text, mbox, link).

Message #8 received at 41297@debbugs.gnu.org (full text, mbox, reply):

On 16.05.20 00:57, Ekaitz Zarraga wrote:
> From 417f64adc854e5d717351fec68872ed19a9ac3df Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sat, 16 May 2020 00:49:53 +0200
> Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

Please add a dot add the end of sentences.

>     * gnu/packages/engineering.scm (openctm): Change inputs

Maybe rephrase it to: Move pkg-config to native-inputs.

> ---
>  gnu/packages/engineering.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index aec692174a..aab414bf0e 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2557,11 +2557,12 @@ official SDK.")
>            (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
>        (build-system gnu-build-system)
>        (native-inputs
> +       `(("pkg-config" ,pkg-config)))
> +      (inputs
>         `(("mesa" ,mesa)
>           ("glu" ,glu)
>           ("glut" ,freeglut)
> -         ("gtk" ,gtk+-2)
> -         ("pkg-config" ,pkg-config)))
> +         ("gtk" ,gtk+-2)))
>        (arguments
>         `(#:tests? #f                              ;no tests
>           #:phases
> --

Otherwise it looks good.

Information forwarded to guix-patches@gnu.org:
bug#41297; Package guix-patches. (Sat, 16 May 2020 09:58:02 GMT) (full text, mbox, link).

Message #11 received at 41297@debbugs.gnu.org (full text, mbox, reply):

Hi,

>
> Maybe rephrase it to: Move pkg-config to native-inputs.
>

In fact, the pkg-config is the only one that it's not moved. The change is moving all of the others to inputs.

I really bad at describing what I did. I don't know how to say it short and accurately :D

Thanks!

Information forwarded to guix-patches@gnu.org:
bug#41297; Package guix-patches. (Sat, 16 May 2020 10:08:02 GMT) (full text, mbox, link).

Message #14 received at 41297@debbugs.gnu.org (full text, mbox, reply):

On 16.05.20 11:57, Ekaitz Zarraga wrote:
> Hi,
>
>>
>> Maybe rephrase it to: Move pkg-config to native-inputs.
>>
>
> In fact, the pkg-config is the only one that it's not moved. The change is moving all of the others to inputs.
>
> I really bad at describing what I did. I don't know how to say it short and accurately :D

Ah, so it's the other way round. So move mesa, glu, glut and gtk+-2 to
inputs.

Information forwarded to guix-patches@gnu.org:
bug#41297; Package guix-patches. (Sat, 16 May 2020 10:26:02 GMT) (full text, mbox, link).

Message #17 received at 41297@debbugs.gnu.org (full text, mbox, reply):

Hi,

> Ah, so it's the other way round. So move mesa, glu, glut and gtk+-2 to
> inputs.

Short and accurate. Thanks

Here it goes:



From 9e6f5503fd8837bcbb03eed3a05d6105b1752fc3 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sat, 16 May 2020 12:22:09 +0200
Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs

    * gnu/packages/engineering.scm (openctm): Move mesa, glu, glut and
    gtk+-2 to inputs
---
 gnu/packages/engineering.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index aec692174a..aab414bf0e 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2557,11 +2557,12 @@ official SDK.")
           (base32 "01wb70m48xh5gwhv60a5brv4sxl0i0rh038w32cgnlxn5x86s9f1"))))
       (build-system gnu-build-system)
       (native-inputs
+       `(("pkg-config" ,pkg-config)))
+      (inputs
        `(("mesa" ,mesa)
          ("glu" ,glu)
          ("glut" ,freeglut)
-         ("gtk" ,gtk+-2)
-         ("pkg-config" ,pkg-config)))
+         ("gtk" ,gtk+-2)))
       (arguments
        `(#:tests? #f                              ;no tests
          #:phases
--
2.26.1

Information forwarded to guix-patches@gnu.org:
bug#41297; Package guix-patches. (Sat, 16 May 2020 17:25:01 GMT) (full text, mbox, link).

Message #20 received at 41297@debbugs.gnu.org (full text, mbox, reply):

Hi,

Ekaitz Zarraga <ekaitz@elenq.tech> skribis:

>>From 9e6f5503fd8837bcbb03eed3a05d6105b1752fc3 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sat, 16 May 2020 12:22:09 +0200
> Subject: [PATCH] gnu: openctm: Correct inputs vs native-inputs
>
>     * gnu/packages/engineering.scm (openctm): Move mesa, glu, glut and
>     gtk+-2 to inputs

Applied, thanks, and sorry for not catching it earlier!

Ludo’.

Added tag(s) fixed. Request was from Ludovic Courtès <ludo@gnu.org> to control@debbugs.gnu.org. (Mon, 18 May 2020 12:32:02 GMT) (full text, mbox, link).

bug closed, send any further explanations to 41297@debbugs.gnu.org and Ekaitz Zarraga <ekaitz@elenq.tech> Request was from Ludovic Courtès <ludo@gnu.org> to control@debbugs.gnu.org. (Mon, 18 May 2020 12:32:02 GMT) (full text, mbox, link).

bug archived. Request was from Debbugs Internal Request <help-debbugs@gnu.org> to internal_control@debbugs.gnu.org. (Tue, 16 Jun 2020 11:24:06 GMT) (full text, mbox, link).

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Mon Nov 4 22:06:33 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.