GNU bug report logs

#39258 Faster guix search using an sqlite cache

PackageSource(s)Maintainer(s)
guix-patches PTS Buildd Popcon
Full log

Message #358 received at 39258@debbugs.gnu.org (full text, mbox, reply):

Received: (at 39258) by debbugs.gnu.org; 15 Jun 2020 20:18:46 +0000
From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 15 16:18:46 2020
Received: from localhost ([127.0.0.1]:47560 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1jkvZ8-0000NP-Az
	for submit@debbugs.gnu.org; Mon, 15 Jun 2020 16:18:46 -0400
Received: from mugam.systemreboot.net ([139.59.75.54]:47076)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arunisaac@systemreboot.net>) id 1jkvZ4-0000ND-Ke
 for 39258@debbugs.gnu.org; Mon, 15 Jun 2020 16:18:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date:
 References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
 Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
 Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
 List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=XTjt+hL6kTgRtgDdRGuFat1EXlW6tKcxy5xWcfA8ysE=; b=f5Odcm9OWeOjxnPoMgE8ILZXW
 /47MNizWrCMuL3jqkHOi+ZUU2vRoj+Dcq+0Ps8Sz/n8tEl2WHBtVzhPN1MI+s8UlUAiWK6Qo6Dfn1
 009N+KfykymAAebw3vjVoQh6nzAJi5cmnBUwdonF6Y6A+yvXkN23O5I+xfuAIFwXbk68U=;
Received: from [192.168.2.1] (helo=steel)
 by systemreboot.net with esmtpsa  (TLS1.3) tls TLS_AES_256_GCM_SHA384
 (Exim 4.93) (envelope-from <arunisaac@systemreboot.net>)
 id 1jkvYz-001RD6-1b; Tue, 16 Jun 2020 01:48:37 +0530
From: Arun Isaac <arunisaac@systemreboot.net>
To: Ludovic Courtès <ludo@gnu.org>
Subject: Re: [bug#39258] [PATCH 2/4] ui: Use string matching with literal
 search strings.
In-Reply-To: <87ftayzrqi.fsf@gnu.org>
References: <20200601000030.7443-1-arunisaac@systemreboot.net>
 <20200601000030.7443-3-arunisaac@systemreboot.net> <87y2owmyf3.fsf@gnu.org>
 <cu7bllnnnty.fsf@systemreboot.net> <87ftayzrqi.fsf@gnu.org>
Date: Tue, 16 Jun 2020 01:48:31 +0530
Message-ID: <87a714nkvc.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 39258
Cc: 39258@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
[Message part 1 (text/plain, inline)]
>> So, shall I push the remaining patches (patches 1, 3, 4) after applying
>> the change you suggested for patch 1 (use of if versus cond)?
>
> Yes, definitely!

Done!

>>>> * guix/scripts/package.scm (process-query): Make search query a regexp only if
>>>> it is not a literal search string.
>>>> * guix/ui.scm (relevance): Use string matching with literal search strings and
>>>> regexp matching with regexp search strings.
>>>
>>> How does this affect performance?
>
> (To be clear, I’m referring specifically to this patch.)

Oh, I misunderstood. Here are the results specifically comparing patch 2
against the latest master (that includes the patches 1, 3 and 4 I just
pushed). All readings are on a warm cache.

|----------------------------------+--------+-------|
| query                            | before | after |
|----------------------------------+--------+-------|
| guix search strategy game        |    2.1 |   1.7 |
| guix search strategy game caesar |    1.8 |   1.5 |
|----------------------------------+--------+-------|
[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Thu Jul 10 13:38:32 2025; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.