#39136 - [PATCH] gnu: services: Add endlessh.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #8 received at 39136@debbugs.gnu.org (full text, mbox, reply):

Received: (at 39136) by debbugs.gnu.org; 25 Jul 2020 20:08:55 +0000
From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 25 16:08:55 2020
Received: from localhost ([127.0.0.1]:51223 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1jzQTX-0002Is-6K
	for submit@debbugs.gnu.org; Sat, 25 Jul 2020 16:08:55 -0400
Received: from mail-lj1-f169.google.com ([209.85.208.169]:35362)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <go.wigust@gmail.com>) id 1jzQTV-0002IX-Pw
 for 39136@debbugs.gnu.org; Sat, 25 Jul 2020 16:08:54 -0400
Received: by mail-lj1-f169.google.com with SMTP id q4so13337927lji.2
 for <39136@debbugs.gnu.org>; Sat, 25 Jul 2020 13:08:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=YlsGf/6tUQEbCjhz+rRJY6MsIxTjTcrGPc8aDV9CTVo=;
 b=V4TqgogwNu5maVvz/ohf6IwclaBDiEbGdgwWN5AEWc/a6u67ul+XrcOe32F6Vs6wdO
 31uMQ1AJmiqEhR27yA3XhIUPGpVtKJot78mvq/pVkAbaZ489Sz/+UnRfW58C/5E4U64E
 m9yyZSJyyhtlqkrfBsFE8Vv3YvI+d7kSX5KYNAdI5KHxrcy1IW8g9RUF6MteWE+O63AC
 ODkl7GLx5PLgi7HmLl7u/dZUo1ztM9rplp9s9P4fY9EKKcVC9FA4yTQg6SoHdhdiTz4o
 9PYp+RGEjMXk6iUa4OH1UwnluZ1R0hOpYiLNwAnL0zuzi5Rv49am1VfHWF5VIGGgvuHQ
 Uv/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=YlsGf/6tUQEbCjhz+rRJY6MsIxTjTcrGPc8aDV9CTVo=;
 b=YfIk5YBPaEaXtWtSF9EVjy+5Vye0pJaNTLTAn3D6sFVQTcUAOK2lnQqLEcUyenGcsk
 cdeNfaH26npNJt38v40Nzz2PLjshO8NqYALPrcN1y8b2fRGXTzoFgeLLasIRIejtIP1S
 d8RYo1at3C+d5KLXnIiQg0UEzXsgMDF0ztsftuohFE6ncQgpj6owiQVNvy0XDV2C+PmG
 4U6TiVHuDr53nQ6Uu0r8uT6Yrz83GhUyLyWpgbfmC9EFVPRvxNYZP3SIYHa5Cead0VBs
 4ZaunJ3oVulb/vyU1VgQtYW+OxUcB6w0uY7V0TiRxHyOwDKNjzTd+eJkjBfb11R+LFEA
 VE8w==
X-Gm-Message-State: AOAM533rjCB5KPodzroSFOVrm8BZhVPu1VItp4M+a9f/4GWzUYqA/c65
 DECEM0ul8zbvDnJ0e0SbOgoobohw
X-Google-Smtp-Source: ABdhPJwl+rNSZErxLfj3AEUSaLAy0fNA80ySiloRVY7hohLJJTrBeGgmb/lUcVhxE9SVBJGkWZDj+g==
X-Received: by 2002:a05:651c:1134:: with SMTP id
 e20mr2066962ljo.40.1595707727552; 
 Sat, 25 Jul 2020 13:08:47 -0700 (PDT)
Received: from guixsd (ppp91-122-98-213.pppoe.avangarddsl.ru. [91.122.98.213])
 by smtp.gmail.com with ESMTPSA id
 m26sm211705ljc.129.2020.07.25.13.08.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 25 Jul 2020 13:08:46 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@gmail.com>
To: anothersms@gmail.com (Nicolò Balzarotti)
Subject: Re: [bug#39136] [PATCH] gnu: services: Add endlessh.
References: <874kwx91k6.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
Date: Sat, 25 Jul 2020 23:08:44 +0300
In-Reply-To: <874kwx91k6.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
 ("Nicolò Balzarotti"'s message of "Tue, 14 Jan 2020
 22:21:29 +0100")
Message-ID: <87365fl5mb.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 39136
Cc: 39136@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

[Message part 1 (text/plain, inline)]

Hi,

That patch was forgotten for some reason, but we still have a succeeded
to build ‘endlessh’ package which missing a service!  :-)

anothersms@gmail.com (Nicolò Balzarotti) writes:

> This is my first service :) I know I still miss documentation and tests,
> but before diving into it I wanted a general feedback on it (so that if
> we decide to change something I don't have to adjust the docs and the
> tests twice).

Tests are appreciated ;-)

> Endlessh is already in the repo, but for those who don't know: it's a
> fake ssh server; it should be used to prevent bruteforce attacks and the
> like by "freezing" the connection on the standard port (while the real
> ssh server is on another non-standard port).  So, I don't know if as
> default port should be 22 or, as it is now, 2222 (program's default).

2222 is OK.  But we need this be documented in ‘doc/guix.texi’.  Could
you take a look on this, please?

> My second doubt is regarding the place; it's an ssh server, but its main
> purpose is for security? Maybe should go under admin.scm? I'm not sure

I think gnu/services/ssh.scm is good.

[…]

> +(define-record-type* <endlessh-configuration>
> +  endlessh-configuration make-endlessh-configuration
> +  endlessh-configuration?
> +  ;; list of two symbols, allowed values are ipv4, ipv6 or both
> +  (bind-family endlessh-configuration-bind-family (default '(ipv4 ipv6)))

Please, move ‘(default …)’ things on a separate line.

[…]

Otherwise LGTM.  Could you send an update with a documented service?

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Tue Jan 7 02:43:55 2025; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#39136 [PATCH] gnu: services: Add endlessh.