GNU bug report logs

#37962 [PATCH] gnu: emacs-evil: Remove undo-tree dependency.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Reported by Clément Lassieur <clement@lassieur.org>
Date 2019-10-28T15:35:02
Severity normal
Tags fixed
Done clement@lassieur.org (Clément Lassieur)
Bug is Archived

Reply or subscribe to this bug. View this bug as an mbox, status mbox, or maintainer mbox

Report forwarded to guix-patches@gnu.org:
bug#37962; Package guix-patches. (Mon, 28 Oct 2019 15:35:02 GMT) (full text, mbox, link).

Acknowledgement sent to Clément Lassieur <clement@lassieur.org>:
New bug report received and forwarded. Copy sent to guix-patches@gnu.org. (Mon, 28 Oct 2019 15:35:02 GMT) (full text, mbox, link).

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

Because it is buggy and unnecessary.  See
<https://github.com/emacs-evil/evil/issues/1074>.

* gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
emacs-undo-tree and emacs-goto-chg.
---
 gnu/packages/emacs-xyz.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 688206452e..ba8ece1e22 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")
         (base32
          "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
     (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-undo-tree" ,emacs-undo-tree)
-       ("emacs-goto-chg" ,emacs-goto-chg)))
     (home-page "https://github.com/emacs-evil/evil")
     (synopsis "Extensible Vi layer for Emacs")
     (description
-- 
2.23.0

Information forwarded to guix-patches@gnu.org:
bug#37962; Package guix-patches. (Mon, 28 Oct 2019 15:44:02 GMT) (full text, mbox, link).

Message #8 received at 37962@debbugs.gnu.org (full text, mbox, reply):

The idea is that if people need it, they can install it and it'll just
work, but I personnaly don't want 'u' to be bound to undo-tree because
it has unfixed bugs that can lead to data loss[1].

'r' won't work anymore, but C-/ can be used instead[2].

Cheers,
Clément

[1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
[2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948

Information forwarded to guix-patches@gnu.org:
bug#37962; Package guix-patches. (Mon, 28 Oct 2019 15:51:02 GMT) (full text, mbox, link).

Message #11 received at 37962@debbugs.gnu.org (full text, mbox, reply):

clement@lassieur.org (Clément Lassieur) writes:

> The idea is that if people need it, they can install it and it'll just
> work, but I personnaly don't want 'u' to be bound to undo-tree because
> it has unfixed bugs that can lead to data loss[1].
>
> 'r' won't work anymore, but C-/ can be used instead[2].

I meant C-r (undo-tree-redo).

>
> Cheers,
> Clément
>
> [1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
> [2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948

Information forwarded to guix-patches@gnu.org:
bug#37962; Package guix-patches. (Tue, 29 Oct 2019 07:44:02 GMT) (full text, mbox, link).

Message #14 received at submit@debbugs.gnu.org (full text, mbox, reply):

Hello Clément,

This LGTM!

Thanks,

Mathieu

Clément Lassieur writes:

> Because it is buggy and unnecessary.  See
> <https://github.com/emacs-evil/evil/issues/1074>.
>
> * gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
> emacs-undo-tree and emacs-goto-chg.
> ---
>  gnu/packages/emacs-xyz.scm | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 688206452e..ba8ece1e22 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")
>          (base32
>           "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
>      (build-system emacs-build-system)
> -    (propagated-inputs
> -     `(("emacs-undo-tree" ,emacs-undo-tree)
> -       ("emacs-goto-chg" ,emacs-goto-chg)))
>      (home-page "https://github.com/emacs-evil/evil")
>      (synopsis "Extensible Vi layer for Emacs")
>      (description

Information forwarded to guix-patches@gnu.org:
bug#37962; Package guix-patches. (Tue, 29 Oct 2019 07:44:02 GMT) (full text, mbox, link).

Information forwarded to guix-patches@gnu.org:
bug#37962; Package guix-patches. (Tue, 29 Oct 2019 10:08:01 GMT) (full text, mbox, link).

Message #20 received at 37962@debbugs.gnu.org (full text, mbox, reply):

thanks!  Pushed.

bug closed, send any further explanations to 37962@debbugs.gnu.org and Clément Lassieur <clement@lassieur.org> Request was from Clément Lassieur <clement@lassieur.org> to control@debbugs.gnu.org. (Tue, 29 Oct 2019 17:55:01 GMT) (full text, mbox, link).

Added tag(s) fixed. Request was from Clément Lassieur <clement@lassieur.org> to control@debbugs.gnu.org. (Tue, 29 Oct 2019 21:01:01 GMT) (full text, mbox, link).

Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs@gnu.org> to internal_control@debbugs.gnu.org. (Tue, 29 Oct 2019 21:09:02 GMT) (full text, mbox, link).

Removed tag(s) fixed and patch. Request was from clement@lassieur.org (Clément Lassieur) to control@debbugs.gnu.org. (Tue, 29 Oct 2019 21:09:02 GMT) (full text, mbox, link).

Added tag(s) fixed. Request was from clement@lassieur.org (Clément Lassieur) to control@debbugs.gnu.org. (Tue, 29 Oct 2019 21:20:01 GMT) (full text, mbox, link).

bug closed, send any further explanations to 37962@debbugs.gnu.org and Clément Lassieur <clement@lassieur.org> Request was from clement@lassieur.org (Clément Lassieur) to control@debbugs.gnu.org. (Tue, 29 Oct 2019 21:20:01 GMT) (full text, mbox, link).

bug archived. Request was from Debbugs Internal Request <help-debbugs@gnu.org> to internal_control@debbugs.gnu.org. (Wed, 27 Nov 2019 12:24:05 GMT) (full text, mbox, link).

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Mon Nov 4 22:05:30 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.