#37744 - Insecure permissions on /var/guix/profiles/per-user (CVE-2019-18192)

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #36 received at 37744@debbugs.gnu.org (full text, mbox, reply):

Received: (at 37744) by debbugs.gnu.org; 16 Oct 2019 14:13:01 +0000
From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 10:13:01 2019
Received: from localhost ([127.0.0.1]:46333 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1iKk2v-0001JX-Kp
	for submit@debbugs.gnu.org; Wed, 16 Oct 2019 10:13:01 -0400
Received: from tobias.gr ([80.241.217.52]:46274)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@tobias.gr>) id 1iKk2t-0001JH-GN
 for 37744@debbugs.gnu.org; Wed, 16 Oct 2019 10:13:01 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 1278db18;
 Wed, 16 Oct 2019 14:12:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@tobias.gr; bh=PbZ3+oqmqfPTGEwPAJcWwT
 3kxqvyg2iUJEHMNraS+Mc=; b=WeodXvZUcT43z0wD38l58wNeEc5Ok5JtA0uONd
 XEJb61d6QMbAlb0vOBak3wYZKPoCCkBtjcw/yn2h1gmFOFXVUSgddgnOLhJhfFo3
 VGO3pKfzRyPKNpFMgGjpvl6pf+yxOQEiKJOgnqU5HLdVFWIymz6DHho0tnzq6su5
 ijAzgnKjfhAF014UZXChZxc6aUsr4+0J5LDf3NBnz13yzwHgOK9xM2HaqOeJJZH9
 1SmZjVghl/NXS7PsYFpixhhYdbSGDJGxJl/ojj3n51rqmI3EjQD6a0YmV8tRHqQ5
 uOduPcXt8T1liRxcKtWtbXOeESFvl9+CXAGt6yQSBMIU24VA==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 07ab53aa
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Wed, 16 Oct 2019 14:12:52 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: Ludovic Courtès <ludo@gnu.org>
Subject: Re: bug#37744: Per-user profile directory hijack (CVE-2019-17365 for
 Nix)
References: <87o8yjsr8o.fsf@gnu.org> <87blujsqq0.fsf@gnu.org>
 <87y2xno85o.fsf@nckx> <87d0eyuqzd.fsf@gnu.org> <87mue2nkrj.fsf@nckx>
 <8736fttby6.fsf@gnu.org> <87tv89rnva.fsf@gnu.org>
In-reply-to: <87tv89rnva.fsf@gnu.org>
Date: Wed, 16 Oct 2019 16:12:50 +0200
Message-ID: <87imoook2l.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 37744
Cc: 37744@debbugs.gnu.org, guix-security@gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

[Message part 1 (text/plain, inline)]

Ludo',

That was swift, thanks!

IANAC++.

Ludovic Courtès 写道：
> diff --git a/nix/libstore/local-store.cc 
> b/nix/libstore/local-store.cc
> index 3b08492c64..3793382361 100644
> --- a/nix/libstore/local-store.cc
> +++ b/nix/libstore/local-store.cc
> @@ -88,8 +88,9 @@ LocalStore::LocalStore(bool reserveSpace)
>  
>          Path perUserDir = profilesDir + "/per-user";
>          createDirs(perUserDir);
> -        if (chmod(perUserDir.c_str(), 01777) == -1)
> -            throw SysError(format("could not set permissions on 
> '%1%' to 1777") % perUserDir);
> +        if (chmod(perUserDir.c_str(), 0755) == -1)
> +            throw SysError(format("could not set permissions on 
> '%1%' to 755")
> +                           % perUserDir);
>  
>          mode_t perm = 01775;

This is inside

 if (getuid() == 0 && settings.buildUsersGroup != "") {
   …
 }

It's not clear to me why the second condition here is relevant, 
but I don't have the big picture.  Nor do I suspect I want it.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 11:10:45 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#37744 Insecure permissions on /var/guix/profiles/per-user (CVE-2019-18192)