Acknowledgement sent
to zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze):
New bug report received and forwarded. Copy sent to guix-patches@gnu.org.
(Sat, 13 Jul 2019 17:53:02 GMT) (full text, mbox, link).
I hope that creating an entirely new file for this isn't too intrusive.
My thinking is that, when the upstream Java implementation of the I2P
daemon is packaged, it can go in 'i2p.scm', along with any related
packages such as I2P-Bote.
Jakob L. Kreuze (2):
gnu: Add websocketpp.
gnu: Add i2pd.
gnu/local.mk | 1 +
gnu/packages/i2p.scm | 85 ++++++++++++++++++++++++++++++++++++++++++++
gnu/packages/web.scm | 28 +++++++++++++++
3 files changed, 114 insertions(+)
create mode 100644 gnu/packages/i2p.scm
--
2.22.0
Hello,
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> * gnu/packages/web.scm (websocketpp): New variable.
[...]
> +(define-public websocketpp
> + (package
> + (name "websocketpp")
^
I indented with an extra space here…
> + (synopsis "C++ library implementing the WebSocket protocol.")
^
… and removed this period. :-)
Applied, thanks!
Ludo’.
Information forwarded
to guix-patches@gnu.org: bug#36638; Package guix-patches.
(Mon, 15 Jul 2019 16:30:03 GMT) (full text, mbox, link).
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> * gnu/packages/i2p.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
The package definition LGTM but… “make install” installs too many
things, and in the wrong place:
--8<---------------cut here---------------start------------->8---
$ find /gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/lib
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/lib/libi2pdclient.a
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/lib/libi2pd.a
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/bin
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/bin/i2pd
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/version.h
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/TunnelConfig.h
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/Poly1305.h
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/Gzip.cpp
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/Ed25519.h
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/Siphash.h
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/MatchedDestination.cpp
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/api.cpp
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/src/WebSocks.cpp
[…]
/gnu/store/yyddprfp7ypjhr8kswi004smmrryh3lc-i2pd-2.27.0/LICENSE
--8<---------------cut here---------------end--------------->8---
We should at least remove everything under src/ as well as the top-level
‘LICENSE’ file.
As for the .a files, we should either not install them at all, or
install .so files instead.
Could you take a look?
Thanks,
Ludo’.
Information forwarded
to guix-patches@gnu.org: bug#36638; Package guix-patches.
(Mon, 15 Jul 2019 16:32:01 GMT) (full text, mbox, link).
Ludovic Courtès <ludo@gnu.org> skribis:
> Hello,
>
> zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
>
>> * gnu/packages/web.scm (websocketpp): New variable.
[...]
> Applied, thanks!
Actually no! :-)
On closer inspection, the file layout is also fishy:
--8<---------------cut here---------------start------------->8---
$ find /gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/lib
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/lib/cmake
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/lib/cmake/websocketpp
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/lib/cmake/websocketpp/websocketpp-configVersion.cmake
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/lib/cmake/websocketpp/websocketpp-config.cmake
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin/test_processor_hybi00
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin/test_sha1
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin/test_transport_iostream_base
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin/test_transport_asio_timers
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin/test_processor_hybi08
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin/test_transport
/gnu/store/rm6a4v8m8plzskjmig2vmly91qxl4z8q-websocketpp-0.8.1/bin/test_utilities
--8<---------------cut here---------------end--------------->8---
All of bin/ should be removed I think, because these look like unit
tests, no?
Also, there’s no .so or .a file, but that’s because it’s a header-only
library, right?
Thanks,
Ludo’.
Information forwarded
to guix-patches@gnu.org: bug#36638; Package guix-patches.
(Tue, 16 Jul 2019 16:49:02 GMT) (full text, mbox, link).
Ludovic Courtès <ludo@gnu.org> writes:
> We should at least remove everything under src/ as well as the
> top-level ‘LICENSE’ file.
>
> As for the .a files, we should either not install them at all, or
> install .so files instead.
>
> Could you take a look?
I'll sit down and take a closer look when I get the chance. It seems to
be a funny build system setup; the libi2pd header files are installed to
'src/', and given the CMake flags I'm using, we /should/ be getting .so
files instead of .a files.
> All of bin/ should be removed I think, because these look like unit
> tests, no?
Good catch! I need to start looking at the output directories for the
packages I write :p I wouldn't have expected 'make install' to install
the unit tests as well
> Also, there’s no .so or .a file, but that’s because it’s a header-only
> library, right?
Yes.
Regards,
Jakob
Should be fixed now. BUILD_SHARED_LIBS was disabled by default.
On an unrelated note, is there a way to obtain the source directory when
patches are applied to 'origin'? '(assoc-ref %build-inputs "source")'
works fine here, but if I were to use a patch to deal with the
extraneous files installed by i2pd, it points to an xzipped archive.
Jakob L. Kreuze (2):
gnu: Add websocketpp.
gnu: Add i2pd.
gnu/local.mk | 1 +
gnu/packages/i2p.scm | 107 +++++++++++++++++++++++++++++++++++++++++++
gnu/packages/web.scm | 36 +++++++++++++++
3 files changed, 144 insertions(+)
create mode 100644 gnu/packages/i2p.scm
--
2.22.0
Hi!
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> * gnu/packages/web.scm (websocketpp): New variable.
Applied with the minor changes below, in particular returning #t from
the build phase.
Thanks,
Ludo’.
Hi!
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> * gnu/packages/web.scm (websocketpp): New variable.
Applied with the minor changes below, in particular returning #t from
the build phase.
Thanks,
Ludo’.
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> On an unrelated note, is there a way to obtain the source directory when
> patches are applied to 'origin'? '(assoc-ref %build-inputs "source")'
> works fine here, but if I were to use a patch to deal with the
> extraneous files installed by i2pd, it points to an xzipped archive.
The current working when the ‘snippet’ is executed is the source
directory. But maybe I’m overlooking something?
Thanks,
Ludo’.
Added tag(s) fixed.
Request was from Ludovic Courtès <ludo@gnu.org>
to control@debbugs.gnu.org.
(Thu, 18 Jul 2019 09:30:05 GMT) (full text, mbox, link).
bug closed, send any further explanations to
36638@debbugs.gnu.org and zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze)
Request was from Ludovic Courtès <ludo@gnu.org>
to control@debbugs.gnu.org.
(Thu, 18 Jul 2019 09:30:05 GMT) (full text, mbox, link).
bug archived.
Request was from Debbugs Internal Request <help-debbugs@gnu.org>
to internal_control@debbugs.gnu.org.
(Thu, 15 Aug 2019 11:24:05 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the
GNU Public License version 2. The current version can be
obtained from https://bugs.debian.org/debbugs-source/.