#33359 On emacs-clang-format

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Tim Gesthuizen <tim.gesthuizen@yahoo.de>

To: bug-guix@gnu.org

Subject: On emacs-clang-format

Date: Mon, 12 Nov 2018 22:40:13 +0100

[Message part 1 (text/plain, inline)]

Hi,
I noticed that someone packaged emacs-clang-format.
There are some problems with the current package definition:

- clang already distributes the same functionality (Maybe I am missing a
  feature that clangs version does not have though).
- The package also includes integration for clang-rename.
- The package should probably have a more generic name and function as a
  package for all emacs integration clang offers.
- The clang package is installing the same files under share/clang.
  Maybe those should be removed.
- The license is incorrect. The version that is cloned from github
  also seems to have some licensing issues (Missing full license...)

You'll find an example package definition attached.
This can probably be optimized a little bit more so that the full clang
tarball does not need to be extracted twice.

Tim.

[0001-gnu-Add-emacs-clang-tooling.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 33359@debbugs.gnu.org (full text, mbox, reply):

From: ludo@gnu.org (Ludovic Courtès)

To: Tim Gesthuizen <tim.gesthuizen@yahoo.de>, Pierre Neidhardt <mail@ambrevar.xyz>

Cc: 33359@debbugs.gnu.org

Subject: Re: bug#33359: On emacs-clang-format

Date: Wed, 14 Nov 2018 11:25:13 +0100

Hi Tim,

Thanks for your feedback.

Tim Gesthuizen <tim.gesthuizen@yahoo.de> skribis:

> I noticed that someone packaged emacs-clang-format.
> There are some problems with the current package definition:
>
> - clang already distributes the same functionality (Maybe I am missing a
>   feature that clangs version does not have though).
> - The package also includes integration for clang-rename.
> - The package should probably have a more generic name and function as a
>   package for all emacs integration clang offers.
> - The clang package is installing the same files under share/clang.
>   Maybe those should be removed.
> - The license is incorrect. The version that is cloned from github
>   also seems to have some licensing issues (Missing full license...)
>
> You'll find an example package definition attached.
> This can probably be optimized a little bit more so that the full clang
> tarball does not need to be extracted twice.

Pierre, WDYT?

Thanks in advance!  :-)

Ludo’.

Message #11 received at 33359@debbugs.gnu.org (full text, mbox, reply):

From: Pierre Neidhardt <mail@ambrevar.xyz>

To: Ludovic Courtès <ludo@gnu.org>

Cc: 33359@debbugs.gnu.org, Tim Gesthuizen <tim.gesthuizen@yahoo.de>

Subject: Re: bug#33359: On emacs-clang-format

Date: Wed, 14 Nov 2018 11:48:50 +0100

[Message part 1 (text/plain, inline)]

That's absolutely right, I didn't know clang packaged it already.

Here is the listing.

--8<---------------cut here---------------start------------->8---
> ls -1 /gnu/store/...-clang-6.0.1/share/clang
bash-autocomplete.sh
clang-format-bbedit.applescript
clang-format-diff.py
clang-format-sublime.py
clang-format.el
clang-format.py
clang-rename.el
clang-rename.py
--8<---------------cut here---------------end--------------->8---

Not should we fix the Emacs package, but also the Vim .py files, the
Sublime+bbedit extensions (which we can discard I guess) and the Bash
completion.

I see a few ways we can proceed:

- Deprecate emacs-clang-format.

  - Use emacs-clang-tooling as suggested by Tim.

  - Use clang as it is and fix the installation of the share folder.
    
  - Use clang:emacs output and clang:vim output.

- Keep emacs-clang-format but use the Clang source (as per Tim suggestion), and
  add emacs-clang-rename from the same source.

In all cases we need to fix the installation of the Bash completion file and
maybe to discard the Sublime+bbedit extensions.

> : - The license is incorrect. The version that is cloned from github
> :   also seems to have some licensing issues (Missing full license...)

Which license?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 33359@debbugs.gnu.org (full text, mbox, reply):

From: Tim Gesthuizen <tim.gesthuizen@yahoo.de>

To: Pierre Neidhardt <mail@ambrevar.xyz>, Ludovic Courtès <ludo@gnu.org>

Cc: 33359@debbugs.gnu.org

Subject: Re: bug#33359: On emacs-clang-format

Date: Wed, 14 Nov 2018 16:56:18 +0100

[Message part 1 (text/plain, inline)]

On 14.11.2018 11:48, Pierre Neidhardt wrote:
>> : - The license is incorrect. The version that is cloned from github
>> :   also seems to have some licensing issues (Missing full license...)
> 
> Which license?
> 

The emacs-clang-format package definition claims that the package is
licensed under the GPLv3+. The files in the repository are licensed
under the same license that clang is licensed under ( The headers of the
files actually say that they are from the LLVM project). This means the
package is licensed under University of Illinois/NCSA Open Source License.
So while it would probably be legal to distribute binaries and source
code under the terms of the GPL this should probably be fixed :)

Tim.

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at 33359@debbugs.gnu.org (full text, mbox, reply):

From: Pierre Neidhardt <mail@ambrevar.xyz>

To: Tim Gesthuizen <tim.gesthuizen@yahoo.de>

Cc: 33359@debbugs.gnu.org, Ludovic Courtès <ludo@gnu.org>

Subject: Re: bug#33359: On emacs-clang-format

Date: Mon, 26 Nov 2018 14:54:47 +0100

[Message part 1 (text/plain, inline)]

I went ahead and implemented the aforementioned approach:

> - Keep emacs-clang-format but use the Clang source (as per Tim suggestion), and
>   add emacs-clang-rename from the same source.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.