GNU bug report logs

#33347 [PATCH 0/4] gnu: teeworlds: Update to 0.7.0 [fixes CVE-2018-18541].

PackageSource(s)Maintainer(s)
guix-patches PTS Buildd Popcon
Full log

Message #44 received at 33347@debbugs.gnu.org (full text, mbox, reply):

Received: (at 33347) by debbugs.gnu.org; 14 Nov 2018 17:40:22 +0000
From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 14 12:40:22 2018
Received: from localhost ([127.0.0.1]:52487 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gMz9K-00067v-AN
	for submit@debbugs.gnu.org; Wed, 14 Nov 2018 12:40:22 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:42795)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@famulari.name>) id 1gMz9H-00067h-Fp
 for 33347@debbugs.gnu.org; Wed, 14 Nov 2018 12:40:21 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id EF84421CA5;
 Wed, 14 Nov 2018 12:40:13 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Wed, 14 Nov 2018 12:40:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=7cek/3QukL/j33H6i+5DnMWP
 TrLPLXQC9FWF7558+ss=; b=13yqax8NM9vogPX0TLxlZgwdfAtCrRq2un45aVHX
 6K7PoeGIDLmsrB/GwnznYl10Rph6YLbgIEZ6yFFXYfhYzIdJHwG2C4O4mqJ7dQjb
 +X2mySCiiaSsQVHjUgUGmbEr+vMT9Fl/QLB/ea9lbywwR3pH82fmn5VhBRNh0w+U
 aHA=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7cek/3
 QukL/j33H6i+5DnMWPTrLPLXQC9FWF7558+ss=; b=orakqx/HaPwyMe5R86fJYB
 5qM3OS/DvTJFu11Y9CMKKJlJxHLL4PauArXbxeCoPBj/TkQFa9pIv9UZW2tNfGQZ
 8LbyMTQHtFBb04ibIPIJGu8ywVIFiz0HeHq66SbKmD3ljg1I26ngwpmzJHzEhIJY
 u2xtPDu+FzKgzQouOZgyzYNe4cvM1YF61L0IhZaADDY0YOP3ljdNVv5CijdeQOd/
 ZbOeEb/rnx/5Za9CEcGi+R1n24hIe/VrxmASg49XmzzctSc+pKo7y/+xj1zhfWVj
 jdIWm0FrU724Fg+J+GybKurkP7CeEDRRzgeNVjs6T+FlRf2UEPOVuL+SVYQnb9vQ
 ==
X-ME-Sender: <xms:_V3sWxBom5YzFK68FaoCEn-GV0Y8QZumc3mDLcDrWWSCXCUxcEZloA>
X-ME-Proxy: <xmx:_V3sW3FlQ5_-M0skxEzSBP4dxp_kb2ajqkIYFEgq-1oqAdSVOnrPOA>
 <xmx:_V3sW-TXzcgA9BKZahig4FeIYJasBQyHH0txAFhL9yRFicS5NHu_Yw>
 <xmx:_V3sW_ft9gtXdYaMN3Wry52igilyI_GR-Mk0hObvR0mXikTxlELmBQ>
 <xmx:_V3sW7nSxUHoyo0aatq99xpF60Tk-1H3izRkz5MMHUHfbQb3960vRw>
 <xmx:_V3sW9PuvrV6fOE5k-rAO9iPS5M04cSxd2MzVGCzJtxk3TRomViCnw>
 <xmx:_V3sW0bQFokT4RxOAVsXRvYdmfsebHqZdYbm-X-jLP2d87_BV-LLBA>
Received: from localhost (unknown [172.56.29.245])
 by mail.messagingengine.com (Postfix) with ESMTPA id CADD5E40E6;
 Wed, 14 Nov 2018 12:40:12 -0500 (EST)
Date: Wed, 14 Nov 2018 12:39:31 -0500
From: Leo Famulari <leo@famulari.name>
To: Alex Vong <alexvong1995@gmail.com>
Subject: Re: [bug#33347] [PATCH 4/4] gnu: teeworlds: Update to 0.7.0 [fixes
 CVE-2018-18541].
Message-ID: <20181114173931.GB2408@jasmine.lan>
References: <871s7r3095.fsf@gmail.com> <87k1lj1le4.fsf@gmail.com>
 <20181113165310.GC8498@jasmine.lan> <8736s33hnq.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE"
Content-Disposition: inline
In-Reply-To: <8736s33hnq.fsf@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 33347
Cc: 33347@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
[Message part 1 (text/plain, inline)]
On Wed, Nov 14, 2018 at 09:36:25PM +0800, Alex Vong wrote:
> Well, I though we have a policy to remove bundle dependencies in order
> to avoid building the same library many times. Do we make exceptions for
> shared libraries w/o a build system? (an exception I can think of is
> gnulib)

In general, yes, our policy is to unbundle things when practical.

But there are some commonly used software implementations of basic
functions (like base64, sha1 (most hash functions actually), et cetera)
that are specifically designed to be copied and pasted into the
application that will be using them.

You can usually tell this is the case because the thing will not have
any build system at all, like you suggest. Also because you find the
same copy-pasted code in almost every program you look at, like with
base64 and the hash functions.

> Besides, the FIXME comment seems to suggest future readers to help
> remove the bundled pnglite. Debian also removes the bundled pnglite in
> teeworlds[0].

Well, at a certain point it becomes a matter of taste, and the choice
should be made by the person doing the work — you! Either way is fine
for Guix :) The important thing is to get this Teeworlds fix pushed
without too much delay.
[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 12:14:31 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.