#33347 - [PATCH 0/4] gnu: teeworlds: Update to 0.7.0 [fixes CVE-2018-18541].

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #29 received at 33347@debbugs.gnu.org (full text, mbox, reply):

Received: (at 33347) by debbugs.gnu.org; 13 Nov 2018 16:53:19 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 13 11:53:19 2018
Received: from localhost ([127.0.0.1]:50544 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gMbwF-0003he-8C
	for submit@debbugs.gnu.org; Tue, 13 Nov 2018 11:53:19 -0500
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:59159)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@famulari.name>) id 1gMbwD-0003hP-Qh
 for 33347@debbugs.gnu.org; Tue, 13 Nov 2018 11:53:18 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 6673293A;
 Tue, 13 Nov 2018 11:53:11 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Tue, 13 Nov 2018 11:53:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=fKwhB+353jTY1yRYEzk0MZJ4
 YUkZo8U2JXGzT35h4x0=; b=Wc4XTTx6urvIM+Eb049/tm+8f9+ObmJ17AyVAYd4
 aK2gONpogmObL/4/g5FZi+f54HKJwPOK3BiFT9oojCwTsr1j7zdRD2MX0njVcsHO
 nPIbTO11xEQkpOUt2P+d4CrFTW54dJdumUuZh9SnMaHcj4gIs8gXwfew5PCLl7Ob
 /qg=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fKwhB+
 353jTY1yRYEzk0MZJ4YUkZo8U2JXGzT35h4x0=; b=dyPt5kY0NsNPRRb/8ACvDy
 vBUqYTTu98VktM7fMFQvXYJ2MxfJU0myz+av8q0iI7ekB4iMIARM5JsPPuYVuGv4
 Eyo1nBZb9ghAkQLicbA+hxGurE2fnEdPuIr8SkPOD5cpD1ZDqiE2c+Wc0t71J+eb
 ZvkMLnBU/Pv/WEhr2GBeZe8y5wuY7sunkvoYxcBf20xFj29amboKZKV1FdJl6zy1
 hI3DcKY6u9pUGcwzEOAo1eLMNJoIcQ2XShIf/wnEsI3TIVqhGs9pzKRtgKnPRqF8
 ZyCUrHBjWX0ubqDDQYC4bzmLeYMf75YhckeGLQHVXVXpCAlXxZe258ldXMhC17Kg
 ==
X-ME-Sender: <xms:dgHrW6ZjgHWp3xMf2coInr1dTTX74Gc_FWRYy5781xzfc7_eODPj9g>
X-ME-Proxy: <xmx:dgHrW2aaDTawmhnljTwDGNGlC4aIe47ZIyKVz8dFwJeZ8uFV0J30Jw>
 <xmx:dgHrW31-G6QULsaWIlAV4OFFKR6vW8UWN4Nk8gpWdS-RcjMPa_aYwQ>
 <xmx:dgHrWznZZMSyKh_jWIIRbcXdQqPqpidAwhv9klkDMyuNw1-Xz1nIqQ>
 <xmx:dgHrWz_JGvOboTBJvMuKlXczztYkX99tiaYVshinz4CWwIqr8qzseg>
 <xmx:dgHrW6Exu1lI1cJz4WyBSLm2vgmIFwuaxiwQNJyOLingwYMYwsw-9Q>
 <xmx:dwHrWygZLbKGf-Iq5mA-T_hoFIhvMP2RxeMux8UaegW7ykd2gEXFuQ>
Received: from localhost (pool-71-105-200-72.nycmny.fios.verizon.net
 [71.105.200.72])
 by mail.messagingengine.com (Postfix) with ESMTPA id A8B39102DE;
 Tue, 13 Nov 2018 11:53:10 -0500 (EST)
Date: Tue, 13 Nov 2018 11:53:10 -0500
From: Leo Famulari <leo@famulari.name>
To: Alex Vong <alexvong1995@gmail.com>
Subject: Re: [bug#33347] [PATCH 4/4] gnu: teeworlds: Update to 0.7.0 [fixes
 CVE-2018-18541].
Message-ID: <20181113165310.GC8498@jasmine.lan>
References: <871s7r3095.fsf@gmail.com>
 <87k1lj1le4.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="gr/z0/N6AeWAPJVB"
Content-Disposition: inline
In-Reply-To: <87k1lj1le4.fsf@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 33347
Cc: 33347@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

[Message part 1 (text/plain, inline)]

On Mon, Nov 12, 2018 at 03:09:39AM +0800, Alex Vong wrote:
>           (replace 'configure
>             (lambda* (#:key outputs #:allow-other-keys)
> +             (define (use-latest-json-parser file)
> +               (substitute* file
> +                 (("engine/external/json-parser/json\\.h")
> +                  "json-parser/json.h")
> +                 (("json_parse_ex\\(&JsonSettings, pFileData, aError\\);")
> +                  "json_parse_ex(&JsonSettings,
> +                                 pFileData,
> +                                 strlen(pFileData),
> +                                 aError);")))
> +

Please add a code comment explaining this.

> -    ;; FIXME: teeworlds bundles the sources of "pnglite", a two-file PNG
> -    ;; library without a build system.

These sorts of mini-libraries are designed to be copied and pasted into
host projects rather than packaged on their own. That's why they don't
include a build system. For example, many cryptographic primitive
implementations are distributed this way — that's why you never see a
package for 'SHA256'. Is there a particular reason we should unbundle
pnglite?

[signature.asc (application/pgp-signature, inline)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 12:17:20 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#33347 [PATCH 0/4] gnu: teeworlds: Update to 0.7.0 [fixes CVE-2018-18541].