#33290 [PATCH 1/8] gnu: go-github-com-prometheus-common-expfmt: Disable tests for go-1.11.

Message #29 received at 33290@debbugs.gnu.org (full text, mbox, reply):

Received: (at 33290) by debbugs.gnu.org; 6 Nov 2018 17:37:16 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 06 12:37:15 2018
Received: from localhost ([127.0.0.1]:37607 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gK5Hv-0008Ri-GP
	for submit@debbugs.gnu.org; Tue, 06 Nov 2018 12:37:15 -0500
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44651)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@ambrevar.xyz>) id 1gK5Hr-0008QW-DB
 for 33290@debbugs.gnu.org; Tue, 06 Nov 2018 12:37:11 -0500
X-Originating-IP: 90.92.25.161
Received: from mimimi.home (lfbn-1-12201-161.w90-92.abo.wanadoo.fr
 [90.92.25.161]) (Authenticated sender: mail@ambrevar.xyz)
 by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B7B5DFF810
 for <33290@debbugs.gnu.org>; Tue,  6 Nov 2018 17:37:10 +0000 (UTC)
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: 33290@debbugs.gnu.org
Subject: [PATCH 7/8] gnu: demlo: Add workaround for go-1.11.
Date: Tue,  6 Nov 2018 18:37:08 +0100
Message-Id: <20181106173709.9883-6-mail@ambrevar.xyz>
X-Mailer: git-send-email 2.19.1
In-Reply-To: <20181106173709.9883-1-mail@ambrevar.xyz>
References: <87in1ayurm.fsf@ambrevar.xyz>
 <20181106173709.9883-1-mail@ambrevar.xyz>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 33290
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* gnu/packages/music.scm (demlo): Add workaround for go-1.11.
---
 gnu/packages/music.scm | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index cdd06647e..bbdf58b18 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4235,7 +4235,10 @@ console music players.")
          ("go-github-com-michiwend-gomusicbrainz" ,go-github-com-michiwend-gomusicbrainz)
          ("go-github-com-stevedonovan-luar" ,go-github-com-stevedonovan-luar)
          ("go-github-com-wtolson-go-taglib" ,go-github-com-wtolson-go-taglib)
-         ("go-github-com-yookoala-realpath" ,go-github-com-yookoala-realpath)))
+         ("go-github-com-yookoala-realpath" ,go-github-com-yookoala-realpath)
+         ;; Those should not be needed, see TODO below.
+         ("pkg-config" ,pkg-config)
+         ("taglib" ,taglib)))
       (inputs
        `(("chromaprint" ,chromaprint)
          ("ffmpeg" ,ffmpeg)))
@@ -4243,6 +4246,23 @@ console music players.")
        `(#:import-path "gitlab.com/ambrevar/demlo"
          #:phases
          (modify-phases %standard-phases
+           ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+           ;; rebuilt (https://bugs.gnu.org/32919).  Thus we need to
+           ;; re-specify the special flags of golua, the pkg-config + taglib
+           ;; native-inputs, and the 'check phase below.
+           (replace 'build
+             (lambda* (#:key import-path #:allow-other-keys)
+               (invoke "go" "install"
+                       "-v"  ; print the name of packages as they are compiled
+                       "-x"  ; print each command as it is invoked
+                       "-ldflags=-s -w" ; strip the symbol table and debug
+                       "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+                       import-path)))
+           (replace 'check
+             (lambda* (#:key import-path #:allow-other-keys)
+               (invoke "go" "test"
+                       "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+                       import-path)))
            (add-after 'install 'wrap-program
              (lambda* (#:key inputs outputs #:allow-other-keys)
                (let ((out (assoc-ref outputs "out"))
-- 
2.19.1

Send a report that this bug log contains spam.