#31719 - icedtea-3 binaries contain references to icedtea-2

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #93 received at 31719@debbugs.gnu.org (full text, mbox, reply):

Received: (at 31719) by debbugs.gnu.org; 20 Apr 2021 11:32:16 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 07:32:16 2021
Received: from localhost ([127.0.0.1]:53121 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1lYoc3-0004IG-P2
	for submit@debbugs.gnu.org; Tue, 20 Apr 2021 07:32:16 -0400
Received: from zancanaro.com.au ([45.76.117.151]:51346)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <carlo@zancanaro.id.au>) id 1lYoc1-0004Fj-OS
 for 31719@debbugs.gnu.org; Tue, 20 Apr 2021 07:32:14 -0400
Received: by zancanaro.com.au (Postfix, from userid 116)
 id A0DAF34226; Tue, 20 Apr 2021 11:32:11 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on vultr
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=4.0 tests=ALL_TRUSTED,BAYES_00,
 URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2
Received: from jolteon (n175-37-31-147.bla1.nsw.optusnet.com.au
 [175.37.31.147])
 by zancanaro.com.au (Postfix) with ESMTPSA id A2B9934224;
 Tue, 20 Apr 2021 11:32:10 +0000 (UTC)
References: <YDzXeFFnGenPdZfn@jurong> <87o8g2pni4.fsf@gnu.org>
 <20210301231534.1d4e440a@alma-ubu.fritz.box> <878s5ltj0o.fsf@elephly.net>
 <20210416212233.05ac87de@alma-ubu.fritz.box>
 <87fszpc1du.fsf@zancanaro.id.au> <87czutbd2f.fsf@zancanaro.id.au>
 <87a6pxb69o.fsf@zancanaro.id.au> <YH2uQKCqLAmBiPE3@jurong>
 <87wnsym944.fsf@elephly.net> <YH6SCaSNrRiqocqT@jurong>
 <878s5de2ac.fsf_-_@gnu.org>
User-agent: mu4e 1.4.15; emacs 27.2
From: Carlo Zancanaro <carlo@zancanaro.id.au>
To: Ludovic Courtès <ludo@gnu.org>
Subject: Re: bug#31719: icedtea-3 binaries contain references to icedtea-2
In-reply-to: <878s5de2ac.fsf_-_@gnu.org>
Date: Tue, 20 Apr 2021 21:32:10 +1000
Message-ID: <87tuo18a4l.fsf@zancanaro.id.au>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 31719
Cc: Ricardo Wurmus <rekado@elephly.net>, Andreas Enge <andreas@enge.fr>,
 31719@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

[Message part 1 (text/plain, inline)]

Hi Ludo!

On Tue, Apr 20 2021, Ludovic Courtès wrote:
>                      (find-library (lambda (name)
> -                                    (or (search-path
> -                                         library-path
> -                                         (string-append "lib" 
> name ".so"))
> -                                        (string-append "lib" 
> name ".so")))))
> +                                    (search-path
> +                                     library-path
> +                                     (string-append "lib" name 
> ".so")))))
>                 (for-each

As discussed on IRC, the "or" is actually important here to avoid 
substituting #f as the library name. I've attached a patch on top 
of yours that adds the "or" back (including the other two that I 
missed in my earlier patch), and also switches to "string-append" 
which is less sensitive to this problem.

I have built up to openjdk11 with this patch, and I see less #f's 
in the result. There are still some in the compiled libraries, but 
I haven't investigated thoroughly as to whether they're correct or 
not.

Carlo

[0001-gnu-Fix-openjdk-library-substitution-when-libraries-.patch (text/x-diff, attachment)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 08:49:18 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#31719 icedtea-3 binaries contain references to icedtea-2