#29562 [PATCH] gnu: lua5.1-socket: Update to 3.0-rc1 (for IPv6 support).

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: guix-patches@gnu.org

Subject: [PATCH] gnu: lua5.1-socket: Update to 3.0-rc1 (for IPv6 support).

Date: Mon, 4 Dec 2017 16:14:48 +0100

* gnu/packages/lua.scm (lua5.1-socket): Update to 3.0-rc1.
[source]: Change upstream URI.
[arguments]: Set INSTALL_TOP environment variable instead of INSTALL_TOP_SHARE
and INSTALL_TOP_LIB.
---
 gnu/packages/lua.scm | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
index d5f55b963..3a528599f 100644
--- a/gnu/packages/lua.scm
+++ b/gnu/packages/lua.scm
@@ -173,21 +173,20 @@ language.")
 (define-public lua5.1-socket
   (package
     (name "lua5.1-socket")
-    (version "2.0.2")
+    (version "3.0-rc1")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://files.luaforge.net/releases/"
-                                  "luasocket/luasocket/luasocket-"
-                                  version "/luasocket-" version ".tar.gz"))
+              (uri (string-append
+                    "https://github.com/diegonehab/luasocket/archive/v"
+                    version ".tar.gz"))
               (sha256
                (base32
-                "19ichkbc4rxv00ggz8gyf29jibvc2wq9pqjik0ll326rrxswgnag"))))
+                "0j8jx8bjicvp9khs26xjya8c495wrpb7parxfnabdqa5nnsxjrwb"))))
     (build-system gnu-build-system)
     (arguments
      `(#:make-flags
        (let ((out (assoc-ref %outputs "out")))
-         (list (string-append "INSTALL_TOP_SHARE=" out "/share/lua/5.1")
-               (string-append "INSTALL_TOP_LIB=" out "/lib/lua/5.1")))
+         (list (string-append "INSTALL_TOP=" out)))
        #:phases
        (modify-phases %standard-phases
          (delete 'configure)
-- 
2.15.1

Message #8 received at 29562@debbugs.gnu.org (full text, mbox, reply):

From: Leo Famulari <leo@famulari.name>

To: Clément Lassieur <clement@lassieur.org>

Cc: 29562@debbugs.gnu.org

Subject: Re: [bug#29562] [PATCH] gnu: lua5.1-socket: Update to 3.0-rc1 (for IPv6 support).

Date: Mon, 4 Dec 2017 14:24:55 -0500

[Message part 1 (text/plain, inline)]

On Mon, Dec 04, 2017 at 04:14:48PM +0100, Clément Lassieur wrote:
> * gnu/packages/lua.scm (lua5.1-socket): Update to 3.0-rc1.
> [source]: Change upstream URI.
> [arguments]: Set INSTALL_TOP environment variable instead of INSTALL_TOP_SHARE
> and INSTALL_TOP_LIB.

Typically we don't package release candidates or beta software.
Sometimes we do, if there are critical bugs fixed in the RC that we
can't backport, or if the upstream development seems to have stalled
without issuing a final release.

Can you give more detail about this case?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 29562@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: Leo Famulari <leo@famulari.name>

Cc: 29562@debbugs.gnu.org

Subject: Re: [bug#29562] [PATCH] gnu: lua5.1-socket: Update to 3.0-rc1 (for IPv6 support).

Date: Mon, 04 Dec 2017 23:08:16 +0100

Leo Famulari <leo@famulari.name> writes:

> On Mon, Dec 04, 2017 at 04:14:48PM +0100, Clément Lassieur wrote:
>> * gnu/packages/lua.scm (lua5.1-socket): Update to 3.0-rc1.
>> [source]: Change upstream URI.
>> [arguments]: Set INSTALL_TOP environment variable instead of INSTALL_TOP_SHARE
>> and INSTALL_TOP_LIB.
>
> Typically we don't package release candidates or beta software.
> Sometimes we do, if there are critical bugs fixed in the RC that we
> can't backport, or if the upstream development seems to have stalled
> without issuing a final release.
>
> Can you give more detail about this case?

Sure.  This patch adds support for IPv6 to Prosody.  See
https://prosody.im/doc/ipv6 and
https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00050.html.

Even though it's a release candidate, it's four years old, it's
recommended by Prosody, and I believe IPv6 is really important.

Message #14 received at 29562@debbugs.gnu.org (full text, mbox, reply):

From: Leo Famulari <leo@famulari.name>

To: Clément Lassieur <clement@lassieur.org>

Cc: 29562@debbugs.gnu.org

Subject: Re: [bug#29562] [PATCH] gnu: lua5.1-socket: Update to 3.0-rc1 (for IPv6 support).

Date: Tue, 5 Dec 2017 21:19:09 -0500

[Message part 1 (text/plain, inline)]

On Mon, Dec 04, 2017 at 11:08:16PM +0100, Clément Lassieur wrote:
> Leo Famulari <leo@famulari.name> writes:
> > Can you give more detail about this case?
> 
> Sure.  This patch adds support for IPv6 to Prosody.  See
> https://prosody.im/doc/ipv6 and
> https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00050.html.
> 
> Even though it's a release candidate, it's four years old, it's
> recommended by Prosody, and I believe IPv6 is really important.

Given that this RC is 4 years old, implements a critical feature (IPv6),
and is recommended by one of our major packages which is also its own
user, LGTM :)

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 29562@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: Leo Famulari <leo@famulari.name>

Cc: 29562@debbugs.gnu.org

Subject: Re: [bug#29562] [PATCH] gnu: lua5.1-socket: Update to 3.0-rc1 (for IPv6 support).

Date: Wed, 06 Dec 2017 08:26:49 +0100

Leo Famulari <leo@famulari.name> writes:

> On Mon, Dec 04, 2017 at 11:08:16PM +0100, Clément Lassieur wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> > Can you give more detail about this case?
>> 
>> Sure.  This patch adds support for IPv6 to Prosody.  See
>> https://prosody.im/doc/ipv6 and
>> https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00050.html.
>> 
>> Even though it's a release candidate, it's four years old, it's
>> recommended by Prosody, and I believe IPv6 is really important.
>
> Given that this RC is 4 years old, implements a critical feature (IPv6),
> and is recommended by one of our major packages which is also its own
> user, LGTM :)

Haha, thank you for the review :-)

Send a report that this bug log contains spam.