#28751 - GuixSD setuid-programs handling creates setuid binaries in the store

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #24 received at 28751@debbugs.gnu.org (full text, mbox, reply):

Received: (at 28751) by debbugs.gnu.org; 29 Dec 2017 23:09:57 +0000
From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 18:09:57 2017
Received: from localhost ([127.0.0.1]:57033 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1eV3mn-0002dC-7o
	for submit@debbugs.gnu.org; Fri, 29 Dec 2017 18:09:57 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60393)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@famulari.name>) id 1eV3ml-0002d5-CV
 for 28751@debbugs.gnu.org; Fri, 29 Dec 2017 18:09:55 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 383ED216CD;
 Fri, 29 Dec 2017 18:09:55 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute4.internal (MEProxy); Fri, 29 Dec 2017 18:09:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=content-type:date:from:in-reply-to:message-id:mime-version
 :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=
 mesmtp; bh=574KhnnHteuYn7jJAn+HgN7IbsevSsj/VJZPHjiEZto=; b=HeQOS
 y+cAkQJqPqIQLaKHMll0RovOmU2AdrIlQj0XQFN9DRcd7L+oa9F6ToDQMTGhsGsq
 tjATao90aiuMGzwRRi+hBPnfLtp5f9BR04xKO6l3w8SfMcM06qRlm6mZ7OPqDwc7
 BnNz01scHeO8UTmkqny26Jf+Cl57T5Y+6DBd/s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=fm1; bh=574KhnnHteuYn7jJAn+HgN7IbsevS
 sj/VJZPHjiEZto=; b=JDubrOg11wqjKPkt3ywsNnEPMw552AtkHupi8deQGnxGc
 h3p/k186QP4QuqbSp5nkO+DRP2ciDxo6677hskLu8OD5GLj/bZkdJI9QfPRdyEQr
 Dqroa+PCkd166KNUnD3M1NvjyXl40EIrPQT4hLzrK6Y5df/HdS/926Zfdp2yO6jZ
 D6uwrvdCm63h65FxHbg6ZF9h+3ZD5dHn9U9rzni7ttALe5ByqXvsS9kl9EqMLngz
 QX7VDZtpfS8ECFt3l1IJVK8WYfHQukUONsIEHLmScEmHJj4HXdLrJBWKQsOe+Tg2
 oFhH5fB/mVE7lC1K5u+kA0gUysD7Q1UesMBnB7V/g==
X-ME-Sender: <xms:Q8tGWkqEqFiiDzrmstA_s10m-kAyt7QtSIQ7CwpODX0VBtZwX4RYzA>
Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70])
 by mail.messagingengine.com (Postfix) with ESMTPA id E8AE9244C7
 for <28751@debbugs.gnu.org>; Fri, 29 Dec 2017 18:09:54 -0500 (EST)
Date: Fri, 29 Dec 2017 18:09:53 -0500
From: Leo Famulari <leo@famulari.name>
To: 28751@debbugs.gnu.org
Subject: Re: bug#28751: GuixSD setuid-programs handling creates setuid
 binaries in the store
Message-ID: <20171229230953.GA10185@jasmine.lan>
References: <87h8v9cuhw.fsf@gnu.org> <877ew5cu56.fsf@gnu.org>
 <87lgklbekx.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="/NkBOFFp2J2Af1nK"
Content-Disposition: inline
In-Reply-To: <87lgklbekx.fsf@gnu.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 28751
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

[Message part 1 (text/plain, inline)]

On Sun, Oct 08, 2017 at 09:54:22PM +0200, Ludovic Courtès wrote:
> ludo@gnu.org (Ludovic Courtès) skribis:
> 
> > ludo@gnu.org (Ludovic Courtès) skribis:
> >
> >> On GuixSD, ‘activate-setuid-programs’ in (gnu build activation) would
> >> create setuid-root binaries under /gnu/store for all the programs listed
> >> under ‘setuid-programs’ in the ‘operating-system’ declaration.
> >
> > Fixed by
> > <https://git.savannah.gnu.org/cgit/guix.git/commit/?id=5e66574a128937e7f2fcf146d146225703ccfd5d>.
> 
> Detailed announcement at:
> 
>   https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00090.html

FYI, this was assigned CVE-2017-1000455.

I just received the attached JSON from the Distributed Weakness Filing
project (DWF) in response to my CVE application.

I assume it will show up in the regular places (MITRE etc) eventually.

Having thought about this bug for a while, I think it was not too bad in
practice. The setuid executable files could be copied or preserved
somehow by an attacker whether they were in the store or in
/run/setuid-programs.

[CVE-2017-1000455.json (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 11:17:49 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#28751 GuixSD setuid-programs handling creates setuid binaries in the store