#27852 [PATCH] gnu: node: Update to 8.2.1.

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Jelle Licht <jlicht@fsfe.org>

To: guix-patches@gnu.org

Subject: [PATCH] gnu: node: Update to 8.2.1.

Date: Thu, 27 Jul 2017 17:33:05 +0200

[Message part 1 (text/plain, inline)]

It seems the node devs do not expect packagers to run `make check':
https://github.com/nodejs/node/issues/14513

Anyway, attached you will find a patch which updates node to its latest
released version while still allowing use to run most of the included test
suite.

At some point in time someone could look into getting node to build
reproducibly. Who knows, it might even be me ;-).

- Jelle

[Message part 2 (text/html, inline)]

[0001-gnu-node-Update-to-8.2.1.patch (text/x-patch, attachment)]

Message #8 received at 27852@debbugs.gnu.org (full text, mbox, reply):

From: ludo@gnu.org (Ludovic Courtès)

To: Jelle Licht <jlicht@fsfe.org>

Cc: 27852@debbugs.gnu.org

Subject: Re: [bug#27852] [PATCH] gnu: node: Update to 8.2.1.

Date: Fri, 28 Jul 2017 21:40:17 +0200

Jelle Licht <jlicht@fsfe.org> skribis:

> From f88297638a82858dff61176f646cdc4ddca748cf Mon Sep 17 00:00:00 2001
> From: Jelle Licht <jlicht@fsfe.org>
> Date: Thu, 27 Jul 2017 17:11:08 +0200
> Subject: [PATCH] gnu: node: Update to 8.2.1.
>
> * gnu/packages/node.scm (node): Update to 8.2.1.
> (node)[arguments]: Removed broken linter test.

LGTM!

> -             ;; Having the build fail because of linter errors is insane!
> +             ;; Linting is no longer supported in the release tarball
>               (substitute* '("Makefile")
> -               (("	\\$\\(MAKE\\) jslint") "")
> -               (("	\\$\\(MAKE\\) cpplint\n") ""))
> +               (("	\\$\\(MAKE\\) lint") ""))

Maybe add a link to <https://github.com/nodejs/node/issues/14513> for
future reference?

Thanks,
Ludo’.

Message #11 received at 27852@debbugs.gnu.org (full text, mbox, reply):

From: ludo@gnu.org (Ludovic Courtès)

To: Jelle Licht <jlicht@fsfe.org>

Cc: 27852@debbugs.gnu.org

Subject: Re: [bug#27852] [PATCH] gnu: node: Update to 8.2.1.

Date: Sat, 02 Sep 2017 00:20:11 +0200

Jelle, it looks like this fell through the cracks a warm summer
inevitably creates, no?  :-)

Ludo’.

ludo@gnu.org (Ludovic Courtès) skribis:

> Jelle Licht <jlicht@fsfe.org> skribis:
>
>> From f88297638a82858dff61176f646cdc4ddca748cf Mon Sep 17 00:00:00 2001
>> From: Jelle Licht <jlicht@fsfe.org>
>> Date: Thu, 27 Jul 2017 17:11:08 +0200
>> Subject: [PATCH] gnu: node: Update to 8.2.1.
>>
>> * gnu/packages/node.scm (node): Update to 8.2.1.
>> (node)[arguments]: Removed broken linter test.
>
> LGTM!
>
>> -             ;; Having the build fail because of linter errors is insane!
>> +             ;; Linting is no longer supported in the release tarball
>>               (substitute* '("Makefile")
>> -               (("	\\$\\(MAKE\\) jslint") "")
>> -               (("	\\$\\(MAKE\\) cpplint\n") ""))
>> +               (("	\\$\\(MAKE\\) lint") ""))
>
> Maybe add a link to <https://github.com/nodejs/node/issues/14513> for
> future reference?
>
> Thanks,
> Ludo’.

Send a report that this bug log contains spam.