#26361 Icecat patches

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: guix-patches@gnu.org

Cc: Andreas Enge <andreas@enge.fr>

Subject: Icecat patches

Date: Tue, 04 Apr 2017 16:05:33 +0200

The first patch fixes the crash (see
http://lists.gnu.org/archive/html/guix-devel/2017-04/msg00091.html).

The second re-enables parallel build.  I don't know why it was
disabled.  Andreas, please comment if you think it should not be
re-enabled :)

Clément

Message #8 received at 26361@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: 26361@debbugs.gnu.org

Subject: [PATCH 1/2] gnu: icecat: Use bundled ICU to avoid crashes.

Date: Tue, 4 Apr 2017 16:08:07 +0200

gnu/packages/gnuzilla.scm (icecat)[arguments] <#:configure-flags>:
Temporarily comment out "--with-system-icu".
---
 gnu/packages/gnuzilla.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 76a65f09e..adf72e41e 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
+;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -509,7 +510,11 @@ standards.")
                            "--with-system-jpeg"        ; must be libjpeg-turbo
                            "--with-system-libevent"
                            "--with-system-libvpx"
-                           "--with-system-icu"
+
+                           ;; FIXME: It is preferable to build with system
+                           ;; libraries, but this fixes crashes.
+                           ;; "--with-system-icu"
+
                            "--with-system-nspr"
                            "--with-system-nss"
                            "--enable-system-pixman"
-- 
2.11.0

Message #11 received at 26361@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: 26361@debbugs.gnu.org

Subject: [PATCH 2/2] gnu: icecat: Re-enable parallel build.

Date: Tue, 4 Apr 2017 16:08:08 +0200

gnu/packages/gnuzilla.scm (icecat)[arguments]: Re-enable parallel build.
---
 gnu/packages/gnuzilla.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index adf72e41e..74063cfb7 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -473,7 +473,6 @@ standards.")
     (arguments
      `(#:tests? #f          ; no check target
        #:out-of-source? #t  ; must be built outside of the source directory
-       #:parallel-build? #f
 
        ;; XXX: There are RUNPATH issues such as
        ;; $prefix/lib/icecat-31.6.0/plugin-container NEEDing libmozalloc.so,
-- 
2.11.0

Message #16 received at 26361@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: 26361@debbugs.gnu.org

Subject: Re: bug#26361: [PATCH 1/2] gnu: icecat: Use bundled ICU to avoid crashes.

Date: Tue, 04 Apr 2017 19:12:26 +0200

> gnu/packages/gnuzilla.scm (icecat)[arguments] <#:configure-flags>:
^
I forgot the * here.  I'll add it when I push.  Same with the other
patch.

> Temporarily comment out "--with-system-icu".

> ---
>  gnu/packages/gnuzilla.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index 76a65f09e..adf72e41e 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -5,6 +5,7 @@
>  ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
>  ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
> +;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -509,7 +510,11 @@ standards.")
>                             "--with-system-jpeg"        ; must be libjpeg-turbo
>                             "--with-system-libevent"
>                             "--with-system-libvpx"
> -                           "--with-system-icu"
> +
> +                           ;; FIXME: It is preferable to build with system
> +                           ;; libraries, but this fixes crashes.
> +                           ;; "--with-system-icu"
> +
>                             "--with-system-nspr"
>                             "--with-system-nss"
>                             "--enable-system-pixman"

Message #19 received at 26361@debbugs.gnu.org (full text, mbox, reply):

From: Marius Bakke <mbakke@fastmail.com>

To: Clément Lassieur <clement@lassieur.org>, 26361@debbugs.gnu.org

Cc: Andreas Enge <andreas@enge.fr>

Subject: Re: bug#26361: Icecat patches

Date: Tue, 04 Apr 2017 19:18:50 +0200

[Message part 1 (text/plain, inline)]

Clément Lassieur <clement@lassieur.org> writes:

> The first patch fixes the crash (see
> http://lists.gnu.org/archive/html/guix-devel/2017-04/msg00091.html).
>
> The second re-enables parallel build.  I don't know why it was
> disabled.  Andreas, please comment if you think it should not be
> re-enabled :)

I can confirm that these two patches work for me. No crashes so far, and
*much* faster build time. I'd say ship it :)

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 26361@debbugs.gnu.org (full text, mbox, reply):

From: Clément Lassieur <clement@lassieur.org>

To: Marius Bakke <mbakke@fastmail.com>

Cc: Andreas Enge <andreas@enge.fr>, 26361@debbugs.gnu.org

Subject: Re: bug#26361: Icecat patches

Date: Tue, 04 Apr 2017 20:23:43 +0200

Marius Bakke <mbakke@fastmail.com> writes:

> Clément Lassieur <clement@lassieur.org> writes:
>
>> The first patch fixes the crash (see
>> http://lists.gnu.org/archive/html/guix-devel/2017-04/msg00091.html).
>>
>> The second re-enables parallel build.  I don't know why it was
>> disabled.  Andreas, please comment if you think it should not be
>> re-enabled :)
>
> I can confirm that these two patches work for me. No crashes so far, and
> *much* faster build time. I'd say ship it :)

Pushed!

Message #29 received at 26361@debbugs.gnu.org (full text, mbox, reply):

From: ng0 <contact.ng0@cryptolab.net>

To: Clément Lassieur <clement@lassieur.org>

Cc: Marius Bakke <mbakke@fastmail.com>, 26361@debbugs.gnu.org, Andreas Enge <andreas@enge.fr>

Subject: Re: bug#26361: Icecat patches

Date: Tue, 4 Apr 2017 21:41:17 +0000

Clément Lassieur transcribed 0.5K bytes:
> Marius Bakke <mbakke@fastmail.com> writes:
> 
> > Clément Lassieur <clement@lassieur.org> writes:
> >
> >> The first patch fixes the crash (see
> >> http://lists.gnu.org/archive/html/guix-devel/2017-04/msg00091.html).
> >>
> >> The second re-enables parallel build.  I don't know why it was
> >> disabled.  Andreas, please comment if you think it should not be
> >> re-enabled :)
> >
> > I can confirm that these two patches work for me. No crashes so far, and
> > *much* faster build time. I'd say ship it :)
> 
> Pushed!
> 
> 
> 

Many thanks!

Also: I think that moved the compile time for icecat from ~3 hours down
to 30 minutes, excluding grafting (other updates are still running).

Excellent :)

Send a report that this bug log contains spam.