[PATCH] build-system: emacs: Fix getting package dependencies.

  • Done
  • quality assurance status badge
Details
3 participants
  • Andreas Enge
  • Ilya Chernyshov
  • Nicolas Graves
Owner
unassigned
Submitted by
Ilya Chernyshov
Severity
normal

Debbugs page

I
I
Ilya Chernyshov wrote on 30 Jul 08:30 -0700
(address . guix-patches@gnu.org)
CAGEwbGXYGSLYd9me35sB-+-paNHE3Vid3Vq3zZv8p_BTjk1tyg@mail.gmail.com
Hi. `ensure-package-description' procedure from emacs-build-system.scm
contains an undefined elisp function `package--prepare-dependencies'. It
was replaced with `lm--prepare-package-dependencies' after 29.1 release.
You can see the changes here:
Attachment: file
From 91d5af8e8883a15601f2a6c1e7c21fba704d1cef Mon Sep 17 00:00:00 2001
From: Ilya Chernyshov <ichernyshovvv@gmail.com>
Date: Wed, 30 Jul 2025 19:45:32 +0500
Subject: [PATCH] build-system: emacs: Fix getting package dependencies.

* guix/build/emacs-build-system (ensure-package-description): Use
lm-package-requires to get package dependencies.
---
guix/build/emacs-build-system.scm | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

Toggle diff (19 lines)
diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm
index ffa6d3cbb0..b7f31c7fee 100644
--- a/guix/build/emacs-build-system.scm
+++ b/guix/build/emacs-build-system.scm
@@ -193,11 +193,7 @@ (define %write-pkg-file-form
(and (re-search-forward ,summary-regexp nil t)
(match-string-no-properties 1)))
package--default-summary)
- (let ((require-lines (lm-header-multiline "package-requires")))
- (and require-lines
- (package--prepare-dependencies
- (package-read-from-string
- (mapconcat 'identity require-lines " ")))))
+ (lm-package-requires)
:kind 'single
:url (lm-homepage)
:keywords (lm-keywords-list)
--
2.49.0
N
N
Nicolas Graves wrote on 31 Jul 08:41 -0700
87v7n8id0v.fsf@ngraves.fr
I think this is already fixed on the emacs-team branch:

The issue is that indeed we probably need to do something to get it
merged quicker, because it's fixes rather than updates.

@Enge could we for instance drop the reproducibility patch on
emacs-team (which I can build locally without issues, but CI doesn't
seem to like it too much), and take precedence over "update" branches.
I feel it's very bad for user experience to have those errors hanging,
and emacs packages are mostly light and not that numerous, so it
shouldn't be too high of a cost on CI. I don't support selfishness of
one team, but we'll keep having these reports until we fix what's
broken.

Errors are : #603 ; #736 ; #1309 ; #997 ;
And most likely too : #993 ; #836 ; #1035 ;

@lilyp, WDYT?

Best regards,
Nicolas


On 2025-07-30 15:30, Ilya Chernyshov wrote:

Toggle quote (34 lines)
> Hi. `ensure-package-description' procedure from emacs-build-system.scm
> contains an undefined elisp function `package--prepare-dependencies'. It
> was replaced with `lm--prepare-package-dependencies' after 29.1 release.
> You can see the changes here:
> https://cgit.git.savannah.gnu.org/cgit/emacs.git/commit/?id=bb5399e3cd75450db6db9b3c5829f7bd87ca1308
> From 91d5af8e8883a15601f2a6c1e7c21fba704d1cef Mon Sep 17 00:00:00 2001
> From: Ilya Chernyshov <ichernyshovvv@gmail.com>
> Date: Wed, 30 Jul 2025 19:45:32 +0500
> Subject: [PATCH] build-system: emacs: Fix getting package dependencies.
>
> * guix/build/emacs-build-system (ensure-package-description): Use
> lm-package-requires to get package dependencies.
> ---
> guix/build/emacs-build-system.scm | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm
> index ffa6d3cbb0..b7f31c7fee 100644
> --- a/guix/build/emacs-build-system.scm
> +++ b/guix/build/emacs-build-system.scm
> @@ -193,11 +193,7 @@ (define %write-pkg-file-form
> (and (re-search-forward ,summary-regexp nil t)
> (match-string-no-properties 1)))
> package--default-summary)
> - (let ((require-lines (lm-header-multiline "package-requires")))
> - (and require-lines
> - (package--prepare-dependencies
> - (package-read-from-string
> - (mapconcat 'identity require-lines " ")))))
> + (lm-package-requires)
> :kind 'single
> :url (lm-homepage)
> :keywords (lm-keywords-list)

--
Best regards,
Nicolas Graves
Closed
A
A
Andreas Enge wrote on 1 Aug 08:34 -0700
(name . Nicolas Graves)(address . ngraves@ngraves.fr)
aIzeiG3pF43vh4o1@jurong
Hello,

Am Thu, Jul 31, 2025 at 05:41:04PM +0200 schrieb Nicolas Graves:
Toggle quote (7 lines)
> @Enge could we for instance drop the reproducibility patch on
> emacs-team (which I can build locally without issues, but CI doesn't
> seem to like it too much), and take precedence over "update" branches.
> I feel it's very bad for user experience to have those errors hanging,
> and emacs packages are mostly light and not that numerous, so it
> shouldn't be too high of a cost on CI.

one solution would be to somehow extract fixes out of the emacs-team
branch and to apply them to master. I do not know whether this is
possible depending on the scope of the changes.

Andreas
N
N
Nicolas Graves wrote on 3 Aug 23:34 -0700
(name . Andreas Enge)(address . andreas@enge.fr)
87fre7sih9.fsf@ngraves.fr
On 2025-08-01 17:34, Andreas Enge wrote:

Toggle quote (14 lines)
> Hello,
>
> Am Thu, Jul 31, 2025 at 05:41:04PM +0200 schrieb Nicolas Graves:
>> @Enge could we for instance drop the reproducibility patch on
>> emacs-team (which I can build locally without issues, but CI doesn't
>> seem to like it too much), and take precedence over "update" branches.
>> I feel it's very bad for user experience to have those errors hanging,
>> and emacs packages are mostly light and not that numerous, so it
>> shouldn't be too high of a cost on CI.
>
> one solution would be to somehow extract fixes out of the emacs-team
> branch and to apply them to master. I do not know whether this is
> possible depending on the scope of the changes.

There are very little patches, a couple of them only. The scope of
affected packages is: 1673 for emacs-minimal, 38 for emacs-no-x, 98 for
emacs.

The scope is big for a master push, but most of these packages are
light, it has nothing to do with pushing such changes with heavy C/C++
packages.

--
Best regards,
Nicolas Graves
?
Your comment

This issue is archived.

To comment on this conversation send an email to 79129@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 79129
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch