[PATCH 0/3] Update gopls.

  • Done
  • quality assurance status badge
Details
2 participants
  • Sharlatan Hellseher
  • Tomas Volf
Owner
unassigned
Submitted by
Tomas Volf
Severity
normal

Debbugs page

T
T
Tomas Volf wrote on 12 Jul 15:42 -0700
(address . guix-patches@gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
cover.1752360127.git.~@wolfsden.cz
Update gopls to 1.19.1.

Tomas Volf (3):
gnu: go-honnef-co-go-tools: Update to 0.6.1.
gnu: Add go-github-com-fatih-gomodifytags-modifytags.
gnu: gopls: Update to 0.19.1.

gnu/packages/golang-apps.scm | 15 ++++++++++-----
gnu/packages/golang-check.scm | 7 +++++--
gnu/packages/golang-xyz.scm | 33 +++++++++++++++++++++++++++++++++
3 files changed, 48 insertions(+), 7 deletions(-)

--
2.50.0
T
T
Tomas Volf wrote on 12 Jul 15:47 -0700
[PATCH 1/3] gnu: go-honnef-co-go-tools: Update to 0.6.1.
(address . 79002@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
c9762ef2bd1b13597c18ba3659fe169d300239f8.1752360127.git.~@wolfsden.cz
* gnu/packages/golang-check.scm (go-honnef-co-go-tools): Update to 0.6.1.
[arguments]: Use go-1.23.
[propagated-inputs]: Add go-golang-org-x-exp.

Change-Id: I113e77de26f72a8b88052a1d5b687ee0293c406d
---
gnu/packages/golang-check.scm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Toggle diff (44 lines)
diff --git a/gnu/packages/golang-check.scm b/gnu/packages/golang-check.scm
index a62b34c5a2..fc1e186267 100644
--- a/gnu/packages/golang-check.scm
+++ b/gnu/packages/golang-check.scm
@@ -51,6 +51,7 @@ (define-module (gnu packages golang-check)
#:use-module (guix utils)
#:use-module (gnu packages)
#:use-module (gnu packages bash)
+ #:use-module (gnu packages golang)
#:use-module (gnu packages golang-build)
#:use-module (gnu packages golang-xyz)
#:use-module (gnu packages version-control))
@@ -2754,7 +2755,7 @@ (define-public go-gotest-tools-v3
(define-public go-honnef-co-go-tools
(package
(name "go-honnef-co-go-tools")
- (version "0.4.7")
+ (version "0.6.1")
(source
(origin
(method git-fetch)
@@ -2764,10 +2765,11 @@ (define-public go-honnef-co-go-tools
(file-name (git-file-name name version))
(sha256
(base32
- "1n58skq2a0vhsgdfdkyqi00d3vv13kiw9b4mxx6xfyb6ysrdy7d1"))))
+ "0y4xbb91mv1rj7aps5g7hz1mhf5pbdc8yp5bxz6dq5ajlmfqwi3s"))))
(build-system go-build-system)
(arguments
(list
+ #:go go-1.23
#:import-path "honnef.co/go/tools"
#:phases
#~(modify-phases %standard-phases
@@ -2780,6 +2782,7 @@ (define-public go-honnef-co-go-tools
(invoke "go" "test" "-v" "./..."))))))))
(propagated-inputs
(list go-github-com-burntsushi-toml
+ go-golang-org-x-exp
go-golang-org-x-exp-typeparams
go-golang-org-x-mod
go-golang-org-x-tools))
--
2.50.0
T
T
Tomas Volf wrote on 12 Jul 15:47 -0700
[PATCH 2/3] gnu: Add go-github-com-fatih-gomodifytags-modifytags.
(address . 79002@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
dcc0d8645d345ae9b4f5633784c498dabbc6b8c5.1752360127.git.~@wolfsden.cz
* gnu/packages/golang-xyz.scm (go-github-com-fatih-gomodifytags-modifytags):
New variable.

Change-Id: I821d8fee339666f0c655bf2a7f53c068ddeb9bc9
---
gnu/packages/golang-xyz.scm | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)

Toggle diff (46 lines)
diff --git a/gnu/packages/golang-xyz.scm b/gnu/packages/golang-xyz.scm
index 78dac852ed..6f40d06f88 100644
--- a/gnu/packages/golang-xyz.scm
+++ b/gnu/packages/golang-xyz.scm
@@ -6065,6 +6065,39 @@ (define-public go-github-com-fatih-color
defined output to the standard output.")
(license license:expat)))
+(define-public go-github-com-fatih-gomodifytags-modifytags
+ (let ((commit "f3939df9aa3cc13eb51e50268af256b4f9272cdb")
+ (rev "0"))
+ (package
+ (name "go-github-com-fatih-gomodifytags-modifytags")
+ (version (git-version "1.17.0" rev commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/fatih/gomodifytags")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0gr9bs5f94kpnmjsg7dn6gr7yazlgllyypy2g6xvqrhgzrk2ckbr"))))
+ (build-system go-build-system)
+ (arguments
+ (list
+ #:import-path "github.com/fatih/gomodifytags/modifytags"
+ #:unpack-path "github.com/fatih/gomodifytags"))
+ (propagated-inputs (list go-github-com-fatih-structtag
+ go-github-com-fatih-camelcase))
+ (home-page "https://github.com/fatih/gomodifytags")
+ (synopsis "gomodifytags")
+ (description
+ "Go tool to modify/update field tags in structs. @@code{gomodifytags} makes it
+easy to update, add or delete the tags in a struct field. You can easily add
+new tags, update existing tags (such as appending a new key, i.e: @@code{db},
+@@code{xml}, etc..) or remove existing tags. It also allows you to add and
+remove tag options. It's intended to be used by an editor, but also has modes
+to run it from the terminal. Read the usage section below for more information.")
+ (license license:bsd-3))))
+
(define-public go-github-com-fatih-structs
(package
(name "go-github-com-fatih-structs")
--
2.50.0
T
T
Tomas Volf wrote on 12 Jul 15:47 -0700
[PATCH 3/3] gnu: gopls: Update to 0.19.1.
(address . 79002@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
7206fc2a7e496b5babbf5c3db49a31efb0f85a24.1752360127.git.~@wolfsden.cz
* gnu/packages/golang-apps.scm (gopls): Update to 0.19.1.
[arguments]: Use go-1.24.
<#:phases>: Add 'set-env.
[native-inputs]: Add go-github-com-fatih-gomodifytags-modifytags.

Change-Id: I5d3b371f3eadf0e6f28d3def228849e46772b7fb
---
gnu/packages/golang-apps.scm | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

Toggle diff (46 lines)
diff --git a/gnu/packages/golang-apps.scm b/gnu/packages/golang-apps.scm
index c0a35c2e2a..36ea2b7620 100644
--- a/gnu/packages/golang-apps.scm
+++ b/gnu/packages/golang-apps.scm
@@ -124,7 +124,7 @@ (define-public gopls
(name "gopls")
;; XXX: Starting from 0.14.0 gppls needs golang.org/x/telemetry, which
;; needs to be discussed if it may be included in Guix.
- (version "0.18.1")
+ (version "0.19.1")
(source
(origin
(method git-fetch)
@@ -133,11 +133,11 @@ (define-public gopls
(commit (go-version->git-ref version #:subdir "gopls"))))
(file-name (git-file-name name version))
(sha256
- (base32 "0s396bjwac1acrlpbp7k7xfyhmkykyxc08w6hirbdhlq8vg923p7"))))
+ (base32 "1dihdw4nzp21hlbwxf6qyhyfgavi1a55lmlyk36czd85v0jcp6a0"))))
(build-system go-build-system)
(arguments
(list
- #:go go-1.23
+ #:go go-1.24
#:install-source? #f
#:import-path "golang.org/x/tools/gopls"
#:unpack-path "golang.org/x/tools"
@@ -153,9 +153,14 @@ (define-public gopls
(lambda _
;; XXX: Write a procedure deleting all but current module source
;; to cover case with monorepo.
- (delete-file-recursively "src/golang.org/x/tools"))))))
+ (delete-file-recursively "src/golang.org/x/tools")))
+ (add-before 'check 'set-env
+ (lambda _
+ ;; Required for fingerprint_test.TestMatches.
+ (setenv "GODEBUG" "gotypesalias=1"))))))
(native-inputs
- (list go-github-com-google-go-cmp
+ (list go-github-com-fatih-gomodifytags-modifytags
+ go-github-com-google-go-cmp
go-github-com-jba-templatecheck
go-golang-org-x-mod
go-golang-org-x-sync
--
2.50.0
S
S
Sharlatan Hellseher wrote on 13 Jul 02:47 -0700
[PATCH 0/3] Update gopls.
(address . 79002@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
87ldospgls.fsf@gmail.com
Hi,

Thank you for the patch!

Why not to open a Merge Request on CodeBerg?


---
Oleg
-----BEGIN PGP SIGNATURE-----

iQJKBAEBCgA0FiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmhzgK8WHHNoYXJsYXRh
bnVzQGdtYWlsLmNvbQAKCRB21ye/9izStaHkEACevQJmMYb9hUzzB3DiY8ePe/F0
iefVc4+sj9JT+TmkW0DVKzkMe4ypf6u2wQEkiDKyERogno49xc6rlffhmZ/eIDFd
0b2H1D/56TV6gujnuHf0x03lPHwrg2wN/ZYA8ewYrw+pns3BisZLYzBlF1Q5NptE
Biodw4B4LTj8SINNKgBXys8CNG4RyJ9/pt8ICBhcDtconASTcLe0KDWqMkmfE1XI
MB/oR/rTD6Tz1rZJfzOiDVerdsboKKrEDPqfP+d/CvxI2BUUuR51Sw99gQLSFdOz
ZMXBCUg6YfKiVOtVsDxhY7jCZeK6akPZL+rYKkD4UMpGbOdmNm5AjpVtDUU9MgRg
Fgn77wthyXq0SQlcLs/Tu+bk29YpqHTj2PQ6U451DaDbVRW7YcxsDaWGHrAp+caH
imnyfAgmB/qDEu7vLmrRbywj2/daDWkfPhhgxYYQA6YK3cy+z2pM02OBVLlARdwl
TtZ2+KOsgt0Pox4fIar7Z3F2OM23SZ78c8nRQ6wN0yx6RAfKdIHRNzHHXcyIxcoJ
UMnQaMUgTUxjvHd++HSJmCYUvb3urnFJ6ooOOuRM3Eo3p30nxwMVIjySjHXv5iXd
vWMVramW5Bt3OkHRx22T+ey3tXettwzjuFF8p2b628BMuMfyyx9yOMOrEN+h/JT8
+JFzT6x873XZ/aOIOA==
=ke17
-----END PGP SIGNATURE-----

T
T
Tomas Volf wrote on 13 Jul 16:10 -0700
(name . Sharlatan Hellseher)(address . sharlatanus@gmail.com)(address . 79002@debbugs.gnu.org)
87v7nv3cx0.fsf@wolfsden.cz
Hi :)

Sharlatan Hellseher <sharlatanus@gmail.com> writes:

Toggle quote (4 lines)
> Why not to open a Merge Request on CodeBerg?
>
> https://codeberg.org/guix/guix/pulls

I do not currently have a Codeberg account -- which is a necessary
prerequisite for making a pull request -- and due to my concerns
regarding the Terms of Use that I have raised during the GCD procedure,
I do not currently want to make one. Ludovic mentioned the possibility
of discussing the issues with Codeberg after the migration, so I am
waiting on the result of that.

At the same time I fully acknowledge that I am in a tiny minority, so it
is not exactly a important issue. Since the mailing list will be
operational until the end of year (at least), I am planning to figure
out my feelings regarding Codeberg in the winter.

Tomas

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
S
S
Sharlatan Hellseher wrote on 14 Jul 03:46 -0700
[PATCH 0/3] Update gopls.
(address . 79002-done@debbugs.gnu.org)
87h5zfoxr0.fsf@gmail.com
Hi,

Pushed with modifications to master:

6cf00e6cdec * master origin/master gnu: gopls: Update to 0.19.1.
3fea0faff60 * gnu: Add go-github-com-fatih-gomodifytags.
710f245eea7 * gnu: go-honnef-co-go-tools: Update to 0.6.1.

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQJKBAEBCgA0FiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmh04CMWHHNoYXJsYXRh
bnVzQGdtYWlsLmNvbQAKCRB21ye/9izStTN9D/0UwmytzCMC2I5/azN4o4xEzxsV
16tTrPUz1irMSCERlWYmOcUi3xdm0CBD67rd2/moBMP8oH36+0nQpkMWJek4FJWF
5+oJTzzqBLUq0kh210biMMJpGbqtCYUBKF+jGmfK8jCjfiVc8zSvEKuauPNbmsDt
73agZ0nBWVGmU5KSb//DDjQ0Eg7QantV8whKjY2jQRUldXz1NoCkvEjkLW37d1kQ
fn/Ti2o9MHoEbAq7O50sJ8mBzMsDXwDZuIPNe5OzndInlcZVcyoYXjdu9xAwJaiz
OzMUS9wS7bPHStFHbm+eZQMTyqhr2bOP76gwlOY5zJfDF73tOUas6BNVFOQNa+8n
mr/0NjrMRbsiihUWwWwqN2Zk4KUUDrNPqK0/cV3qnd4Yd8uCBpgbKoaPMAW1NHdd
SFXYKN1nEc8LQkxE193B+lLGohy0oZzxoUFhB0P3olNf7/taUM0qxpRKvaVcLJUr
4XQr3Vo2Z9xf+OlZjNQBcCOoDAcdBdDjS3AX5giIWnAmueZHQu45Z7QOT/Sr/nFV
dCZwbHC/FakhAh/zxxDl8qSwJn6XW3daJaunJITtasdrrf46E5dMtaIavU6aNLrc
Ez9lL7eXJGmVxvo7/afLZ+mFIRSolvVV4b6ihiUO8lodEhudbEaJbI7IGkyqPiOf
h0e5FDkR+z5f4FL1pA==
=EWpL
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 79002@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 79002
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch