telegram-desktop package fails to build

  • Done
  • quality assurance status badge
Details
5 participants
  • Apoorv Singh
  • Jonathan Brielmaier
  • Liliana Marie Prikler
  • Maxim Cournoyer
  • Arseniy Zaostrovnykh
Owner
unassigned
Submitted by
Apoorv Singh
Severity
normal

Debbugs page

A
A
Apoorv Singh wrote on 12 Mar 19:07 -0700
(address . bug-guix@gnu.org)
87jz8tznrj.fsf@gmail.com
telegram-desktop package fails to build on latest guix, here are
the logs,

/gnu/store/ylgkrq9j1gyfig2y66srmgsbyh9w20d9-binutils-2.41/bin/ar
qc liblib_spellcheck.a
CMakeFiles/lib_spellcheck.dir/spellcheck/third_party/language_cld3.cpp.o
CMakeFiles/lib_spellcheck.dir/spellcheck/third_party/hunspell_controller.cpp.o
CMakeFiles/lib_spellcheck.dir/spellcheck/third_party/spellcheck_hunspell.cpp.o
CMakeFiles/lib_spellcheck.dir/spellcheck/spellcheck_highlight_syntax.cpp.o
CMakeFiles/lib_spellcheck.dir/spellcheck/spellcheck_utils.cpp.o
CMakeFiles/lib_spellcheck.dir/spellcheck/spellcheck_value.cpp.o
CMakeFiles/lib_spellcheck.dir/spellcheck/spelling_highlighter.cpp.o
CMakeFiles/lib_spellcheck.dir/spellcheck/spelling_highlighter_helper.cpp.o
CMakeFiles/lib_spellcheck.dir/lib_spellcheck_autogen/F3DR3ROXBB/qrc_highlighting.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/common/crl_common_fp_exceptions.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/common/crl_common_list.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/common/crl_common_on_main.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/common/crl_common_queue.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/dispatch/crl_dispatch_async.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/dispatch/crl_dispatch_queue.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/dispatch/crl_dispatch_semaphore.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/linux/crl_linux_time.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/winapi/crl_winapi_async.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/winapi/crl_winapi_fp_exceptions.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/winapi/crl_winapi_list.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/winapi/crl_winapi_semaphore.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/winapi/crl_winapi_time.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/crl_object_on_thread.cpp.o
../lib_crl/CMakeFiles/lib_crl.dir/crl/crl_time.cpp.o
/gnu/store/ylgkrq9j1gyfig2y66srmgsbyh9w20d9-binutils-2.41/bin/ranlib
liblib_spellcheck.a
make[2]: Leaving directory
'/tmp/guix-build-telegram-desktop-5.5.5.drv-0/build'
[ 34%] Built target lib_spellcheck
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:
In lambda function:
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:793:36:
error: ‘class gi::repository::Gio::Credentials’ has no member
named ‘get_unix_pid’
793 | return credentials.get_unix_pid(nullptr)
| ^~~~~~~~~~~~
In file included from
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/object.hpp:4,
from
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/gi.hpp:35,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/build/gen/webview/webview.hpp:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:24:
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/callback.hpp:
In instantiation of ‘gi::detail::connectable<R(Args
...)>::data::data(T&&) [with T =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
Enable = void; R = bool; Args =
{gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials}]’:


/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/object.hpp:432:36:
required from ‘gulong
gi::repository::GObject::Object::connect(gi::detail::cstring_v,
Functor&&) [with F = bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials);
Functor =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
gulong = long unsigned int; gi::detail::cstring_v =
gi::detail::cstring_v_d<>]’
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/object.hpp:546:44:
required from ‘gulong gi::signal_proxy<R(Instance, Args ...),
Base>::connect(Functor&&) [with Functor =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
R = bool; Instance = gi::repository::Gio::DBusAuthObserver; Args =
{gi::repository::Gio::IOStream, gi::repository::Gio::Credentials};
Base = gi::repository::GObject::Object; gulong = long unsigned
int]’
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:789:60:
required from here
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/callback.hpp:687:19:
error: no matching function for call to
‘std::function<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::function(Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>)’
687 | data(T &&t) : callable(std::forward<T>(t))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/functional:59,
from
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/pstl/glue_algorithm_defs.h:13,
from
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/algorithm:74,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/qglobal.h:142,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/qiterator.h:43,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/qmap.h:43,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/QMap:1,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_base/base/ordered_set.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_base/base/basic_types.h:10,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/webview_common.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/webview_interface.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:7:
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/std_function.h:435:9:
note: candidate: ‘template<class _Functor, class _Constraints>
std::function<_Res(_ArgTypes ...)>::function(_Functor&&) [with
_Functor = _Functor; _Constraints = _Constraints; _Res = bool;
_ArgTypes = {gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials}]’
435 | function(_Functor&& __f)
| ^~~~~~~~


/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/type_traits:2205:11:
error: no type named ‘type’ in ‘struct std::enable_if<false,
void>’
2205 | using __enable_if_t = typename enable_if<_Cond,
_Tp>::type;
| ^~~~~~~~~~~~~
In file included from
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/functional:59,
from
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/pstl/glue_algorithm_defs.h:13,
from
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/algorithm:74,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/qglobal.h:142,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/qiterator.h:43,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/qmap.h:43,
from
/gnu/store/vp4h9l92l4phccfbs8sd14i4cyxz970p-qtbase-5.15.15/include/qt5/QtCore/QMap:1,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_base/base/ordered_set.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_base/base/basic_types.h:10,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/webview_common.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/webview_interface.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.h:9,
from
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:7:
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/callback.hpp:
In instantiation of ‘gi::detail::connectable<R(Args
...)>::data::data(T&&) [with T =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
Enable = void; R = bool; Args =
{gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials}]’:
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/stl_construct.h:97:14:
required from ‘constexpr decltype (::new(void*(0)) _Tp)
std::construct_at(_Tp*, _Args&& ...) [with _Tp =
gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data; _Args =
{Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>}; decltype (::new(void*(0))
_Tp) =
gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data*]’
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/alloc_traits.h:518:4:
required from ‘static constexpr void
std::allocator_traits<std::allocator<_CharT>
Toggle quote (2 lines)
>::construct(std::allocator_traits<std::allocator<_CharT>
>::allocator_type&, _Up*, _Args&& ...) [with _Up =
gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data; _Args =
{Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>}; _Tp =
gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data;
std::allocator_traits<std::allocator<_CharT> >::allocator_type =
std::allocator<gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data>]’
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/shared_ptr_base.h:519:39:
required from ‘std::_Sp_counted_ptr_inplace<_Tp, _Alloc,
_Lp>::_Sp_counted_ptr_inplace(_Alloc, _Args&& ...) [with _Args =
{Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>}; _Tp =
gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data; _Alloc =
std::allocator<gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data>; __gnu_cxx::_Lock_policy
_Lp = __gnu_cxx::_S_atomic]’
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/shared_ptr_base.h:650:16:
required from ‘std::__shared_count<_Lp>::__shared_count(_Tp*&,
std::_Sp_alloc_shared_tag<_Alloc>, _Args&& ...) [with _Tp =
gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data; _Alloc =
std::allocator<gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data>; _Args =
{Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>}; __gnu_cxx::_Lock_policy _Lp =
__gnu_cxx::_S_atomic]’
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/shared_ptr_base.h:1342:14:
required from ‘std::__shared_ptr<_Tp,
_Lp>::__shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...)
[with _Alloc =
std::allocator<gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data>; _Args =
{Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>}; _Tp =
gi::detail::connectable<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>::data; __gnu_cxx::_Lock_policy
_Lp = __gnu_cxx::_S_atomic]’
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/shared_ptr.h:409:59:
[ skipping 5 instantiation contexts, use
-ftemplate-backtrace-limit=0 to disable ]
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/callback.hpp:802:66:
required from ‘gi::detail::transform_callback_wrapper<R(Args ...),
CR(CArgs ...)>::with_transfer<AUTODESTROY, RetTransfer,
Transfers>::with_transfer(T&&) [with T =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
bool AUTODESTROY = false; RetTransfer = gi::transfer_full_t;
Transfers = {gi::transfer_none_t, gi::transfer_none_t,
gi::transfer_none_t}; R = bool; Args =
{gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials};
CR = int; CArgs = {_GDBusAuthObserver*, _GIOStream*,
_GCredentials*}]’
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/callback.hpp:875:62:
required from ‘gi::detail::transform_signal_wrapper<R(Args
...)>::transform_signal_wrapper(T&&) [with T =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
R = bool; Args = {gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials}]’
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/object.hpp:421:14:
required from ‘gulong
gi::repository::GObject::Object::connect_data(gi::detail::cstring_v,
Functor&&, GConnectFlags) [with F =
bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials);
Functor =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
gulong = long unsigned int; gi::detail::cstring_v =
gi::detail::cstring_v_d<>]’
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/object.hpp:432:36:
required from ‘gulong
gi::repository::GObject::Object::connect(gi::detail::cstring_v,
Functor&&) [with F = bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials);
Functor =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
gulong = long unsigned int; gi::detail::cstring_v =
gi::detail::cstring_v_d<>]’
/gnu/store/kdwmwgjfpb87picxjzczah0vzz7g2nw4-cppgir-for-telegram-desktop-2.0-0.9c4f582/include/cppgir/gi/object.hpp:546:44:
required from ‘gulong gi::signal_proxy<R(Instance, Args ...),
Base>::connect(Functor&&) [with Functor =
Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>;
R = bool; Instance = gi::repository::Gio::DBusAuthObserver; Args =
{gi::repository::Gio::IOStream, gi::repository::Gio::Credentials};
Base = gi::repository::GObject::Object; gulong = long unsigned
int]’
/tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:789:60:
required from here
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/std_function.h:404:7:
note: candidate: ‘std::function<_Res(_ArgTypes
...)>::function(std::function<_Res(_ArgTypes ...)>&&) [with _Res =
bool; _ArgTypes = {gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials}]’
404 | function(function&& __x) noexcept
| ^~~~~~~~
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/std_function.h:404:27:
note: no known conversion for argument 1 from
‘Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>’
to ‘std::function<bool(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream,
gi::repository::Gio::Credentials)>&&’
404 | function(function&& __x) noexcept
| ~~~~~~~~~~~^~~
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/std_function.h:386:7:
note: candidate: ‘std::function<_Res(_ArgTypes
...)>::function(const std::function<_Res(_ArgTypes ...)>&) [with
_Res = bool; _ArgTypes = {gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials}]’
386 | function(const function& __x)
| ^~~~~~~~
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/std_function.h:386:32:
note: no known conversion for argument 1 from
‘Webview::WebKitGTK::{anonymous}::Instance::startProcess()::<lambda(gi::repository::Gio::DBusAuthObserver,
gi::repository::Gio::IOStream, gi::repository::Gio::Credentials)>’
to ‘const
This message was truncated. Download the full message here.
A
A
Arseniy Zaostrovnykh wrote on 15 Mar 08:23 -0700
(address . 76991@debbugs.gnu.org)
CANy7P7TbYzoerxqGGjLnLOJUG3nBtw+_BgKrkPMbLgBs0G9uYg@mail.gmail.com
I've been bisecting this for a few days, and I found out that
telegram-desktop broke in one of the following commits (I can't say more
precisely, as in all of these commits one of the dependencies fails to
build):

02e367863e * gnu: webkitgtk: Update to 2.46.0.
0c4a080564 * gnu: wpebackend-fdo: Update to 1.14.3.
53d8218792 * gnu: libwpe: Update to 1.16.0.
cf15cab918 * gnu: sysprof: Add libdex to inputs.
06ba3b09f4 * gnu: libsecret: Fix build.
2a5ab42e6f * gnu: gst-editing-services: Fix build.
19d906f82f * gnu: gst-plugins-bad: Disable failing test.
eef3e925fb * gnu: gjs: Fix build.
6056174792 * gnu: json-glib: Update to 1.10.0.
dae7f8b822 * gnu: python-pygobject: Update to 3.50.0.
e289080871 * gnu: cairo: Update to 1.18.2.
200cbecb42 * gnu: bootstrap glib and gobject against each other.
17d9803374 * gnu: gobject-introspection: Update to 1.82.0.

It seems that it is the gobject-introspection that broke it (17d9803374 *
gnu: gobject-introspection: Update to 1.82.0). Probably it broke other
stuff too that's why I wasn't able to build dependencies of
telegram-desktop.

Nonetheless, it seems that upgrading cppgir-for-telegram-desktop package to
the latest version fixes it, so I'll prepare and send a patch shortly.

--
Necto.
Attachment: file
A
A
Arseniy Zaostrovnykh wrote on 15 Mar 23:17 -0700
[PATCH] gnu: cppgir-for-telegram-desktop: Update to 2e96cab to fix telegram
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
c64ff65831ca6e41cacc03f47692398b4c7e9aa5.1742105565.git.necto.ne@gmail.com
* gnu/packages/glib.scm (cppgir-for-telegram-desktop): Update to the
latest version 2e96cab8ed40df326815b87b1e4b449e0c1a5947 to fix
telegram-desktop build that was broken since the gobject-introspection
update (17d9803374 * gnu: gobject-introspection: Update to 1.82.0)

Change-Id: I336168d49c5ac96ce5205f9824ce42701edb058c
---
gnu/packages/glib.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index 91bb183152..fb1acceac4 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -1649,7 +1649,7 @@ (define-public cppgir
;; telegram-desktop requires a more recent version of cppgir
(define-public cppgir-for-telegram-desktop
- (let ((commit "9c4f5820d94d62ab451501f016bfea97156518f4")
+ (let ((commit "2e96cab8ed40df326815b87b1e4b449e0c1a5947")
(revision "0"))
(package
(inherit cppgir)
@@ -1664,4 +1664,4 @@ (define-public cppgir-for-telegram-desktop
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "1fa9nf4yljfarihaqj5kd98yysrky7q316mh6l5b1rq39ga15k9b")))))))
+ (base32 "0rdcgnriw8s5fqyx2v4218ii647l4fl1s9crnm9ihzf9bpl2p5p9")))))))

base-commit: f9726d5498e63a433fdd3398a4439089072482d5
--
2.48.1
A
A
Arseniy Zaostrovnykh wrote on 16 Mar 13:40 -0700
[PATCH 0/3] Fix telegram-desktop build and update it
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
cover.1742157532.git.necto.ne@gmail.com
After fixing the telegram-desktop build (via updating cppgir), I couldn't
manage to actually run it (the build passes fine) but it constantly crashes at
runtime.

This patch series inlcudes the single patch I've sent to this thread before,
so it completely supercedes it. In addition to fixing the build, it updates
telegram-desktop to the most recent stable version. This new version (5.12.3)
does build and run smoothly on my machine.

Arseniy Zaostrovnykh (3):
gnu: cppgir-for-telegram-desktop: Update to 2e96cab to fix telegram
gnu: c++-gsl: Update to 4.2.0
gnu: telegram-desktop: Update to version 5.12.3

gnu/packages/cpp.scm | 4 +-
gnu/packages/glib.scm | 4 +-
.../patches/lib-tl-for-telegram-memcpy.patch | 27 +++++++++
...ram-desktop-hashmap-incomplete-value.patch | 60 +++++++++++++++++++
.../patches/telegram-desktop-qguiapp.patch | 26 ++++++++
.../telegram-desktop-unbundle-gsl.patch | 31 ----------
gnu/packages/telegram.scm | 51 ++++++++--------
7 files changed, 144 insertions(+), 59 deletions(-)
create mode 100644 gnu/packages/patches/lib-tl-for-telegram-memcpy.patch
create mode 100644 gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch
create mode 100644 gnu/packages/patches/telegram-desktop-qguiapp.patch
delete mode 100644 gnu/packages/patches/telegram-desktop-unbundle-gsl.patch


base-commit: f9726d5498e63a433fdd3398a4439089072482d5
--
2.48.1
A
A
Arseniy Zaostrovnykh wrote on 16 Mar 13:45 -0700
[PATCH 1/3] gnu: cppgir-for-telegram-desktop: Update to 2e96cab
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
1159f2f9f7d596d03f6ab7ac72bf789e80ad16dc.1742157532.git.necto.ne@gmail.com
* gnu/packages/glib.scm (cppgir-for-telegram-desktop): Update to the
latest version 2e96cab8ed40df326815b87b1e4b449e0c1a5947 to fix
telegram-desktop build that was broken since the gobject-introspection
update (17d9803374 * gnu: gobject-introspection: Update to 1.82.0)

Change-Id: I336168d49c5ac96ce5205f9824ce42701edb058c
---
gnu/packages/glib.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (21 lines)
diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index 91bb183152..fb1acceac4 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -1649,7 +1649,7 @@ (define-public cppgir
;; telegram-desktop requires a more recent version of cppgir
(define-public cppgir-for-telegram-desktop
- (let ((commit "9c4f5820d94d62ab451501f016bfea97156518f4")
+ (let ((commit "2e96cab8ed40df326815b87b1e4b449e0c1a5947")
(revision "0"))
(package
(inherit cppgir)
@@ -1664,4 +1664,4 @@ (define-public cppgir-for-telegram-desktop
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "1fa9nf4yljfarihaqj5kd98yysrky7q316mh6l5b1rq39ga15k9b")))))))
+ (base32 "0rdcgnriw8s5fqyx2v4218ii647l4fl1s9crnm9ihzf9bpl2p5p9")))))))
--
2.48.1
A
A
Arseniy Zaostrovnykh wrote on 16 Mar 13:45 -0700
[PATCH 2/3] gnu: c++-gsl: Update to 4.2.0
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
618d9c05dcec7fb1a009a5a3aeafd6152c4b154f.1742157532.git.necto.ne@gmail.com
* gnu/packages/cpp.scm (c++-gsl): Update to 4.2.0
It is needed to build the newer telegram v5.12.3

Change-Id: Iceb1c17d4195711159aa03ad161f094c3e78bbd9
---
gnu/packages/cpp.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 8d482d1fbd..4a351bf0d9 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -399,7 +399,7 @@ (define-public robin-hood-hashing
(define-public c++-gsl
(package
(name "c++-gsl")
- (version "4.0.0")
+ (version "4.2.0")
(source
(origin
(method git-fetch)
@@ -411,7 +411,7 @@ (define-public c++-gsl
(file-name
(git-file-name name version))
(sha256
- (base32 "0dgb3rb6x2276d3v7x568m3zhqr67rhk8ynqgm3c304avnmcaw3i"))))
+ (base32 "08w3ppd43wx9vq641ljw5izjd7p5w7drynw13ll9shwy41ydif9n"))))
(build-system cmake-build-system)
(native-inputs
(list googletest pkg-config))
--
2.48.1
A
A
Arseniy Zaostrovnykh wrote on 16 Mar 13:45 -0700
[PATCH 3/3] gnu: telegram-desktop: Update to version 5.12.3
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
1318f2a5d117712067bb459090bbb592c0ac6ee5.1742157532.git.necto.ne@gmail.com
* gnu/packages/telegram.scm (%telegram-version): Update to 5.12.3
(cmake-helpers-for-telegram-desktop): update to revision used by v5.12.3
Remove the obsolete patch (the PR was merged in this revision)
(codegen-for-telegram-desktop): update to revision used by v5.12.3
(lib-base-for-telegram-desktop): update to revision used by v5.12.3
(lib-lottie-for-telegram-desktop): update to revision used by v5.12.3
(lib-rpl-for-telegram-desktop): update to revision used by v5.12.3
(lib-spellcheck-for-telegram-desktop): update to revision used by v5.12.3
(lib-tl-for-telegram-desktop): Apply a patch to fix gcc-11
compilation error
(lib-ui-for-telegram-desktop): update to revision used by v5.12.3
(lib-webrtc-for-telegram-desktop): update to revision used by v5.12.3
(telegram-desktop): Update to v5.12.3; apply patches to make it compile
* gnu/packages/patches/telegram-desktop-unbundle-gsl.patch: removed
no longer needed in the new revision
* gnu/packages/patches/lib-tl-for-telegram-memcpy.patch:
new file. patch to fix a compilation error
* gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch:
new file. patch to fix a compilation error
* gnu/packages/patches/telegram-desktop-qguiapp.patch:
new file. patch to fix a compilation error

Change-Id: Iaa34ff2cd3f55aa92b1d9ba61a2ff66a72eb1132
---
.../patches/lib-tl-for-telegram-memcpy.patch | 27 +++++++++
...ram-desktop-hashmap-incomplete-value.patch | 60 +++++++++++++++++++
.../patches/telegram-desktop-qguiapp.patch | 26 ++++++++
.../telegram-desktop-unbundle-gsl.patch | 31 ----------
gnu/packages/telegram.scm | 51 ++++++++--------
5 files changed, 140 insertions(+), 55 deletions(-)
create mode 100644 gnu/packages/patches/lib-tl-for-telegram-memcpy.patch
create mode 100644 gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch
create mode 100644 gnu/packages/patches/telegram-desktop-qguiapp.patch
delete mode 100644 gnu/packages/patches/telegram-desktop-unbundle-gsl.patch

Toggle diff (345 lines)
diff --git a/gnu/packages/patches/lib-tl-for-telegram-memcpy.patch b/gnu/packages/patches/lib-tl-for-telegram-memcpy.patch
new file mode 100644
index 0000000000..90809cc1ce
--- /dev/null
+++ b/gnu/packages/patches/lib-tl-for-telegram-memcpy.patch
@@ -0,0 +1,27 @@
+From 7e08865a01b265bd884bb9e39ecc86497bcf5203 Mon Sep 17 00:00:00 2001
+From: Arseniy Zaostrovnykh <necto.ne@gmail.com>
+Date: Sun, 16 Mar 2025 20:56:37 +0100
+Subject: [PATCH] [PATCH] tl/tl_basic_types.h: Fix compilation error for
+ missing memcpy
+
+ * tl/tl_basic_types.h: Add include for cstring to fix the compilation
+ error about missing memcpy raised by gcc 11
+---
+ tl/tl_basic_types.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tl/tl_basic_types.h b/tl/tl_basic_types.h
+index 5eadf62..e9b6da5 100644
+--- a/tl/tl_basic_types.h
++++ b/tl/tl_basic_types.h
+@@ -11,6 +11,7 @@
+ #include "base/bytes.h"
+
+ #include <QtCore/QVector>
++#include <cstring>
+
+ namespace tl {
+ namespace details {
+--
+2.48.1
+
diff --git a/gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch b/gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch
new file mode 100644
index 0000000000..bbbce489e9
--- /dev/null
+++ b/gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch
@@ -0,0 +1,60 @@
+From 3865a179b3aed172bac4a3dcd1f320270de16dcf Mon Sep 17 00:00:00 2001
+From: Arseniy Zaostrovnykh <necto.ne@gmail.com>
+Date: Sun, 16 Mar 2025 20:49:16 +0100
+Subject: [PATCH] [PATCH] dialogs_inner_widget: Fix use-before-definition
+ compile error
+
+ * Telegram/SourceFiles/dialogs/dialogs_inner_widget.h: include headers
+ and eagerly define TagCache to avoid using under-defined types for
+ std::unsigned_map values.
+ * Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp: remove the
+ definition of TagCache that is now in the header
+---
+ Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp | 5 -----
+ Telegram/SourceFiles/dialogs/dialogs_inner_widget.h | 7 ++++++-
+ 2 files changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
+index 39e047897..9687405aa 100644
+--- a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
++++ b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
+@@ -247,11 +247,6 @@ struct InnerWidget::PeerSearchResult {
+ BasicRow row;
+ };
+
+-struct InnerWidget::TagCache {
+- Ui::ChatsFilterTagContext context;
+- QImage frame;
+-};
+-
+ Key InnerWidget::FilterResult::key() const {
+ return row->key();
+ }
+diff --git a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h
+index 2500f43d1..c85c5ce32 100644
+--- a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h
++++ b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h
+@@ -16,6 +16,8 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
+ #include "ui/effects/animations.h"
+ #include "ui/rp_widget.h"
+ #include "ui/userpic_view.h"
++#include "dialogs/dialogs_common.h"
++#include "ui/chat/chats_filter_tag.h"
+
+ namespace style {
+ struct DialogRow;
+@@ -226,7 +228,10 @@ private:
+ struct CollapsedRow;
+ struct HashtagResult;
+ struct PeerSearchResult;
+- struct TagCache;
++ struct TagCache {
++ Ui::ChatsFilterTagContext context;
++ QImage frame;
++ };
+
+ enum class JumpSkip {
+ PreviousOrBegin,
+--
+2.48.1
+
diff --git a/gnu/packages/patches/telegram-desktop-qguiapp.patch b/gnu/packages/patches/telegram-desktop-qguiapp.patch
new file mode 100644
index 0000000000..7c45443887
--- /dev/null
+++ b/gnu/packages/patches/telegram-desktop-qguiapp.patch
@@ -0,0 +1,26 @@
+From 1f0dd322053c462c1ac291948a42f7187cfd37ae Mon Sep 17 00:00:00 2001
+From: Arseniy Zaostrovnykh <necto.ne@gmail.com>
+Date: Sun, 16 Mar 2025 20:45:06 +0100
+Subject: [PATCH] current_geo_location_linux.cpp: Add a missing include
+
+* Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp:
+ Fix the missing class compilation failure reported by gcc-11
+---
+ .../SourceFiles/platform/linux/current_geo_location_linux.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp b/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp
+index 7015af739..326ccbf28 100644
+--- a/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp
++++ b/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp
+@@ -10,6 +10,7 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
+ #include "core/current_geo_location.h"
+ #include "base/platform/linux/base_linux_library.h"
+
++#include <QGuiApplication>
+ #include <gio/gio.h>
+
+ namespace Platform {
+--
+2.48.1
+
diff --git a/gnu/packages/patches/telegram-desktop-unbundle-gsl.patch b/gnu/packages/patches/telegram-desktop-unbundle-gsl.patch
deleted file mode 100644
index f89d326a5c..0000000000
--- a/gnu/packages/patches/telegram-desktop-unbundle-gsl.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From a3ac6df0441b4caca28b1df87febc420e18942ce Mon Sep 17 00:00:00 2001
-From: Zephyr Lykos <git@mochaa.ws>
-Date: Mon, 23 Oct 2023 15:55:24 +0800
-Subject: [PATCH] Revert "Force usage of GSL fork because of a libstdc++ bug."
-
-This reverts commit 982546b169df3d479e6511425870327559b38a89.
-<https://github.com/microsoft/GSL/commit/e64c97fc2cfc11992098bb38eda932de275e3f4d>
----
- external/gsl/CMakeLists.txt | 2 --
- 1 file changed, 2 deletions(-)
-
-diff --git a/external/gsl/CMakeLists.txt b/external/gsl/CMakeLists.txt
-index 8eaf19c5..344f9488 100644
---- a/external/gsl/CMakeLists.txt
-+++ b/external/gsl/CMakeLists.txt
-@@ -7,7 +7,6 @@
- add_library(external_gsl INTERFACE IMPORTED GLOBAL)
- add_library(desktop-app::external_gsl ALIAS external_gsl)
-
--#[[
- if (DESKTOP_APP_USE_PACKAGED)
- if (DESKTOP_APP_USE_PACKAGED_LAZY)
- find_package(Microsoft.GSL 4.0.0 QUIET)
-@@ -20,7 +19,6 @@ if (DESKTOP_APP_USE_PACKAGED)
- return()
- endif()
- endif()
--]]
-
- # https://gitlab.kitware.com/cmake/cmake/-/issues/25222
- if (NOT EXISTS ${third_party_loc}/GSL/include)
diff --git a/gnu/packages/telegram.scm b/gnu/packages/telegram.scm
index c0b2122bf5..37772fa274 100644
--- a/gnu/packages/telegram.scm
+++ b/gnu/packages/telegram.scm
@@ -83,7 +83,7 @@ (define-module (gnu packages telegram)
#:use-module (guix build-system python)
#:use-module (guix build-system qt))
-(define %telegram-version "5.5.5")
+(define %telegram-version "5.12.3")
(define libyuv-for-telegram-desktop
(let ((commit "04821d1e7d60845525e8db55c7bcd41ef5be9406")
@@ -105,41 +105,39 @@ (define cmake-helpers-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/cmake_helpers.git")
- (commit "05a7db2e2d2a59ecf42483debca4944d09154b5b")))
+ (commit "90e6d73100a9fd2dc4c30a270c3bbc1d35924f32")))
(file-name
(git-file-name "cmake-helpers-for-telegram-desktop" %telegram-version))
(patches
- ;; https://github.com/desktop-app/cmake_helpers/pull/320
;; https://github.com/desktop-app/cmake_helpers/pull/305
- (search-patches "telegram-desktop-unbundle-gsl.patch"
- "telegram-desktop-unbundle-cppgir.patch"))
+ (search-patches "telegram-desktop-unbundle-cppgir.patch"))
(sha256
(base32
- "1gapyk5a8rsl8vigbz0l8h9858f2lkhkd2pjy72zivp0mrq8w0hr"))))
+ "0mpz0adsyzsr5crxcjfr96x133yl4j55nm5f3gv5w1q1g1vk283r"))))
(define codegen-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/codegen.git")
- (commit "0af136124083369073b8fdaf45f0816fd2b10bad")))
+ (commit "4155b9ae2d4c5a37b9738afa8ef9fa20d8fdcb44")))
(file-name
(git-file-name "codegen-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "057bwn9smrgnyfb1vraf50ihbkhjc4d72msl7vnbqc4h5sg8dav9"))))
+ "1h45rsi4nrkr3j312ji8qlkbzsb948nszmnylwimh5v65n90p21a"))))
(define lib-base-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_base.git")
- (commit "547e7f2914d9b5548dd17e70a3a7bf5d6606afc3")))
+ (commit "b28088164b7a46c70ae2cfd9daf865f6425610b2")))
(file-name
(git-file-name "lib-base-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "0sgm2prhd4fw89afh62k7i4i7mj60n170kqz50b0mad927zngxvn"))))
+ "1dwqdnasn3igr7i14hkx1glxj0gn6rd852bj0w3k1ai9j295wnfz"))))
(define lib-crl-for-telegram-desktop
(origin
@@ -158,12 +156,12 @@ (define lib-lottie-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_lottie.git")
- (commit "1a700e5a0d7c3e2f617530354ff2a47c5c72bb4a")))
+ (commit "3eb4a97f1dd038bc4b6bd2884262242382a37e79")))
(file-name
(git-file-name "lib-lottie-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "18w35sz6k3wcv07v0szx3avpfdl0rjby6yqm1fzmx7fqw2jn6wpl"))))
+ "04sgbspp0wngpr5w2wjfl1hwk1kiy8kwk2sz841f1yj231s7v6xw"))))
(define lib-qr-for-telegram-desktop
(origin
@@ -182,24 +180,24 @@ (define lib-rpl-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_rpl.git")
- (commit "8b1015d1bd57ef03fcd07a3eeddd3f5a9b688ade")))
+ (commit "9a3ce435f4054e6cbd45e1c6e3e27cfff515c829")))
(file-name
(git-file-name "lib-rpl-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "12sdhaqby5vlvd5jsj12b3xsqiaknqvijv9ydlyxclx8zail64lv"))))
+ "02g84i1d1hb5kqnhfr90fnw8nq1khqky95x52v2kx8zz05i1r8vs"))))
(define lib-spellcheck-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_spellcheck.git")
- (commit "e76981e133a1d29f3ceb557f53850a8d822f439a")))
+ (commit "8809cc72d07087ec61a1e8569de4da95aac45474")))
(file-name
(git-file-name "lib-spellcheck-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "0dslsy3d6gmxaj6yv49zjgl2b2mh75j7fpnbynglr02h3m2fdj96"))))
+ "0zxk7vxr29f8scdi2ymvvz4zh9zkln8r57y1n65x0vfi8vdihn1a"))))
(define lib-storage-for-telegram-desktop
(origin
@@ -221,6 +219,8 @@ (define lib-tl-for-telegram-desktop
(commit "237cbeb9d1c637759f89a508c1d854caf16e1984")))
(file-name
(git-file-name "lib-tl-for-telegram-desktop" %telegram-version))
+ (patches
+ (search-patches "lib-tl-for-telegram-memcpy.patch"))
(sha256
(base32
"1ji3gypy4yf9knsgylnyz5gc2kii7lls5ymj1rkf0daixdz931cm"))))
@@ -230,36 +230,36 @@ (define lib-ui-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_ui.git")
- (commit "c4e3a08e6fb90a6174c8b592d9eb747dd4d3f9c5")))
+ (commit "ba969667301ae4d8da2c2f6c4528bea63443f607")))
(file-name
(git-file-name "lib-ui-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "1lbfy4fbb52lklfwn6kxny3mwl653r4vc80k922kwjfgbcy9c25f"))))
+ "17h6awwna9qn98a0zk85xhh8ibgh3g7665khpgd752pya4jg27jw"))))
(define lib-webrtc-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_webrtc.git")
- (commit "8751e27d50d2f26b5d20673e5ddba38e90953570")))
+ (commit "169ba6b1d5e58e9d1cfa7b7d5c85c119e6c6e2db")))
(file-name
(git-file-name "lib-webrtc-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "0f05pqb83qckghzlhnwqbi9qfi9xw7qsv8jampl4qyaq9q0w9p20"))))
+ "0xh24qdy82j9mricja4ahzrsw9bgiklqy2mc0r891cblmmm2d90j"))))
(define lib-webview-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_webview.git")
- (commit "2de655f58dc327e40d5d9df71300a0d0fdb39c9f")))
+ (commit "f546969919a5946d49a504f8159041fa5b55c3df")))
(file-name
(git-file-name "lib-webview-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "12vrif0685vb068mj5sd7cknav1n66jysp18j21nlp0am9pw7ydj"))))
+ "178mf6lvgj4y5lscb68pc0yn3jcn66g04zszj74hpya18zjbmavw"))))
(define tgcalls-for-telegram-desktop
(origin
@@ -433,11 +433,14 @@ (define-public telegram-desktop
(file-name
(git-file-name name version))
(sha256
- (base32 "12fdybn085s3i3a8hwi0bmdns7jxvg0k662n04jgffirgsz8n54m"))
+ (base32 "16dfk36xfsizrxmxcid9kwj2dvxfp42382hqcan9rsrgjlqm6ymy"))
(patches
(search-patches
;; https://github.com/telegramdesktop/tdesktop/pull/24126
- "telegram-desktop-allow-disable-libtgvoip.patch"))
+ "telegram-desktop-allow-disable-libtgvoip.patch"
+ ;; Make it compatible with GCC 11.
+ "telegram-desktop-qguiapp.patch"
+ "telegram-desktop-hashmap-incomplete-value.patch"))
(modules '((guix build utils)
(ice-9 ftw)
(srfi srfi-1)))
--
2.48.1
L
L
Liliana Marie Prikler wrote on 16 Mar 14:34 -0700
Re: [PATCH 1/3] gnu: cppgir-for-telegram-desktop: Update to 2e96cab
3fe249a321c3d9a8b2a1a762513e1358d61c4c81.camel@gmail.com
Am Sonntag, dem 16.03.2025 um 21:45 +0100 schrieb Arseniy Zaostrovnykh:
Toggle quote (5 lines)
> * gnu/packages/glib.scm (cppgir-for-telegram-desktop): Update to the
> latest version 2e96cab8ed40df326815b87b1e4b449e0c1a5947 to fix
> telegram-desktop build that was broken since the gobject-
> introspection
> update (17d9803374 * gnu: gobject-introspection: Update to 1.82.0)
Longer explanations should go before the ChangeLog. Otherwise the
template it "Update to VERSION."

As a side note, pointing at commits and blaming them is not that nice
:)
"The current version fails to build with gobject-introspection 1.82
because of <reason>, hence we update to a newer version that is
compatible." would make sense if reason is known either upstream or
downstream.

Toggle quote (1 lines)
> Change-Id: I336168d49c5ac96ce5205f9824ce42701edb058c
If you can reference a bug other than this, you can use a Fixes:
annotation here.

Toggle quote (15 lines)
> ---
>  gnu/packages/glib.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> index 91bb183152..fb1acceac4 100644
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -1649,7 +1649,7 @@ (define-public cppgir
>  
>  ;; telegram-desktop requires a more recent version of cppgir
>  (define-public cppgir-for-telegram-desktop
> -  (let ((commit "9c4f5820d94d62ab451501f016bfea97156518f4")
> +  (let ((commit "2e96cab8ed40df326815b87b1e4b449e0c1a5947")
>          (revision "0"))
Do bump the revision. For the message header, report the full version
as shown via `guix show'.
Toggle quote (11 lines)
>      (package
>        (inherit cppgir)
> @@ -1664,4 +1664,4 @@ (define-public cppgir-for-telegram-desktop
>             (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32
> "1fa9nf4yljfarihaqj5kd98yysrky7q316mh6l5b1rq39ga15k9b")))))))
> +          (base32
> "0rdcgnriw8s5fqyx2v4218ii647l4fl1s9crnm9ihzf9bpl2p5p9")))))))

Cheers
L
L
Liliana Marie Prikler wrote on 16 Mar 14:34 -0700
Re: [PATCH 2/3] gnu: c++-gsl: Update to 4.2.0
b63747844ae793c3884115128143419b1c09178a.camel@gmail.com
Am Sonntag, dem 16.03.2025 um 21:45 +0100 schrieb Arseniy Zaostrovnykh:
Toggle quote (1 lines)
> * gnu/packages/cpp.scm (c++-gsl): Update to 4.2.0
Missing period at the end (also in the header).

Toggle quote (1 lines)
>   It is needed to build the newer telegram v5.12.3
This is gratuitous information :)

Toggle quote (29 lines)
> Change-Id: Iceb1c17d4195711159aa03ad161f094c3e78bbd9
> ---
>  gnu/packages/cpp.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 8d482d1fbd..4a351bf0d9 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -399,7 +399,7 @@ (define-public robin-hood-hashing
>  (define-public c++-gsl
>    (package
>      (name "c++-gsl")
> -    (version "4.0.0")
> +    (version "4.2.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -411,7 +411,7 @@ (define-public c++-gsl
>         (file-name
>          (git-file-name name version))
>         (sha256
> -        (base32
> "0dgb3rb6x2276d3v7x568m3zhqr67rhk8ynqgm3c304avnmcaw3i"))))
> +        (base32
> "08w3ppd43wx9vq641ljw5izjd7p5w7drynw13ll9shwy41ydif9n"))))
>      (build-system cmake-build-system)
>      (native-inputs
>       (list googletest pkg-config))
Cheers
L
L
Liliana Marie Prikler wrote on 16 Mar 14:40 -0700
Re: [PATCH 3/3] gnu: telegram-desktop: Update to version 5.12.3
6915cf1f8ba04b29be6a6af5037e34444eb0f4c3.camel@gmail.com
Am Sonntag, dem 16.03.2025 um 21:45 +0100 schrieb Arseniy Zaostrovnykh:
Toggle quote (1 lines)
>  * gnu/packages/telegram.scm (%telegram-version): Update to 5.12.3
Missing period.
Toggle quote (4 lines)
>       (cmake-helpers-for-telegram-desktop): update to revision used
> by v5.12.3
>           Remove the obsolete patch (the PR was merged in this
> revision)
Don't pointlessly indent stuff in the ChangeLog.

Instead of repeating yourself, write something like "Adjust
accordingly." You can then use "Likewise." for all the ones below
this.

Do explicitly name the patches that get added/removed.

Toggle quote (27 lines)
>       (codegen-for-telegram-desktop): update to revision used by
> v5.12.3
>       (lib-base-for-telegram-desktop): update to revision used by
> v5.12.3
>       (lib-lottie-for-telegram-desktop): update to revision used by
> v5.12.3
>       (lib-rpl-for-telegram-desktop): update to revision used by
> v5.12.3
>       (lib-spellcheck-for-telegram-desktop): update to revision used
> by v5.12.3
>       (lib-tl-for-telegram-desktop): Apply a patch to fix gcc-11
>          compilation error
>       (lib-ui-for-telegram-desktop): update to revision used by
> v5.12.3
>       (lib-webrtc-for-telegram-desktop): update to revision used by
> v5.12.3
>       (telegram-desktop): Update to v5.12.3; apply patches to make it
> compile
>  * gnu/packages/patches/telegram-desktop-unbundle-gsl.patch: removed
>       no longer needed in the new revision
>  * gnu/packages/patches/lib-tl-for-telegram-memcpy.patch:
>       new file. patch to fix a compilation error
>  * gnu/packages/patches/telegram-desktop-hashmap-incomplete-
> value.patch:
>       new file. patch to fix a compilation error
>  * gnu/packages/patches/telegram-desktop-qguiapp.patch:
>       new file. patch to fix a compilation error
I don't see these added to gnu/local.mk. That is an issue.

As for formatting the ChangeLog, please check out `git log'. In
particular, always capitalise the first word after the colon.

Cheers
A
A
Arseniy Zaostrovnykh wrote on 17 Mar 01:07 -0700
[PATCH 1/3] gnu: cppgir-for-telegram-desktop: Update to 2e96cab.
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
24b8ad3779c5d2cc0275501bdb925396fe54003c.1742198692.git.necto.ne@gmail.com
Current cppgir-for-telegram-desktop version with gobject-introspection 1.82
leads to a compilation failure of telegram-desktop. The latest version
2e96cab8ed40df326815b87b1e4b449e0c1a5947 is compatible.

* gnu/packages/glib.scm (cppgir-for-telegram-desktop): Update to version
2e96cab8ed40df326815b.

Change-Id: I336168d49c5ac96ce5205f9824ce42701edb058c

Change-Id: I6710e701783a4ef54351c0fb92ff6cc07ee4540d
---
gnu/packages/glib.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index 91bb183152..fb1acceac4 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -1649,7 +1649,7 @@ (define-public cppgir
;; telegram-desktop requires a more recent version of cppgir
(define-public cppgir-for-telegram-desktop
- (let ((commit "9c4f5820d94d62ab451501f016bfea97156518f4")
+ (let ((commit "2e96cab8ed40df326815b87b1e4b449e0c1a5947")
(revision "0"))
(package
(inherit cppgir)
@@ -1664,4 +1664,4 @@ (define-public cppgir-for-telegram-desktop
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "1fa9nf4yljfarihaqj5kd98yysrky7q316mh6l5b1rq39ga15k9b")))))))
+ (base32 "0rdcgnriw8s5fqyx2v4218ii647l4fl1s9crnm9ihzf9bpl2p5p9")))))))

base-commit: f9726d5498e63a433fdd3398a4439089072482d5
--
2.48.1
A
A
Arseniy Zaostrovnykh wrote on 17 Mar 01:07 -0700
[PATCH 2/3] gnu: c++-gsl: Update to 4.2.0.
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
a43c88321252c184e208c94355413685828eb5a6.1742198692.git.necto.ne@gmail.com
* gnu/packages/cpp.scm (c++-gsl): Update to 4.2.0.

Change-Id: Iceb1c17d4195711159aa03ad161f094c3e78bbd9
---
gnu/packages/cpp.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 8d482d1fbd..4a351bf0d9 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -399,7 +399,7 @@ (define-public robin-hood-hashing
(define-public c++-gsl
(package
(name "c++-gsl")
- (version "4.0.0")
+ (version "4.2.0")
(source
(origin
(method git-fetch)
@@ -411,7 +411,7 @@ (define-public c++-gsl
(file-name
(git-file-name name version))
(sha256
- (base32 "0dgb3rb6x2276d3v7x568m3zhqr67rhk8ynqgm3c304avnmcaw3i"))))
+ (base32 "08w3ppd43wx9vq641ljw5izjd7p5w7drynw13ll9shwy41ydif9n"))))
(build-system cmake-build-system)
(native-inputs
(list googletest pkg-config))
--
2.48.1
A
A
Arseniy Zaostrovnykh wrote on 17 Mar 01:07 -0700
[PATCH 3/3] gnu: telegram-desktop: Update to version 5.12.3.
(address . 76991@debbugs.gnu.org)(name . Arseniy Zaostrovnykh)(address . necto.ne@gmail.com)
1662d77783fc1274bc91c665331d733e1226f580.1742198692.git.necto.ne@gmail.com
Add three patches to fix the compilation errors raised by gcc 11.
so telegram-desktop-unbundle-gsl.patch is no longer needed.

* gnu/packages/telegram.scm (%telegram-version): Update to 5.12.3.
(codegen-for-telegram-desktop): Update to revision used by v5.12.3.
(lib-base-for-telegram-desktop): Likewise.
(lib-lottie-for-telegram-desktop): Likewise.
(lib-rpl-for-telegram-desktop): Likewise.
(lib-spellcheck-for-telegram-desktop): Likewise.
(lib-ui-for-telegram-desktop): Likewise.
(lib-webrtc-for-telegram-desktop): Likewise.
(cmake-helpers-for-telegram-desktop): Likewise;
Remove the obsolete patch.
(lib-tl-for-telegram-desktop):
Apply a patch to fix gcc-11 compilation error.
(telegram-desktop): Update to v5.12.3;
Apply patches to make it compile.
* gnu/packages/patches/telegram-desktop-unbundle-gsl.patch: Remove.
* gnu/packages/patches/lib-tl-for-telegram-memcpy.patch: New file.
* gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch:
New file.
* gnu/packages/patches/telegram-desktop-qguiapp.patch: New file.
* gnu/local.mk: Adjust accordingly.

Change-Id: Iaa34ff2cd3f55aa92b1d9ba61a2ff66a72eb1132
---
gnu/local.mk | 4 +-
.../patches/lib-tl-for-telegram-memcpy.patch | 26 ++++++++
...ram-desktop-hashmap-incomplete-value.patch | 59 +++++++++++++++++++
.../patches/telegram-desktop-qguiapp.patch | 26 ++++++++
.../telegram-desktop-unbundle-gsl.patch | 31 ----------
gnu/packages/telegram.scm | 51 ++++++++--------
6 files changed, 141 insertions(+), 56 deletions(-)
create mode 100644 gnu/packages/patches/lib-tl-for-telegram-memcpy.patch
create mode 100644 gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch
create mode 100644 gnu/packages/patches/telegram-desktop-qguiapp.patch
delete mode 100644 gnu/packages/patches/telegram-desktop-unbundle-gsl.patch

Toggle diff (366 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index 4cb60ade0f..be04ee9afd 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1840,6 +1840,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lib-tl-for-telegram-memcpy.patch \
%D%/packages/patches/llama-cpp-vulkan-optional.patch \
%D%/packages/patches/llhttp-ponyfill-object-fromentries.patch \
%D%/packages/patches/lvm2-no-systemd.patch \
@@ -2299,8 +2300,9 @@ dist_patch_DATA = \
%D%/packages/patches/texinfo-headings-single.patch \
%D%/packages/patches/texinfo-5-perl-compat.patch \
%D%/packages/patches/telegram-desktop-allow-disable-libtgvoip.patch \
+ %D%/packages/patches/telegram-desktop-hashmap-incomplete-value.patch \
+ %D%/packages/patches/telegram-desktop-qguiapp.patch \
%D%/packages/patches/telegram-desktop-unbundle-cppgir.patch \
- %D%/packages/patches/telegram-desktop-unbundle-gsl.patch \
%D%/packages/patches/telegram-purple-adjust-test.patch \
%D%/packages/patches/telepathy-glib-fix-test.patch \
%D%/packages/patches/teuchos-remove-duplicate-using.patch \
diff --git a/gnu/packages/patches/lib-tl-for-telegram-memcpy.patch b/gnu/packages/patches/lib-tl-for-telegram-memcpy.patch
new file mode 100644
index 0000000000..5980c70fb2
--- /dev/null
+++ b/gnu/packages/patches/lib-tl-for-telegram-memcpy.patch
@@ -0,0 +1,26 @@
+From 7e08865a01b265bd884bb9e39ecc86497bcf5203 Mon Sep 17 00:00:00 2001
+From: Arseniy Zaostrovnykh <necto.ne@gmail.com>
+Date: Sun, 16 Mar 2025 20:56:37 +0100
+Subject: [PATCH] tl/tl_basic_types.h: Fix compile error for missing memcpy.
+
+ * tl/tl_basic_types.h: Add include for cstring to fix the compilation
+ error about missing memcpy raised by gcc 11.
+---
+ tl/tl_basic_types.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tl/tl_basic_types.h b/tl/tl_basic_types.h
+index 5eadf62..e9b6da5 100644
+--- a/tl/tl_basic_types.h
++++ b/tl/tl_basic_types.h
+@@ -11,6 +11,7 @@
+ #include "base/bytes.h"
+
+ #include <QtCore/QVector>
++#include <cstring>
+
+ namespace tl {
+ namespace details {
+--
+2.48.1
+
diff --git a/gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch b/gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch
new file mode 100644
index 0000000000..f162adf269
--- /dev/null
+++ b/gnu/packages/patches/telegram-desktop-hashmap-incomplete-value.patch
@@ -0,0 +1,59 @@
+From 3865a179b3aed172bac4a3dcd1f320270de16dcf Mon Sep 17 00:00:00 2001
+From: Arseniy Zaostrovnykh <necto.ne@gmail.com>
+Date: Sun, 16 Mar 2025 20:49:16 +0100
+Subject: [PATCH] dialogs_inner_widget: Fix use-before-def compile error.
+
+ * Telegram/SourceFiles/dialogs/dialogs_inner_widget.h: Include headers
+ and eagerly define TagCache to avoid using under-defined types for
+ std::unsigned_map values.
+ * Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp: Remove the
+ definition of TagCache that is now in the header.
+---
+ Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp | 5 -----
+ Telegram/SourceFiles/dialogs/dialogs_inner_widget.h | 7 ++++++-
+ 2 files changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
+index 39e047897..9687405aa 100644
+--- a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
++++ b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
+@@ -247,11 +247,6 @@ struct InnerWidget::PeerSearchResult {
+ BasicRow row;
+ };
+
+-struct InnerWidget::TagCache {
+- Ui::ChatsFilterTagContext context;
+- QImage frame;
+-};
+-
+ Key InnerWidget::FilterResult::key() const {
+ return row->key();
+ }
+diff --git a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h
+index 2500f43d1..c85c5ce32 100644
+--- a/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h
++++ b/Telegram/SourceFiles/dialogs/dialogs_inner_widget.h
+@@ -16,6 +16,8 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
+ #include "ui/effects/animations.h"
+ #include "ui/rp_widget.h"
+ #include "ui/userpic_view.h"
++#include "dialogs/dialogs_common.h"
++#include "ui/chat/chats_filter_tag.h"
+
+ namespace style {
+ struct DialogRow;
+@@ -226,7 +228,10 @@ private:
+ struct CollapsedRow;
+ struct HashtagResult;
+ struct PeerSearchResult;
+- struct TagCache;
++ struct TagCache {
++ Ui::ChatsFilterTagContext context;
++ QImage frame;
++ };
+
+ enum class JumpSkip {
+ PreviousOrBegin,
+--
+2.48.1
+
diff --git a/gnu/packages/patches/telegram-desktop-qguiapp.patch b/gnu/packages/patches/telegram-desktop-qguiapp.patch
new file mode 100644
index 0000000000..a5d8e32443
--- /dev/null
+++ b/gnu/packages/patches/telegram-desktop-qguiapp.patch
@@ -0,0 +1,26 @@
+From 1f0dd322053c462c1ac291948a42f7187cfd37ae Mon Sep 17 00:00:00 2001
+From: Arseniy Zaostrovnykh <necto.ne@gmail.com>
+Date: Sun, 16 Mar 2025 20:45:06 +0100
+Subject: [PATCH] current_geo_location_linux.cpp: Add a missing include.
+
+* Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp:
+ Fix the missing class compilation failure reported by gcc-11.
+---
+ .../SourceFiles/platform/linux/current_geo_location_linux.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp b/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp
+index 7015af739..326ccbf28 100644
+--- a/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp
++++ b/Telegram/SourceFiles/platform/linux/current_geo_location_linux.cpp
+@@ -10,6 +10,7 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
+ #include "core/current_geo_location.h"
+ #include "base/platform/linux/base_linux_library.h"
+
++#include <QGuiApplication>
+ #include <gio/gio.h>
+
+ namespace Platform {
+--
+2.48.1
+
diff --git a/gnu/packages/patches/telegram-desktop-unbundle-gsl.patch b/gnu/packages/patches/telegram-desktop-unbundle-gsl.patch
deleted file mode 100644
index f89d326a5c..0000000000
--- a/gnu/packages/patches/telegram-desktop-unbundle-gsl.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From a3ac6df0441b4caca28b1df87febc420e18942ce Mon Sep 17 00:00:00 2001
-From: Zephyr Lykos <git@mochaa.ws>
-Date: Mon, 23 Oct 2023 15:55:24 +0800
-Subject: [PATCH] Revert "Force usage of GSL fork because of a libstdc++ bug."
-
-This reverts commit 982546b169df3d479e6511425870327559b38a89.
-<https://github.com/microsoft/GSL/commit/e64c97fc2cfc11992098bb38eda932de275e3f4d>
----
- external/gsl/CMakeLists.txt | 2 --
- 1 file changed, 2 deletions(-)
-
-diff --git a/external/gsl/CMakeLists.txt b/external/gsl/CMakeLists.txt
-index 8eaf19c5..344f9488 100644
---- a/external/gsl/CMakeLists.txt
-+++ b/external/gsl/CMakeLists.txt
-@@ -7,7 +7,6 @@
- add_library(external_gsl INTERFACE IMPORTED GLOBAL)
- add_library(desktop-app::external_gsl ALIAS external_gsl)
-
--#[[
- if (DESKTOP_APP_USE_PACKAGED)
- if (DESKTOP_APP_USE_PACKAGED_LAZY)
- find_package(Microsoft.GSL 4.0.0 QUIET)
-@@ -20,7 +19,6 @@ if (DESKTOP_APP_USE_PACKAGED)
- return()
- endif()
- endif()
--]]
-
- # https://gitlab.kitware.com/cmake/cmake/-/issues/25222
- if (NOT EXISTS ${third_party_loc}/GSL/include)
diff --git a/gnu/packages/telegram.scm b/gnu/packages/telegram.scm
index c0b2122bf5..37772fa274 100644
--- a/gnu/packages/telegram.scm
+++ b/gnu/packages/telegram.scm
@@ -83,7 +83,7 @@ (define-module (gnu packages telegram)
#:use-module (guix build-system python)
#:use-module (guix build-system qt))
-(define %telegram-version "5.5.5")
+(define %telegram-version "5.12.3")
(define libyuv-for-telegram-desktop
(let ((commit "04821d1e7d60845525e8db55c7bcd41ef5be9406")
@@ -105,41 +105,39 @@ (define cmake-helpers-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/cmake_helpers.git")
- (commit "05a7db2e2d2a59ecf42483debca4944d09154b5b")))
+ (commit "90e6d73100a9fd2dc4c30a270c3bbc1d35924f32")))
(file-name
(git-file-name "cmake-helpers-for-telegram-desktop" %telegram-version))
(patches
- ;; https://github.com/desktop-app/cmake_helpers/pull/320
;; https://github.com/desktop-app/cmake_helpers/pull/305
- (search-patches "telegram-desktop-unbundle-gsl.patch"
- "telegram-desktop-unbundle-cppgir.patch"))
+ (search-patches "telegram-desktop-unbundle-cppgir.patch"))
(sha256
(base32
- "1gapyk5a8rsl8vigbz0l8h9858f2lkhkd2pjy72zivp0mrq8w0hr"))))
+ "0mpz0adsyzsr5crxcjfr96x133yl4j55nm5f3gv5w1q1g1vk283r"))))
(define codegen-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/codegen.git")
- (commit "0af136124083369073b8fdaf45f0816fd2b10bad")))
+ (commit "4155b9ae2d4c5a37b9738afa8ef9fa20d8fdcb44")))
(file-name
(git-file-name "codegen-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "057bwn9smrgnyfb1vraf50ihbkhjc4d72msl7vnbqc4h5sg8dav9"))))
+ "1h45rsi4nrkr3j312ji8qlkbzsb948nszmnylwimh5v65n90p21a"))))
(define lib-base-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_base.git")
- (commit "547e7f2914d9b5548dd17e70a3a7bf5d6606afc3")))
+ (commit "b28088164b7a46c70ae2cfd9daf865f6425610b2")))
(file-name
(git-file-name "lib-base-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "0sgm2prhd4fw89afh62k7i4i7mj60n170kqz50b0mad927zngxvn"))))
+ "1dwqdnasn3igr7i14hkx1glxj0gn6rd852bj0w3k1ai9j295wnfz"))))
(define lib-crl-for-telegram-desktop
(origin
@@ -158,12 +156,12 @@ (define lib-lottie-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_lottie.git")
- (commit "1a700e5a0d7c3e2f617530354ff2a47c5c72bb4a")))
+ (commit "3eb4a97f1dd038bc4b6bd2884262242382a37e79")))
(file-name
(git-file-name "lib-lottie-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "18w35sz6k3wcv07v0szx3avpfdl0rjby6yqm1fzmx7fqw2jn6wpl"))))
+ "04sgbspp0wngpr5w2wjfl1hwk1kiy8kwk2sz841f1yj231s7v6xw"))))
(define lib-qr-for-telegram-desktop
(origin
@@ -182,24 +180,24 @@ (define lib-rpl-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_rpl.git")
- (commit "8b1015d1bd57ef03fcd07a3eeddd3f5a9b688ade")))
+ (commit "9a3ce435f4054e6cbd45e1c6e3e27cfff515c829")))
(file-name
(git-file-name "lib-rpl-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "12sdhaqby5vlvd5jsj12b3xsqiaknqvijv9ydlyxclx8zail64lv"))))
+ "02g84i1d1hb5kqnhfr90fnw8nq1khqky95x52v2kx8zz05i1r8vs"))))
(define lib-spellcheck-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_spellcheck.git")
- (commit "e76981e133a1d29f3ceb557f53850a8d822f439a")))
+ (commit "8809cc72d07087ec61a1e8569de4da95aac45474")))
(file-name
(git-file-name "lib-spellcheck-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "0dslsy3d6gmxaj6yv49zjgl2b2mh75j7fpnbynglr02h3m2fdj96"))))
+ "0zxk7vxr29f8scdi2ymvvz4zh9zkln8r57y1n65x0vfi8vdihn1a"))))
(define lib-storage-for-telegram-desktop
(origin
@@ -221,6 +219,8 @@ (define lib-tl-for-telegram-desktop
(commit "237cbeb9d1c637759f89a508c1d854caf16e1984")))
(file-name
(git-file-name "lib-tl-for-telegram-desktop" %telegram-version))
+ (patches
+ (search-patches "lib-tl-for-telegram-memcpy.patch"))
(sha256
(base32
"1ji3gypy4yf9knsgylnyz5gc2kii7lls5ymj1rkf0daixdz931cm"))))
@@ -230,36 +230,36 @@ (define lib-ui-for-telegram-desktop
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_ui.git")
- (commit "c4e3a08e6fb90a6174c8b592d9eb747dd4d3f9c5")))
+ (commit "ba969667301ae4d8da2c2f6c4528bea63443f607")))
(file-name
(git-file-name "lib-ui-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "1lbfy4fbb52lklfwn6kxny3mwl653r4vc80k922kwjfgbcy9c25f"))))
+ "17h6awwna9qn98a0zk85xhh8ibgh3g7665khpgd752pya4jg27jw"))))
(define lib-webrtc-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_webrtc.git")
- (commit "8751e27d50d2f26b5d20673e5ddba38e90953570")))
+ (commit "169ba6b1d5e58e9d1cfa7b7d5c85c119e6c6e2db")))
(file-name
(git-file-name "lib-webrtc-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "0f05pqb83qckghzlhnwqbi9qfi9xw7qsv8jampl4qyaq9q0w9p20"))))
+ "0xh24qdy82j9mricja4ahzrsw9bgiklqy2mc0r891cblmmm2d90j"))))
(define lib-webview-for-telegram-desktop
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/desktop-app/lib_webview.git")
- (commit "2de655f58dc327e40d5d9df71300a0d0fdb39c9f")))
+ (commit "f546969919a5946d49a504f8159041fa5b55c3df")))
(file-name
(git-file-name "lib-webview-for-telegram-desktop" %telegram-version))
(sha256
(base32
- "12vrif0685vb068mj5sd7cknav1n66jysp18j21nlp0am9pw7ydj"))))
+ "178mf6lvgj4y5lscb68pc0yn3jcn66g04zszj74hpya18zjbmavw"))))
(define tgcalls-for-telegram-desktop
(origin
@@ -433,11 +433,14 @@ (define-public telegram-desktop
(file-name
(git-file-name name version))
(sha256
- (base32 "12fdybn085s3i3a8hwi0bmdns7jxvg0k662n04jgffirgsz8n54m"))
+ (base32 "16dfk36xfsizrxmxcid9kwj2dvxfp42382hqcan9rsrgjlqm6ymy"))
(patches
(search-patches
;; https://github.com/telegramdesktop/tdesktop/pull/24126
- "telegram-desktop-allow-disable-libtgvoip.patch"))
+ "telegram-desktop-allow-disable-libtgvoip.patch"
+ ;; Make it compatible with GCC 11.
+ "telegram-desktop-qguiapp.patch"
+ "telegram-desktop-hashmap-incomplete-value.patch"))
(modules '((guix build utils)
(ice-9 ftw)
(srfi srfi-1)))
--
2.48.1
A
A
Arseniy Zaostrovnykh wrote on 17 Mar 01:12 -0700
Re: telegram-desktop package fails to build
CANy7P7TUnsX9uF4cqC-gHi9imKV37WOSbULyukjPOGXWXp8Row@mail.gmail.com
@Liliana Marie Prikler

Toggle quote (2 lines)
> As a side note, pointing at commits and blaming them is not that nice :)

I didn't intend to point and blame. I included the commit mainly because it
took me several days of bisecting to find and I wanted to spare this effort
if anyone would decide to look for the same thing :).

I adjusted the patches according to your suggestions, please take another
look.

--
Necto.
Attachment: file
J
J
Jonathan Brielmaier wrote on 17 Mar 13:03 -0700
telegram-desktop package fails to build
(address . 76991@debbugs.gnu.org)
d6ea2bed-9d90-4475-ac8f-c606d17cc966@web.de
@Arseniy:
I think it's fine to point to another commit which causes the build
failure and kind of "forces" this update of telegram/it's dependencies...

~Jonathan
M
M
Maxim Cournoyer wrote on 19 Mar 22:49 -0700
control message for bug #76991
(address . control@debbugs.gnu.org)
87h63op7yh.fsf@gmail.com
close 76991
quit
J
J
Jonathan Brielmaier wrote on 22 Mar 16:28 -0700
telegram-desktop package fails to build
(address . 76991@debbugs.gnu.org)
698697ca-431f-4ec4-a748-37bd62048f24@web.de
I've built the patch for c++-gsl and telegram-desktop and pushed them.

~Jonathan
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76991@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 76991
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch