[PATCH] gnu: supertuxkart: Keep 'supertuxkart.desktop' file.

  • Done
  • quality assurance status badge
Details
2 participants
  • Eric Bavier
  • Nigko Yerden
Owner
unassigned
Submitted by
Nigko Yerden
Severity
normal

Debbugs page

N
N
Nigko Yerden wrote on 11 Mar 02:22 -0700
(address . guix-patches@gnu.org)(name . Nigko Yerden)(address . nigko.yerden@gmail.com)
f5ac094e724aece36b255f0e6a09453b002a1772.1741684979.git.nigko.yerden@gmail.com
* gnu/packages/games.scm (supertuxkart)[arguments]: Fix regexp in
'disable-data-install' phase so that the line in CMakeList.txt that installs
'supertuxkart.desktop' file is not commented out.

Change-Id: I408cdfeb9425c39228d38df4c15aee326e19dc34
---
gnu/packages/games.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index fd22b0243f..89e06a3a81 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4845,7 +4845,7 @@ (define-public supertuxkart
(add-before 'configure 'disable-data-install
(lambda _
(substitute* "CMakeLists.txt"
- (("^install\\(.*STK_DATA_DIR" &)
+ (("^install\\(DIRECTORY.*STK_DATA_DIR" &)
(string-append "# " &))))))))
(inputs
(list curl

base-commit: f70ad6267bf2bbafbf5eb0a1d04e2d624af796c5
--
2.48.1
N
N
Nigko Yerden wrote on 12 Mar 09:33 -0700
c8aafc07-0709-41e3-ac90-ff8e91176c54@gmail.com
Hello Eric Bavier,

I am very appreciate for your commit [1] that splits data from supertuxkart
package. Indeed, it was very annoying to download more than 700MB on almost
every upgrade. However, it seems that I found a minor bug in your nice patch:
supertuxkart has lost its .desktop file. Certainly, not everyone needs
.desktop file, but I think it would be better to keep it:)
Here [2] I suggest a one-line bug-fix. I checked that the supertuxkart
package is successfully built and works with this patch applied.

What do you think?

Thank you for your work!

Regards,
Nigko

E
E
Eric Bavier wrote on 13 Mar 19:48 -0700
95f4604c-e9ab-46e3-9250-1872ead62109@posteo.net
Hi Nigko,

I'm glad someone appreciates my improvement also.  Good catch, and
thanks for the patch!  It looks good to me.  I've applied it in commit
92124591eedf27e988c84f75acd4b4d99ff43122.

`~Eric

On 3/12/25 11:33, Nigko Yerden wrote:
Toggle quote (24 lines)
> Hello Eric Bavier,
>
> I am very appreciate for your commit [1] that splits data from
> supertuxkart
> package. Indeed, it was very annoying to download more than 700MB on
> almost
> every upgrade. However, it seems that I found a minor bug in your nice
> patch:
> supertuxkart has lost its .desktop file. Certainly, not everyone needs
> .desktop file, but I think it would be better to keep it:)
>
> Here [2] I suggest a one-line bug-fix. I checked that the supertuxkart
> package is successfully built and works with this patch applied.
>
> What do you think?
>
> Thank you for your work!
>
> Regards,
> Nigko
>
> [1]
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b33214d80e3e07421626449415e14bf120d93c9
> [2] https://issues.guix.gnu.org/76936
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76936@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 76936
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch