[PATCH 0/3] gnu: plasma: Add missing packages.

  • Open
  • quality assurance status badge
Details
3 participants
  • Liliana Marie Prikler
  • Maxim Cournoyer
  • Sughosha
Owner
unassigned
Submitted by
Sughosha
Severity
normal

Debbugs page

S
S
Sughosha wrote on 18 Feb 09:46 -0800
(address . guix-patches@gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
cover.1739900401.git.sughosha@disroot.org
This patchset adds missing packages to plasma package, missing packages
providing system dbus services to plasma-dbus-service service and missing
packages providing polkit actions to plasma-polkit-settings service.

Sughosha (3):
gnu: plasma: Add missing packages.
services: plasma-dbus-service: Add missing packages.
services: plasma-polkit-settings: Add missing packages.

gnu/packages/kde-plasma.scm | 6 ++++++
gnu/services/desktop.scm | 7 +++++++
2 files changed, 13 insertions(+)


base-commit: fc29a7193781df44a15cb7a8bdc236805ddd0595
--
2.47.1
S
S
Sughosha wrote on 18 Feb 09:56 -0800
[PATCH 2/3] services: plasma-dbus-service: Add missing packages.
(address . 76400@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
c4111158299f5bd185f5bca7ca3a99787f9d65fc.1739900401.git.sughosha@disroot.org
* gnu/services/desktop.scm (plasma-dbus-service): Add kdeplasma-addons,
kpmcore and kwalletmanager.

Change-Id: Icef5290368f681b95be3cf14d0238f1bbf47c0f6
---
gnu/services/desktop.scm | 3 +++
1 file changed, 3 insertions(+)

Toggle diff (19 lines)
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 708034f89c..7c9fe3552d 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1895,9 +1895,12 @@ (define (plasma-dbus-service config)
"plasma-workspace"
"kactivitymanagerd"
"plasma-disks"
+ "kdeplasma-addons"
"kinfocenter"
"libksysguard"
+ "kpmcore"
"ktexteditor"
+ "kwalletmanager"
"powerdevil"
"bluedevil"
"kwallet"
--
2.47.1
S
S
Sughosha wrote on 18 Feb 09:56 -0800
[PATCH 1/3] gnu: plasma: Add missing packages.
(address . 76400@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
37458792ab242001f56c342bae6f4b5fe10c6794.1739900401.git.sughosha@disroot.org
* gnu/packages/kde-plasma.scm (plasma)[propagated-inputs]: Add kpmcore,
kwalletmanager and partitionmanager.

Change-Id: Ic6c5ac3156c140742627f804fef8f9317492e8ff
---
gnu/packages/kde-plasma.scm | 6 ++++++
1 file changed, 6 insertions(+)

Toggle diff (33 lines)
diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
index 098b977866..f98c4df8b5 100644
--- a/gnu/packages/kde-plasma.scm
+++ b/gnu/packages/kde-plasma.scm
@@ -1713,6 +1713,7 @@ (define-public plasma
kde-cli-tools
kdecoration
kdeplasma-addons
+ kpmcore
ktexteditor
kscreen
libkscreen
@@ -1732,6 +1733,7 @@ (define-public plasma
ksshaskpass
discover
kmenuedit
+ partitionmanager
plasma-welcome
plasma-browser-integration
plasma-desktop
@@ -1748,6 +1750,10 @@ (define-public plasma
(resolve-interface
'(gnu packages kde-systemtools))
'konsole)
+ (module-ref
+ (resolve-interface
+ '(gnu packages kde-systemtools))
+ 'kwalletmanager)
(module-ref
(resolve-interface
'(gnu packages kde-systemtools))
--
2.47.1
S
S
Sughosha wrote on 18 Feb 09:56 -0800
[PATCH 3/3] services: plasma-polkit-settings: Add missing packages.
(address . 76400@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
06cbadb7fc6e8da3709407df0b0ada934ee89aad.1739900401.git.sughosha@disroot.org
* gnu/services/desktop.scm (plasma-polkit-settings): Add kdeplasma-addons,
kglobalaccel, kpmcore and kwalletmanager.

Change-Id: I4e5544a7211fdf898b02ea51750e6d66a3b79ca9
---
gnu/services/desktop.scm | 4 ++++
1 file changed, 4 insertions(+)

Toggle diff (20 lines)
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 7c9fe3552d..a937218adf 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1880,9 +1880,13 @@ (define (plasma-polkit-settings config)
'("plasma-desktop"
"plasma-workspace"
"plasma-disks"
+ "kdeplasma-addons"
+ "kglobalaccel"
"kinfocenter"
"libksysguard"
+ "kpmcore"
"ktexteditor"
+ "kwalletmanager"
"powerdevil"
"plasma-firewall"))))
--
2.47.1
M
M
Maxim Cournoyer wrote on 22 Feb 06:19 -0800
Re: [bug#76400] [PATCH 0/3] gnu: plasma: Add missing packages.
(name . Sughosha)(address . sughosha@disroot.org)
871pvqt63u.fsf@gmail.com
Hi,

Sughosha <sughosha@disroot.org> writes:

Toggle quote (9 lines)
> This patchset adds missing packages to plasma package, missing packages
> providing system dbus services to plasma-dbus-service service and missing
> packages providing polkit actions to plasma-polkit-settings service.
>
> Sughosha (3):
> gnu: plasma: Add missing packages.
> services: plasma-dbus-service: Add missing packages.
> services: plasma-polkit-settings: Add missing packages.

Could you add a new commit ordering the list of packages, and then
rebase the above on top, making sure to preserve the lexcographical
ordering?

When done please send a v2!

--
Thanks,
Maxim
S
S
Sughosha wrote on 22 Feb 18:52 -0800
[PATCH v2 1/4] gnu: plasma: Add missing dependencies.
(address . 76400@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
455a1611a6744e1b791dfc907d93794dd20bc661.1740279137.git.sughosha@disroot.org
* gnu/packages/kde-plasma.scm (plasma)[propagated-inputs]: Add kpmcore,
kwalletmanager and partitionmanager.

Change-Id: I382eb94f23693e71df9a684465c7e72e2607f886
---
gnu/packages/kde-plasma.scm | 3 +++
1 file changed, 3 insertions(+)

Toggle diff (31 lines)
diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
index 8d177d147f..40f2fce510 100644
--- a/gnu/packages/kde-plasma.scm
+++ b/gnu/packages/kde-plasma.scm
@@ -1713,12 +1713,14 @@ (define-public plasma
kde-cli-tools
kdecoration
kdeplasma-addons
+ kpmcore
ktexteditor
kscreen
libkscreen
krdp
ksystemstats
kwallet
+ kwalletmanager
kwallet-pam
kwin
plasma-workspace-wallpapers
@@ -1732,6 +1734,7 @@ (define-public plasma
ksshaskpass
discover
kmenuedit
+ partitionmanager
plasma-welcome
plasma-browser-integration
plasma-desktop

base-commit: c8623b1f11b7259fcb10a422dcde174b72584958
--
2.47.1
S
S
Sughosha wrote on 22 Feb 18:52 -0800
[PATCH v2 2/4] services: plasma-dbus-service: Add missing packages.
(address . 76400@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
b168f51f8eb0d9e2d1bc949d51e4c833ad5e80e8.1740279137.git.sughosha@disroot.org
* gnu/services/desktop.scm (plasma-dbus-service): Add kdeplasma-addons,
kpmcore and kwalletmanager.

Change-Id: Icef5290368f681b95be3cf14d0238f1bbf47c0f6
---
gnu/services/desktop.scm | 3 +++
1 file changed, 3 insertions(+)

Toggle diff (19 lines)
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 708034f89c..7c9fe3552d 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1895,9 +1895,12 @@ (define (plasma-dbus-service config)
"plasma-workspace"
"kactivitymanagerd"
"plasma-disks"
+ "kdeplasma-addons"
"kinfocenter"
"libksysguard"
+ "kpmcore"
"ktexteditor"
+ "kwalletmanager"
"powerdevil"
"bluedevil"
"kwallet"
--
2.47.1
S
S
Sughosha wrote on 22 Feb 18:52 -0800
[PATCH v2 3/4] services: plasma-polkit-settings: Add missing packages.
(address . 76400@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
2e9219a0f91e5c831ed6514592512143b78b22af.1740279137.git.sughosha@disroot.org
* gnu/services/desktop.scm (plasma-polkit-settings): Add kdeplasma-addons,
kglobalaccel, kpmcore and kwalletmanager.

Change-Id: I4e5544a7211fdf898b02ea51750e6d66a3b79ca9
---
gnu/services/desktop.scm | 4 ++++
1 file changed, 4 insertions(+)

Toggle diff (20 lines)
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 7c9fe3552d..a937218adf 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1880,9 +1880,13 @@ (define (plasma-polkit-settings config)
'("plasma-desktop"
"plasma-workspace"
"plasma-disks"
+ "kdeplasma-addons"
+ "kglobalaccel"
"kinfocenter"
"libksysguard"
+ "kpmcore"
"ktexteditor"
+ "kwalletmanager"
"powerdevil"
"plasma-firewall"))))
--
2.47.1
S
S
Sughosha wrote on 22 Feb 18:52 -0800
[PATCH v2 4/4] gnu: plasma: Re-order propageated-inputs.
(address . 76400@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)
c8d0d5ee4a08849bcfa620b59d24281dceb535b3.1740279137.git.sughosha@disroot.org
* gnu/packages/kde-plasma.scm (plasma)[propagated-inputs]: Re-order.

Change-Id: I809649e6e68f29307c8261d14dbb2838c8916e19
---
gnu/packages/kde-plasma.scm | 74 ++++++++++++++++++-------------------
1 file changed, 37 insertions(+), 37 deletions(-)

Toggle diff (117 lines)
diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
index 40f2fce510..3f28957f80 100644
--- a/gnu/packages/kde-plasma.scm
+++ b/gnu/packages/kde-plasma.scm
@@ -1693,53 +1693,64 @@ (define-public plasma
(list #:builder #~(begin
(mkdir #$output))))
;; TODO: cleanup, check what is no need
- (propagated-inputs (list kdeclarative ;; require by sddm breeze theme
- plasma5support ;; require by sddm breeze theme
- qt5compat ;; require by sddm breeze theme
- kiconthemes ;; require by sddm breeze theme
- ksvg ;; require by sddm breeze theme
- qqc2-desktop-style ; qtquickcontrols2 theme
- ocean-sound-theme
- qtdeclarative
- qtsvg ;; for svg support
- qtbase ;; why?
- baloo
- breeze-icons ; default mouse icon
+ (propagated-inputs (list baloo
+ bluedevil
breeze
breeze-gtk
- layer-shell-qt
+ breeze-icons ; default mouse icon
+ discover
drkonqi
kactivitymanagerd ; require this run dbus
+ kdeclarative ;; require by sddm breeze theme
kde-cli-tools
kdecoration
+ kde-gtk-config
kdeplasma-addons
+ kglobalaccel
+ kglobalacceld
+ kiconthemes ;; require by sddm breeze theme
+ kinfocenter
+ kmenuedit
kpmcore
- ktexteditor
- kscreen
- libkscreen
krdp
+ kscreen
+ kscreenlocker
+ ksshaskpass
+ ksvg ;; require by sddm breeze theme
ksystemstats
+ ktexteditor
kwallet
kwalletmanager
kwallet-pam
kwin
- plasma-workspace-wallpapers
+ layer-shell-qt
+ libkscreen
libksysguard
milou
+ ocean-sound-theme
oxygen-sounds
- qqc2-breeze-style
- kde-gtk-config
- kinfocenter
- kscreenlocker
- ksshaskpass
- discover
- kmenuedit
partitionmanager
- plasma-welcome
+ plasma5support ;; require by sddm breeze theme
plasma-browser-integration
plasma-desktop
plasma-disks
+ plasma-firewall
+ plasma-integration
+ plasma-nm
+ plasma-pa
+ plasma-systemmonitor
+ plasma-vault
+ plasma-welcome
+ plasma-workspace
+ plasma-workspace-wallpapers
polkit-kde-agent
+ powerdevil
+ qqc2-breeze-style
+ qqc2-desktop-style ; qtquickcontrols2 theme
+ qt5compat ;; require by sddm breeze theme
+ qtbase ;; why?
+ qtdeclarative
+ qtsvg ;; for svg support
system-settings
xdg-desktop-portal-kde
;; module cyclic referencing
@@ -1754,19 +1765,8 @@ (define-public plasma
(module-ref
(resolve-interface
'(gnu packages kde-systemtools))
- 'spectacle)
- plasma-firewall
- plasma-integration
- plasma-nm
- plasma-pa
- plasma-systemmonitor
- bluedevil
+ 'spectacle)))
;; plasma-thunderbolt ;; waiting for bolt
- kglobalaccel
- kglobalacceld
- plasma-vault
- plasma-workspace
- powerdevil))
(synopsis "The KDE Plasma desktop environment")
(home-page "https://kde.org/plasma-desktop/")
(description
--
2.47.1
L
L
Liliana Marie Prikler wrote 18 hours ago
b202a4afbda5c2fa03998c8d4fda7620809ae13e.camel@gmail.com
Am Sonntag, dem 23.02.2025 um 08:22 +0530 schrieb Sughosha:
Toggle quote (46 lines)
> * gnu/packages/kde-plasma.scm (plasma)[propagated-inputs]: Re-order.
>
> Change-Id: I809649e6e68f29307c8261d14dbb2838c8916e19
> ---
>  gnu/packages/kde-plasma.scm | 74 ++++++++++++++++++-----------------
> --
>  1 file changed, 37 insertions(+), 37 deletions(-)
>
> diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-
> plasma.scm
> index 40f2fce510..3f28957f80 100644
> --- a/gnu/packages/kde-plasma.scm
> +++ b/gnu/packages/kde-plasma.scm
> @@ -1693,53 +1693,64 @@ (define-public plasma
>       (list #:builder #~(begin
>                           (mkdir #$output))))
>      ;; TODO: cleanup, check what is no need
> -    (propagated-inputs (list kdeclarative ;; require by sddm breeze
> theme
> -                             plasma5support ;; require by sddm
> breeze theme
> -                             qt5compat ;; require by sddm breeze
> theme
> -                             kiconthemes ;; require by sddm breeze
> theme
> -                             ksvg ;; require by sddm breeze theme
> -                             qqc2-desktop-style ; qtquickcontrols2
> theme
> -                             ocean-sound-theme
> -                             qtdeclarative
> -                             qtsvg ;; for svg support
> -                             qtbase ;; why?
> -                             baloo
> -                             breeze-icons ; default mouse icon
> +    (propagated-inputs (list baloo
> +                             bluedevil
>                               breeze
>                               breeze-gtk
> -                             layer-shell-qt
> +                             breeze-icons ; default mouse icon
> +                             discover
>                               drkonqi
>                               kactivitymanagerd ; require this run
> dbus
> +                             kdeclarative ;; require by sddm breeze
> theme
Note: it's "required".
Also, single semicolons are preferable for line comments. If you use
emacs, M-; should do what you mean :)
Toggle quote (8 lines)
>                               kde-cli-tools
>                               kdecoration
> +                             kde-gtk-config
>                               kdeplasma-addons
> +                             kglobalaccel
> +                             kglobalacceld
> +                             kiconthemes ;; require by sddm breeze
> theme
Likewise… and so on for the rest.
Toggle quote (83 lines)
> +                             kinfocenter
> +                             kmenuedit
>                               kpmcore
> -                             ktexteditor
> -                             kscreen
> -                             libkscreen
>                               krdp
> +                             kscreen
> +                             kscreenlocker
> +                             ksshaskpass
> +                             ksvg ;; require by sddm breeze theme
>                               ksystemstats
> +                             ktexteditor
>                               kwallet
>                               kwalletmanager
>                               kwallet-pam
>                               kwin
> -                             plasma-workspace-wallpapers
> +                             layer-shell-qt
> +                             libkscreen
>                               libksysguard
>                               milou
> +                             ocean-sound-theme
>                               oxygen-sounds
> -                             qqc2-breeze-style
> -                             kde-gtk-config
> -                             kinfocenter
> -                             kscreenlocker
> -                             ksshaskpass
> -                             discover
> -                             kmenuedit
>                               partitionmanager
> -                             plasma-welcome
> +                             plasma5support ;; require by sddm
> breeze theme
>                               plasma-browser-integration
>                               plasma-desktop
>                               plasma-disks
> +                             plasma-firewall
> +                             plasma-integration
> +                             plasma-nm
> +                             plasma-pa
> +                             plasma-systemmonitor
> +                             plasma-vault
> +                             plasma-welcome
> +                             plasma-workspace
> +                             plasma-workspace-wallpapers
>                               polkit-kde-agent
> +                             powerdevil
> +                             qqc2-breeze-style
> +                             qqc2-desktop-style ; qtquickcontrols2
> theme
> +                             qt5compat ;; require by sddm breeze
> theme
> +                             qtbase ;; why?
> +                             qtdeclarative
> +                             qtsvg ;; for svg support
>                               system-settings
>                               xdg-desktop-portal-kde
>                               ;; module cyclic referencing
> @@ -1754,19 +1765,8 @@ (define-public plasma
>                               (module-ref
>                                (resolve-interface
>                                 '(gnu packages kde-systemtools))
> -                              'spectacle)
> -                             plasma-firewall
> -                             plasma-integration
> -                             plasma-nm
> -                             plasma-pa
> -                             plasma-systemmonitor
> -                             bluedevil
> +                              'spectacle)))
>                               ;; plasma-thunderbolt ;; waiting for
> bolt
> -                             kglobalaccel
> -                             kglobalacceld
> -                             plasma-vault
> -                             plasma-workspace
> -                             powerdevil))
>      (synopsis "The KDE Plasma desktop environment")
>      (home-page "https://kde.org/plasma-desktop/")
>      (description

Other than that LGTM. Since you're soloing kde-team at the moment,
feel free to push.

Cheers
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76400@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 76400
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch