A guile package for SRFI-235.

  • Done
  • quality assurance status badge
Details
2 participants
  • jgart
  • Yuval Langer
Owner
unassigned
Submitted by
Yuval Langer
Severity
normal

Debbugs page

Y
Y
Yuval Langer wrote on 7 Sep 06:02 -0700
(address . guix-patches@gnu.org)
CAK0OjG3M5aXrGZPEc43raD_c9s0-UMEQSMDnXUyCOMb+63S3EA@mail.gmail.com
Hi,

here's my package definition for SRFI-235.

Please review!

Many thanks,
Yuval Langer.
From 56f2508f1bd35ae74846555f65aa0c267bcc4eaf Mon Sep 17 00:00:00 2001
Message-Id: <56f2508f1bd35ae74846555f65aa0c267bcc4eaf.1725714029.git.yuval.langer@gmail.com>
From: Yuval Langer <yuval.langer@gmail.com>
Date: Sat, 7 Sep 2024 16:00:04 +0300
Subject: [PATCH] Add guile-srfi-235.

---
gnu/packages/guile-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)

Toggle diff (52 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3bcb0e82bb..a558674989 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4079,6 +4079,45 @@ procedures, and procedures created with it have predictable behavior when
applied to surplus arguments.")
(license license:expat)))
+(define-public guile-srfi-235
+ (let ((version "1.0.0")
+ (revision "1")
+ (commit "643a44aa9d6872962257995ecb0a31eb06a71d88"))
+ (package
+ (name "guile-srfi-235")
+ (version (git-version version revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url
+ "https://github.com/scheme-requests-for-implementation/srfi-235")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1slkcr67ad12ipkbhjdzjhbnsyvq5wi7cssvgv110fr2dy4rciwp"))))
+ (build-system guile-build-system)
+ (arguments
+ (list
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'move-create-and-delete-files
+ (lambda _
+ (substitute* "srfi/235.sld"
+ (("srfi 235")
+ "srfi srfi-235"))
+ (rename-file "srfi/235.sld" "srfi/srfi-235.scm"))))))
+ (native-inputs (list gnu:packages:guile:guile-3.0))
+ (home-page
+ "https://github.com/scheme-requests-for-implementation/srfi-235")
+ (synopsis "Combinators for Guile Scheme")
+ (description
+ "This SRFI contains various procedures that accept and return procedures, as
+well as a few others, drawn from an earlier version of Chicken.
+Common Lisp has a few of them too, and more come from the Standard
+Prelude from Programming Praxis. Using these procedures helps to keep
+code terse and reduce the need for ad hoc lambdas.")
+ (license license:expat))))
+
(define-public emacsy
(package
(name "emacsy")
--
2.30.2
J
J
jgart wrote on 7 Sep 12:25 -0700
(address . 73096@debbugs.gnu.org)(name . Yuval Langer)(address . yuval.langer@gmail.com)
877cbnp8ou.fsf@dismail.de
Hi,

Can you send a v2 with a proper commit message?

See the commit history for examples.

--
all the best,
jgart
Y
Y
Yuval Langer wrote on 7 Sep 15:20 -0700
(address . 73096@debbugs.gnu.org)(name . jgart)(address . jgart@dismail.de)
CAK0OjG2cVHd_pTxvaT08LO5xVYwjR-mJ0dLyURHur9Wp-DonOQ@mail.gmail.com
On Sat, Sep 7, 2024 at 10:26 PM jgart <jgart@dismail.de> wrote:
Toggle quote (6 lines)
>
>
> Hi,
>
> Can you send a v2 with a proper commit message?

Sorry about that.

Toggle quote (2 lines)
> See the commit history for examples.

Took from myself.

Toggle quote (4 lines)
> --
> all the best,
> jgart

And again sorry for sending to you instead of the mailing list. Not
used to debbug's process.
From 9a1ad98df904022396a3a22b3b722209b0c1d78f Mon Sep 17 00:00:00 2001
Message-Id: <9a1ad98df904022396a3a22b3b722209b0c1d78f.1725746354.git.yuval.langer@gmail.com>
From: Yuval Langer <yuval.langer@gmail.com>
Date: Sat, 7 Sep 2024 16:00:04 +0300
Subject: [PATCH] gnu: Add guile-srfi-235.

* gnu/packages/guile-xyz.scm (guile-srfi-235): New variable.
---
gnu/packages/guile-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)

Toggle diff (52 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3bcb0e82bb..a558674989 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4079,6 +4079,45 @@ procedures, and procedures created with it have predictable behavior when
applied to surplus arguments.")
(license license:expat)))
+(define-public guile-srfi-235
+ (let ((version "1.0.0")
+ (revision "1")
+ (commit "643a44aa9d6872962257995ecb0a31eb06a71d88"))
+ (package
+ (name "guile-srfi-235")
+ (version (git-version version revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url
+ "https://github.com/scheme-requests-for-implementation/srfi-235")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1slkcr67ad12ipkbhjdzjhbnsyvq5wi7cssvgv110fr2dy4rciwp"))))
+ (build-system guile-build-system)
+ (arguments
+ (list
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'move-create-and-delete-files
+ (lambda _
+ (substitute* "srfi/235.sld"
+ (("srfi 235")
+ "srfi srfi-235"))
+ (rename-file "srfi/235.sld" "srfi/srfi-235.scm"))))))
+ (native-inputs (list gnu:packages:guile:guile-3.0))
+ (home-page
+ "https://github.com/scheme-requests-for-implementation/srfi-235")
+ (synopsis "Combinators for Guile Scheme")
+ (description
+ "This SRFI contains various procedures that accept and return procedures, as
+well as a few others, drawn from an earlier version of Chicken.
+Common Lisp has a few of them too, and more come from the Standard
+Prelude from Programming Praxis. Using these procedures helps to keep
+code terse and reduce the need for ad hoc lambdas.")
+ (license license:expat))))
+
(define-public emacsy
(package
(name "emacsy")
--
2.30.2
Y
Y
Yuval Langer wrote on 7 Sep 21:02 -0700
(address . 73096@debbugs.gnu.org)
CAK0OjG3cjJGXXp61q_9vzmkv+QQyjrAknaChEchHdpHFrkU1Sw@mail.gmail.com
Friend (robin on Libera) just noticed I didn't remove the
gnu:packages:guile: prefix I use for my own Guix channel. Uploading
the hopefully final version of this patch.
From 2922975cb88444b7abfb8fe971a4eb77deab0474 Mon Sep 17 00:00:00 2001
Message-Id: <2922975cb88444b7abfb8fe971a4eb77deab0474.1725768085.git.yuval.langer@gmail.com>
From: Yuval Langer <yuval.langer@gmail.com>
Date: Sat, 7 Sep 2024 16:00:04 +0300
Subject: [PATCH] gnu: Add guile-srfi-235.

* gnu/packages/guile-xyz.scm (guile-srfi-235): New variable.
---
gnu/packages/guile-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)

Toggle diff (52 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3bcb0e82bb..792b1c6fa8 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4079,6 +4079,45 @@ procedures, and procedures created with it have predictable behavior when
applied to surplus arguments.")
(license license:expat)))
+(define-public guile-srfi-235
+ (let ((version "1.0.0")
+ (revision "1")
+ (commit "643a44aa9d6872962257995ecb0a31eb06a71d88"))
+ (package
+ (name "guile-srfi-235")
+ (version (git-version version revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url
+ "https://github.com/scheme-requests-for-implementation/srfi-235")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1slkcr67ad12ipkbhjdzjhbnsyvq5wi7cssvgv110fr2dy4rciwp"))))
+ (build-system guile-build-system)
+ (arguments
+ (list
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'move-create-and-delete-files
+ (lambda _
+ (substitute* "srfi/235.sld"
+ (("srfi 235")
+ "srfi srfi-235"))
+ (rename-file "srfi/235.sld" "srfi/srfi-235.scm"))))))
+ (native-inputs (list guile-3.0))
+ (home-page
+ "https://github.com/scheme-requests-for-implementation/srfi-235")
+ (synopsis "Combinators for Guile Scheme")
+ (description
+ "This SRFI contains various procedures that accept and return procedures, as
+well as a few others, drawn from an earlier version of Chicken.
+Common Lisp has a few of them too, and more come from the Standard
+Prelude from Programming Praxis. Using these procedures helps to keep
+code terse and reduce the need for ad hoc lambdas.")
+ (license license:expat))))
+
(define-public emacsy
(package
(name "emacsy")
--
2.30.2
J
J
jgart wrote on 9 Sep 11:17 -0700
(address . 73096-done@debbugs.gnu.org)
87a5gg6696.fsf@dismail.de
Applied, thanks!

I tested with the following in a REPL:

scheme@(guile-user)> ,use(srfi srfi-235)
scheme@(guile-user)> (if-procedure #t (lambda () 1) (lambda () 2))
$1 = 1
#<unspecified>
scheme@(guile-user)> (if-procedure #f (lambda () 1) (lambda () 2))
$2 = 2
#<unspecified>

--
all the best,
jgart
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 73096@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 73096
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch