[PATCH] gnu: git: Fix perl search-paths of wrapped programs.

Done

Details

3 participants

Ashish SHUKLA
Maxim Cournoyer
Simon Tournier

Owner: unassigned

Submitted by: Simon Tournier

Severity: normal

Debbugs page

Simon Tournier wrote on 4 Sep 18:55 -0700

Recipients:(address . guix-patches@gnu.org)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com

Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271,

where the git-send-email and gitweb.cgi wrap-programs had translated into the

"new style" using G-exps. See https://issues.guix.gnu.org/73030.

* gnu/packages/version-control.scm (git)[arguments]<phases>: Restore the

complete list of propagated inputs by modifying the functional composition

order.

Change-Id: Idfa33d9e5519aa9303b10138a166391244636ede

---

gnu/packages/version-control.scm | 22 +++++++++++++---------

1 file changed, 13 insertions(+), 9 deletions(-)

Hi,

Since there is no team, I guess, let CC people who submitted and reviewed the

initial patch. ;-)

Well, is this patch allowed to go to directly to master? Because it triggers

888 rebuilds:

$ ./pre-inst-env guix refresh -l git | cut -f1 -d':'

Building the following 411 packages would ensure 888 dependent packages are rebuilt

Cheers,

simon

PS: Sent using this fix. ;-) But an annoyance remains about Need MIME::Base64

and Authen::SASL; it requires perl-authen-sasl.

Toggle diff (50 lines)diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1db783b731..d43382368b 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -55,6 +55,7 @@
 ;;; Copyright © 2024 Hilton Chain <hako@ultrarare.space>
 ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
 ;;; Copyright © 2024 Suhail Singh <suhail@bayesians.ca>
+;;; Copyright © 2024 Simon Tournier <zimon.toutoune@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -657,21 +658,24 @@ (define-public git
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-authen-sasl")
-                                   (this-package-input "perl-net-smtp-ssl")
-                                   (this-package-input
-                                    "perl-io-socket-ssl")))))))
+                            (map last
+                                 (append-map
+                                  package-transitive-propagated-inputs
+                                  (list (this-package-input "perl-authen-sasl")
+                                        (this-package-input "perl-net-smtp-ssl")
+                                        (this-package-input
+                                         "perl-io-socket-ssl"))))))))
+
                   ;; Tell 'gitweb.cgi' where perl modules are.
                   (wrap-program (string-append out "/share/gitweb/gitweb.cgi")
                     `("PERL5LIB" ":" prefix
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-cgi")))))))
+                            (map last
+                                 (append-map
+                                  package-transitive-propagated-inputs
+                                  (list (this-package-input "perl-cgi"))))))))
 
                   ;; Tell 'git-submodule' where Perl is.
                   (wrap-program git-sm

base-commit: ed95ddeb1e58c314f2e22b4cd35986042f3e2f21
-- 
2.45.2

Simon Tournier wrote on 4 Sep 19:37 -0700

[PATCH v2] gnu: git: Fix perl search-paths of wrapped programs.

Recipients:(address . 73034@debbugs.gnu.org)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:8c204cfb8764c7f284775b68ee55998dbc32d17e.1725503559.git.zimon.toutoune@gmail.com

Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271,

where the git-send-email and gitweb.cgi wrap-programs had translated into the

"new style" using G-exps. See https://issues.guix.gnu.org/73030.

* gnu/packages/version-control.scm (git)[arguments]<phases>: Restore the

complete list of propagated inputs by modifying the functional composition

order.

Change-Id: Ia4e5feeae6418a9f098464556b74bc871e761be1

---

gnu/packages/version-control.scm | 29 ++++++++++++++++++++---------

1 file changed, 20 insertions(+), 9 deletions(-)

Hi,

Change since v1:

'package-transitive-propagated-inputs' does not return the package itself, so

let manually add it.

Cheers,

simon

Toggle diff (57 lines)diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1db783b731..b8192035c2 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -55,6 +55,7 @@
 ;;; Copyright © 2024 Hilton Chain <hako@ultrarare.space>
 ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
 ;;; Copyright © 2024 Suhail Singh <suhail@bayesians.ca>
+;;; Copyright © 2024 Simon Tournier <zimon.toutoune@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -657,21 +658,31 @@ (define-public git
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-authen-sasl")
-                                   (this-package-input "perl-net-smtp-ssl")
-                                   (this-package-input
-                                    "perl-io-socket-ssl")))))))
+                            (let ((these-inputs
+                                   (list (this-package-input "perl-authen-sasl")
+                                         (this-package-input "perl-net-smtp-ssl")
+                                         (this-package-input "perl-io-socket-ssl"))))
+                              (append
+                               these-inputs
+                               (map last
+                                    (append-map
+                                     package-transitive-propagated-inputs
+                                     these-inputs))))))))
+
                   ;; Tell 'gitweb.cgi' where perl modules are.
                   (wrap-program (string-append out "/share/gitweb/gitweb.cgi")
                     `("PERL5LIB" ":" prefix
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-cgi")))))))
+                            (let ((these-inputs
+                                   (list (this-package-input "perl-cgi"))))
+                              (append
+                               these-inputs
+                               (map last
+                                    (append-map
+                                     package-transitive-propagated-inputs
+                                     these-inputs))))))))
 
                   ;; Tell 'git-submodule' where Perl is.
                   (wrap-program git-sm

base-commit: ed95ddeb1e58c314f2e22b4cd35986042f3e2f21
-- 
2.45.2

Ashish SHUKLA wrote on 5 Sep 05:47 -0700

Re: [PATCH] gnu: git: Fix perl search-paths of wrapped programs.

Recipients:(address . 73034@debbugs.gnu.org)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:D3YD1E1WCVDS.39ZY98YCDOTLA@lostca.se

Hi,

If we're going to apply this patch which would trigger so many rebuilds,

I suggest combining it with git 2.46.0 update, I sent in issue #72413[0]

Also, this patch fixed, git-send-email for me.

[0] https://issues.guix.gnu.org/72413

Thanks!

Ashish

Simon Tournier wrote on 5 Sep 08:34 -0700

[PATCH v3 1/3] gnu: git: Fix perl search-paths of wrapped programs.

Recipients:(address . 73034@debbugs.gnu.org)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:96af57a183e3829bef3da8586b7d255ce52c4cc1.1725550253.git.zimon.toutoune@gmail.com

Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271,

where the git-send-email and gitweb.cgi wrap-programs had translated into the

"new style" using G-exps. See https://issues.guix.gnu.org/73030.

* gnu/packages/version-control.scm (git)[arguments]<phases>: Restore the

complete list of propagated inputs by modifying the functional composition

order.

Change-Id: Ia4e5feeae6418a9f098464556b74bc871e761be1

---

gnu/packages/version-control.scm | 29 ++++++++++++++++++++---------

1 file changed, 20 insertions(+), 9 deletions(-)

Toggle diff (55 lines)diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1db783b731..b8192035c2 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -55,6 +55,7 @@
 ;;; Copyright © 2024 Hilton Chain <hako@ultrarare.space>
 ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
 ;;; Copyright © 2024 Suhail Singh <suhail@bayesians.ca>
+;;; Copyright © 2024 Simon Tournier <zimon.toutoune@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -657,21 +658,31 @@ (define-public git
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-authen-sasl")
-                                   (this-package-input "perl-net-smtp-ssl")
-                                   (this-package-input
-                                    "perl-io-socket-ssl")))))))
+                            (let ((these-inputs
+                                   (list (this-package-input "perl-authen-sasl")
+                                         (this-package-input "perl-net-smtp-ssl")
+                                         (this-package-input "perl-io-socket-ssl"))))
+                              (append
+                               these-inputs
+                               (map last
+                                    (append-map
+                                     package-transitive-propagated-inputs
+                                     these-inputs))))))))
+
                   ;; Tell 'gitweb.cgi' where perl modules are.
                   (wrap-program (string-append out "/share/gitweb/gitweb.cgi")
                     `("PERL5LIB" ":" prefix
                       ,(search-path-as-list
                         '("lib/perl5/site_perl")
                         '#$(delete-duplicates
-                            (append-map
-                             (compose last package-transitive-propagated-inputs)
-                             (list (this-package-input "perl-cgi")))))))
+                            (let ((these-inputs
+                                   (list (this-package-input "perl-cgi"))))
+                              (append
+                               these-inputs
+                               (map last
+                                    (append-map
+                                     package-transitive-propagated-inputs
+                                     these-inputs))))))))
 
                   ;; Tell 'git-submodule' where Perl is.
                   (wrap-program git-sm
-- 
2.45.2

Simon Tournier wrote on 5 Sep 08:34 -0700

[PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0

Recipients:(address . 73034@debbugs.gnu.org)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:cover.1725550253.git.zimon.toutoune@gmail.com

Hi,

Since changes to the package Git imply large rebuilds, this series integrates

submission #72413.

Change since v2: Restore the ’origin’ of git-manpages under native-inputs.

Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside the phase.

Toggle snippet (17 lines)+          (add-after 'split 'install-man-pages
+            (lambda _
+              (let ((man (string-append #$output "/share/man")))
+                (mkdir-p man)
+                (with-directory-excursion man
+                  (invoke
+                   "tar" "xvf"
+                   #$(origin
+                       (method url-fetch)
+                       (uri (string-append
+                             "mirror://kernel.org/software/scm/git/"
+                             "git-manpages-" version ".tar.xz"))
+                       (sha256
+                        (base32
+                         "0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8ja4qymw"))))))))

And this appears to me a bad idea, because 1. it makes harder to know what are

the inputs and more importantly 2. it is hidden from procedure

’package-direct-sources’, which means it will not be archived.

Cheers,

simon

1: https://issues.guix.gnu.org/72413

Ashish SHUKLA (1):

gnu: git: Update to 2.46.0

Simon Tournier (2):

gnu: git: Fix perl search-paths of wrapped programs.

gnu: git: Move git-manpages origin from phases to native-inputs.

gnu/packages/version-control.scm | 77 +++++++++++++++++++-------------

1 file changed, 47 insertions(+), 30 deletions(-)

base-commit: 7d2ced8d6d9c38327592d312376d59a8c37fc160

2.45.2

Simon Tournier wrote on 5 Sep 08:34 -0700

[PATCH v3 3/3] gnu: git: Move git-manpages origin from phases to native-inputs.

Recipients:(address . 73034@debbugs.gnu.org)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:3a6d3ee8f2768bef9f17196b82c47c99c2ea09f5.1725550253.git.zimon.toutoune@gmail.com

The move from native-inputs to the install-man-pages phase had been done by

f288604428e9c8f096ec9e0eccf207e079806271.

* gnu/packages/version-control.scm (git)[arguments]<phases>: Move git-manpages

origin from here...

[native-inputs]: ...to here.

Change-Id: I9fa543f7410bce6eb8a82d275eab81a1ea86ecc0

---

gnu/packages/version-control.scm | 44 ++++++++++++++++++--------------

1 file changed, 25 insertions(+), 19 deletions(-)

Toggle diff (58 lines)diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 9a4c2fdbdc..3e8f042d18 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -695,26 +695,32 @@ (define-public git
                   (with-directory-excursion man
                     (invoke
                      "tar" "xvf"
-                     #$(origin
-                         (method url-fetch)
-                         (uri (string-append
-                               "mirror://kernel.org/software/scm/git/"
-                               "git-manpages-" (package-version this-package)
-                               ".tar.xz"))
-                         (sha256
-                          (base32
-                           "1lvvhzypllbyd8j6m0p9qgd3gqg10gch9s7lqif8vr9n80fqn4fw"))))))))))))
+                     #$(this-package-native-input "git-manpages"))))))))))
     (native-inputs
-     (modify-inputs (package-native-inputs git-minimal)
-       ;; For subtree documentation.
-       (append asciidoc
-               docbook2x
-               docbook-xml-4.5
-               docbook-xsl
-               libxslt
-               pkg-config
-               texinfo
-               xmlto)))
+     (cons
+      ;; To build the man pages from the git sources, we would need a dependency
+      ;; on a full XML tool chain, and building it actually takes ages.  So we
+      ;; use this lazy approach and use released tarball.
+      `("git-manpages"
+       ,(origin
+           (method url-fetch)
+           (uri (string-append
+                 "mirror://kernel.org/software/scm/git/git-manpages-"
+                 (package-version this-package) ".tar.xz"))
+           (sha256
+            (base32
+             "1lvvhzypllbyd8j6m0p9qgd3gqg10gch9s7lqif8vr9n80fqn4fw"))))
+
+      (modify-inputs (package-native-inputs git-minimal)
+        ;; For subtree documentation.
+        (append asciidoc
+                docbook2x
+                docbook-xml-4.5
+                docbook-xsl
+                libxslt
+                pkg-config
+                texinfo
+                xmlto))))
     (inputs
      (modify-inputs (package-inputs git-minimal)
        (append bash-minimal             ;for wrap-program
-- 
2.45.2

Simon Tournier wrote on 5 Sep 08:34 -0700

[PATCH v3 2/3] gnu: git: Update to 2.46.0

Recipients:(address . 73034@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)

Message-ID:bce916651ce136e27296c02633ac57b977484b9d.1725550253.git.zimon.toutoune@gmail.com

* gnu/packages/version-control.scm (git-minimal): Update to 2.46.0.

(git)[arguments]<phases>{install-man-pages} Update hash for the

git-manpages.

Change-Id: I686825ffba828e88e37ff156fab23fd43155d210

---

gnu/packages/version-control.scm | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (32 lines)diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index b8192035c2..9a4c2fdbdc 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -249,14 +249,14 @@ (define git-cross-configure-flags
 (define-public git-minimal
   (package
     (name "git-minimal")
-    (version "2.45.2")
+    (version "2.46.0")
     (source (origin
              (method url-fetch)
              (uri (string-append "mirror://kernel.org/software/scm/git/git-"
                                  version ".tar.xz"))
              (sha256
               (base32
-               "1nws1vjgj54sv32wxl1h3n1jkcpabqv7a605hhafsby0n5zfigsi"))))
+               "15bzq9m6c033qiz5q5gw1nqw4m452vvqax30wbms6z4bl9i384kz"))))
     (build-system gnu-build-system)
     (arguments
      (list
@@ -703,7 +703,7 @@ (define-public git
                                ".tar.xz"))
                          (sha256
                           (base32
-                           "1pqrp46kwbxycqld39027ph1cvkq9am156y3sswn6w2khsg30f09"))))))))))))
+                           "1lvvhzypllbyd8j6m0p9qgd3gqg10gch9s7lqif8vr9n80fqn4fw"))))))))))))
     (native-inputs
      (modify-inputs (package-native-inputs git-minimal)
        ;; For subtree documentation.
-- 
2.45.2

Maxim Cournoyer wrote on 5 Sep 21:17 -0700

Re: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0

Recipients:(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:87msklct5u.fsf@gmail.com

Hi,

Simon Tournier <zimon.toutoune@gmail.com> writes:

Toggle quote (29 lines)> Hi,
>
> Since changes to the package Git imply large rebuilds, this series integrates
> submission #72413.
>
> Change since v2: Restore the ’origin’ of git-manpages under native-inputs.
>
> Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside the phase.
>
> +          (add-after 'split 'install-man-pages
> +            (lambda _
> +              (let ((man (string-append #$output "/share/man")))
> +                (mkdir-p man)
> +                (with-directory-excursion man
> +                  (invoke
> +                   "tar" "xvf"
> +                   #$(origin
> +                       (method url-fetch)
> +                       (uri (string-append
> +                             "mirror://kernel.org/software/scm/git/"
> +                             "git-manpages-" version ".tar.xz"))
> +                       (sha256
> +                        (base32
> +                         "0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8ja4qymw"))))))))
>
> And this appears to me a bad idea, because 1. it makes harder to know what are
> the inputs and more importantly 2. it is hidden from procedure
> ’package-direct-sources’, which means it will not be archived.

I believe your argument 1. is going to affect any label-free package

definitions needing additional origins copied in, so the issue is bigger

than just this commit, in my opinion.

About 2; perhaps it'd be preferable to build the doc from source, if

that doesn't introduce cycles or too large of a native inputs graph.

Thanks,

Maxim

Simon Tournier wrote on 6 Sep 03:31 -0700

Recipients:(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)

Message-ID:87le05hy4m.fsf@gmail.com

Hi Maxim,

On Fri, 06 Sep 2024 at 13:17, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

Toggle quote (8 lines)

>> And this appears to me a bad idea, because 1. it makes harder to know what are

>> the inputs and more importantly 2. it is hidden from procedure

>> ’package-direct-sources’, which means it will not be archived.

> I believe your argument 1. is going to affect any label-free package

> definitions needing additional origins copied in, so the issue is bigger

> than just this commit, in my opinion.

Well, is it not changing the scope of the work being reviewed?

If not, sorry, I do not understand what you mean. Could you explain more?

In my views, what comes from the outside should be listed under inputs,

native-inputs or propagated-inputs. I mean, that’s somehow the

principle from functional paradigm. Putting an ’origin’ inside an

arguments is somehow a way to get around that principle, IMHO.

For instance, packages farstream, gnulib-checkout, smithforth,

gnome-recipes and dmd-bootstrap should also be fixed.

If you mean that it’s not easy to fix, from my understanding, it changes

the scope of the work being reviewed but let take the opportunity to

discuss. :-)

Currently it’s not possible to write something like:

Toggle snippet (15 lines)(native-inputs (append
                    (list
                     `("foo"
                       ,(origin
                          (method git-fetch)
                          (uri (git-reference
                                (url "https://somewhere.org/plop")
                                (commit (string-append "v" version))))
                          (file-name (git-file-name "plip" version))
                          (sha256
                           (base32
                            "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx")))))
                    (list bar baz and other)))

It appears to me that something is lacking: inputs-append. ;-) We could

have a macro or a procedure that does the dance, allowing to mix both

“styles”.

Toggle quote (3 lines)

> About 2; perhaps it'd be preferable to build the doc from source, if

> that doesn't introduce cycles or too large of a native inputs graph.

This is out of the scope, IMHO.  Yes, I agree: it might be preferable
but while waiting, it appears to me even more preferable to not have a
package that hides all its sources. ;-)

Cheers,
simon

Simon Tournier wrote on 6 Sep 08:53 -0700

Recipients:(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)

Message-ID:87a5gkixri.fsf@gmail.com

Re,

On Fri, 06 Sep 2024 at 12:31, Simon Tournier <zimon.toutoune@gmail.com> wrote:

Toggle quote (4 lines)

>> I believe your argument 1. is going to affect any label-free package

>> definitions needing additional origins copied in, so the issue is bigger

>> than just this commit, in my opinion.

[...]

Toggle quote (4 lines)

> from my understanding, it changes

> the scope of the work being reviewed but let take the opportunity to

> discuss. :-)

See submission #73073 https://issues.guix.gnu.org/73073.

Cheers,

simon

Maxim Cournoyer wrote on 8 Sep 05:10 -0700

Recipients:(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:874j6qfir7.fsf@gmail.com

Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> writes:

Toggle quote (16 lines)> Re,
>
> On Fri, 06 Sep 2024 at 12:31, Simon Tournier <zimon.toutoune@gmail.com> wrote:
>
>>> I believe your argument 1. is going to affect any label-free package
>>> definitions needing additional origins copied in, so the issue is bigger
>>> than just this commit, in my opinion.
>
> [...]
>
>>                                        from my understanding, it changes
>> the scope of the work being reviewed but let take the opportunity to
>> discuss. :-)
>
> See submission #73073 <https://issues.guix.gnu.org/73073>.

Thanks for following up with concrete ideas.  It seems the discussion
still has some ways to go before we reach consensus there, but at least
it seems clear we do not want to go back to reintroducing labels, so
I've applied 1/3 and 3/3 but left out 2/3.

Thank you for fixing my botched wrapped-program phase translation :-).
We can now use 'git send-email' and friends easily again.

-- 
Thanks,
Maxim

Closed

Simon Tournier wrote on 9 Sep 10:50 -0700

Re: bug#73034: [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0

Recipients:(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)

Message-ID:87zfogra14.fsf@gmail.com

Hi Maxim,

On Sun, 08 Sep 2024 at 21:10, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

Toggle quote (2 lines)

> We can now use 'git send-email' and friends easily again.

Cool! Thank you.

Cheers,

simon

Closed

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 73034@patchwise.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 73034

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date