[PATCH] gnu: go-github-com-elliotchance-orderedmap: Fix tests.

  • Done
  • quality assurance status badge
Details
2 participants
  • Greg Hogan
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Greg Hogan
Severity
normal

Debbugs page

G
G
Greg Hogan wrote on 3 Sep 14:27 -0700
(address . guix-patches@gnu.org)(name . Greg Hogan)(address . code@greghogan.com)
e966d8a3c08c23e9f25e355b8a23c6eccc2c32a9.1725398734.git.code@greghogan.com
* gnu/packages/golang-xyz.scm (go-github-com-elliotchance-orderedmap)
[arguments]<#:phases>: Replace 'check and only run short tests so as to
exclude flaky performance tests.

Change-Id: If9fbc5510643f9d5e3ccff09f71e00a9cdfbe92f
---
gnu/packages/golang-xyz.scm | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

Toggle diff (25 lines)
diff --git a/gnu/packages/golang-xyz.scm b/gnu/packages/golang-xyz.scm
index 796341a66bc..6c17d0a74b9 100644
--- a/gnu/packages/golang-xyz.scm
+++ b/gnu/packages/golang-xyz.scm
@@ -2154,7 +2154,15 @@ (define-public go-github-com-elliotchance-orderedmap
(base32 "1hhyk96l6mfijkay9ga6jqpczpn34fbqkjrqj3v9pf5p1hzd0xdx"))))
(build-system go-build-system)
(arguments
- (list #:import-path "github.com/elliotchance/orderedmap"))
+ (list #:import-path "github.com/elliotchance/orderedmap"
+ #:phases
+ #~(modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key tests? import-path #:allow-other-keys)
+ (when tests?
+ ;; The full test suite runs flaky performance tests,
+ ;; so only run the short tests.
+ (invoke "go" "test" "-test.short" import-path)))))))
(native-inputs
(list go-github-com-stretchr-testify))
(home-page "https://github.com/elliotchance/orderedmap")

base-commit: 19e0b937857563e77841a4fc5433589fa98c810d
--
2.46.0
S
S
Sharlatan Hellseher wrote on 4 Sep 02:15 -0700
(address . 73011-done@debbugs.gnu.org)
87ttevye2x.fsf@gmail.com
Hi Greg,

Thanks for the patch.

I've applied minor modification to the patch to make sure "v2" inherits
replaced check phase as well.

Pushed as 5b841a42fbf3ffd929ba76e37753ba1cb4797125 to master.

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmbYJTYACgkQdtcnv/Ys
0rWalxAAquptGHFLwcfhefffsMqTgqV66poal1RViJrOnrE9uy0PbZIX1qnxYh0f
PXRDoPZg1p5zoNT55FRRwzzEczpu3fzQDpmHglTFX3YJO1bBnUfWjlEMzH1LdJIh
x0qKcug+PrpD4Y67FlF/yEP5i+iH4lWgtH0CEAms36jC7pyvdbK9lY28ss8BJY5A
fHIzryYr0FuLlXd9IPRQb2XeQ+nbnknnF0tv8Yv1nVBnTVyVm5RI3AEax5iKt7le
VQokrJygKJ9hC5HyjwQyjByqNnz2LLG0kID7MOJFUdUnB3kcSqBb9TYsh/0FCveg
p0oWNxJ2hqk6hMfoPQYhJrwFwFE8dKjf7aa0ZHtFoysuTeB2pyoSc6dqGYc6F3Ed
PJ7z+FeUqiboPwM/9VYTS8KCNHQDFXslfnn6HGI0i0sHphd4ggk77t+r358w6XLt
GCmZYnLJO9qBZYvbLS5f/j6hyKCm6i5zhsJesn1ydKIxDZIT4pnyRwS9JfSwkvK0
ipoQqGNtnm82uKYmDZM9k3QN6sCyXVW6S0oTVHMK0WAuV5akQtkPEKoAJ/U2hBud
JRAJPEOVJQEB6Bk3e5n9DoH4plHXlgW9CTTda28mlmxIF+VrCeTaOEA+JZdysnBU
iPeW/ss5JvaRUDY3ackYIYzmU+sCAzUG5JHQI3+nD++ijVMTlU8=
=17ZU
-----END PGP SIGNATURE-----

Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 73011@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 73011
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch