qt-tools is unnecessary optional dependency for monero

  • Done
  • quality assurance status badge
Details
3 participants
  • 0xFFFC
  • Guillaume Le Vaillant
  • Maxim Cournoyer
Owner
unassigned
Submitted by
0xFFFC
Severity
normal

Debbugs page

0
0
0xFFFC wrote on 24 Aug 13:26 -0700
(name . bug-guix@gnu.org)(address . bug-guix@gnu.org)
YVBTlUtHLFqbjeVVluAkH7akb9mfcCxFxGjjmA5BBhiK-whc7B2V4ZCtKqPDJ_YpR9rvyqBo-ldKKsC8wrewB4vVda7JOB2dmof130CMdzU=@proton.me
Hi Guix community,

Thank you for your great software :)

I noticed that the Monero package has an (a huge) unnecessary dependency here [1]. qt is an optional dependency for Monero code base (we only need that in case of using translations).

Anyway to make this optional? or get rid of this?


Freedom wins.
0xFFFC
Attachment: file
G
G
Guillaume Le Vaillant wrote on 25 Aug 12:01 -0700
(name . 0xFFFC)(address . 0xFFFC0000@proton.me)(address . 72797@debbugs.gnu.org)
877cc4e8a8.fsf@kitej
0xFFFC via Bug reports for GNU Guix <bug-guix@gnu.org> skribis:

Toggle quote (13 lines)
> Hi Guix community,
>
> Thank you for your great software :)
>
> I noticed that the Monero package has an (a huge) unnecessary dependency here [1]. qt is an optional dependency for Monero code base (we only need that in case of using translations).
>
> Anyway to make this optional? or get rid of this?
>
> 1.https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/finance.scm#n716
>
> Freedom wins.
> 0xFFFC

Hi.

The qt-tools package is used to create the binary translations files
that are used by the monero-wallet-cli program, which seems to be
a useful thing.

What kind of issue is the dependency on qt-tools causing for you?

To disable translations, a variant of the monero package like the
following could work (not tested, I'm writing this example on the fly):

Toggle snippet (6 lines)
(define-public monero-without-translations
(inherit monero)
(name monero-without-translations)
(native-inputs (package-native-inputs monero)
(delete "qttools-5")))
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZst/jw8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j/9ogD9HGw2DQ6qxziU0H1MEuA8SJYAE31//I7c16Pb
nDLG1ucBAIYLblcqLR/VwRlzn0hc1vq+006d2Phiid2iI2jwhmAc
=dAgF
-----END PGP SIGNATURE-----

G
G
Guillaume Le Vaillant wrote on 25 Aug 14:25 -0700
(name . 0xFFFC)(address . 0xFFFC0000@proton.me)(address . 72797@debbugs.gnu.org)
8734mse1m1.fsf@kitej
Here's a corrected definition:

Toggle snippet (7 lines)
(define-public monero-without-translations
(package
(inherit monero)
(name "monero-without-translations")
(native-inputs (modify-inputs (package-native-inputs monero)
(delete "qttools")))))
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZsuhVg8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j+FZQD+JwCUed6B6MNruTUAKdNQDRQxZ8TZKsUHj881
JzRNQKEA/0/4GaadxZu0go1SumAnjn/TPHOIrh4Ze8tdUxS641EA
=P/Ee
-----END PGP SIGNATURE-----

M
M
Maxim Cournoyer wrote on 14 Sep 06:04 -0700
(name . Guillaume Le Vaillant)(address . glv@posteo.net)
877cbetmhr.fsf@gmail.com
tag 72797 + notabug
quit

Hi Guillaume,

Guillaume Le Vaillant <glv@posteo.net> writes:

Toggle quote (10 lines)
> Here's a corrected definition:
>
> (define-public monero-without-translations
> (package
> (inherit monero)
> (name "monero-without-translations")
> (native-inputs (modify-inputs (package-native-inputs monero)
> (delete "qttools")))))
>

Thanks for providing the above tip for users who'd like rewrite the
dependencies of monero. Guix will continue shipping translations in its
stock package, so you should use the above. qt-tools is also a native
dependency, so shouldn't end up in the closure of the built package.

--
Thanks,
Maxim
?
Your comment

This issue is archived.

To comment on this conversation send an email to 72797@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 72797
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch