[PATCH 0/2] Update qmmp

  • Done
  • quality assurance status badge
Details
2 participants
  • Timotej Lazar
  • Zheng Junjie
Owner
unassigned
Submitted by
Timotej Lazar
Severity
normal

Debbugs page

T
T
Timotej Lazar wrote on 20 Apr 06:08 -0700
(address . guix-patches@gnu.org)(name . Timotej Lazar)(address . timotej.lazar@araneo.si)
cover.1713618464.git.timotej.lazar@araneo.si
Timotej Lazar (2):
gnu: qmmp: Update to 2.1.7.
gnu: qmmp: Add missing inputs.

gnu/packages/music.scm | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)


base-commit: 0f68306268773f0eaa4327e1f6fdcb39442e4a34
--
2.41.0
T
T
Timotej Lazar wrote on 20 Apr 06:12 -0700
[PATCH 1/2] gnu: qmmp: Update to 2.1.7.
(address . 70481@debbugs.gnu.org)(name . Timotej Lazar)(address . timotej.lazar@araneo.si)
ac5fc334c4535daf30e3b555d7c865880140c1c4.1713618464.git.timotej.lazar@araneo.si
* gnu/packages/music.scm (qmmp): Update to 2.1.7.
[properties]: Add release-monitoring-url.
---
gnu/packages/music.scm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Toggle diff (34 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ceac94a592..86b46bfdfe 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -603,15 +603,15 @@ (define-public ctrlr
(define-public qmmp
(package
(name "qmmp")
- (version "2.1.6")
+ (version "2.1.7")
(source
(origin
(method url-fetch)
- (uri (string-append "https://qmmp.ylsoftware.com/files/"
+ (uri (string-append "https://qmmp.ylsoftware.com/files/qmmp/"
(version-major+minor version) "/"
"qmmp-" version ".tar.bz2"))
(sha256
- (base32 "1jpflf17198ascaqmxla6ajb69bnj8zzngk32vdyyw5443kshylj"))))
+ (base32 "0wqy4dh5cci67d822zn2535l0vsvd9c9sqsbscz4j530c6y6g9z6"))))
(build-system qt-build-system)
(arguments
(list #:qtbase qtbase
@@ -650,6 +650,8 @@ (define-public qmmp
(native-inputs
(list pkg-config))
(home-page "https://qmmp.ylsoftware.com")
+ (properties
+ `((release-monitoring-url . "https://qmmp.ylsoftware.com/downloads.php")))
(synopsis "Qt-based music player")
(description "Music player with support for most common audio formats, and
plugins for various additional features such as visualization, effects and
--
2.41.0
T
T
Timotej Lazar wrote on 20 Apr 06:12 -0700
[PATCH 2/2] gnu: qmmp: Add missing inputs.
(address . 70481@debbugs.gnu.org)(name . Timotej Lazar)(address . timotej.lazar@araneo.si)
4927fa124957b92040c0386a733b03a9ce1f2ebb.1713618464.git.timotej.lazar@araneo.si
* gnu/packages/music.scm (qmmp): Add inputs to support unpacking skins.
[inputs]: Add tar and unzip.
[arguments]: Add phase to set absolute paths to these programs.

Change-Id: I79a6530ad27b474ecc64e5b7de36e0370595bc69
---
gnu/packages/music.scm | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

Toggle diff (32 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 86b46bfdfe..df3ff38b4a 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -615,7 +615,15 @@ (define-public qmmp
(build-system qt-build-system)
(arguments
(list #:qtbase qtbase
- #:tests? #f)) ; there are no tests
+ #:tests? #f ; there are no tests
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'set-paths
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "src/plugins/Ui/skinned/skinreader.cpp"
+ (("\"(tar|unzip)\"" _ name)
+ (let ((file (string-append "/bin/" name)))
+ (string-append "\"" (search-input-file inputs file) "\"")))))))))
(inputs
;; Missing optional inputs:
;; libsidplay2 ; input plugin
@@ -645,6 +653,8 @@ (define-public qmmp
qttools
soxr
taglib
+ tar ; for loading skins
+ unzip ; for loading skins
wavpack
wildmidi))
(native-inputs
--
2.41.0
Z
Z
Zheng Junjie wrote on 21 Apr 21:46 -0700
Re: [bug#70481] [PATCH 0/2] Update qmmp
(name . Timotej Lazar)(address . timotej.lazar@araneo.si)(address . 70481-done@debbugs.gnu.org)
871q6yknsh.fsf@iscas.ac.cn
Timotej Lazar <timotej.lazar@araneo.si> writes:

Toggle quote (10 lines)
> Timotej Lazar (2):
> gnu: qmmp: Update to 2.1.7.
> gnu: qmmp: Add missing inputs.
>
> gnu/packages/music.scm | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
>
> base-commit: 0f68306268773f0eaa4327e1f6fdcb39442e4a34

LGTM, push. see
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmYl644ACgkQO1qpk+Gi
3/Bggg//bLZGRUrCTCj92Zx0oFeSvCoXfomsvE4ZtqKIeCcsYaPwyM6ygrEqgtnK
+ECe/ipgiXN6H/3WjcAqY2OLP7OIG1FPNfUiDdzq8Pbv/6XvheH5F7io6y6gse8d
9o+EmbH7EDC5blUirPxF1UsUYclm2cAO4XztIw4NfVG0hMUs3nVJ5CZRdsR8m3D1
85KdqUOCDQdZDtmRD/XOZ9o/7qPhC09xg4h6OYEZIgDBHcmlKgfKeCI1qUjUAr27
0MyS1hzfelTBItwBEfydqkGcocleptksNWnSCPqdyusZbZtQSM+a2UdgG+CDeQjG
ClUHuqbOSewg3RGgvx7ZGKwI71kvH+gi3m+kQ8O1d8UqcNXylaGWnPvcKs4XAYk5
Mpcdvmp/xeMJsfXzt3WSpHesLHZc+PpaYJyh7MLNthSsPF6NZVryGvQL7DbH53Cx
BoR3UM4M7cJFgGNEE5a8S/UHYhIGFc1LjYDUSvfLR8UjhVIZlENX7m//BRW5/VRZ
JmVQHWOqyPWKIdw2guvl07o3EgqBDQ4Uv6Pw+rm17RSBWWPZ2uq47Ytwctj4ssCX
sKwa/tIkIxorc9cLoEMDKEOq+afQPKqjo62T/hUvpQtQkoXl3Gtkluat3r5+LnUK
/w5kEACbf4bj+VtZA1UvscE7eL/Sx+VmdlgD0XXH2MMzgHxWDEs=
=5Bmr
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 70481@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70481
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch