On Tue, Apr 16, 2024 at 11:21:26PM +0100, Christopher Baines wrote:
Toggle quote (46 lines)
> "ashish.is--- via Guix-patches" via <guix-patches@gnu.org> writes:
>
> > From: Ashish SHUKLA <ashish.is@lostca.se>
> >
> > * gnu/packages/version-control.scm (fnc): New variable.
> >
> > Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684
> > Signed-off-by: Ashish SHUKLA <ashish.is@lostca.se>
> > ---
> > gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> > index 96ca1df552..33607940ec 100644
> > --- a/gnu/packages/version-control.scm
> > +++ b/gnu/packages/version-control.scm
> > @@ -4145,3 +4145,28 @@ (define-public git-sizer
> > (description "Compute various size metrics for a Git repository, flagging
> > those that might cause problems or inconvenience.")
> > (license license:expat)))
> > +
> > +(define-public fnc
> > + (package
> > + (name "fnc")
> > + (version "0.16")
> > + (source (origin
> > + (method url-fetch)
> > + (uri
> > + (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" version ".tar.gz"))
> > + (sha256
> > + (base32
> > + "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy"))))
> > + (build-system gnu-build-system)
> > + (arguments
> > + '(#:phases (modify-phases %standard-phases
> > + (delete 'configure))
> > + #:tests? #f
> > + #:make-flags (list "CC=gcc"
> > + (string-append "PREFIX=" (assoc-ref %outputs "out")))))
>
> The arguments needed a bit of touching up. Using gexp's is the new
> style. It's unclear why the tests are disabled, I guess it's because
> there are no tests so I've added a comment to this effect. Hardcoding
> CC=gcc also causes problems for cross building, so use (cc-for-target)
> instead.
Thanks for catching this, it indeed crossed my mind, but I was not sure what to replace it with should someone chose to build with `clang' (or other C language compiler), and `cc' is not present.
Toggle quote (13 lines)
> > + (inputs (list ncurses zlib sqlite-next))
> > + (home-page "https://fnc.bsdbox.org")
> > + (synopsis "Interactive text-based user interface for Fossil")
> > + (description "fnc uses ncurses and libfossil to create a fossil ui experience in
> > +the terminal, and parse local changes at the hunk level to prepare atomic commits.")
> > + (license license:isc)))
> >
> > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293
>
> I did have a quick check over the source, including a concatenated
> sqlite seems unusual and not ideal, but I'm not quite sure how it's
> used.
libfossil is a library implementation of fossil ships with bundled sqlite3, and the author decide to bundle libfossil, and so sqlite3 comes with it.
Toggle quote (12 lines)
>
> One final change I made was moving the package definition up off the
> bottom of the file (as if everyone adds new packages there, it causes
> merge conflicts).
>
> I've pushed this to master with the changes I describe as
> a45b2c7c63c6af9c42698e12b6809c41c0926de3 so please take a look.
>
> Thanks,
>
> Chris
Thanks!
--
Ashish | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0
"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmYflY1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2
ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP
pLBG/w/8C7zElodKXntITeFvcJXYuyI4oW9KufmGcfFWINWeb8szUvi3LmBCegn0
efVIFLRlfW4p46/GxvXzqL3xJUete4wKxwzar19aW7Oc4hAQ5cAb5v3+BNC3sH4a
s6OEZoPwVApJNxELK9Jgy01u2iUsN59rn1T7F87tGtqBk694dw1eNzkb5AtmSBVY
4v2NIkYpjHfhz4VdYSGDfxAgyabootFspsvfAPkGvPnyB7xMI+zwHbT7fqrfFxfU
BxVgWFwe9NrweGfcpbAyd90uZHs+QiL9NkPFihM3V52o0PVUTAqXIu7VTCa0+h1C
eANVjakxCklIY37BiGgOof7yNKBGSMO16qmR3DDGrMp7y6o+oYGA3OPPVr4ElYr2
qv1K693JpQU84+B2sVedvopPrT/XPsMLEcaVsTkbITXCoEjJXVtk6O940ezqbQTh
Lo3378lN2yHEdGOc6APgVxAPuiTZ/io6HhaoNLykVmWibTUgUT6j8uoxDr7BMlSq
ss8HOD2tBeb/3dEwryP6bC9LbrdKop4ff4y8fmVs/IY64g9UAxaauqXfF7IgA+gk
nTIoZrueI/HIfSKrsGQGrU96uPWsPUI4O6rj2RZiKQhyiliN8E5cbFw2rilkfjMo
uOt4zj1aajOsFFh6+kl49m1+Avauxt7PGzCyScqn6V0Ayn+UxuI=
=ejuW
-----END PGP SIGNATURE-----