[PATCH] gnu: evolution-data-server-3.44: Disable failing test on aarch64.

  • Done
  • quality assurance status badge
Details
4 participants
  • Christopher Baines
  • Maxim Cournoyer
  • Roman Scherer
  • Roman Scherer
Owner
unassigned
Submitted by
Roman Scherer
Severity
normal

Debbugs page

R
R
Roman Scherer wrote on 7 Apr 06:03 -0700
(address . guix-patches@gnu.org)(name . Roman Scherer)(address . roman@burningswell.com)
610209de070832c5f7e20425f6b36a6ba69d02a6.1712494693.git.roman@burningswell.com
* gnu/packages/gnome.scm (evolution-data-server-3.44): Disable failing test on aarch64.

Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
---
gnu/packages/gnome.scm | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

Toggle diff (39 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 4934ade3dd..933ff8179f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8302,7 +8302,17 @@ (define-public evolution-data-server-3.44
(propagated-inputs
(modify-inputs (package-propagated-inputs evolution-data-server)
(delete "gtk")
- (replace "libsoup" libsoup-minimal-2)))))
+ (replace "libsoup" libsoup-minimal-2)))
+ (arguments
+ (substitute-keyword-arguments (package-arguments evolution-data-server)
+ ((#:phases phases '%standard-phases)
+ #~(modify-phases #$phases
+ #$@(if (target-aarch64?)
+ #~((add-after 'unpack 'disable-failing-tests
+ (lambda _
+ (substitute* "tests/libebook/client/CMakeLists.txt"
+ (("test-book-client-custom-summary") "")))))
+ '())))))))
(define-public caribou
(package

base-commit: 12f02c9bb87b8ea756e5c09806522e6df8b7e1ca
prerequisite-patch-id: 0250f6d992ee74e81797cb1266771a825226fa0b
prerequisite-patch-id: e03a4f63a64eda0c1f229e0b92d130a9beadefa5
prerequisite-patch-id: 09e6b4e8c70f5eb7996f78194c59245f38d3241b
prerequisite-patch-id: a12882ccf5bbef1edbd1110f128cd107f84a1377
prerequisite-patch-id: 2c83a46f3bcf9d3e153e2543fe9a57e5f33af286
prerequisite-patch-id: 3c1ca4618ff254748694208007768994f8f3f180
prerequisite-patch-id: c6c55378dfbf74f5862c5b5609fe7cc3dc4b52d7
prerequisite-patch-id: 6307af77f1d5ccaef3accfce06479f604cdfd260
prerequisite-patch-id: 1f06621d95d4b22729a1461bca01feeb0d491324
prerequisite-patch-id: 2b5ca4e046c327f00c14fb9a0b7a08b6e4014bcb
prerequisite-patch-id: 7ebd64a45f6032d0fa2317d3b276cd93544ea187
prerequisite-patch-id: 6f659e1af6f034cd0f3541f605fa7c0f12845380
--
2.41.0
R
R
Roman Scherer wrote on 7 Apr 06:23 -0700
[PATCH v2] gnu: evolution-data-server: Disable failing test on aarch64.
(address . 70259@debbugs.gnu.org)(name . Roman Scherer)(address . roman@burningswell.com)
c8ef4332f306ef76328aebe2fcd329912ef92ad4.1712495942.git.roman@burningswell.com
* gnu/packages/gnome.scm (evolution-data-server): Disable failing test on aarch64.

Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
---

Just after I fixed evolution-data-server-3.44, the evolution-data-server
packages also started to fail. This test is flaky on my aarch64 machine.

gnu/packages/gnome.scm | 6 ++++++
1 file changed, 6 insertions(+)

Toggle diff (31 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 4934ade3dd..7a58c01e8c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8219,6 +8219,12 @@ (define-public evolution-data-server
"-DWITH_PHONENUMBER=ON"))
#:phases
#~(modify-phases %standard-phases
+ #$@(if (target-aarch64?)
+ #~((add-after 'unpack 'disable-failing-aarch64-tests
+ (lambda _
+ (substitute* "tests/libebook/client/CMakeLists.txt"
+ (("test-book-client-custom-summary") "")))))
+ '())
(add-after 'unpack 'disable-failing-tests
(lambda _
;; tests/book-migration/test-migration.c:160:test_fetch_contacts:

base-commit: 12f02c9bb87b8ea756e5c09806522e6df8b7e1ca
prerequisite-patch-id: 0250f6d992ee74e81797cb1266771a825226fa0b
prerequisite-patch-id: e03a4f63a64eda0c1f229e0b92d130a9beadefa5
prerequisite-patch-id: 09e6b4e8c70f5eb7996f78194c59245f38d3241b
prerequisite-patch-id: a12882ccf5bbef1edbd1110f128cd107f84a1377
prerequisite-patch-id: 2c83a46f3bcf9d3e153e2543fe9a57e5f33af286
prerequisite-patch-id: 3c1ca4618ff254748694208007768994f8f3f180
prerequisite-patch-id: c6c55378dfbf74f5862c5b5609fe7cc3dc4b52d7
prerequisite-patch-id: 6307af77f1d5ccaef3accfce06479f604cdfd260
prerequisite-patch-id: 1f06621d95d4b22729a1461bca01feeb0d491324
prerequisite-patch-id: 2b5ca4e046c327f00c14fb9a0b7a08b6e4014bcb
prerequisite-patch-id: 7ebd64a45f6032d0fa2317d3b276cd93544ea187
prerequisite-patch-id: 6f659e1af6f034cd0f3541f605fa7c0f12845380
--
2.41.0
C
C
Christopher Baines wrote on 15 Apr 02:05 -0700
(name . Roman Scherer)(address . roman@burningswell.com)
87cyqr0zdy.fsf@cbaines.net
Roman Scherer <roman@burningswell.com> writes:

Toggle quote (11 lines)
> * gnu/packages/gnome.scm (evolution-data-server): Disable failing test on aarch64.
>
> Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
> ---
>
> Just after I fixed evolution-data-server-3.44, the evolution-data-server
> packages also started to fail. This test is flaky on my aarch64 machine.
>
> gnu/packages/gnome.scm | 6 ++++++
> 1 file changed, 6 insertions(+)

Could you include the bit about the test being flaky in a comment, and
maybe also some information about how it fails (so that others can see
if they get a similar failure)?

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYc7dlfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcYzQ/+Lsxcpfm9iUsk4Hr/EjACFzy+4p1sP7NY
yMvFcNnXMusvSxBQ9k6dVRMMjdZe0fuLAfHC3MHSPltmDDzCMIorQ4sDFnw/WE7M
u6z/S8SrokzNdV4zLZfdQmowzxvIupXK5owv9++Yg/kEXrs4B6FP+ICzvKg7Cp+s
F9n39GSu23UenIOlQXHNSYejmyQ1SIhjoX8iTs5N/YDq4lPlGhIpHtzojIY1RtOq
F8sMi0oJVUI2eAYhj4BW7zVdxSch133aArJ9IOnSjWQ0IkztQ4BnDvFHAUxdFeD+
TqBN9yJqsTf5IKiJSSfjGyCjQKc5HentRDYxsmEdvTN4y4DVoXwqKeGfrka/Og1n
DpHiGBhrvhrQmqWdv3ErKKbm295AIPryZpfHOiPmuicRRNpVKb5hIexRszOgiOGJ
eBsuOrOaR1F29rxpmTVrDnMSqABzdaeXqOJfhYO2g06Fy4wam2jPByxqSoURutD/
w25iz/MbMMMJNAiApk8agyg4AcIygi5Mk1fmC4bZHPi/q4HO9W4STCzhtia/z5BV
kLahwS7AmnjSWGExYf6Kx2ab5f8badUsa4GCMonFsASchoka4pq38K6iWcE8Q/oj
FXXg13YFB92kdCmCcYPD2O9QErkPTWCFRV6EmeuxbnA+nuSHWzepl/aPxc9lbKv2
v6jEK6swQlw=
=4z8D
-----END PGP SIGNATURE-----

R
R
Roman Scherer wrote on 15 Apr 10:43 -0700
(name . Christopher Baines)(address . mail@cbaines.net)
86v84imshw.fsf@burningswell.com
Christopher Baines <mail@cbaines.net> writes:

Hi Christopher,

thanks for looking into this. Building evolution-data-server fails on my
Apple M1. I attached a new patch that contains the build error message
in the commit.

Roman
Attachment: v3-0001-gnu-evolution-data-server-Disable-failing-test-on.patch
Toggle quote (20 lines)
> Roman Scherer <roman@burningswell.com> writes:
>
>> * gnu/packages/gnome.scm (evolution-data-server): Disable failing test on aarch64.
>>
>> Change-Id: Iccb75f2144b773a8b94242aaee9e6acedaa3af0b
>> ---
>>
>> Just after I fixed evolution-data-server-3.44, the evolution-data-server
>> packages also started to fail. This test is flaky on my aarch64 machine.
>>
>> gnu/packages/gnome.scm | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
> Could you include the bit about the test being flaky in a comment, and
> maybe also some information about how it fails (so that others can see
> if they get a similar failure)?
>
> Thanks,
>
> Chris
-----BEGIN PGP SIGNATURE-----

iQFTBAEBCAA9FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmYdZzsfHHJvbWFuLnNj
aGVyZXJAYnVybmluZ3N3ZWxsLmNvbQAKCRA92lJSfSrBmcOjB/sEDr4XY14wtlX6
/UTcDbGQ3++viem8qXQ7cwMCDV17r2zNx1BpVVkQyHRe0jwLLvnjJX9QpI/dz2fz
2kDshTTXRwyub1ZauBq4E7hkXiaHHGYK7aYqZCBkgssKOntJXXZvs1bJV1oxLPAS
Lkr2vQr3hPQtoOE/NabPihGIW1NiLl/POpUm/eN8qn5kCHehdESwhUhjPuzwrK0T
MZn1+jHSTgoBK+6UqtEIxNn8pEFgMr4VPtkS2B53mr7IBma9UR7UNdBaqSfsV447
mwb/XbqNbinKhJMt78NPwjTgpqfs6cjWms/z3yzkapynoDtff0/yZ/PUAq5mmCf+
dALJy0MD
=IJEZ
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 17 Apr 10:11 -0700
(name . Roman Scherer)(address . roman.scherer@burningswell.com)
874jbzsymf.fsf@cbaines.net
Roman Scherer <roman.scherer@burningswell.com> writes:

Toggle quote (8 lines)
> Christopher Baines <mail@cbaines.net> writes:
>
> Hi Christopher,
>
> thanks for looking into this. Building evolution-data-server fails on my
> Apple M1. I attached a new patch that contains the build error message
> in the commit.

Thanks, I've pushed this to master as
77acd4b4aaecea72a7b5249f602eac8bea67880b.

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYgArhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfynA/9HtAd/pUAq5Mg87NXq8S3LTImqHg3W08o
D95QNvwHEmS7lDPXQgF0wHaMm7Z5dJgtORF+LDK1HFXr+AwFQjuIZ0P4VRYdcleQ
qTLHYvDgECsl/hq/mrTQgDfdsnv6zA36hpmzZj80jbYUhC26i1tSW49rRmZuA3II
5sjVXxMgJOcvUJsQEdNlbu9DtSXEmrvbASt1enDAVTtrUSuFLU/ZJUom8pdYnNFY
1JXyRjqfgnhNW9NeLsNosziGYqSWIeIEhuO1YSF+lh82Zc4ioI2NFjOlk402bxsN
PlQNFDuuuYRlDO+JkdvJmOqj2bCLe/TN4kNVKxrNbi6OHN1s05r3X4YjC+R818KB
2Xt9oNjSOMfRfXU5Krd2LLif4e3T2VYLbltJ06PxdXZhklJe4RI5XuheBrrsH4lN
vM/oViuRFoyjuwkXFNFCry1G7qtt95AS0+W8fjkZZEt/+MLEW/0oJLP98OV/0fLW
qKtXDKgjSa9h0h52CU+cvJ2eKA1SXsyQlTVRM9STvHth8emfARX3PapEFhqzoo77
BXBOLoxERTIeO+AExxo4C4CgaaeM9t1JheIVfAweWXMHcu8vflRyy/+4raQJnaST
ump/0Xsib3Yd4idpJnGHAWafsEXcwL6HumrRv4wrzpXcqAyUuy2wXPdh94Iy7HzM
fQDcF/VMuco=
=dMEJ
-----END PGP SIGNATURE-----

Closed
M
M
Maxim Cournoyer wrote on 18 Apr 18:53 -0700
(name . Roman Scherer)(address . roman.scherer@burningswell.com)
87v84em832.fsf@gmail.com
Hi Roman,

Roman Scherer <roman.scherer@burningswell.com> writes:

Toggle quote (8 lines)
> Christopher Baines <mail@cbaines.net> writes:
>
> Hi Christopher,
>
> thanks for looking into this. Building evolution-data-server fails on my
> Apple M1. I attached a new patch that contains the build error message
> in the commit.

Also, a nitpick to mind for the future: it'd be even nicer to have a
link to the upstream issue registered for this problem, so that it
eventually gets fixed and can be removed on our side.

--
Thanks,
Maxim
?
Your comment

This issue is archived.

To comment on this conversation send an email to 70259@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70259
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch