[PATCH] gnu: babl: Disable failing test on aarch64.

  • Done
  • quality assurance status badge
Details
3 participants
  • Christopher Baines
  • Roman Scherer
  • Roman Scherer
Owner
unassigned
Submitted by
Roman Scherer
Severity
normal

Debbugs page

R
R
Roman Scherer wrote on 7 Apr 05:17 -0700
(address . guix-patches@gnu.org)(name . Roman Scherer)(address . roman@burningswell.com)
bee23551bc8c55d0980ad71449fa65bf9076af44.1712491898.git.roman@burningswell.com
* gnu/packages/gimp.scm (babl): Disable failing test on aarch64.

Change-Id: Icf2c2a9ea5986149902f741f96d1847d2403c1f4
---
gnu/packages/gimp.scm | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

Toggle diff (39 lines)
diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index b458a6397c..bcc18ad3cf 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -193,8 +193,16 @@ (define-public babl
"0x8lxvnhfpssj84x47y3y06vsvhd5afb9jknw38c8ymbxafzxpi6"))))
(build-system meson-build-system)
(arguments
- `(#:configure-flags
- (list "-Dwith-docs=false")))
+ (list
+ #:configure-flags #~(list "-Dwith-docs=false")
+ #:phases
+ #~(modify-phases %standard-phases
+ #$@(if (target-aarch64?)
+ #~((add-after 'unpack 'disable-failing-test
+ (lambda _
+ (substitute* "tests/meson.build"
+ (("'float-to-8bit',") "")))))
+ '()))))
(native-inputs
(list gobject-introspection pkg-config vala))
(propagated-inputs

base-commit: 12f02c9bb87b8ea756e5c09806522e6df8b7e1ca
prerequisite-patch-id: 0250f6d992ee74e81797cb1266771a825226fa0b
prerequisite-patch-id: e03a4f63a64eda0c1f229e0b92d130a9beadefa5
prerequisite-patch-id: 09e6b4e8c70f5eb7996f78194c59245f38d3241b
prerequisite-patch-id: a12882ccf5bbef1edbd1110f128cd107f84a1377
prerequisite-patch-id: 2c83a46f3bcf9d3e153e2543fe9a57e5f33af286
prerequisite-patch-id: 3c1ca4618ff254748694208007768994f8f3f180
prerequisite-patch-id: c6c55378dfbf74f5862c5b5609fe7cc3dc4b52d7
prerequisite-patch-id: 6307af77f1d5ccaef3accfce06479f604cdfd260
prerequisite-patch-id: 1f06621d95d4b22729a1461bca01feeb0d491324
prerequisite-patch-id: 2b5ca4e046c327f00c14fb9a0b7a08b6e4014bcb
prerequisite-patch-id: 8d0e6879dd97e7a2183b915bbd1ca588d968aec0
prerequisite-patch-id: 7ebd64a45f6032d0fa2317d3b276cd93544ea187
--
2.41.0
C
C
Christopher Baines wrote on 15 Apr 02:02 -0700
(name . Roman Scherer)(address . roman@burningswell.com)(address . 70257@debbugs.gnu.org)
87o7ab0zji.fsf@cbaines.net
Roman Scherer <roman@burningswell.com> writes:

Toggle quote (7 lines)
> * gnu/packages/gimp.scm (babl): Disable failing test on aarch64.
>
> Change-Id: Icf2c2a9ea5986149902f741f96d1847d2403c1f4
> ---
> gnu/packages/gimp.scm | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)

QA doesn't show any test failure being fixed.

Do you see this happening just some of the time, or only in some
situations? Also, can you include more information in the commit/a
comment about the specific failure?

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYc7RFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdOdg/+MIaG2OWKF1G3LMfNBlruaYaP0eyIZK5+
VGGOxYoDyhXJslNSudtwQ3LhOUBdQTJfbXJCrfhA73jF7NUfEsCV0tpF3C4AG25A
r+7xnXScXNGRvP7xID7umIPmQFkHR3BOWdE7AzxkEnon3a7i/DQxuJyRr6k7OYcd
381p/1behSW74UM0PQTns15QFFDlTZtcU1tiOrNCx2Vvmud6nMpQLLLtIIEFfyhc
RVzZRXXCa7w7sJTACL7UyfW2soMsKgxl1L2Bju4+/tHJE1CNNHchpBgcllEOAXw6
HNqtUT/z7aJDPrIDL1nRymbP/BCx/Hx9QTVhu/kw/YW/WkF7UuDA/ffgKokWIw2k
TqQ1g+in11c6uixTGzdC0NozVKELfEIMP2xKZ8ydj7+x5i3lNPonlnETYh65cbYl
kkLZ0Y1chR7HL2B767q+1Nsr47fIrANbluLZPYiWk/SgzieWOGv7bVCKiGGbMd0z
SV1tzEFYNc5SenG3NjvK42GJOyvcdmr7ickpRRh/8gTQM4qCIgaTbbGVz3jz2ROW
tYjzd1g20w15eoM8VZ5iviakCAMmUu2qlRqSH7TJRxIKpUoz/bYvhk5X/G4NJjAg
KppLHr2WWi4q9Laoci3S5soubQyqNzl/mkTkM1lno81X92AdXP35KjGxXi40QFpR
F7rjVdc16mc=
=OBQA
-----END PGP SIGNATURE-----

R
R
Roman Scherer wrote on 15 Apr 10:46 -0700
(name . Christopher Baines)(address . mail@cbaines.net)
86pluqmsd7.fsf@burningswell.com
Hi Christopher,

thanks for looking into this. Building babl fails on my Apple M1. I
attached a new patch that contains the build error message in the
commit.

Roman
From 8f4903b08d792eb6948685073df1c1e1c6fa1ade Mon Sep 17 00:00:00 2001
Message-ID: <8f4903b08d792eb6948685073df1c1e1c6fa1ade.1713203117.git.roman@burningswell.com>
From: Roman Scherer <roman@burningswell.com>
Date: Sun, 7 Apr 2024 14:05:39 +0200
Subject: [PATCH v2] gnu: babl: Disable failing test on aarch64.

* gnu/packages/gimp.scm (babl): Disable failing test on aarch64.

Change-Id: Icf2c2a9ea5986149902f741f96d1847d2403c1f4

---

The float-to-8bit test fails on an Apple M1 (aarch64) with the following message:

9/28 float-to-8bit FAIL 0.11s exit status 1
Toggle quote (1 lines)
>>> LD_LIBRARY_PATH=/tmp/guix-build-babl-0.1.108.drv-0/build/babl BABL_PATH=/tmp/guix-build-babl-0.1.108.drv-0/build/extensions MALLOC_PERTURB_=94 /tmp/guix-build-babl-0.1.108.drv-0/build/tests/float-to-8bit
????????????????????????????????????? ? ?????????????????????????????????????
stdout:
float -> u8 1 failed #1[1] got 76 expected 77
stderr:
" 0x43b9f0 0x4390b0 1" 1541377792 BablFishPath
cost:146.000000 error:0.000000000000
"/tmp/guix-build-babl-0.1.108.drv-0/build/extensions/gggl.so 0: R'G'B'A float to R'G'B'A u8" 0 BablConversionLinear
pixels:0
error: 0.000000
??????????????????????????????????????????????????????????????????????????????
---
gnu/packages/gimp.scm | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

Toggle diff (38 lines)
diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index b458a6397c..bcc18ad3cf 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -193,8 +193,16 @@ (define-public babl
"0x8lxvnhfpssj84x47y3y06vsvhd5afb9jknw38c8ymbxafzxpi6"))))
(build-system meson-build-system)
(arguments
- `(#:configure-flags
- (list "-Dwith-docs=false")))
+ (list
+ #:configure-flags #~(list "-Dwith-docs=false")
+ #:phases
+ #~(modify-phases %standard-phases
+ #$@(if (target-aarch64?)
+ #~((add-after 'unpack 'disable-failing-test
+ (lambda _
+ (substitute* "tests/meson.build"
+ (("'float-to-8bit',") "")))))
+ '()))))
(native-inputs
(list gobject-introspection pkg-config vala))
(propagated-inputs

base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293
prerequisite-patch-id: 0250f6d992ee74e81797cb1266771a825226fa0b
prerequisite-patch-id: e03a4f63a64eda0c1f229e0b92d130a9beadefa5
prerequisite-patch-id: 09e6b4e8c70f5eb7996f78194c59245f38d3241b
prerequisite-patch-id: a12882ccf5bbef1edbd1110f128cd107f84a1377
prerequisite-patch-id: 2c83a46f3bcf9d3e153e2543fe9a57e5f33af286
prerequisite-patch-id: 3c1ca4618ff254748694208007768994f8f3f180
prerequisite-patch-id: c6c55378dfbf74f5862c5b5609fe7cc3dc4b52d7
prerequisite-patch-id: 6307af77f1d5ccaef3accfce06479f604cdfd260
prerequisite-patch-id: 1f06621d95d4b22729a1461bca01feeb0d491324
prerequisite-patch-id: 2b5ca4e046c327f00c14fb9a0b7a08b6e4014bcb
prerequisite-patch-id: 7ebd64a45f6032d0fa2317d3b276cd93544ea187
--
2.41.0
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (18 lines)
> Roman Scherer <roman@burningswell.com> writes:
>
>> * gnu/packages/gimp.scm (babl): Disable failing test on aarch64.
>>
>> Change-Id: Icf2c2a9ea5986149902f741f96d1847d2403c1f4
>> ---
>> gnu/packages/gimp.scm | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> QA doesn't show any test failure being fixed.
>
> Do you see this happening just some of the time, or only in some
> situations? Also, can you include more information in the commit/a
> comment about the specific failure?
>
> Thanks,
>
> Chris
-----BEGIN PGP SIGNATURE-----

iQFTBAEBCAA9FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmYdZ+QfHHJvbWFuLnNj
aGVyZXJAYnVybmluZ3N3ZWxsLmNvbQAKCRA92lJSfSrBmU1ZCAC1tNgHWzzEooZO
6FSjyNyOGHXN+sq61JkWyc9foYbIPAZ8hNARdfYNTDwD9dQrjmto/pEc54wiWflk
M5q1VG/ofRGKccXtofgyROPOH5PHS7wMMG5C/rgkbsVSpQRPD1gaef0Aam6xqiSp
7opmOXu+0nIk+g67uMzykM9JT6jTkv63jpQOqAQi2nyqeWgmIEkFABTHNCcPs/K9
iMQn7ROJI7he6A7ms0S2jVq9IM3uQ4jUhP7FQZofVgKbNgmh5yAoaLU7JFZBL6B1
NYpjl25x+33Pkd6LwdLnvmJNpIFeGZ9o57QGcOmFDUHdBn0fww3q5tARtmlMqsYn
SlsvqpYe
=PPo+
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 17 Apr 10:10 -0700
(name . Roman Scherer)(address . roman.scherer@burningswell.com)
87a5lrsyn7.fsf@cbaines.net
Roman Scherer <roman.scherer@burningswell.com> writes:

Toggle quote (6 lines)
> Hi Christopher,
>
> thanks for looking into this. Building babl fails on my Apple M1. I
> attached a new patch that contains the build error message in the
> commit.

Thanks, I've pushed this to master as
e1fefe84aa73d6d48ab43f7c613c7bc6d14d082f.

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYgApxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xcy9w//fmCS2I0wq7X9RETNqsTFu612oOnbNrsJ
TxWuAKr2zU8tC5OaoU9tpLZkHQx8wAKLkgLIXGKrkZ1UM1OvIiryaZIcU61nO9bZ
MVf9Dc25wamfaEmMZaph6Bx26S8u0DvU7Xk+eX8gnxhSHV/DSxtj7BmZNMsP3NMx
Llh5dt7X9ayR9VTD+d5pnVrbigR0mhq9L41tHBXzoZ0Zm4DvzDx9o6uPNRDYcLv0
80Fc0kOG7jO7EQcMuxnEwrJMJZ9ydWLQit5Lf/IkylDuvI6MsitzLLGakqRoQN6S
XU0bHWmNiUWHnJ0riWcYH9GkBOKfe2RjRx8Yuqa4/p8cLycsrURLBcCUblZ1SnKa
Qop4onbxUJdX18i6lImYStbLMnzJXYdtXWfAAQjNJr5Dee056YDXOoHlSGd0NCJQ
PJOOnCi0EdbujKz2UpwzfmpQScnD5pLVkdwjE7B98pZIN0heMd8rWbeJE70o0IWg
rWrGcZvoEuI3TRQXx7iH/oknnN9G2Pqx+C8Vhhgn7PeCqirxCMUsDtjk1EoTebZk
ATt94vyGkeWOVCHsKbvJzVcyudi0GkH2LYt4TGYLdyWx+mChPiHqigR0xGWfRUN1
/59DgjbdjGHY5NOe2CkOZmevVhNMjmp2yUzBahWzhlYIKdy1HID+5V+Tc0kso8QU
00Fz6aL3rSg=
=tqAy
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 70257@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70257
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch