[PATCH] Update emacs-lsp-mode to 9.0.0

  • Done
  • quality assurance status badge
Details
3 participants
  • Apoorv
  • Dale Mellor
  • Nicolas Goaziou
Owner
Somebody
Submitted by
Apoorv
Severity
normal

Debbugs page

A
A
Apoorv wrote on 5 Apr 23:49 -0700
(name . Guix Patches)(address . guix-patches@gnu.org)
Num9s9x-0--9@tuta.io
lsp-mode got a update recently https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0,which fixes this issue  that I was facing. So I am sharing a patch for the update.

--
Sent with Tuta; enjoy secure & ad-free emails:
Attachment: file
From 58b41a21ec3c6e3a09e869183141c17ba83c69d5 Mon Sep 17 00:00:00 2001
From: apoorv569 <apoorvs569@gmail.com>
Date: Sat, 6 Apr 2024 11:56:52 +0530
Subject: [PATCH] Update emacs-lsp-mode to 9.0.0

---
gnu/packages/emacs-xyz.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (29 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 864889b51f..f5c169b60d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30677,11 +30677,11 @@ (define-public emacs-dockerfile-mode
(license license:asl2.0)))
(define-public emacs-lsp-mode
- (let ((commit "26c4d3e54ad2956623e64132312fe864274d346f")
+ (let ((commit "0f85b3854de0b1f54fbbbdbd542fb2fe72d1dbe6")
(revision "1"))
(package
(name "emacs-lsp-mode")
- (version (git-version "8.0.1" revision commit))
+ (version (git-version "9.0.0" revision commit))
(source
(origin
(method git-fetch)
@@ -30690,7 +30690,7 @@ (define-public emacs-lsp-mode
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "0klnik69b5y6s2q00vyshxymlg7k4x9x6m7wpsf7z9w12qn27alx"))))
+ (base32 "1njf76b67n7pqihfyj6749ib8p885wfmjkxj2ilsvqhd2xkzk95q"))))
(build-system emacs-build-system)
(arguments
`(#:emacs ,emacs ;need libxml support
--
2.41.0
D
D
Dale Mellor wrote on 6 Apr 02:32 -0700
Own 70233
(name . control)(address . control@debbugs.gnu.org)
8df43b4be16d39e218516a11eb9a6f7d984791b0.camel@rdmp.org
owner 70233 !
user guix
usertag 70233 + under-review
quit
D
D
Dale Mellor wrote on 6 Apr 03:12 -0700
[PATCH v2] Update emacs-lsp-mode to 9.0.0
(address . 70233@debbugs.gnu.org)
20240406101215.761857-1-guix-devel-0brg6b@rdmp.org
From: Apoorv <apoorvs@tuta.io>

lsp-mode got an update recently
that I was facing.

* gnu/packages/emacs-xyz.scm[emacs-lsp-mode]: update upstream data

Review:
* minimal change to refer to new upstream version
* license is correct (unchanged)
* reason for change is unclear, but updating to a new major version seems
like a good idea!
* guix lint is clean
* installed, tested with rust-analyzer LSP

Reviewed-by: Dale Mellor <guix-devel-0brg6b@rdmp.org>
---
gnu/packages/emacs-xyz.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (29 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e460fccc5b..db2dd41e52 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30677,11 +30677,11 @@ (define-public emacs-dockerfile-mode
(license license:asl2.0)))
(define-public emacs-lsp-mode
- (let ((commit "26c4d3e54ad2956623e64132312fe864274d346f")
+ (let ((commit "0f85b3854de0b1f54fbbbdbd542fb2fe72d1dbe6")
(revision "1"))
(package
(name "emacs-lsp-mode")
- (version (git-version "8.0.1" revision commit))
+ (version (git-version "9.0.0" revision commit))
(source
(origin
(method git-fetch)
@@ -30690,7 +30690,7 @@ (define-public emacs-lsp-mode
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "0klnik69b5y6s2q00vyshxymlg7k4x9x6m7wpsf7z9w12qn27alx"))))
+ (base32 "1njf76b67n7pqihfyj6749ib8p885wfmjkxj2ilsvqhd2xkzk95q"))))
(build-system emacs-build-system)
(arguments
`(#:emacs ,emacs ;need libxml support
--
2.41.0
N
N
Nicolas Goaziou wrote on 6 Apr 08:10 -0700
Re: [bug#70233] [PATCH] Update emacs-lsp-mode to 9.0.0
(name . Apoorv via Guix-patches via)(address . guix-patches@gnu.org)
877cha7civ.fsf@nicolasgoaziou.fr
Hello,

Apoorv via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (4 lines)
> lsp-mode got a update recently
> https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0, which fixes
> this issue  that I was facing. So I am sharing a patch for the update.

Thank you.

I used the "9.0.0" tag instead of a random commit hash, and normalized
commit message.

Applied!

Regards,
--
Nicolas Goaziou
?
Your comment

This issue is archived.

To comment on this conversation send an email to 70233@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70233
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch