[PATCH] gnu: gtk: Fix tests on aarch64.

  • Done
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Leo Nikkilä
Owner
unassigned
Submitted by
Leo Nikkilä
Severity
normal

Debbugs page

L
L
Leo Nikkilä wrote on 30 Mar 20:14 -0700
(address . guix-patches@gnu.org)(name . Leo Nikkilä)(address . hello@lnikki.la)
20240331031704.1604-1-hello@lnikki.la
GTK tests are currently failing on aarch64 with:

36/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing / gl big-checkerboard-scaled-down2 FAIL 0.37s exit status 1
37/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-flipped-gl / gl big-checkerboard-scaled-down2 flipped FAIL 0.32s exit status 1
38/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-repeated-gl / gl big-checkerboard-scaled-down2 repeated FAIL 0.25s exit status 1
39/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-rotated-gl / gl big-checkerboard-scaled-down2 rotated FAIL 0.32s exit status 1
40/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-masked-gl / gl big-checkerboard-scaled-down2 masked FAIL 0.26s exit status 1

Seems other distributions like Debian have disabled these tests due to
similar issues, although I'm unsure why they're also failing with the
X11 test setup.

* gnu/packages/gtk.scm (gtk)[arguments]<#:test-options>: Skip failing
tests like Debian.
---
gnu/packages/gtk.scm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 9252315fd2..da56834df6 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1157,7 +1157,12 @@ (define-public gtk
"--no-suite=failing"
"--no-suite=flaky"
"--no-suite=headless" ; requires mutter…
- "--no-suite=gsk-compare-broadway")
+ "--no-suite=gsk-compare-broadway"
+ ;; These seem to fail on aarch64, and Debian has
+ ;; also disabled these, see:
+ ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050075
+ "--no-suite=wayland_failing"
+ "--no-suite=wayland_gles_failing")
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'generate-gdk-pixbuf-loaders-cache-file
--
2.41.0
E
E
Efraim Flashner wrote on 2 Apr 11:17 -0700
(name . Leo Nikkilä)(address . hello@lnikki.la)(address . 70098-done@debbugs.gnu.org)
ZgxLrgaJLdf1K2as@3900XT
I had previously added a phase to manually skip those tests but I like
your way with the configure flag much better.

Thanks! Patch pushed (and my own reverted).

--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmYMS64ACgkQQarn3Mo9
g1HRHRAAjqrX/P+iv/CAoHf0Lb8FhxJap28jGzJDH3KUPvG780Cpi4nJJayOsCWW
supUi4l879/kgEj8IzqqgvqYxrOZ43C6KCsIiJZrDpyfVQ+QMGnuH71dduQ44Vll
XcxQSqxuEvf1L1Ha3Is7x+6FNVwlULYKITr+CxB/SO4xwRO7B84bzzUImrEhytNI
MH+yLJTKed3hYO2CDEb//sfVwcVljb4Y0gohDBh+o1tVkDPDDq+okFB2WIwpkx1B
aQS4WV0Ou+flcgKgzPFLjjxd64f5p6Ruc6bng3ibUd6JKSiNankVZWS4rV/lZdhz
8QNXp8ZbVI704ckdCMJkpDdxmFOQfutrgt5kTQetlFyTDl83mnCVKZiX2+E65v/p
pvUP43KuFVHaCacoXolxDXYovUw8gufkf4wqErxuueIigoJuO4Wd+m4yKw46Lagg
1q/YJvJ3RNRKVMu8BZsd9ckte1Qsa2H5sCkBDBvpmDPBGLQxyKsTIwzeKysUvFVj
aPZRdRMs1GvLbWS8O2XmpFUPxMRTCGUFag/90v84S8MUWTb1eaTbDQJl4uznqpye
KyOQmrbLBO6wkuJrn1kJViOCaka+Vski8EWqw+KjPrYaiVz8jWXe8Qn/V8T258Qs
w0rgvpGnG1mMSs9R4dpvFhF2H5thVLuAlN/VPy4H665szS4DNJM=
=YUgc
-----END PGP SIGNATURE-----


Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 70098@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70098
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch