[PATCH] gnu: python-pandera: Update to 0.18.0.

  • Done
  • quality assurance status badge
Details
3 participants
  • jgart
  • Troy Figiel
  • Vagrant Cascadian
Owner
unassigned
Submitted by
Troy Figiel
Severity
normal

Debbugs page

T
T
Troy Figiel wrote on 2 Mar 12:46 -0800
(address . guix-patches@gnu.org)
87wmqkpcuq.fsf@troyfigiel.com
* gnu/packages/python-science.scm (python-pandera): Update to 0.18.0.
[source]: Remove snippet.
[arguments]<#:phases>: Add 'fix-tests phase.
---
gnu/packages/python-science.scm | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)

Toggle diff (51 lines)
diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index b6a116f16b..93b5c5c91d 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -826,7 +826,7 @@ (define-public python-pandarallel
(define-public python-pandera
(package
(name "python-pandera")
- (version "0.17.2")
+ (version "0.18.0")
(source
(origin
;; No tests in the PyPI tarball.
@@ -836,14 +836,7 @@ (define-public python-pandera
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
- (base32 "1mnqk583z90k1n0z3lfa4rd0ng40v7hqfk7phz5gjmxlzfjbxa1x"))
- (modules '((guix build utils)))
- ;; These tests require PySpark and Modin. We need to remove the entire
- ;; directory, since the conftest.py in these directories contain
- ;; imports. (See: https://github.com/pytest-dev/pytest/issues/7452)
- (snippet '(begin
- (delete-file-recursively "tests/pyspark")
- (delete-file-recursively "tests/modin")))))
+ (base32 "14b5aij5zjkwvsimg0v00qvp59mhhq7ljim4qghcn432vkg9gh47"))))
(build-system pyproject-build-system)
(arguments
(list
@@ -854,7 +847,16 @@ (define-public python-pandera
;; positives. These tests currently fail.
"not test_python_std_list_dict_generics"
" and not test_python_std_list_dict_empty_and_none"
- " and not test_pandas_modules_importable"))))
+ " and not test_pandas_modules_importable"))
+ #:phases #~(modify-phases %standard-phases
+ (add-before 'check 'fix-tests
+ (lambda _
+ ;; These tests require PySpark and Modin. We need to
+ ;; remove the entire directory, since the conftest.py
+ ;; in these directories contain imports. (See:
+ ;; https://github.com/pytest-dev/pytest/issues/7452)
+ (for-each delete-file-recursively
+ '("tests/pyspark" "tests/modin")))))))
;; Pandera comes with a lot of extras. We test as many as possible, but do
;; not include all of them in the propagated-inputs. Currently, we have to
;; skip the pyspark and io tests due to missing packages python-pyspark

base-commit: 6f5ea7ac1acb3d1c53baf7620cca66cc87fe5a73
--
2.42.0
V
V
Vagrant Cascadian wrote on 8 Mar 22:44 -0800
87h6hfj44l.fsf@contorta
On 2024-03-02, Troy Figiel wrote:
Toggle quote (4 lines)
> diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
> index b6a116f16b..93b5c5c91d 100644
> --- a/gnu/packages/python-science.scm
> +++ b/gnu/packages/python-science.scm
...
Toggle quote (35 lines)
> @@ -836,14 +836,7 @@ (define-public python-pandera
> (commit (string-append "v" version))))
> (file-name (git-file-name name version))
> (sha256
> - (base32 "1mnqk583z90k1n0z3lfa4rd0ng40v7hqfk7phz5gjmxlzfjbxa1x"))
> - (modules '((guix build utils)))
> - ;; These tests require PySpark and Modin. We need to remove the entire
> - ;; directory, since the conftest.py in these directories contain
> - ;; imports. (See: https://github.com/pytest-dev/pytest/issues/7452)
> - (snippet '(begin
> - (delete-file-recursively "tests/pyspark")
> - (delete-file-recursively "tests/modin")))))
> + (base32 "14b5aij5zjkwvsimg0v00qvp59mhhq7ljim4qghcn432vkg9gh47"))))
> (build-system pyproject-build-system)
> (arguments
> (list
> @@ -854,7 +847,16 @@ (define-public python-pandera
> ;; positives. These tests currently fail.
> "not test_python_std_list_dict_generics"
> " and not test_python_std_list_dict_empty_and_none"
> - " and not test_pandas_modules_importable"))))
> + " and not test_pandas_modules_importable"))
> + #:phases #~(modify-phases %standard-phases
> + (add-before 'check 'fix-tests
> + (lambda _
> + ;; These tests require PySpark and Modin. We need to
> + ;; remove the entire directory, since the conftest.py
> + ;; in these directories contain imports. (See:
> + ;; https://github.com/pytest-dev/pytest/issues/7452)
> + (for-each delete-file-recursively
> + '("tests/pyspark" "tests/modin")))))))
> ;; Pandera comes with a lot of extras. We test as many as possible, but do
> ;; not include all of them in the propagated-inputs. Currently, we have to
> ;; skip the pyspark and io tests due to missing packages python-pyspark

Any compelling reason why the test removal should be moved from a
snippet to a phase? The documentation admits to this being an elusive
distinction, not really clearing things up much:


Other than that, this looks like a trivial version bump. :)

Builds fine, no dependents...

live well,
vagrant
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZewFWwAKCRDcUY/If5cW
qhfEAQDcdr/rd/ehzfICNmMDjlwyd0Y4veu2lY1z5kZK7jQnHAD/QwJ1DStTCZa6
aCvw3ArC0lkFP3n5bqQ3S3zXCc9JFgw=
=G6eK
-----END PGP SIGNATURE-----

T
T
Troy Figiel wrote on 9 Mar 00:50 -0800
c2052043-1928-46e5-acc1-2672513353b7@troyfigiel.com
Hi vagrant,

On 2024-03-09 07:44, Vagrant Cascadian wrote:
Toggle quote (5 lines)
> Any compelling reason why the test removal should be moved from a
> snippet to a phase? The documentation admits to this being an elusive
> distinction, not really clearing things up much:
>

I read the following as stating we should keep any source code that
could be used to build the package on different systems, including tests
that could be run on other systems:

Toggle snippet (5 lines)
The source derived from an origin should produce a source that can be
used to build the package on any system that the upstream package
supports (i.e., act as the corresponding source).

Other than that, no reason and either would be fine in my opinion. The
current documentation is more confusing rather than enlightening in this
case.

Best wishes,

Troy
J
J
jgart wrote on 24 Jun 13:03 -0700
Re: [PATCH] gnu: python-pandera: Update to 0.18.0.
69e0593c3d4bd451ff6e15ce4ddcc71b52772564@dismail.de
Hi Troy,

Thanks for your work on this.

Can you send an updated patch and I'll take another look?

This patch no longer applies cleanly.

all best,

jgart

https://whereis.みんな/
T
T
Troy Figiel wrote on 24 Jun 14:58 -0700
cd8d3b34cfe28292368d46651e74cd5bee1ced85.camel@troyfigiel.com
Hi jgart,

Sorry, life got in the way. I will pull in the latest Guix master,
rebase and see if python-pandera still builds.

Best wishes,

Troy
T
T
Troy Figiel wrote on 24 Jun 15:09 -0700
Re: [bug#69514] [PATCH] gnu: python-pandera: Update to 0.18.0.
bede479f104be27851de21fdde802e71590567a6.camel@troyfigiel.com
Well, these are the nicest issues to solve :-) It seems python-pandera
was already bumped to 0.18.0 by commit
da9eed295c8737b8563a3472d7a82b34270d181b. We can close this issue.
J
J
jgart wrote on 24 Jun 16:11 -0700
64222bdb807616cf666da12c4841b1d3dc2f2830@dismail.de
Thanks for the notice. Ok, closing this issue.

all best,

jgart
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 69514@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 69514
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch