[PATCH] gnu: elfutils: Move inputs to propagated-inputs.

  • Done
  • quality assurance status badge
Details
3 participants
  • Maxim Cournoyer
  • odion
  • Olivier Dion
Owner
unassigned
Submitted by
Olivier Dion
Severity
normal

Debbugs page

O
O
Olivier Dion wrote on 25 Jan 12:00 -0800
(address . guix-patches@gnu.org)(name . Olivier Dion)(address . olivier.dion@polymtl.ca)
d3fff9672d86c34e060f2495b4e29643e09301e1.1706212816.git.olivier.dion@polymtl.ca
zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
and zlib packages must be propagated for pkg-config to work on libdw and
libelf.

* gnu/packages/elf.scm (elfutils): Move packages ...
[inputs]: ... from here ...
[propagated-inputs]: ... to here.

Change-Id: Ic89d226b2392fe821b207302d3b386f9633b981a
---
gnu/packages/elf.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm
index a100038f14..b760f1b339 100644
--- a/gnu/packages/elf.scm
+++ b/gnu/packages/elf.scm
@@ -138,7 +138,7 @@ (define-public elfutils
'()))))
(native-inputs (list m4))
- (inputs (list xz zlib))
+ (propagated-inputs (list xz zlib))
(home-page "https://sourceware.org/elfutils/")
(synopsis "Collection of utilities and libraries to handle ELF files and
DWARF data")

base-commit: ed7eb108e5ba38135db99aa3b162f88797c372f9
--
2.41.0
M
M
Maxim Cournoyer wrote on 30 May 06:47 -0700
(name . Olivier Dion)(address . olivier.dion@polymtl.ca)(address . 68718@debbugs.gnu.org)
874jafe7j3.fsf@gmail.com
Hi,

Olivier Dion <olivier.dion@polymtl.ca> writes:

Toggle quote (5 lines)
> zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
> Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
> and zlib packages must be propagated for pkg-config to work on libdw and
> libelf.

Could you please mention the above in a comment above the
propagated-inputs field (in code)?

--
Thanks,
Maxim
M
M
Maxim Cournoyer wrote on 30 May 06:47 -0700
control message for bug #68718
(address . control@debbugs.gnu.org)
8734pze7ix.fsf@gmail.com
tags 68718 + moreinfo
quit
O
O
odion wrote on 30 May 09:09 -0700
[PATCH v2] gnu: elfutils: Move inputs to propagated-inputs.
(address . 68718@debbugs.gnu.org)
ef3fb5da37a548d196be711273498929b3ee91f0.1717085316.git.olivier.dion@polymtl.ca
From: Olivier Dion <olivier.dion@polymtl.ca>

zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
and zlib packages must be propagated for pkg-config to work on libdw and
libelf.

* gnu/packages/elf.scm (elfutils): Move packages ...
[inputs]: ... from here ...
[propagated-inputs]: ... to here.

Change-Id: Ic89d226b2392fe821b207302d3b386f9633b981a
---
gnu/packages/elf.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Toggle diff (21 lines)
diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm
index a100038f14..484f8dfc2c 100644
--- a/gnu/packages/elf.scm
+++ b/gnu/packages/elf.scm
@@ -138,7 +138,11 @@ (define-public elfutils
'()))))
(native-inputs (list m4))
- (inputs (list xz zlib))
+ ;; zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
+ ;; Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the
+ ;; xz and zlib packages must be propagated for pkg-config to work on libdw
+ ;; and libelf.
+ (propagated-inputs (list xz zlib))
(home-page "https://sourceware.org/elfutils/")
(synopsis "Collection of utilities and libraries to handle ELF files and
DWARF data")

base-commit: c2cb630061d937e26bcbd5ae7962f692f640a4ee
--
2.41.0
M
M
Maxim Cournoyer wrote on 30 May 20:13 -0700
(address . odion@efficios.com)
87ttied66m.fsf@gmail.com
Hi,

odion@efficios.com writes:

Toggle quote (11 lines)
> From: Olivier Dion <olivier.dion@polymtl.ca>
>
> zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
> Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
> and zlib packages must be propagated for pkg-config to work on libdw and
> libelf.
>
> * gnu/packages/elf.scm (elfutils): Move packages ...
> [inputs]: ... from here ...
> [propagated-inputs]: ... to here.

I've reworded the GNU ChangeLog part like:

* gnu/packages/elf.scm (elfutils)
[inputs]: Turn into...
[propagated-inputs]: ... this field.

Toggle quote (20 lines)
> Change-Id: Ic89d226b2392fe821b207302d3b386f9633b981a
> ---
> gnu/packages/elf.scm | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm
> index a100038f14..484f8dfc2c 100644
> --- a/gnu/packages/elf.scm
> +++ b/gnu/packages/elf.scm
> @@ -138,7 +138,11 @@ (define-public elfutils
> '()))))
>
> (native-inputs (list m4))
> - (inputs (list xz zlib))
> + ;; zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
> + ;; Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the
> + ;; xz and zlib packages must be propagated for pkg-config to work on libdw
> + ;; and libelf.
> + (propagated-inputs (list xz zlib))

And simplified this to:

(propagated-inputs (list xz zlib)) ;in Requires of libdw.pc, libelf.pc

and...

Actually, these are in 'Requires.private', which ought to be only useful
for static compilation (though these would be consulted for Cflags since
there's no Cflags.private in pkg-config).

pkgconf handles this better than pkg-config, letting you do without
propagation here, as long as the libs are found in a standard include
path and you are building a shared library.

I think with the planned switch to pkgconf, we probably should avoid
propagation here unless really necessary; do you have a failing example
at hand?

--
Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 68718@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 68718
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch