[PATCH] etc: gitconfig: Run etc/teams.scm from correct environment.

etc/teams.scm script so that any user that have git:send-email installed can

use it in the Guix checkout without changing their environment.

---

etc/git/gitconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

Clément Lassieur <clement@lassieur.org> writes:

I'm not sure I understand; why does etc/teams.scm cc-members-header-cmd

fail in an environment where git:send-email is available?

--

Thanks,

Maxim

tags 66605 + moreinfo

quit

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

Because it requires (git) and (guix ui). So you need ./pre-inst-env for

(guix ui), plus guile, guile-git and guile-gcrypt. The minimal setup

would be:

`guix shell guile guile-git guile-gcrypt git git:send-email --pure -- ./pre-inst-env git send-email`

or

`guix shell guile guile-git guile-gcrypt -- ./pre-inst-env git send-email`

with an impure environment containing git and git:send-email.

But it could be shortened as

`guix shell git:send-email -D guix --pure -- ./pre-inst-env git send-email`

However, in this case `guix shell git:send-email` is necessary even with

impure environments containing git and git:send-email because `-D guix`

pulls git without pulling git:send-email.

Thanks,

Clément

any user that has git:send-email installed can use it in the Guix checkout

without changing their environment. (teams.scm uses (git) and (guix ui).)

---

etc/git/gitconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

Clément Lassieur <clement@lassieur.org> writes:

I had noticed as well that since Guix depends on 'git', we now have to

include git:send-email to the profile to be able to use it, like:

'guix shell -D guix git:send-email'.

I think on foreign distributions, you also need to use mumi or git

send-email in ./pre-inst-env, which is what your patch solves, I

believe. This is not needed on a Guix System because the guix-daemon

used by it adds the Guix modules to the GUILE_LOAD_PATH.

--

Thanks,

Maxim

forcemerge 66605 66616

quit

forcemerge 66605 66617

quit

Hello,

Clément Lassieur <clement@lassieur.org> writes:

Even nicer could be using 'guix repl' in the teams.scm script shebang.

This way even for those using it outside of 'git send-email', it'd

always work.

--

Thanks,

Maxim

I can't find a nice solution to do that. And I think people who run teams.scm directly will expect a guile crash and make sure to get the correct environment, so it's not really a problem at that point.

This is not the case for people who run `git send-email`. Those people don't expect a guile crash.

So if you have a clean solution that works in a shebang (without the file being detected as a shell script by most editors), please show it :-)

This ensures the correct Guix dependencies are always available for the

script.

Fixes: https://issues.guix.gnu.org/66605

Change-Id: I7a01750c6c5f0696b6c36b1e6caa9389d9e6822c

---

.gitignore | 1 -

configure.ac | 1 -

etc/{teams.scm.in => teams.scm} | 8 ++++++--

3 files changed, 6 insertions(+), 4 deletions(-)

rename etc/{teams.scm.in => teams.scm} (99%)

mode change 100644 => 100755

This ensures the correct Guix dependencies are always available for the

script.

Fixes: https://issues.guix.gnu.org/66605

---

Changes in v5:

- Redirect command -v output to /dev/null

.gitignore | 1 -

configure.ac | 1 -

etc/{teams.scm.in => teams.scm} | 8 ++++++--

3 files changed, 6 insertions(+), 4 deletions(-)

rename etc/{teams.scm.in => teams.scm} (99%)

mode change 100644 => 100755

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

Sounds good to me! Of course, please commit it as your own.

Thank you very much,

Clément

Hi,

Clément Lassieur <clement@lassieur.org> writes:

Done! Thanks for the report!

--

Thanks,

Maxim