gnu: games: Update openrct2.

  • Open
  • quality assurance status badge
Details
3 participants
  • Daniel Trujillo Viedma
  • Liliana Marie Prikler
  • Christopher Baines
Owner
unassigned
Submitted by
Daniel Trujillo Viedma
Severity
normal

Debbugs page

D
D
Daniel Trujillo Viedma wrote on 23 Sep 2023 15:40
(address . guix-patches@gnu.org)
001037da-e7af-ef56-1440-e475277ac244@gmail.com
Hello! My name is Daniel, I'm a newbie in Guix.


This is my second patch (the first one didn't ended well:
aware that may be problems with it.


This patch updates openrct to a newer version, and fixes current issues
(I recall the title sequences weren't working before). This is a
considerable bump, and openrct2 builds have been splitted into some
extra packages (openmsx, opensfx, etc...) which are also included in the
patch.

Additionally moved openrct2 definition together with its extra packages
(openquest was defined between those and openrct2 itself).

The total size of the package is 727.0 MiB

I tried to contact the author of the patch adding openrct2 to Guix in
Rutger Helling, at rhelling@mykolab.com but I always get an "Address not
found" error.


Looking forward to hear from you all.

Cheers,

Dani.
D
D
Daniel Trujillo Viedma wrote on 23 Sep 2023 15:42
Re: bug#66172: Acknowledgement (gnu: games: Update openrct2.)
(address . 66172@debbugs.gnu.org)
dee7f3ed-8cbc-da0a-31f0-daceef6f8dcf@gmail.com
Of course, I forgot to attach the patch. Sorry for that...
Attachment: 0001-Update-openrct2.patch
L
L
Liliana Marie Prikler wrote on 24 Sep 2023 02:26
1fed343196c2abb76df14ef5bf2c7d7700e24c1b.camel@gmail.com
Am Sonntag, dem 24.09.2023 um 00:42 +0200 schrieb Daniel Trujillo
Viedma:

Toggle quote (3 lines)
> Subject: [PATCH] Update: openrct2
>
> ---
You're missing a ChangeLog for your changes. Please try to mimic the
general layout of the commits around (for more information see chapter
22, Contributing, in the Guix manual).

Toggle quote (8 lines)
> (description
> - "openrct2-title-sequences is a set of title sequences for
> OpenRCT2.")
> - (license license:gpl3+)))
> + "Contains the title sequence that is distributed with each
> release of
> +OpenRCT2.")
> + (license license:cc-by4.0)))
Descriptions should be complete sentences ("This package contains…").

Try not to move packages around as you edit them and in general, do one
commit for one package at a time. That is, first update title
sequences, then objects, …, then add the new packages, then update
openrct2 proper, and then if it's still needed move it to where you
want it to be in the file, all with separate commits.

Cheers
C
C
Christopher Baines wrote on 11 Oct 2023 03:25
tag 66172 moreinfo
(address . control@debbugs.gnu.org)
87h6mxjw1e.fsf@cbaines.net
tags 66172 + moreinfo
quit
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 66172@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 66172
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch