[PATCH 0/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.

  • Done
  • quality assurance status badge
Details
3 participants
  • Hilton Chain
  • Maxim Cournoyer
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Hilton Chain
Severity
normal

Debbugs page

H
H
Hilton Chain wrote on 3 Aug 2023 01:46
(address . guix-patches@gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
cover.1691046969.git.hako@ultrarare.space
Hello Guix!

This patchset updates go-google-golang-org-protobuf to 1.31.0 and
go-github-com-golang-protobuf-proto to 1.5.3 (latest versions), then renames
the latter to go-github-com-golang-protobuf.

Their dependency is changed from
go-google-golang-org-protobuf
-> go-github-com-golang-protobuf-proto
-> go-github-com-google-go-cmp-cmp
to
go-github-com-golang-protobuf
-> go-google-golang-org-protobuf
-> go-github-com-google-go-cmp-cmp

Since there's no Go file in their unpack-path, I have added builds and checks
for the Go packages described in the docs of these two Go modules.

I have built all affected packages reported by `guix refresh -l' for each
commit on my system (x86_64-linux).

Thanks

Hilton Chain (3):
gnu: go-google-golang-org-protobuf: Update to 1.31.0.
gnu: go-github-com-golang-protobuf-proto: Update to 1.5.3.
gnu: go-github-com-golang-protobuf-proto: Rename to go-github-com-golang-protobuf.

gnu/packages/golang.scm | 110 ++++++++++++++++++++++++++++++-------
gnu/packages/syncthing.scm | 4 +-
2 files changed, 91 insertions(+), 23 deletions(-)


base-commit: 23e2ff223c0511317edf236504fb474e3b5ac301
--
2.41.0
H
H
Hilton Chain wrote on 3 Aug 2023 01:47
[PATCH 1/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
fd53c7f9f6f5f22e25ca8f73f6e45bbaceee1144.1691046969.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-google-golang-org-protobuf): Update to 1.31.0.
[arguments]: Build Go packages and run tests.
[propagated-inputs]: Remove go-github-com-golang-protobuf-proto.
---
gnu/packages/golang.scm | 56 +++++++++++++++++++++++++++++++++++------
1 file changed, 48 insertions(+), 8 deletions(-)

Toggle diff (79 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index ea6aadbe80..51bc717064 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8433,7 +8433,7 @@ (define-public go-github-com-golang-protobuf-proto
(define-public go-google-golang-org-protobuf
(package
(name "go-google-golang-org-protobuf")
- (version "1.28.0")
+ (version "1.31.0")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -8442,16 +8442,56 @@ (define-public go-google-golang-org-protobuf
(file-name (git-file-name name version))
(sha256
(base32
- "1nzcc4qc00afi24nb7nlnwyzvvr6b8s8qdrn1sw085nygh2y2x8r"))))
+ "1xf18kzz96hgfy1vlbnydrizzpxkqj2iamfdbj3dx5a1zz5mi8n0"))))
(build-system go-build-system)
(arguments
(list #:import-path "google.golang.org/protobuf"
- #:tests? #f ; source-only package
- #:phases #~(modify-phases %standard-phases
- ;; source-only package
- (delete 'build))))
- (propagated-inputs (list go-github-com-google-go-cmp-cmp
- go-github-com-golang-protobuf-proto))
+ #:phases
+ #~(let ((go-packages '("proto"
+ "encoding/protojson"
+ "encoding/prototext"
+ "encoding/protowire"
+ "reflect/protoreflect"
+ "reflect/protoregistry"
+ "reflect/protodesc"
+ "reflect/protopath"
+ "reflect/protorange"
+ "testing/protocmp"
+ "testing/protopack"
+ "testing/prototest"
+ "types/dynamicpb"
+ "types/known/anypb"
+ "types/known/timestamppb"
+ "types/known/durationpb"
+ "types/known/wrapperspb"
+ "types/known/structpb"
+ "types/known/fieldmaskpb"
+ "types/known/apipb"
+ "types/known/typepb"
+ "types/known/sourcecontextpb"
+ "types/known/emptypb"
+ "types/descriptorpb"
+ "types/pluginpb"
+ "compiler/protogen"
+ "cmd/protoc-gen-go")))
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path build-flags #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'build)
+ #:import-path (format #f "~a/~a" import-path pkg)
+ #:build-flags build-flags))
+ go-packages)))
+ (replace 'check
+ (lambda* (#:key tests? import-path #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'check)
+ #:tests? tests?
+ #:import-path (format #f "~a/~a" import-path pkg)))
+ go-packages)))))))
+ (propagated-inputs (list go-github-com-google-go-cmp-cmp))
(home-page "https://google.golang.org/protobuf")
(synopsis "Go library for Protocol Buffers")
(description
--
2.41.0
H
H
Hilton Chain wrote on 3 Aug 2023 01:47
[PATCH 2/3] gnu: go-github-com-golang-protobuf-proto: Update to 1.5.3.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
11e7c41a7723c7ad219c627231300f94f1e86086.1691046970.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Update to
1.5.3.
[arguments]: Enable tests.
[propagated-inputs]: Add go-google-golang-org-protobuf.
---
gnu/packages/golang.scm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Toggle diff (33 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 51bc717064..25690f6665 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8408,7 +8408,7 @@ (define-public gotestsum
(define-public go-github-com-golang-protobuf-proto
(package
(name "go-github-com-golang-protobuf-proto")
- (version "1.3.1")
+ (version "1.5.3")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -8417,13 +8417,13 @@ (define-public go-github-com-golang-protobuf-proto
(file-name (git-file-name name version))
(sha256
(base32
- "15am4s4646qy6iv0g3kkqq52rzykqjhm4bf08dk0fy2r58knpsyl"))))
+ "03f1w2cd4s8a3xhl61x7yjx81kbzlrjpvnnwmbhqnz814yi7h43i"))))
(build-system go-build-system)
(arguments
'(#:import-path "github.com/golang/protobuf/proto"
- #:unpack-path "github.com/golang/protobuf"
- ;; Requires unpackaged golang.org/x/sync/errgroup
- #:tests? #f))
+ #:unpack-path "github.com/golang/protobuf"))
+ (propagated-inputs
+ (list go-google-golang-org-protobuf))
(synopsis "Go support for Protocol Buffers")
(description "This package provides Go support for the Protocol Buffers
data serialization format.")
--
2.41.0
H
H
Hilton Chain wrote on 3 Aug 2023 01:47
[PATCH 3/3] gnu: go-github-com-golang-protobuf-proto: Rename to go-github-com-golang-protobuf.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
fb29032b3f9dd80d37a3eefc6c422b1e47e0ca38.1691046970.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Rename to...
(go-github-com-golang-protobuf): ... this.
[import-path]: Use github.com/golang/protobuf.
[phases]: Build and check all packages.
(go-github-com-lucas-clemente-quic-go,go-github-com-prometheus-common)
(go-github-com-prometheus-client-golang,go-github-com-onsi-gomega)
[propagated-inputs]: Adjust accordingly.
* gnu/packages/syncthing.scm (go-github-com-prometheus-client-model)
(go-github-com-matttproud-golang-protobuf-extensions-pbutil)
[propagated-inputs]: Adjust accordingly.
---
gnu/packages/golang.scm | 46 ++++++++++++++++++++++++++++++--------
gnu/packages/syncthing.scm | 4 ++--
2 files changed, 39 insertions(+), 11 deletions(-)

Toggle diff (120 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 25690f6665..dcbc780f31 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -7608,7 +7608,7 @@ (define-public go-github-com-lucas-clemente-quic-go
(list go-golang-org-x-crypto go-github-com-cheekybits-genny
go-github-com-marten-seemann-chacha20
go-github-com-marten-seemann-qtls
- go-github-com-golang-protobuf-proto))
+ go-github-com-golang-protobuf))
(synopsis "QUIC in Go")
(description "This package provides a Go language implementation of the QUIC
network protocol.")
@@ -8405,9 +8405,9 @@ (define-public gotestsum
(home-page "https://github.com/gotestyourself/gotestsum")
(license license:asl2.0)))
-(define-public go-github-com-golang-protobuf-proto
+(define-public go-github-com-golang-protobuf
(package
- (name "go-github-com-golang-protobuf-proto")
+ (name "go-github-com-golang-protobuf")
(version "1.5.3")
(source (origin
(method git-fetch)
@@ -8420,8 +8420,37 @@ (define-public go-github-com-golang-protobuf-proto
"03f1w2cd4s8a3xhl61x7yjx81kbzlrjpvnnwmbhqnz814yi7h43i"))))
(build-system go-build-system)
(arguments
- '(#:import-path "github.com/golang/protobuf/proto"
- #:unpack-path "github.com/golang/protobuf"))
+ (list #:import-path "github.com/golang/protobuf"
+ #:phases
+ #~(let ((go-packages '("proto"
+ "jsonpb"
+ "ptypes"
+ "ptypes/any"
+ "ptypes/empty"
+ "ptypes/timestamp"
+ "ptypes/duration"
+ "ptypes/wrappers"
+ "ptypes/struct"
+ "protoc-gen-go/descriptor"
+ "protoc-gen-go/plugin"
+ "protoc-gen-go")))
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path build-flags #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'build)
+ #:import-path (format #f "~a/~a" import-path pkg)
+ #:build-flags build-flags))
+ go-packages)))
+ (replace 'check
+ (lambda* (#:key tests? import-path #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'check)
+ #:tests? tests?
+ #:import-path (format #f "~a/~a" import-path pkg)))
+ go-packages)))))))
(propagated-inputs
(list go-google-golang-org-protobuf))
(synopsis "Go support for Protocol Buffers")
@@ -10212,7 +10241,7 @@ (define-public go-github-com-prometheus-common
;; Source-only package
(delete 'build))))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto
+ (list go-github-com-golang-protobuf
go-github-com-matttproud-golang-protobuf-extensions-pbutil
go-github-com-prometheus-client-model))
(synopsis "Prometheus metrics")
@@ -10269,7 +10298,7 @@ (define-public go-github-com-prometheus-client-golang
(delete 'build))))
(propagated-inputs
(list go-github-com-beorn7-perks-quantile
- go-github-com-golang-protobuf-proto
+ go-github-com-golang-protobuf
go-github-com-prometheus-client-model
go-github-com-prometheus-common
go-github-com-prometheus-procfs
@@ -13452,11 +13481,10 @@ (define-public go-github-com-onsi-gomega
;; Unless we disable the tests, we have a circular dependency on
;; ginkgo/v2.
#:tests? #f))
- (propagated-inputs (list go-github-com-golang-protobuf-proto
+ (propagated-inputs (list go-github-com-golang-protobuf
go-golang-org-x-net
go-golang-org-x-sys
go-golang-org-x-text
- go-google-golang-org-protobuf
go-gopkg-in-yaml-v2))
(home-page "https://github.com/onsi/gomega")
(synopsis "Matcher library for Ginkgo")
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index dd54100ce6..99cb3acdc8 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -841,7 +841,7 @@ (define-public go-github-com-prometheus-client-model
;; Source-only package
(delete 'build))))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto))
+ (list go-github-com-golang-protobuf))
(synopsis "Data model artifacts for Prometheus")
(description "This package provides data model artifacts for Prometheus.")
(home-page "https://github.com/prometheus/client_model")
@@ -869,7 +869,7 @@ (define-public go-github-com-matttproud-golang-protobuf-extensions-pbutil
'(#:import-path "github.com/matttproud/golang_protobuf_extensions/pbutil"
#:unpack-path "github.com/matttproud/golang_protobuf_extensions"))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto))
+ (list go-github-com-golang-protobuf))
(synopsis "Streaming Protocol Buffers in Go")
(description "This package provides various Protocol Buffer
extensions for the Go language, namely support for record length-delimited
--
2.41.0
M
M
Maxim Cournoyer wrote on 5 Sep 2023 06:49
Re: bug#65034: [PATCH 0/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(name . Hilton Chain)(address . hako@ultrarare.space)(address . 65034@debbugs.gnu.org)
87v8cok9wh.fsf_-_@gmail.com
Hi Hilton,

Hilton Chain <hako@ultrarare.space> writes:

Toggle quote (81 lines)
> * gnu/packages/golang.scm (go-google-golang-org-protobuf): Update to 1.31.0.
> [arguments]: Build Go packages and run tests.
> [propagated-inputs]: Remove go-github-com-golang-protobuf-proto.
> ---
> gnu/packages/golang.scm | 56 +++++++++++++++++++++++++++++++++++------
> 1 file changed, 48 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index ea6aadbe80..51bc717064 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -8433,7 +8433,7 @@ (define-public go-github-com-golang-protobuf-proto
> (define-public go-google-golang-org-protobuf
> (package
> (name "go-google-golang-org-protobuf")
> - (version "1.28.0")
> + (version "1.31.0")
> (source (origin
> (method git-fetch)
> (uri (git-reference
> @@ -8442,16 +8442,56 @@ (define-public go-google-golang-org-protobuf
> (file-name (git-file-name name version))
> (sha256
> (base32
> - "1nzcc4qc00afi24nb7nlnwyzvvr6b8s8qdrn1sw085nygh2y2x8r"))))
> + "1xf18kzz96hgfy1vlbnydrizzpxkqj2iamfdbj3dx5a1zz5mi8n0"))))
> (build-system go-build-system)
> (arguments
> (list #:import-path "google.golang.org/protobuf"
> - #:tests? #f ; source-only package
> - #:phases #~(modify-phases %standard-phases
> - ;; source-only package
> - (delete 'build))))
> - (propagated-inputs (list go-github-com-google-go-cmp-cmp
> - go-github-com-golang-protobuf-proto))
> + #:phases
> + #~(let ((go-packages '("proto"
> + "encoding/protojson"
> + "encoding/prototext"
> + "encoding/protowire"
> + "reflect/protoreflect"
> + "reflect/protoregistry"
> + "reflect/protodesc"
> + "reflect/protopath"
> + "reflect/protorange"
> + "testing/protocmp"
> + "testing/protopack"
> + "testing/prototest"
> + "types/dynamicpb"
> + "types/known/anypb"
> + "types/known/timestamppb"
> + "types/known/durationpb"
> + "types/known/wrapperspb"
> + "types/known/structpb"
> + "types/known/fieldmaskpb"
> + "types/known/apipb"
> + "types/known/typepb"
> + "types/known/sourcecontextpb"
> + "types/known/emptypb"
> + "types/descriptorpb"
> + "types/pluginpb"
> + "compiler/protogen"
> + "cmd/protoc-gen-go")))
> + (modify-phases %standard-phases
> + (replace 'build
> + (lambda* (#:key import-path build-flags #:allow-other-keys)
> + (for-each
> + (lambda (pkg)
> + ((assoc-ref %standard-phases 'build)
> + #:import-path (format #f "~a/~a" import-path pkg)
> + #:build-flags build-flags))
> + go-packages)))
> + (replace 'check
> + (lambda* (#:key tests? import-path #:allow-other-keys)
> + (for-each
> + (lambda (pkg)
> + ((assoc-ref %standard-phases 'check)
> + #:tests? tests?
> + #:import-path (format #f "~a/~a" import-path pkg)))
> + go-packages)))))))

Is this a workaround for our lack of Go modules support? An explanatory
comment is needed.

--
Thanks,
Maxim
M
M
Maxim Cournoyer wrote on 5 Sep 2023 06:49
control message for bug #65034
(address . control@debbugs.gnu.org)
87tts8k9w1.fsf@gmail.com
tags 65034 + moreinfo
quit
H
H
Hilton Chain wrote on 23 Sep 2023 06:43
Re: bug#65034: [PATCH 0/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 65034@debbugs.gnu.org)
874jjlqa26.wl-hako@ultrarare.space
Hi Maxim,

On Tue, 05 Sep 2023 21:49:18 +0800,
Maxim Cournoyer wrote:
Toggle quote (1 lines)
>
[...]
Toggle quote (58 lines)
> > (arguments
> > (list #:import-path "google.golang.org/protobuf"
> > - #:tests? #f ; source-only package
> > - #:phases #~(modify-phases %standard-phases
> > - ;; source-only package
> > - (delete 'build))))
> > - (propagated-inputs (list go-github-com-google-go-cmp-cmp
> > - go-github-com-golang-protobuf-proto))
> > + #:phases
> > + #~(let ((go-packages '("proto"
> > + "encoding/protojson"
> > + "encoding/prototext"
> > + "encoding/protowire"
> > + "reflect/protoreflect"
> > + "reflect/protoregistry"
> > + "reflect/protodesc"
> > + "reflect/protopath"
> > + "reflect/protorange"
> > + "testing/protocmp"
> > + "testing/protopack"
> > + "testing/prototest"
> > + "types/dynamicpb"
> > + "types/known/anypb"
> > + "types/known/timestamppb"
> > + "types/known/durationpb"
> > + "types/known/wrapperspb"
> > + "types/known/structpb"
> > + "types/known/fieldmaskpb"
> > + "types/known/apipb"
> > + "types/known/typepb"
> > + "types/known/sourcecontextpb"
> > + "types/known/emptypb"
> > + "types/descriptorpb"
> > + "types/pluginpb"
> > + "compiler/protogen"
> > + "cmd/protoc-gen-go")))
> > + (modify-phases %standard-phases
> > + (replace 'build
> > + (lambda* (#:key import-path build-flags #:allow-other-keys)
> > + (for-each
> > + (lambda (pkg)
> > + ((assoc-ref %standard-phases 'build)
> > + #:import-path (format #f "~a/~a" import-path pkg)
> > + #:build-flags build-flags))
> > + go-packages)))
> > + (replace 'check
> > + (lambda* (#:key tests? import-path #:allow-other-keys)
> > + (for-each
> > + (lambda (pkg)
> > + ((assoc-ref %standard-phases 'check)
> > + #:tests? tests?
> > + #:import-path (format #f "~a/~a" import-path pkg)))
> > + go-packages)))))))
>
> Is this a workaround for our lack of Go modules support? An explanatory
> comment is needed.


Yes, I'll add the comment and send V2, thank you!
H
H
Hilton Chain wrote on 23 Sep 2023 19:39
[PATCH v2 0/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
cover.1695521520.git.hako@ultrarare.space
V1 -> V2:
- Add comment for #:phases change.

Hilton Chain (3):
gnu: go-google-golang-org-protobuf: Update to 1.31.0.
gnu: go-github-com-golang-protobuf-proto: Update to 1.5.3.
gnu: go-github-com-golang-protobuf-proto: Rename to go-github-com-golang-protobuf.

gnu/packages/golang.scm | 112 ++++++++++++++++++++++++++++++-------
gnu/packages/syncthing.scm | 4 +-
2 files changed, 93 insertions(+), 23 deletions(-)

$ git range-diff origin/master v1 v2
1: 67e75293d5 ! 1: 5f6b22ea40 gnu: go-google-golang-org-protobuf: Update to 1.31.0.
@@ gnu/packages/golang.scm: (define-public go-google-golang-org-protobuf
- (delete 'build))))
- (propagated-inputs (list go-github-com-google-go-cmp-cmp
- go-github-com-golang-protobuf-proto))
++ ;; XXX: Workaround for go-build-system's lack of Go modules support
+ #:phases
+ #~(let ((go-packages '("proto"
+ "encoding/protojson"
2: 665d5761cb = 2: 177b76f359 gnu: go-github-com-golang-protobuf-proto: Update to 1.5.3.
3: 47a5b62621 ! 3: fb3bff6d7f gnu: go-github-com-golang-protobuf-proto: Rename to go-github-com-golang-protobuf.
@@ Commit message

* gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Rename to...
(go-github-com-golang-protobuf): ... this.
- [import-path]: Use github.com/golang/protobuf.
- [phases]: Build and check all packages.
+ [arguments]<#:import-path>: Set to "github.com/golang/protobuf".
+ <#:unpack-path>: Remove argument.
+ <#:phases>: Build all Go packages and run tests for them.
(go-github-com-lucas-clemente-quic-go,go-github-com-prometheus-common)
(go-github-com-prometheus-client-golang,go-github-com-onsi-gomega)
[propagated-inputs]: Adjust accordingly.
* gnu/packages/syncthing.scm (go-github-com-prometheus-client-model)
(go-github-com-matttproud-golang-protobuf-extensions-pbutil)
- [propagated-inputs]: Adjust accordingly.
+ [propagated-inputs]: Likewise.

## gnu/packages/golang.scm ##
@@ gnu/packages/golang.scm: (define-public go-github-com-lucas-clemente-quic-go
@@ gnu/packages/golang.scm: (define-public go-github-com-golang-protobuf-proto
- '(#:import-path "github.com/golang/protobuf/proto"
- #:unpack-path "github.com/golang/protobuf"))
+ (list #:import-path "github.com/golang/protobuf"
++ ;; XXX: Workaround for go-build-system's lack of Go modules support
+ #:phases
+ #~(let ((go-packages '("proto"
+ "jsonpb"

base-commit: 4f35ff1275e05be31f5d41464ccf147e9dbfd016
--
2.41.0
H
H
Hilton Chain wrote on 23 Sep 2023 19:39
[PATCH v2 1/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
5f6b22ea4019638026ac945b175e6497257badaf.1695521520.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-google-golang-org-protobuf): Update to 1.31.0.
[arguments]: Build Go packages and run tests.
[propagated-inputs]: Remove go-github-com-golang-protobuf-proto.
---
gnu/packages/golang.scm | 57 +++++++++++++++++++++++++++++++++++------
1 file changed, 49 insertions(+), 8 deletions(-)

Toggle diff (80 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 3d19b48e9f..2a2ba8c13c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8848,7 +8848,7 @@ (define-public go-github-com-golang-protobuf-proto
(define-public go-google-golang-org-protobuf
(package
(name "go-google-golang-org-protobuf")
- (version "1.28.0")
+ (version "1.31.0")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -8857,16 +8857,57 @@ (define-public go-google-golang-org-protobuf
(file-name (git-file-name name version))
(sha256
(base32
- "1nzcc4qc00afi24nb7nlnwyzvvr6b8s8qdrn1sw085nygh2y2x8r"))))
+ "1xf18kzz96hgfy1vlbnydrizzpxkqj2iamfdbj3dx5a1zz5mi8n0"))))
(build-system go-build-system)
(arguments
(list #:import-path "google.golang.org/protobuf"
- #:tests? #f ; source-only package
- #:phases #~(modify-phases %standard-phases
- ;; source-only package
- (delete 'build))))
- (propagated-inputs (list go-github-com-google-go-cmp-cmp
- go-github-com-golang-protobuf-proto))
+ ;; XXX: Workaround for go-build-system's lack of Go modules support
+ #:phases
+ #~(let ((go-packages '("proto"
+ "encoding/protojson"
+ "encoding/prototext"
+ "encoding/protowire"
+ "reflect/protoreflect"
+ "reflect/protoregistry"
+ "reflect/protodesc"
+ "reflect/protopath"
+ "reflect/protorange"
+ "testing/protocmp"
+ "testing/protopack"
+ "testing/prototest"
+ "types/dynamicpb"
+ "types/known/anypb"
+ "types/known/timestamppb"
+ "types/known/durationpb"
+ "types/known/wrapperspb"
+ "types/known/structpb"
+ "types/known/fieldmaskpb"
+ "types/known/apipb"
+ "types/known/typepb"
+ "types/known/sourcecontextpb"
+ "types/known/emptypb"
+ "types/descriptorpb"
+ "types/pluginpb"
+ "compiler/protogen"
+ "cmd/protoc-gen-go")))
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path build-flags #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'build)
+ #:import-path (format #f "~a/~a" import-path pkg)
+ #:build-flags build-flags))
+ go-packages)))
+ (replace 'check
+ (lambda* (#:key tests? import-path #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'check)
+ #:tests? tests?
+ #:import-path (format #f "~a/~a" import-path pkg)))
+ go-packages)))))))
+ (propagated-inputs (list go-github-com-google-go-cmp-cmp))
(home-page "https://google.golang.org/protobuf")
(synopsis "Go library for Protocol Buffers")
(description
--
2.41.0
H
H
Hilton Chain wrote on 23 Sep 2023 19:39
[PATCH v2 2/3] gnu: go-github-com-golang-protobuf-proto: Update to 1.5.3.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
177b76f359a5e74114c1a684d41e24ffa77b1542.1695521520.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Update to
1.5.3.
[arguments]: Enable tests.
[propagated-inputs]: Add go-google-golang-org-protobuf.
---
gnu/packages/golang.scm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Toggle diff (33 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 2a2ba8c13c..f8a0d48b73 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8823,7 +8823,7 @@ (define-public gotestsum
(define-public go-github-com-golang-protobuf-proto
(package
(name "go-github-com-golang-protobuf-proto")
- (version "1.3.1")
+ (version "1.5.3")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -8832,13 +8832,13 @@ (define-public go-github-com-golang-protobuf-proto
(file-name (git-file-name name version))
(sha256
(base32
- "15am4s4646qy6iv0g3kkqq52rzykqjhm4bf08dk0fy2r58knpsyl"))))
+ "03f1w2cd4s8a3xhl61x7yjx81kbzlrjpvnnwmbhqnz814yi7h43i"))))
(build-system go-build-system)
(arguments
'(#:import-path "github.com/golang/protobuf/proto"
- #:unpack-path "github.com/golang/protobuf"
- ;; Requires unpackaged golang.org/x/sync/errgroup
- #:tests? #f))
+ #:unpack-path "github.com/golang/protobuf"))
+ (propagated-inputs
+ (list go-google-golang-org-protobuf))
(synopsis "Go support for Protocol Buffers")
(description "This package provides Go support for the Protocol Buffers
data serialization format.")
--
2.41.0
H
H
Hilton Chain wrote on 23 Sep 2023 19:39
[PATCH v2 3/3] gnu: go-github-com-golang-protobuf-proto: Rename to go-github-com-golang-protobuf.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
fb3bff6d7f0e9f689ace38481d9b112304a7b24c.1695521520.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Rename to...
(go-github-com-golang-protobuf): ... this.
[arguments]<#:import-path>: Set to "github.com/golang/protobuf".
<#:unpack-path>: Remove argument.
<#:phases>: Build all Go packages and run tests for them.
(go-github-com-lucas-clemente-quic-go,go-github-com-prometheus-common)
(go-github-com-prometheus-client-golang,go-github-com-onsi-gomega)
[propagated-inputs]: Adjust accordingly.
* gnu/packages/syncthing.scm (go-github-com-prometheus-client-model)
(go-github-com-matttproud-golang-protobuf-extensions-pbutil)
[propagated-inputs]: Likewise.
---
gnu/packages/golang.scm | 47 ++++++++++++++++++++++++++++++--------
gnu/packages/syncthing.scm | 4 ++--
2 files changed, 40 insertions(+), 11 deletions(-)

Toggle diff (121 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index f8a0d48b73..6fc7b13fef 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8023,7 +8023,7 @@ (define-public go-github-com-lucas-clemente-quic-go
(list go-golang-org-x-crypto go-github-com-cheekybits-genny
go-github-com-marten-seemann-chacha20
go-github-com-marten-seemann-qtls
- go-github-com-golang-protobuf-proto))
+ go-github-com-golang-protobuf))
(synopsis "QUIC in Go")
(description "This package provides a Go language implementation of the QUIC
network protocol.")
@@ -8820,9 +8820,9 @@ (define-public gotestsum
(home-page "https://github.com/gotestyourself/gotestsum")
(license license:asl2.0)))
-(define-public go-github-com-golang-protobuf-proto
+(define-public go-github-com-golang-protobuf
(package
- (name "go-github-com-golang-protobuf-proto")
+ (name "go-github-com-golang-protobuf")
(version "1.5.3")
(source (origin
(method git-fetch)
@@ -8835,8 +8835,38 @@ (define-public go-github-com-golang-protobuf-proto
"03f1w2cd4s8a3xhl61x7yjx81kbzlrjpvnnwmbhqnz814yi7h43i"))))
(build-system go-build-system)
(arguments
- '(#:import-path "github.com/golang/protobuf/proto"
- #:unpack-path "github.com/golang/protobuf"))
+ (list #:import-path "github.com/golang/protobuf"
+ ;; XXX: Workaround for go-build-system's lack of Go modules support
+ #:phases
+ #~(let ((go-packages '("proto"
+ "jsonpb"
+ "ptypes"
+ "ptypes/any"
+ "ptypes/empty"
+ "ptypes/timestamp"
+ "ptypes/duration"
+ "ptypes/wrappers"
+ "ptypes/struct"
+ "protoc-gen-go/descriptor"
+ "protoc-gen-go/plugin"
+ "protoc-gen-go")))
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path build-flags #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'build)
+ #:import-path (format #f "~a/~a" import-path pkg)
+ #:build-flags build-flags))
+ go-packages)))
+ (replace 'check
+ (lambda* (#:key tests? import-path #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'check)
+ #:tests? tests?
+ #:import-path (format #f "~a/~a" import-path pkg)))
+ go-packages)))))))
(propagated-inputs
(list go-google-golang-org-protobuf))
(synopsis "Go support for Protocol Buffers")
@@ -10697,7 +10727,7 @@ (define-public go-github-com-prometheus-common
;; Source-only package
(delete 'build))))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto
+ (list go-github-com-golang-protobuf
go-github-com-matttproud-golang-protobuf-extensions-pbutil
go-github-com-prometheus-client-model))
(synopsis "Prometheus metrics")
@@ -10754,7 +10784,7 @@ (define-public go-github-com-prometheus-client-golang
(delete 'build))))
(propagated-inputs
(list go-github-com-beorn7-perks-quantile
- go-github-com-golang-protobuf-proto
+ go-github-com-golang-protobuf
go-github-com-prometheus-client-model
go-github-com-prometheus-common
go-github-com-prometheus-procfs
@@ -13937,11 +13967,10 @@ (define-public go-github-com-onsi-gomega
;; Unless we disable the tests, we have a circular dependency on
;; ginkgo/v2.
#:tests? #f))
- (propagated-inputs (list go-github-com-golang-protobuf-proto
+ (propagated-inputs (list go-github-com-golang-protobuf
go-golang-org-x-net
go-golang-org-x-sys
go-golang-org-x-text
- go-google-golang-org-protobuf
go-gopkg-in-yaml-v2))
(home-page "https://github.com/onsi/gomega")
(synopsis "Matcher library for Ginkgo")
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index 5570aa9361..30ec34e8f3 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -828,7 +828,7 @@ (define-public go-github-com-prometheus-client-model
;; Source-only package
(delete 'build))))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto))
+ (list go-github-com-golang-protobuf))
(synopsis "Data model artifacts for Prometheus")
(description "This package provides data model artifacts for Prometheus.")
(home-page "https://github.com/prometheus/client_model")
@@ -856,7 +856,7 @@ (define-public go-github-com-matttproud-golang-protobuf-extensions-pbutil
'(#:import-path "github.com/matttproud/golang_protobuf_extensions/pbutil"
#:unpack-path "github.com/matttproud/golang_protobuf_extensions"))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto))
+ (list go-github-com-golang-protobuf))
(synopsis "Streaming Protocol Buffers in Go")
(description "This package provides various Protocol Buffer
extensions for the Go language, namely support for record length-delimited
--
2.41.0
M
M
Maxim Cournoyer wrote on 21 Jan 15:00 -0800
(name . Hilton Chain)(address . hako@ultrarare.space)(address . 65034@debbugs.gnu.org)
87ttn670mc.fsf@gmail.com
Hi Hilton,

Hilton Chain <hako@ultrarare.space> writes:

Toggle quote (12 lines)
> * gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Rename to...
> (go-github-com-golang-protobuf): ... this.
> [arguments]<#:import-path>: Set to "github.com/golang/protobuf".
> <#:unpack-path>: Remove argument.
> <#:phases>: Build all Go packages and run tests for them.
> (go-github-com-lucas-clemente-quic-go,go-github-com-prometheus-common)
> (go-github-com-prometheus-client-golang,go-github-com-onsi-gomega)
> [propagated-inputs]: Adjust accordingly.
> * gnu/packages/syncthing.scm (go-github-com-prometheus-client-model)
> (go-github-com-matttproud-golang-protobuf-extensions-pbutil)
> [propagated-inputs]: Likewise.

I wanted to apply this to core-updates but I think I had merge
conflicts. Could you check if it still applies cleanly, else upload a
v3?

--
Thanks,
Maxim
H
H
Hilton Chain wrote on 25 Jan 09:10 -0800
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 65034@debbugs.gnu.org)
87wmrx1gqd.wl-hako@ultrarare.space
Hi Maxim,

On Mon, 22 Jan 2024 07:00:43 +0800,
Maxim Cournoyer wrote:
Toggle quote (21 lines)
>
> Hi Hilton,
>
> Hilton Chain <hako@ultrarare.space> writes:
>
> > * gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Rename to...
> > (go-github-com-golang-protobuf): ... this.
> > [arguments]<#:import-path>: Set to "github.com/golang/protobuf".
> > <#:unpack-path>: Remove argument.
> > <#:phases>: Build all Go packages and run tests for them.
> > (go-github-com-lucas-clemente-quic-go,go-github-com-prometheus-common)
> > (go-github-com-prometheus-client-golang,go-github-com-onsi-gomega)
> > [propagated-inputs]: Adjust accordingly.
> > * gnu/packages/syncthing.scm (go-github-com-prometheus-client-model)
> > (go-github-com-matttproud-golang-protobuf-extensions-pbutil)
> > [propagated-inputs]: Likewise.
>
> I wanted to apply this to core-updates but I think I had merge
> conflicts. Could you check if it still applies cleanly, else upload a
> v3?

That's because of the go-github-com-quic-go-quic-go name change, I'll send v3.
H
H
Hilton Chain wrote on 25 Jan 09:12 -0800
[PATCH v3 core-updates 0/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
cover.1706202176.git.hako@ultrarare.space
V2 -> V3:
- Rebase.
V1 -> V2:
- Add comment for #:phases change.

Hilton Chain (3):
gnu: go-google-golang-org-protobuf: Update to 1.31.0.
gnu: go-github-com-golang-protobuf-proto: Update to 1.5.3.
gnu: go-github-com-golang-protobuf-proto: Rename to go-github-com-golang-protobuf.

gnu/packages/golang.scm | 111 ++++++++++++++++++++++++++++++-------
gnu/packages/syncthing.scm | 4 +-
2 files changed, 93 insertions(+), 22 deletions(-)


base-commit: 0c2518949dc63948200c6c6d3649d34785a1d84c
--
2.41.0
H
H
Hilton Chain wrote on 25 Jan 09:13 -0800
[PATCH v3 core-updates 1/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
ea75435a70e4097ff1fcfc15a9cac37212c808bc.1706202176.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-google-golang-org-protobuf): Update to 1.31.0.
[arguments]: Build Go packages and run tests.
[propagated-inputs]: Remove go-github-com-golang-protobuf-proto.
---
gnu/packages/golang.scm | 57 +++++++++++++++++++++++++++++++++++------
1 file changed, 49 insertions(+), 8 deletions(-)

Toggle diff (78 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e7306a585c..cb08ddae19 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8260,7 +8260,7 @@ (define-public go-github-com-golang-protobuf-proto
(define-public go-google-golang-org-protobuf
(package
(name "go-google-golang-org-protobuf")
- (version "1.28.0")
+ (version "1.31.0")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -8269,16 +8269,57 @@ (define-public go-google-golang-org-protobuf
(file-name (git-file-name name version))
(sha256
(base32
- "1nzcc4qc00afi24nb7nlnwyzvvr6b8s8qdrn1sw085nygh2y2x8r"))))
+ "1xf18kzz96hgfy1vlbnydrizzpxkqj2iamfdbj3dx5a1zz5mi8n0"))))
(build-system go-build-system)
(arguments
(list #:import-path "google.golang.org/protobuf"
- #:tests? #f ; source-only package
- #:phases #~(modify-phases %standard-phases
- ;; source-only package
- (delete 'build))))
- (propagated-inputs (list go-github-com-google-go-cmp-cmp
- go-github-com-golang-protobuf-proto))
+ ;; XXX: Workaround for go-build-system's lack of Go modules support
+ #:phases
+ #~(let ((go-packages '("proto"
+ "encoding/protojson"
+ "encoding/prototext"
+ "encoding/protowire"
+ "reflect/protoreflect"
+ "reflect/protoregistry"
+ "reflect/protodesc"
+ "reflect/protopath"
+ "reflect/protorange"
+ "testing/protocmp"
+ "testing/protopack"
+ "testing/prototest"
+ "types/dynamicpb"
+ "types/known/anypb"
+ "types/known/timestamppb"
+ "types/known/durationpb"
+ "types/known/wrapperspb"
+ "types/known/structpb"
+ "types/known/fieldmaskpb"
+ "types/known/apipb"
+ "types/known/typepb"
+ "types/known/sourcecontextpb"
+ "types/known/emptypb"
+ "types/descriptorpb"
+ "types/pluginpb"
+ "compiler/protogen"
+ "cmd/protoc-gen-go")))
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path build-flags #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'build)
+ #:import-path (format #f "~a/~a" import-path pkg)
+ #:build-flags build-flags))
+ go-packages)))
+ (replace 'check
+ (lambda* (#:key tests? import-path #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'check)
+ #:tests? tests?
+ #:import-path (format #f "~a/~a" import-path pkg)))
+ go-packages)))))))
+ (propagated-inputs (list go-github-com-google-go-cmp-cmp))
(home-page "https://google.golang.org/protobuf")
(synopsis "Go library for Protocol Buffers")
(description
--
2.41.0
H
H
Hilton Chain wrote on 25 Jan 09:13 -0800
[PATCH v3 core-updates 2/3] gnu: go-github-com-golang-protobuf-proto: Update to 1.5.3.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
3c9a235e51d515dce1fc269a5c021a2bb65b1732.1706202176.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Update to
1.5.3.
[arguments]: Enable tests.
[propagated-inputs]: Add go-google-golang-org-protobuf.
---
gnu/packages/golang.scm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Toggle diff (31 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index cb08ddae19..eaa2b7d305 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8235,7 +8235,7 @@ (define-public gotestsum
(define-public go-github-com-golang-protobuf-proto
(package
(name "go-github-com-golang-protobuf-proto")
- (version "1.3.1")
+ (version "1.5.3")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -8244,13 +8244,13 @@ (define-public go-github-com-golang-protobuf-proto
(file-name (git-file-name name version))
(sha256
(base32
- "15am4s4646qy6iv0g3kkqq52rzykqjhm4bf08dk0fy2r58knpsyl"))))
+ "03f1w2cd4s8a3xhl61x7yjx81kbzlrjpvnnwmbhqnz814yi7h43i"))))
(build-system go-build-system)
(arguments
'(#:import-path "github.com/golang/protobuf/proto"
- #:unpack-path "github.com/golang/protobuf"
- ;; Requires unpackaged golang.org/x/sync/errgroup
- #:tests? #f))
+ #:unpack-path "github.com/golang/protobuf"))
+ (propagated-inputs
+ (list go-google-golang-org-protobuf))
(synopsis "Go support for Protocol Buffers")
(description "This package provides Go support for the Protocol Buffers
data serialization format.")
--
2.41.0
H
H
Hilton Chain wrote on 25 Jan 09:13 -0800
[PATCH v3 core-updates 3/3] gnu: go-github-com-golang-protobuf-proto: Rename to go-github-com-golang-protobuf.
(address . 65034@debbugs.gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
6d1b2746c4dcf2646cedbea047071b731de0f0c6.1706202176.git.hako@ultrarare.space
* gnu/packages/golang.scm (go-github-com-golang-protobuf-proto): Rename to...
(go-github-com-golang-protobuf): ... this.
[arguments]<#:import-path>: Set to "github.com/golang/protobuf".
<#:unpack-path>: Remove argument.
<#:phases>: Build all Go packages and run tests for them.
(go-github-com-quic-go-quic-go,go-github-com-prometheus-common)
(go-github-com-prometheus-client-golang,go-github-com-onsi-gomega)
[propagated-inputs]: Adjust accordingly.
* gnu/packages/syncthing.scm (go-github-com-prometheus-client-model)
(go-github-com-matttproud-golang-protobuf-extensions-pbutil)
[propagated-inputs]: Likewise.

Change-Id: I0efa2deaac2cb2bcd2c11f8791bdf320a56cf729
---
gnu/packages/golang.scm | 46 +++++++++++++++++++++++++++++++-------
gnu/packages/syncthing.scm | 4 ++--
2 files changed, 40 insertions(+), 10 deletions(-)

Toggle diff (115 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index eaa2b7d305..b90b31e7ac 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -7477,7 +7477,7 @@ (define-public go-github-com-quic-go-quic-go
go-golang-org-x-crypto
go-github-com-cheekybits-genny
go-github-com-marten-seemann-chacha20
- go-github-com-golang-protobuf-proto
+ go-github-com-golang-protobuf
go-golang-org-x-crypto
go-golang-org-x-exp
go-golang-org-x-net
@@ -8232,9 +8232,9 @@ (define-public gotestsum
(home-page "https://github.com/gotestyourself/gotestsum")
(license license:asl2.0)))

-(define-public go-github-com-golang-protobuf-proto
+(define-public go-github-com-golang-protobuf
(package
- (name "go-github-com-golang-protobuf-proto")
+ (name "go-github-com-golang-protobuf")
(version "1.5.3")
(source (origin
(method git-fetch)
@@ -8247,8 +8247,38 @@ (define-public go-github-com-golang-protobuf-proto
"03f1w2cd4s8a3xhl61x7yjx81kbzlrjpvnnwmbhqnz814yi7h43i"))))
(build-system go-build-system)
(arguments
- '(#:import-path "github.com/golang/protobuf/proto"
- #:unpack-path "github.com/golang/protobuf"))
+ (list #:import-path "github.com/golang/protobuf"
+ ;; XXX: Workaround for go-build-system's lack of Go modules support
+ #:phases
+ #~(let ((go-packages '("proto"
+ "jsonpb"
+ "ptypes"
+ "ptypes/any"
+ "ptypes/empty"
+ "ptypes/timestamp"
+ "ptypes/duration"
+ "ptypes/wrappers"
+ "ptypes/struct"
+ "protoc-gen-go/descriptor"
+ "protoc-gen-go/plugin"
+ "protoc-gen-go")))
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path build-flags #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'build)
+ #:import-path (format #f "~a/~a" import-path pkg)
+ #:build-flags build-flags))
+ go-packages)))
+ (replace 'check
+ (lambda* (#:key tests? import-path #:allow-other-keys)
+ (for-each
+ (lambda (pkg)
+ ((assoc-ref %standard-phases 'check)
+ #:tests? tests?
+ #:import-path (format #f "~a/~a" import-path pkg)))
+ go-packages)))))))
(propagated-inputs
(list go-google-golang-org-protobuf))
(synopsis "Go support for Protocol Buffers")
@@ -9893,7 +9923,7 @@ (define-public go-github-com-prometheus-common
;; Source-only package
(delete 'build))))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto
+ (list go-github-com-golang-protobuf
go-github-com-matttproud-golang-protobuf-extensions-pbutil
go-github-com-prometheus-client-model))
(synopsis "Prometheus metrics")
@@ -9950,7 +9980,7 @@ (define-public go-github-com-prometheus-client-golang
(delete 'build))))
(propagated-inputs
(list go-github-com-beorn7-perks-quantile
- go-github-com-golang-protobuf-proto
+ go-github-com-golang-protobuf
go-github-com-prometheus-client-model
go-github-com-prometheus-common
go-github-com-prometheus-procfs
@@ -12679,7 +12709,7 @@ (define-public go-github-com-onsi-gomega
;; Unless we disable the tests, we have a circular dependency on
;; ginkgo/v2.
#:tests? #f))
- (propagated-inputs (list go-github-com-golang-protobuf-proto
+ (propagated-inputs (list go-github-com-golang-protobuf
go-golang-org-x-net
go-golang-org-x-sys
go-golang-org-x-text
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index c18b70eb4b..bc0960d379 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -831,7 +831,7 @@ (define-public go-github-com-prometheus-client-model
;; Source-only package
(delete 'build))))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto))
+ (list go-github-com-golang-protobuf))
(synopsis "Data model artifacts for Prometheus")
(description "This package provides data model artifacts for Prometheus.")
(home-page "https://github.com/prometheus/client_model")
@@ -859,7 +859,7 @@ (define-public go-github-com-matttproud-golang-protobuf-extensions-pbutil
'(#:import-path "github.com/matttproud/golang_protobuf_extensions/pbutil"
#:unpack-path "github.com/matttproud/golang_protobuf_extensions"))
(propagated-inputs
- (list go-github-com-golang-protobuf-proto))
+ (list go-github-com-golang-protobuf))
(synopsis "Streaming Protocol Buffers in Go")
(description "This package provides various Protocol Buffer
extensions for the Go language, namely support for record length-delimited
--
2.41.0
S
S
Sharlatan Hellseher wrote on 20 Jun 04:57 -0700
[PATCH 0/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.
(address . 65034-done@debbugs.gnu.org)
8734p7zv17.fsf@gmail.com
Hi,

Pushed as a5165940c6..91cbb4324f to wip-go-team with some modifications.

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmZ0GSQACgkQdtcnv/Ys
0rV3gg/+KoTvl1VsnW9PvXBbDIgZpETaGFrNkZn8ZUITDZsIvmg0d9UEw/ralFFn
/Ed5yH1DOS62sARFS0GeG7Ml+0Cni7MpUc0lSgpfiEYIGW/RETaGrNbrxNTCcwME
zPaXXoUVOMRoYgdO1igTx9Wzgip4+dts1eX09RH1vX1ss6BORJX04j0iJ63vu85B
9jLQ1viStaj0lDOqXIf8dkC0hGBwK8W55p+5U3X84HRV5wvR7Bp6plnNjrIVOl/c
YvTC+GZjD8q8lq46qdMg9USv/zahx2rR+qwS1oAw1z1JfWLVWc3gBXeNACR/ons6
a/+/yOyZ2uDiCK+ro2Go/yDhaMxErKt7ME4d0zrJmk0eTfyi4k2xc/QVXLMTzDb+
lFFSKpSdEhgBa78Ze7dyRurgbjsaSLIbVRvIJz6b2SEYPJCwMlmI6PTaCrWZLVxV
K8LAPFLAjzSPOOHv3lOx0XQ3M4SrkzDbnUnG/FtnhtZ6LUXXZm8yiAbHsBGNXC3r
VQhlp6c4zBJeIHOueIhBa7VrOuP+hi4x1dJQZ717aLQdnJQ4L4gWkIuDlNh6AWeT
HbX60D+eIAZDFmYesXeEhRraEOCSoaIHx0KYnbmaOXBHPzkkapOY6mP1E7tNN3e2
lDTJk8n/atPBShbwP97t3iATksntDQhpq4x51LT0hLZe36Kzptc=
=CfaY
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 65034@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 65034
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch