[PATCH] gnu: pipe-viewer: Add dependency.

  • Done
  • quality assurance status badge
Details
4 participants
  • Sughosha
  • Liliana Marie Prikler
  • Ludovic Courtès
  • Maxime Devos
Owner
unassigned
Submitted by
Sughosha
Severity
normal

Debbugs page

S
S
Sughosha wrote on 3 Jul 2022 19:08
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
JX7o9aDg6NRVU3_Z9QSsXV8x4QgGPr89XVjfAsKgj8u9HXc_AweueLyZOTmznirJym_D79LVi8Di1V3OO5yCD6mKt-Vxvu5kRlpPEEPXyck=@proton.me
Without mpv this application gives the following error:
sh: line 1: mpv: command not found.
Attachment: file
From 0b0e66ba091ed2b4871f855e6ef271cda276aaf0 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Mon, 4 Jul 2022 04:01:12 +0200
Subject: [PATCH] gnu: pipe-viewer: Add dependency.

* gnu/packages/video.scm (pipe-viewer): Add dependency.

This application calls mpv to play audios or videos, so mpv as dependency is required.
---
gnu/packages/video.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 40c31cdaec..07f9e94d34 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1183,7 +1183,8 @@ (define-public pipe-viewer
wget
xdg-utils
youtube-dl
- yt-dlp))
+ yt-dlp
+ mpv))
(propagated-inputs
(list dconf))
(home-page "https://github.com/trizen/pipe-viewer")
--
2.36.1
S
S
Sughosha wrote on 3 Jul 2022 19:21
(name . 56377@debbugs.gnu.org)(address . 56377@debbugs.gnu.org)
kJbtnlZji_RHUPKsPbrieVyPZkjzKS_gZdY4dokLTN6O2_e1qmW_yxrLIoD8K3PVyRAbGrZqwM2jbyzVThXnm-gYqULsquriTBTirAhRJpU=@proton.me
Sorry for the ignorance, mpv has to be propagated-input to work.
Attachment: file
From 0258642badcb5efa9426b8d03ca1226dd7a5d8b1 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Mon, 4 Jul 2022 04:15:59 +0200
Subject: [PATCH] gnu: pipe-viewer: Add dependency.

* gnu/packages/video.scm (pipe-viewer): Add dependency.

This application calls mpv to play audios or videos, so mpv as dependency is required.
---
gnu/packages/video.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 40c31cdaec..eee1f63d4a 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1185,7 +1185,7 @@ (define-public pipe-viewer
youtube-dl
yt-dlp))
(propagated-inputs
- (list dconf))
+ (list dconf mpv))
(home-page "https://github.com/trizen/pipe-viewer")
(synopsis "CLI+GUI YouTube Client")
(description "Pipe-Viewer is a lightweight application for searching and
--
2.36.1
S
S
Sughosha wrote on 3 Jul 2022 19:33
(No Subject)
(name . 56377@debbugs.gnu.org)(address . 56377@debbugs.gnu.org)
fNFo34n4g6F_aE6tb2dgtaTscpUtEdt6m9NvcjfmUroCFUMWqETFfmlG4kz1mLTV9z-G76JMxelAPMancC0eTXuF5_oqqDyUfmcDLyd_meI=@proton.me
Sorry, again, as using the app I understood that mpv is not hardcoded, in the settings I can use any video player. So it doesn't make sense to add mpv as a dependency. I would request to ignore this issue and close it.
Attachment: file
L
L
Liliana Marie Prikler wrote on 3 Jul 2022 23:44
Re: [PATCH] gnu: pipe-viewer: Add dependency.
c8fd018f0e56a81e66aea62a08baef52f1d7a4a6.camel@ist.tugraz.at
Hi

Am Montag, dem 04.07.2022 um 02:21 +0000 schrieb Sughosha:
Toggle quote (1 lines)
> Sorry for the ignorance, mpv has to be propagated-input to work.
Rather than propagating mpv, could you patch the place in which it is
invoked? It doesn't matter if mpv is used as a "fallback" or whatever,
if it calls mpv we might as well make sure it finds mpv.

Cheers
L
L
Ludovic Courtès wrote on 8 Jul 2022 08:30
control message for bug #56377
(address . control@debbugs.gnu.org)
87zghjtyea.fsf@gnu.org
tags 56377 wontfix
close 56377
quit
M
M
Maxime Devos wrote on 29 Jul 2022 09:38
Re: [bug#56377] (No Subject)
d4c8ae19-b32d-c114-84af-cb34a2e384d5@telenet.be
On 04-07-2022 04:33, Sughosha via Guix-patches via wrote:
Toggle quote (4 lines)
> Sorry, again, as using the app I understood that mpv is not hardcoded,
> in the settings I can use any video player. So it doesn't make sense
> to add mpv as a dependency. I would request to ignore this issue and
> close it.
Assuming that mpv isn't overly large, I think it would be nice if
pipe-viewer can always find its default player -- the user can still
override what player to use when desired.
Looking at "guix size mpv pipe-viewer" and "guix size pipe-viewer", mpv
adds 20.1 MiB; I don't know if that's worth it (I'm leaning towards
'not' but I'm undecided).
Greetings,
Maxime.
Attachment: file
Attachment: OpenPGP_0x49E3EE22191725EE.asc
Attachment: OpenPGP_signature
?
Your comment

This issue is archived.

To comment on this conversation send an email to 56377@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 56377
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch