set-grafting: regression in "guix graph"

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • zimoun
Owner
unassigned
Submitted by
zimoun
Severity
normal

Debbugs page

Z
Z
zimoun wrote on 25 Feb 2021 10:06
CAJ3okZ0E5gCxi_VS8RQ0TZGo=KKYSoTm6UFWa5U-cbOSA3v9SQ@mail.gmail.com
Hi,

Using commit 3c548c3e0e, "guix graph hello" works. However, commit
db45712a67 "grafts: Inline 'grafting?' and 'set-grafting'" seems to
introduce a regression:

Toggle snippet (37 lines)
$ ./pre-inst-env guix graph hello
Backtrace:
In ice-9/boot-9.scm:
1736:10 14 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In unknown file:
13 (apply-smob/0 #<thunk 7f204bef3520>)
In ice-9/boot-9.scm:
718:2 12 (call-with-prompt _ _ #<procedure default-prompt-handler (k pr=
oc)>)
In ice-9/eval.scm:
619:8 11 (_ #(#(#<directory (guile-user) 7f204bef6c80>)))
In guix/ui.scm:
2162:12 10 (run-guix-command _ . _)
In guix/scripts/graph.scm:
573:2 9 (guix-graph . _)
In ice-9/boot-9.scm:
1736:10 8 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
1731:15 7 (with-exception-handler #<procedure 7f204a0cb270 at ice-9/boot=
-9.scm:1815:7 (exn)> _ #:unwind? _ #:unwind-for-type _)
1736:10 6 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
152:2 5 (with-fluid* _ _ _)
In unknown file:
4 (_ #<procedure 7f2049e15320 at ice-9/eval.scm:330:13 ()> #<pro=
cedure 7f2049e152e0 at ice-9/eval.scm:383:13 rest> #<procedure call-with-va=
lues (producer consumer)>)
In guix/scripts/graph.scm:
598:37 3 (_ #<store-connection 256.99 7f2049ee3c30>)
598:37 2 (_ #f)
In ice-9/boot-9.scm:
1669:16 1 (raise-exception _ #:continuable? _)
1669:16 0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1669:16: In procedure raise-exception:
Wrong type to apply: #<syntax-transformer set-grafting>


All the best,
simon
L
L
Ludovic Courtès wrote on 1 Mar 2021 01:46
(name . zimoun)(address . zimon.toutoune@gmail.com)(address . 46778@debbugs.gnu.org)
878s77urye.fsf@gnu.org
Hi,

zimoun <zimon.toutoune@gmail.com> skribis:

Toggle quote (4 lines)
> Using commit 3c548c3e0e, "guix graph hello" works. However, commit
> db45712a67 "grafts: Inline 'grafting?' and 'set-grafting'" seems to
> introduce a regression:

[...]

Toggle quote (3 lines)
> ice-9/boot-9.scm:1669:16: In procedure raise-exception:
> Wrong type to apply: #<syntax-transformer set-grafting>

You need to:

rm guix/scripts/graph.go && make

This is an ABI issue: ‘set-grafting’ used to be a procedure and it’s now
a macro.

HTH!

Ludo’.
L
L
Ludovic Courtès wrote on 1 Mar 2021 01:46
control message for bug #46778
(address . control@debbugs.gnu.org)
877dmrury5.fsf@gnu.org
tags 46778 notabug
close 46778
quit
Z
Z
zimoun wrote on 2 Mar 2021 07:21
Re: set-grafting: regression in "guix graph"
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 46778-done@debbugs.gnu.org)
CAJ3okZ3MY7bnM0bbpLzvA3LMyGX0cpadc6EvRS35K6SXV-s_LQ@mail.gmail.com
Hi,

On Mon, 1 Mar 2021 at 10:46, Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (3 lines)
> This is an ABI issue: ‘set-grafting’ used to be a procedure and it’s now
> a macro.

Indeed. Thanks.
Good to know when bisecting. :-)

Cheers,
simon
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 46778@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 46778
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch