[PATCH] gnu: chroma: Fix build.

  • Done
  • quality assurance status badge
Details
3 participants
  • Brett Gilio
  • Jesse Gibbons
  • Ludovic Courtès
Owner
unassigned
Submitted by
Jesse Gibbons
Severity
normal

Debbugs page

J
J
Jesse Gibbons wrote on 20 Jul 2020 23:05
(name . Guix Patches)(address . guix-patches@gnu.org)
6827eede-64e7-52e0-529a-08b79b1598db@gmail.com
* gnu/packages/games.scm: chroma:

[configure-flags]: Add "CFLAGS=-fgnu89-inline"
---
gnu/packages/games.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f4d75eedd4..cff1c0af99 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -40,7 +40,7 @@
;;; Copyright © 2019, 2020 Oleg Pykhalov <go.wigust@gmail.com>
;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2019 Julien Lepiller <julien@lepiller.eu>
-;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix@gmail.com>
+;;; Copyright © 2019, 2020 Jesse Gibbons <jgibbons2357+guix@gmail.com>
;;; Copyright © 2019 Dan Frumin <dfrumin@cs.ru.nl>
;;; Copyright © 2019, 2020 Guillaume Le Vaillant <glv@posteo.net>
;;; Copyright © 2019, 2020 Timotej Lazar <timotej.lazar@araneo.si>
@@ -5895,7 +5895,8 @@ with the mouse isn’t always trivial.")
"047sf00x71xbmi8bqrhfbmr9bk89l2gbykkqsfpw4wz6yfjscs6y"))))
(build-system gnu-build-system)
(arguments
- `(#:tests? #f)) ; no tests included
+ `(#:tests? #f ; no tests included
+ #:configure-flags '("CFLAGS=-fgnu89-inline"))) ; fix inlines
(inputs
`(("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer sdl-ttf)))
("freetype" ,freetype)
L
L
Ludovic Courtès wrote on 21 Jul 2020 09:30
(name . Jesse Gibbons)(address . jgibbons2357@gmail.com)(address . 42453@debbugs.gnu.org)
87zh7sn852.fsf@gnu.org
Hi,

Jesse Gibbons <jgibbons2357@gmail.com> skribis:

Toggle quote (28 lines)
> * gnu/packages/games.scm: chroma:
>
> [configure-flags]: Add "CFLAGS=-fgnu89-inline"
> ---
> gnu/packages/games.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index f4d75eedd4..cff1c0af99 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -40,7 +40,7 @@
> ;;; Copyright © 2019, 2020 Oleg Pykhalov <go.wigust@gmail.com>
> ;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
> ;;; Copyright © 2019 Julien Lepiller <julien@lepiller.eu>
> -;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix@gmail.com>
> +;;; Copyright © 2019, 2020 Jesse Gibbons <jgibbons2357+guix@gmail.com>
> ;;; Copyright © 2019 Dan Frumin <dfrumin@cs.ru.nl>
> ;;; Copyright © 2019, 2020 Guillaume Le Vaillant <glv@posteo.net>
> ;;; Copyright © 2019, 2020 Timotej Lazar <timotej.lazar@araneo.si>
> @@ -5895,7 +5895,8 @@ with the mouse isn’t always trivial.")
> "047sf00x71xbmi8bqrhfbmr9bk89l2gbykkqsfpw4wz6yfjscs6y"))))
> (build-system gnu-build-system)
> (arguments
> - `(#:tests? #f)) ; no tests included
> + `(#:tests? #f ; no tests included
> + #:configure-flags '("CFLAGS=-fgnu89-inline"))) ; fix inlines

Looks like your email client mangled the patch, probably due to
“format=flowed”.

Could you try sending it with ‘git send-email’ or as an attachment, to
42453@debbugs.gnu.org?

TIA!

Ludo’.
J
J
Jesse Gibbons wrote on 21 Jul 2020 11:56
[PATCH] gnu: chroma: Fix build.
(address . 42453@debbugs.gnu.org)
c08ee7fe-3df7-bebf-05b3-2936d651156d@gmail.com
Attached is a patch that fixes the build of Chroma in gnu/packaes/games.scm
From 42d71e4945d5a315ebf3b986082dbbbe99e7d392 Mon Sep 17 00:00:00 2001
From: Jesse Gibbons <jgibbons2357+guix@gmail.com>
Date: Mon, 20 Jul 2020 20:38:30 -0600
Subject: [PATCH 1/1] gnu: chroma: Fix build.

* gnu/packages/games.scm: chroma:
[configure-flags]: Add "CFLAGS=-fgnu89-inline"
---
gnu/packages/games.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (25 lines)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f4d75eedd4..cff1c0af99 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -40,7 +40,7 @@
;;; Copyright © 2019, 2020 Oleg Pykhalov <go.wigust@gmail.com>
;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2019 Julien Lepiller <julien@lepiller.eu>
-;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix@gmail.com>
+;;; Copyright © 2019, 2020 Jesse Gibbons <jgibbons2357+guix@gmail.com>
;;; Copyright © 2019 Dan Frumin <dfrumin@cs.ru.nl>
;;; Copyright © 2019, 2020 Guillaume Le Vaillant <glv@posteo.net>
;;; Copyright © 2019, 2020 Timotej Lazar <timotej.lazar@araneo.si>
@@ -5895,7 +5895,8 @@ with the mouse isn’t always trivial.")
"047sf00x71xbmi8bqrhfbmr9bk89l2gbykkqsfpw4wz6yfjscs6y"))))
(build-system gnu-build-system)
(arguments
- `(#:tests? #f)) ; no tests included
+ `(#:tests? #f ; no tests included
+ #:configure-flags '("CFLAGS=-fgnu89-inline"))) ; fix inlines
(inputs
`(("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer sdl-ttf)))
("freetype" ,freetype)
--
2.27.0
B
B
Brett Gilio wrote on 24 Jul 2020 18:19
(name . Jesse Gibbons)(address . jgibbons2357@gmail.com)(address . 42453@debbugs.gnu.org)
877dus5r2p.fsf@gnu.org
Jesse Gibbons <jgibbons2357@gmail.com> writes:

Toggle quote (2 lines)
> Attached is a patch that fixes the build of Chroma in gnu/packaes/games.scm

Hi Jesse!

Thanks for submitting the unmangled patch! I have reviewed it and pushed
it to master with 982a6e79a2d674ea905e2c63c2378b9df7d64af6. Along with
the push I revised the git commit message and sub-header to be more
descriptive. Thank you, again!

Brett Gilio
L
L
Ludovic Courtès wrote on 27 Jul 2020 02:35
control message for bug #42453
(address . control@debbugs.gnu.org)
871rkx1es7.fsf@gnu.org
tags 42453 fixed
close 42453
quit
?
Your comment

This issue is archived.

To comment on this conversation send an email to 42453@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 42453
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch