[PATCH 1/8] gnu: go-github-com-prometheus-common-expfmt: Disable tests for go-1.11.

  • Done
  • quality assurance status badge
Details
2 participants
  • Leo Famulari
  • Pierre Neidhardt
Owner
unassigned
Submitted by
Pierre Neidhardt
Severity
normal

Debbugs page

P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:16
(address . guix-patches@gnu.org)
20181106171608.24187-1-mail@ambrevar.xyz
* gnu/packages/syncthing.scm (go-github-com-prometheus-common-expfmt): Disable tests for go-1.11.
---
gnu/packages/syncthing.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index 48b52d200..410015c48 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -1097,7 +1097,10 @@ message streaming.")
(string-append (assoc-ref outputs "out")
"/src/github.com/prometheus/common/expfmt/testdata/")
".*\\.gz$"))
- #t)))))
+ #t)))
+ ;; Tests don't pass on go-1.11. See
+ ;; https://github.com/syncthing/syncthing/issues/5311.
+ #:tests? #f))
(propagated-inputs
`(("go-github-com-golang-protobuf-proto"
,go-github-com-golang-protobuf-proto)
--
2.19.1
L
L
Leo Famulari wrote on 6 Nov 2018 09:33
(name . Pierre Neidhardt)(address . mail@ambrevar.xyz)(address . 33290@debbugs.gnu.org)
20181106173303.GB3232@jasmine.lan
On Tue, Nov 06, 2018 at 06:16:08PM +0100, Pierre Neidhardt wrote:
Toggle quote (7 lines)
> * gnu/packages/syncthing.scm (go-github-com-prometheus-common-expfmt): Disable tests for go-1.11.

> + #t)))
> + ;; Tests don't pass on go-1.11. See
> + ;; https://github.com/syncthing/syncthing/issues/5311.
> + #:tests? #f))

Thanks for looking into this! Do you know if only the tests are broken?
Or is the functionality of this package broken as well?
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlvh0E8ACgkQJkb6MLrK
fwgSxg//YplDH+69kXKNQKI94JyQHPAFrAB7drP6iXZfNQbTus9PMsiVDtKAdgkm
ZJ8SaHBR+1szJmUuOoGjj4IqzklrfqMRPGqEMdhF5ioJZhpBDTyb7T3MExApuJ+e
YM2cH++5uOt3IrpJd8ir7jkEDNBkjdSnrZ2WimtsvZ78zlpA3r/KKstidPXpV14t
zp2wst+VBnC1I7yJN8dqrgfjPf2IkpIdFdIIuE+/9bBWKojFZ5HKPdGsRUPl/0aw
EvT1p3WeDuV7vYhckHblFR0b8cJgcbgxMEEW2X4FpE91hpBGT8Yc4PmjFlEjBiU1
EinKLbWui+j5lKSpFZUTSn1+MQjk92Hh1I2FH04O4b1waFHNiAp1sLE8HLwYszgA
CeVQZsonEWxIC+WQzJeJXmLZAebfvSxxvHS0P66ZT/X1ifjriglQoVhc+cWkm+ml
NZwMQ0T9CX0SCXh2gQ5FJlsbPTRxotGpWPSsdTcU/FniV9D8HJgOniLERAgazUZG
XaH4WE7FtJmRaxnB1NRrElmBL/h2bysGC3QOZLrvjiXiN8OpqxkibGEDVLxxzVhK
y654CKsMVC5biIiFdfFRz3V9MKWkiLsYaRoQUz99r2lxRAhY4ivhLSWcuGUxBnsn
lwg/NMu3h2E4mW2+0PmSBLBqkWuxhvMZ4l4cMiDeJ+Vf1V+nz4o=
=N/2T
-----END PGP SIGNATURE-----


P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:34
(name . Leo Famulari)(address . leo@famulari.name)(address . 33290@debbugs.gnu.org)
87in1ayurm.fsf@ambrevar.xyz
From what I've investigated, the failures are only "lints" (check the link, I've
reported this) so nothing should break.

--
Pierre Neidhardt
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlvh0L0ACgkQm9z0l6S7
zH9bbgf+PJ+MmKXSb3biM0Y6QJwYbLVNwik/dygESvL9cepmh3TcHCsnFqIM39Ym
AHuXdLDDlWtIBm+wM+bPiOhk+m0sjlqxUUWWhQNjXuGN51DZbCcV0BvgKm6TpQm0
aXPk1F//31eukrhEw3F0BNaq1ItjG5yR9h7ekye3RdMi30jDA6dGejfRFKOhzLdG
ORak5edPYTUSENyPPzUkz0+4JYWFOE3aeTx+HITs+HVPrshX9LlPyf6KQkMzNHkX
8QW/6KeZxk7aHeqreKqscBAR5Lgz16a/P27+DxUuYvgN4YuUro58XA0k4nKVRFU8
61QRoAbRwpgbPehmSkf4Fswwde4dyQ==
=TEsx
-----END PGP SIGNATURE-----

P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:37
[PATCH 2/8] gnu: go-github-com-audriusbutkevicius-cli: Disable tests for go-1.11.
(address . 33290@debbugs.gnu.org)
20181106173709.9883-1-mail@ambrevar.xyz
* gnu/packages/syncthing.scm (go-github-com-audriusbutkevicius-cli): Disable tests for go-1.11.
---
gnu/packages/syncthing.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index 410015c48..3c5034057 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -900,7 +900,10 @@ the current goroutine's ID.")
"0bg26pfg25vr16jmczig2m493mja2nxjxyswz3hha7avxw20rpi5"))))
(build-system go-build-system)
(arguments
- '(#:import-path "github.com/AudriusButkevicius/cli"))
+ '(#:import-path "github.com/AudriusButkevicius/cli"
+ ;; Tests don't pass on go-1.11. See
+ ;; https://github.com/AudriusButkevicius/cli/pull/1.
+ #:tests? #f))
(synopsis "Library for building command-line interfaces in Go")
(description "This package provides a library for building command-line
interfaces in Go.")
--
2.19.1
P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:37
[PATCH 3/8] gnu: go-gopkg.in-asn1-ber.v1: Disable tests for go-1.11.
(address . 33290@debbugs.gnu.org)
20181106173709.9883-2-mail@ambrevar.xyz
* gnu/packages/syncthing.scm (go-gopkg.in-asn1-ber.v1): Disable tests for go-1.11.
---
gnu/packages/syncthing.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index 3c5034057..0d6846cde 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -1257,7 +1257,10 @@ Prometheus HTTP API.")
"1y8bvzbxpw0lfnn7pbcdwzqj4l90qj6xf88dvv9pxd9yl5g6cskx"))))
(build-system go-build-system)
(arguments
- '(#:import-path "gopkg.in/asn1-ber.v1"))
+ '(#:import-path "gopkg.in/asn1-ber.v1"
+ ;; Tests don't pass on go-1.11. See
+ ;; https://github.com/go-asn1-ber/asn1-ber/issues/20.
+ #:tests? #f))
(synopsis "ASN.1 BER encoding and decoding in Go")
(description "This package provides ASN.1 BER encoding and decoding in the
Go language.")
--
2.19.1
P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:37
[PATCH 4/8] gnu: go-github-com-wtolson-go-taglib: Disable tests for go-1.11.
(address . 33290@debbugs.gnu.org)
20181106173709.9883-3-mail@ambrevar.xyz
* gnu/packages/golang.scm (go-github-com-wtolson-go-taglib): Disable tests for go-1.11.
---
gnu/packages/golang.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e49372d43..a4978af2a 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2423,7 +2423,10 @@ and lookup requests. Browse requests are not supported yet.")
`(("pkg-config" ,pkg-config)
("taglib" ,taglib)))
(arguments
- `(#:import-path "github.com/wtolson/go-taglib"))
+ `(#:import-path "github.com/wtolson/go-taglib"
+ ;; Tests are broken on go-1.11:
+ ;; https://github.com/wtolson/go-taglib/issues/12.
+ #:tests? #f))
(home-page "https://github.com/wtolson/go-taglib")
(synopsis "Go wrapper for taglib")
(description "Go wrapper for taglib")
--
2.19.1
P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:37
[PATCH 5/8] gnu: go-gitlab-com-ambrevar-golua-unicode: Add workaround for go-1.11.
(address . 33290@debbugs.gnu.org)
20181106173709.9883-4-mail@ambrevar.xyz
* gnu/packages/golang.scm (go-gitlab-com-ambrevar-golua-unicode): Add workaround for go-1.11.
---
gnu/packages/golang.scm | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

Toggle diff (31 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index a4978af2a..b6b726019 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2204,10 +2204,23 @@ run a Lua virtual machine.")
#:import-path "gitlab.com/ambrevar/golua/unicode"
#:phases
(modify-phases %standard-phases
+ ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+ ;; rebuilt (https://bugs.gnu.org/32919). Thus we need to re-specify
+ ;; the special flags of golua here and in the 'check phase below.
+ (replace 'build
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "install"
+ "-v" ; print the name of packages as they are compiled
+ "-x" ; print each command as it is invoked
+ "-ldflags=-s -w" ; strip the symbol table and debug
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path)))
(replace 'check
(lambda* (#:key import-path #:allow-other-keys)
(setenv "USER" "homeless-dude")
- (invoke "go" "test" import-path))))))
+ (invoke "go" "test"
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path))))))
(home-page "https://gitlab.com/ambrevar/golua")
(synopsis "Add Unicode support to Golua")
(description "This extension to Arzilli's Golua adds Unicode support to
--
2.19.1
P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:37
[PATCH 6/8] gnu: go-github-com-stevedonovan-luar: Add workaround for go-1.11.
(address . 33290@debbugs.gnu.org)
20181106173709.9883-5-mail@ambrevar.xyz
* gnu/packages/golang.scm (go-github-com-stevedonovan-luar): Add workaround for go-1.11.
---
gnu/packages/golang.scm | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)

Toggle diff (33 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index b6b726019..643ecda9f 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2303,10 +2303,24 @@ similar word.")
"1acjgw9cz1l0l9mzkyk7irz6cfk31wnxgbwa805fvm1rqcjzin2c"))))
(build-system go-build-system)
(native-inputs
- `(("go-github-com-aarzilli-golua" ,go-github-com-aarzilli-golua)))
+ `(("go-github-com-aarzilli-golua" ,go-github-com-aarzilli-golua)
+ ("lua" ,lua)))
(arguments
`(#:tests? #f ; Upstream tests are broken.
- #:import-path "github.com/stevedonovan/luar"))
+ #:import-path "github.com/stevedonovan/luar"
+ ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+ ;; rebuilt (https://bugs.gnu.org/32919). Thus we need to re-specify
+ ;; the special flags of golua and the "lua" native-input.
+ #:phases
+ (modify-phases %standard-phases
+ (replace 'build
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "install"
+ "-v" ; print the name of packages as they are compiled
+ "-x" ; print each command as it is invoked
+ "-ldflags=-s -w" ; strip the symbol table and debug
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path))))))
(home-page "https://github.com/stevedonovan/luar")
(synopsis "Lua reflection bindings for Go")
(description "Luar is designed to make using Lua from Go more
--
2.19.1
P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:37
[PATCH 7/8] gnu: demlo: Add workaround for go-1.11.
(address . 33290@debbugs.gnu.org)
20181106173709.9883-6-mail@ambrevar.xyz
* gnu/packages/music.scm (demlo): Add workaround for go-1.11.
---
gnu/packages/music.scm | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)

Toggle diff (42 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index cdd06647e..bbdf58b18 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4235,7 +4235,10 @@ console music players.")
("go-github-com-michiwend-gomusicbrainz" ,go-github-com-michiwend-gomusicbrainz)
("go-github-com-stevedonovan-luar" ,go-github-com-stevedonovan-luar)
("go-github-com-wtolson-go-taglib" ,go-github-com-wtolson-go-taglib)
- ("go-github-com-yookoala-realpath" ,go-github-com-yookoala-realpath)))
+ ("go-github-com-yookoala-realpath" ,go-github-com-yookoala-realpath)
+ ;; Those should not be needed, see TODO below.
+ ("pkg-config" ,pkg-config)
+ ("taglib" ,taglib)))
(inputs
`(("chromaprint" ,chromaprint)
("ffmpeg" ,ffmpeg)))
@@ -4243,6 +4246,23 @@ console music players.")
`(#:import-path "gitlab.com/ambrevar/demlo"
#:phases
(modify-phases %standard-phases
+ ;; TODO: With our go-1.11, the golua .pkg is not re-used and gets
+ ;; rebuilt (https://bugs.gnu.org/32919). Thus we need to
+ ;; re-specify the special flags of golua, the pkg-config + taglib
+ ;; native-inputs, and the 'check phase below.
+ (replace 'build
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "install"
+ "-v" ; print the name of packages as they are compiled
+ "-x" ; print each command as it is invoked
+ "-ldflags=-s -w" ; strip the symbol table and debug
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path)))
+ (replace 'check
+ (lambda* (#:key import-path #:allow-other-keys)
+ (invoke "go" "test"
+ "-tags" "llua" ; Latest Lua on Guix does not have a version number.
+ import-path)))
(add-after 'install 'wrap-program
(lambda* (#:key inputs outputs #:allow-other-keys)
(let ((out (assoc-ref outputs "out"))
--
2.19.1
P
P
Pierre Neidhardt wrote on 6 Nov 2018 09:37
[PATCH 8/8] gnu: go: Update default to 1.11.
(address . 33290@debbugs.gnu.org)
20181106173709.9883-7-mail@ambrevar.xyz
* gnu/packages/golang.scm (go): Update default to 1.11.
---
gnu/packages/golang.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 643ecda9f..77f854b55 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -528,7 +528,7 @@ in the style of communicating sequential processes (@dfn{CSP}).")
(setenv "GOGC" "400")
#t)))))))))
-(define-public go go-1.9)
+(define-public go go-1.11)
(define-public go-github-com-alsm-ioprogress
(let ((commit "063c3725f436e7fba0c8f588547bee21ffec7ac5")
--
2.19.1
P
P
Pierre Neidhardt wrote on 12 Nov 2018 01:32
control message for bug #33290
(address . control@debbugs.gnu.org)
87r2fqljxy.fsf@ambrevar.xyz
tags 33290 fixed
close 33290
?
Your comment

This issue is archived.

To comment on this conversation send an email to 33290@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 33290
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch