[PATCH 1/3] gnu: octave: Update to 4.4.0.

  • Done
  • quality assurance status badge
Details
4 participants
  • Jonathan Brielmaier
  • Kei Kebreau
  • Ludovic Courtès
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Kei Kebreau
Severity
normal

Debbugs page

K
K
Kei Kebreau wrote on 16 May 2018 16:10
(address . guix-patches@gnu.org)(name . Kei Kebreau)(address . kkebreau@posteo.net)
20180516231033.1680-1-kkebreau@posteo.net
* gnu/packages/maths.scm (octave): Update to 4.4.0.
---
gnu/packages/maths.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 2e6f79ad5..e9a6ceaab 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1323,7 +1323,7 @@ can solve two kinds of problems:
(define-public octave
(package
(name "octave")
- (version "4.2.2")
+ (version "4.4.0")
(source
(origin
(method url-fetch)
@@ -1331,7 +1331,7 @@ can solve two kinds of problems:
version ".tar.lz"))
(sha256
(base32
- "0pkkz1vazsh7ipffb09q0nc2jgx6q27pkkngygjij6jrpcly5zsp"))))
+ "0nm766737gbkq9wqry54a026k3dg7rb1065kngfpwgjz8b544xbp"))))
(build-system gnu-build-system)
(inputs
`(("lapack" ,lapack)
--
2.17.0
K
K
Kei Kebreau wrote on 16 May 2018 16:19
[PATCH 2/3] gnu: Add rxcpp.
(address . 31479@debbugs.gnu.org)(name . Kei Kebreau)(address . kkebreau@posteo.net)
20180516231957.1827-1-kkebreau@posteo.net
* gnu/packages/machine-learning.scm (rxcpp): New variable.
---
gnu/packages/machine-learning.scm | 42 +++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)

Toggle diff (62 lines)
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index f0d35484e..6536d861e 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -4,6 +4,7 @@
;;; Copyright © 2016, 2017 Marius Bakke <mbakke@fastmail.com>
;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Kei Kebreau <kkebreau@posteo.net>
;;; Copyright © 2018 Mark Meyer <mark@ofosos.org>
;;; Copyright © 2018 Ben Woodcroft <donttrustben@gmail.com>
;;; Copyright © 2018 Fis Trivial <ybbs.daans@hotmail.com>
@@ -501,6 +502,47 @@ tools. This enables both rapid prototyping of data pipelines and extensibility
in terms of new algorithms.")
(license license:gpl3+)))
+(define-public rxcpp
+ (package
+ (name "rxcpp")
+ (version "4.0.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/ReactiveX/RxCpp/archive/v"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "0y2isr8dy2n1yjr9c5570kpc9lvdlch6jv0jvw000amwn5d3krsh"))
+ (file-name (string-append name "-" version ".tar.gz"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'remove-werror
+ (lambda _
+ (substitute* (find-files ".")
+ (("-Werror") ""))
+ #t))
+ (replace 'check
+ (lambda _
+ (invoke "ctest"))))))
+ (native-inputs
+ `(("catch" ,catch-framework)))
+ (home-page "http://reactivex.io/")
+ (synopsis "Reactive Extensions for C++")
+ (description
+ "The Reactive Extensions for C++ (RxCpp) is a library of algorithms for
+values-distributed-in-time. ReactiveX is a library for composing asynchronous
+and event-based programs by using observable sequences.
+
+It extends the observer pattern to support sequences of data and/or events and
+adds operators that allow you to compose sequences together declaratively while
+abstracting away concerns about things like low-level threading,
+synchronization, thread-safety, concurrent data structures, and non-blocking
+I/O.")
+ (license license:asl2.0)))
+
(define-public r-adaptivesparsity
(package
(name "r-adaptivesparsity")
--
2.17.0
K
K
Kei Kebreau wrote on 16 May 2018 16:19
[PATCH 3/3] gnu: Update shogun to 6.1.3.
(address . 31479@debbugs.gnu.org)(name . Kei Kebreau)(address . kkebreau@posteo.net)
20180516231957.1827-2-kkebreau@posteo.net
* gnu/packages/machine-learning.scm (shogun): Update to 6.1.3.
[arguments]: Rewrite list of symlinks in 'delete-broken-symlinks' phase.
Rewrite file lists given to substitute* in 'change-R-target-path' and
'fix-octave-modules' phases. Add 'move-rxcpp' phase. Rewrite configure-flags
for the update.
[inputs]: Add eigen.
[native-inputs]: Add rxcpp.
---
gnu/packages/machine-learning.scm | 60 ++++++++++++++-----------------
1 file changed, 27 insertions(+), 33 deletions(-)

Toggle diff (127 lines)
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 6536d861e..e79aa6692 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -37,6 +37,7 @@
#:use-module (guix build-system r)
#:use-module (guix git-download)
#:use-module (gnu packages)
+ #:use-module (gnu packages algebra)
#:use-module (gnu packages autotools)
#:use-module (gnu packages boost)
#:use-module (gnu packages check)
@@ -367,7 +368,7 @@ sample proximities between pairs of cases.")
(define-public shogun
(package
(name "shogun")
- (version "4.0.0")
+ (version "6.1.3")
(source
(origin
(method url-fetch)
@@ -377,7 +378,7 @@ sample proximities between pairs of cases.")
"/sources/shogun-" version ".tar.bz2"))
(sha256
(base32
- "159nlijnb7mnrv9za80wnm1shwvy45hgrqzn51hxy7gw4z6d6fdb"))
+ "1rn9skm3nw6hr7mr3lgp2gfqhi7ii0lyxck7qmqnf8avq349s5jp"))
(modules '((guix build utils)
(ice-9 rdelim)))
(snippet
@@ -423,62 +424,54 @@ sample proximities between pairs of cases.")
"applications/easysvm/data"
"applications/msplicer/data"
"applications/ocr/data"
- "examples/documented/data"
- "examples/documented/matlab_static"
- "examples/documented/octave_static"
- "examples/undocumented/data"
- "examples/undocumented/matlab_static"
- "examples/undocumented/octave_static"
- "tests/integration/data"
- "tests/integration/matlab_static"
- "tests/integration/octave_static"
- "tests/integration/python_modular/tests"))
+ "examples/meta/data"
+ "examples/undocumented/data"))
#t))
(add-after 'unpack 'change-R-target-path
(lambda* (#:key outputs #:allow-other-keys)
- (substitute* '("src/interfaces/r_modular/CMakeLists.txt"
- "src/interfaces/r_static/CMakeLists.txt"
- "examples/undocumented/r_modular/CMakeLists.txt")
+ (substitute* '("src/interfaces/r/CMakeLists.txt"
+ "examples/meta/r/CMakeLists.txt")
(("\\$\\{R_COMPONENT_LIB_PATH\\}")
(string-append (assoc-ref outputs "out")
"/lib/R/library/")))
#t))
(add-after 'unpack 'fix-octave-modules
(lambda* (#:key outputs #:allow-other-keys)
- (substitute* '("src/interfaces/octave_modular/CMakeLists.txt"
- "src/interfaces/octave_static/CMakeLists.txt")
+ (substitute* "src/interfaces/octave/CMakeLists.txt"
(("^include_directories\\(\\$\\{OCTAVE_INCLUDE_DIRS\\}")
- "include_directories(${OCTAVE_INCLUDE_DIRS} ${OCTAVE_INCLUDE_DIRS}/octave"))
-
- ;; change target directory
- (substitute* "src/interfaces/octave_modular/CMakeLists.txt"
+ "include_directories(${OCTAVE_INCLUDE_DIRS} ${OCTAVE_INCLUDE_DIRS}/octave")
+ ;; change target directory
(("\\$\\{OCTAVE_OCT_LOCAL_API_FILE_DIR\\}")
(string-append (assoc-ref outputs "out")
"/share/octave/packages")))
#t))
+ (add-after 'unpack 'move-rxcpp
+ (lambda* (#:key inputs #:allow-other-keys)
+ (let ((rxcpp-dir "shogun/third-party/rxcpp"))
+ (mkdir-p rxcpp-dir)
+ (install-file (assoc-ref inputs "rxcpp") rxcpp-dir)
+ #t)))
(add-before 'build 'set-HOME
;; $HOME needs to be set at some point during the build phase
(lambda _ (setenv "HOME" "/tmp") #t)))
#:configure-flags
(list "-DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE"
"-DUSE_SVMLIGHT=OFF" ;disable proprietary SVMLIGHT
- ;;"-DJavaModular=ON" ;requires unpackaged jblas
- ;;"-DRubyModular=ON" ;requires unpackaged ruby-narray
- ;;"-DPerlModular=ON" ;"FindPerlLibs" does not exist
- ;;"-DLuaModular=ON" ;fails because lua doesn't build pkgconfig file
- "-DOctaveModular=ON"
- "-DOctaveStatic=ON"
- "-DPythonModular=ON"
- "-DPythonStatic=ON"
- "-DRModular=ON"
- "-DRStatic=ON"
- "-DCmdLineStatic=ON")))
+ "-DBUILD_META_EXAMPLES=OFF" ;requires unpackaged ctags
+ ;;"-DINTERFACE_JAVA=ON" ;requires unpackaged jblas
+ ;;"-DINTERFACE_RUBY=ON" ;requires unpackaged ruby-narray
+ ;;"-DINTERFACE_PERL=ON" ;"FindPerlLibs" does not exist
+ ;;"-DINTERFACE_LUA=ON" ;fails because lua doesn't build pkgconfig file
+ "-DINTERFACE_OCTAVE=ON"
+ "-DINTERFACE_PYTHON=ON"
+ "-DINTERFACE_R=ON")))
(inputs
`(("python" ,python)
("numpy" ,python-numpy)
("r-minimal" ,r-minimal)
("octave" ,octave)
("swig" ,swig)
+ ("eigen" ,eigen)
("hdf5" ,hdf5)
("atlas" ,atlas)
("arpack" ,arpack-ng)
@@ -488,7 +481,8 @@ sample proximities between pairs of cases.")
("lzo" ,lzo)
("zlib" ,zlib)))
(native-inputs
- `(("pkg-config" ,pkg-config)))
+ `(("pkg-config" ,pkg-config)
+ ("rxcpp" ,rxcpp)))
;; Non-portable SSE instructions are used so building fails on platforms
;; other than x86_64.
(supported-systems '("x86_64-linux"))
--
2.17.0
K
K
Kei Kebreau wrote on 16 May 2018 16:24
(address . 31479@debbugs.gnu.org)
874lj7w5f2.fsf@posteo.net
Kei Kebreau <kkebreau@posteo.net> writes:

Toggle quote (137 lines)
> * gnu/packages/machine-learning.scm (shogun): Update to 6.1.3.
> [arguments]: Rewrite list of symlinks in 'delete-broken-symlinks' phase.
> Rewrite file lists given to substitute* in 'change-R-target-path' and
> 'fix-octave-modules' phases. Add 'move-rxcpp' phase. Rewrite configure-flags
> for the update.
> [inputs]: Add eigen.
> [native-inputs]: Add rxcpp.
> ---
> gnu/packages/machine-learning.scm | 60 ++++++++++++++-----------------
> 1 file changed, 27 insertions(+), 33 deletions(-)
>
> diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
> index 6536d861e..e79aa6692 100644
> --- a/gnu/packages/machine-learning.scm
> +++ b/gnu/packages/machine-learning.scm
> @@ -37,6 +37,7 @@
> #:use-module (guix build-system r)
> #:use-module (guix git-download)
> #:use-module (gnu packages)
> + #:use-module (gnu packages algebra)
> #:use-module (gnu packages autotools)
> #:use-module (gnu packages boost)
> #:use-module (gnu packages check)
> @@ -367,7 +368,7 @@ sample proximities between pairs of cases.")
> (define-public shogun
> (package
> (name "shogun")
> - (version "4.0.0")
> + (version "6.1.3")
> (source
> (origin
> (method url-fetch)
> @@ -377,7 +378,7 @@ sample proximities between pairs of cases.")
> "/sources/shogun-" version ".tar.bz2"))
> (sha256
> (base32
> - "159nlijnb7mnrv9za80wnm1shwvy45hgrqzn51hxy7gw4z6d6fdb"))
> + "1rn9skm3nw6hr7mr3lgp2gfqhi7ii0lyxck7qmqnf8avq349s5jp"))
> (modules '((guix build utils)
> (ice-9 rdelim)))
> (snippet
> @@ -423,62 +424,54 @@ sample proximities between pairs of cases.")
> "applications/easysvm/data"
> "applications/msplicer/data"
> "applications/ocr/data"
> - "examples/documented/data"
> - "examples/documented/matlab_static"
> - "examples/documented/octave_static"
> - "examples/undocumented/data"
> - "examples/undocumented/matlab_static"
> - "examples/undocumented/octave_static"
> - "tests/integration/data"
> - "tests/integration/matlab_static"
> - "tests/integration/octave_static"
> - "tests/integration/python_modular/tests"))
> + "examples/meta/data"
> + "examples/undocumented/data"))
> #t))
> (add-after 'unpack 'change-R-target-path
> (lambda* (#:key outputs #:allow-other-keys)
> - (substitute* '("src/interfaces/r_modular/CMakeLists.txt"
> - "src/interfaces/r_static/CMakeLists.txt"
> - "examples/undocumented/r_modular/CMakeLists.txt")
> + (substitute* '("src/interfaces/r/CMakeLists.txt"
> + "examples/meta/r/CMakeLists.txt")
> (("\\$\\{R_COMPONENT_LIB_PATH\\}")
> (string-append (assoc-ref outputs "out")
> "/lib/R/library/")))
> #t))
> (add-after 'unpack 'fix-octave-modules
> (lambda* (#:key outputs #:allow-other-keys)
> - (substitute* '("src/interfaces/octave_modular/CMakeLists.txt"
> - "src/interfaces/octave_static/CMakeLists.txt")
> + (substitute* "src/interfaces/octave/CMakeLists.txt"
> (("^include_directories\\(\\$\\{OCTAVE_INCLUDE_DIRS\\}")
> - "include_directories(${OCTAVE_INCLUDE_DIRS} ${OCTAVE_INCLUDE_DIRS}/octave"))
> -
> - ;; change target directory
> - (substitute* "src/interfaces/octave_modular/CMakeLists.txt"
> + "include_directories(${OCTAVE_INCLUDE_DIRS} ${OCTAVE_INCLUDE_DIRS}/octave")
> + ;; change target directory
> (("\\$\\{OCTAVE_OCT_LOCAL_API_FILE_DIR\\}")
> (string-append (assoc-ref outputs "out")
> "/share/octave/packages")))
> #t))
> + (add-after 'unpack 'move-rxcpp
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((rxcpp-dir "shogun/third-party/rxcpp"))
> + (mkdir-p rxcpp-dir)
> + (install-file (assoc-ref inputs "rxcpp") rxcpp-dir)
> + #t)))
> (add-before 'build 'set-HOME
> ;; $HOME needs to be set at some point during the build phase
> (lambda _ (setenv "HOME" "/tmp") #t)))
> #:configure-flags
> (list "-DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE"
> "-DUSE_SVMLIGHT=OFF" ;disable proprietary SVMLIGHT
> - ;;"-DJavaModular=ON" ;requires unpackaged jblas
> - ;;"-DRubyModular=ON" ;requires unpackaged ruby-narray
> - ;;"-DPerlModular=ON" ;"FindPerlLibs" does not exist
> - ;;"-DLuaModular=ON" ;fails because lua doesn't build pkgconfig file
> - "-DOctaveModular=ON"
> - "-DOctaveStatic=ON"
> - "-DPythonModular=ON"
> - "-DPythonStatic=ON"
> - "-DRModular=ON"
> - "-DRStatic=ON"
> - "-DCmdLineStatic=ON")))
> + "-DBUILD_META_EXAMPLES=OFF" ;requires unpackaged ctags
> + ;;"-DINTERFACE_JAVA=ON" ;requires unpackaged jblas
> + ;;"-DINTERFACE_RUBY=ON" ;requires unpackaged ruby-narray
> + ;;"-DINTERFACE_PERL=ON" ;"FindPerlLibs" does not exist
> + ;;"-DINTERFACE_LUA=ON" ;fails because lua doesn't build pkgconfig file
> + "-DINTERFACE_OCTAVE=ON"
> + "-DINTERFACE_PYTHON=ON"
> + "-DINTERFACE_R=ON")))
> (inputs
> `(("python" ,python)
> ("numpy" ,python-numpy)
> ("r-minimal" ,r-minimal)
> ("octave" ,octave)
> ("swig" ,swig)
> + ("eigen" ,eigen)
> ("hdf5" ,hdf5)
> ("atlas" ,atlas)
> ("arpack" ,arpack-ng)
> @@ -488,7 +481,8 @@ sample proximities between pairs of cases.")
> ("lzo" ,lzo)
> ("zlib" ,zlib)))
> (native-inputs
> - `(("pkg-config" ,pkg-config)))
> + `(("pkg-config" ,pkg-config)
> + ("rxcpp" ,rxcpp)))
> ;; Non-portable SSE instructions are used so building fails on platforms
> ;; other than x86_64.
> (supported-systems '("x86_64-linux"))

These patches are really just to upgrade Octave, but the old Shogun
couldn't find the new version of Octave. The shogun update patch is a
WIP, but I don't have enough RAM (only 3.8GB) to make it through Shogun's
build process reliably. Could someone else help out with this patch?
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlr8vZEACgkQ5qXuPBlG
eg1QyQ//fLGrQuyCXRtG7w7kWz/Lc8J5bWNPbwR6X4uUCK6DlwxdiBe4sgZlzbgf
e7a5MBmazE5FSRV3YGnQiZOykHPBU3DzuZ45YgMIQO/2MBU7tgja52GZLUPtHEYc
uYUeoNs2OIF7PEV0iBaMNEQUElJUSlFWW/Jju8VJPKniSVy/FC53Jm6ZG0e9+oSX
Pqbo0fqfpSTlJQvSh3oG0f5it1JjC0Pmxd2J7B2/OE2rbU0tKbburPJkVXoTuvya
0SN1E/9rCBQGTisppyu/lklJ5DoC2R0l/+2sDSXHsAXP3MHw3XBLisJNQuimKYxL
z1EZtVvwL5UrVp1QtmyaAxESEWBcR/tsvtO4kg55354Ri3YaY63ZFvz/4WYMGT/t
VIXPDC4IvTq16zdi48rZcH5VMB9XtwLsuM2OaLGYdqVfbzxDHzlY2iieYAr/y6ic
qiLhyfsPB+Y0NhdkpV4jh8xkoQGcnnVh8mMK4M91Pgoedu8uYxpNhiPl9Lbkp8LC
v6wyT2lzHxfw/5Yy9NcZqMnrxdDJRvckFyPmoF6He37Sia0Kcylziw8ymcDrf1d0
CvUnu5t2f2TMdAIG4ihUGrw36W6QOMUx//io2NHJuegyZVixDzasFO0DjcLwF8dw
36P5FSZgU2oN03nW2ve1G4MPSC26zuBxvJq0wbJWHAYCIGb+ABg=
=NR03
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 17 May 2018 04:24
Re: [bug#31479] [PATCH 1/3] gnu: octave: Update to 4.4.0.
(name . Kei Kebreau)(address . kkebreau@posteo.net)(address . 31479@debbugs.gnu.org)
87h8n634pk.fsf@gnu.org
Kei Kebreau <kkebreau@posteo.net> skribis:

Toggle quote (2 lines)
> * gnu/packages/maths.scm (octave): Update to 4.4.0.

LGTM, thanks!

Ludo'.
L
L
Ludovic Courtès wrote on 17 May 2018 04:26
Re: [bug#31479] [PATCH 2/3] gnu: Add rxcpp.
(name . Kei Kebreau)(address . kkebreau@posteo.net)(address . 31479@debbugs.gnu.org)
87d0xu34mu.fsf@gnu.org
Kei Kebreau <kkebreau@posteo.net> skribis:

Toggle quote (2 lines)
> * gnu/packages/machine-learning.scm (rxcpp): New variable.

[...]

Toggle quote (7 lines)
> + (home-page "http://reactivex.io/")
> + (synopsis "Reactive Extensions for C++")
> + (description
> + "The Reactive Extensions for C++ (RxCpp) is a library of algorithms for
> +values-distributed-in-time. ReactiveX is a library for composing asynchronous
> +and event-based programs by using observable sequences.

LGTM!

Probably machine-learning.scm is not the best place for it, but I can’t
think of a better place.

Thanks,
Ludo’.
J
J
Jonathan Brielmaier wrote on 17 May 2018 04:39
Re: [bug#31479] [PATCH 3/3] gnu: Update shogun to 6.1.3.
(address . guix-patches@gnu.org)
0ccd42b9-0856-0b45-c85b-a792d3b38ab4@web.de
On 17/05/2018 01:24, Kei Kebreau wrote:
Toggle quote (7 lines)
>
> These patches are really just to upgrade Octave, but the old Shogun
> couldn't find the new version of Octave. The shogun update patch is a
> WIP, but I don't have enough RAM (only 3.8GB) to make it through Shogun's
> build process reliably. Could someone else help out with this patch?
>

I build shogun now, lets see how it goes :)
J
J
Jonathan Brielmaier wrote on 17 May 2018 22:58
(address . guix-patches@gnu.org)
0e99a56a-bfb8-5c53-2408-9f202a116eb1@web.de
On 17/05/2018 13:39, Jonathan Brielmaier wrote:
Toggle quote (10 lines)
> On 17/05/2018 01:24, Kei Kebreau wrote:
>>
>> These patches are really just to upgrade Octave, but the old Shogun
>> couldn't find the new version of Octave. The shogun update patch is a
>> WIP, but I don't have enough RAM (only 3.8GB) to make it through Shogun's
>> build process reliably. Could someone else help out with this patch?
>>
>
> I build shogun now, lets see how it goes :)

Unfortunately there was a build error for shogun. I attached the build
log where it fails. It has something to do with the eigen library...
$ /pre-inst-env guix build shogun
[...]
[ 50%] Building CXX object src/shogun/CMakeFiles/libshogun.dir/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp.o
cd /tmp/guix-build-shogun-6.1.3.drv-0/build/src/shogun && /gnu/store/cfdn69spjc44x4sd0acrwhxq6yay3rbc-gcc-5.5.0/bin/c++ -I/tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src -I/tmp/guix-build-shogun-6.1.3.drv-0/build/src -I/tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src/gpl -isystem /gnu/store/iwzn3vhwmzkvhq7sqs6c4bjp2xld17kc-eigen-3.3.4/include/eigen3 -isystem /gnu/store/5s9am1dgn83wj5q5kwfcasqws8zd85zz-rxcpp-4.0.0 -I/gnu/store/mllyvfy39npzra984jsmcm8ksn3x8094-glpk-4.65/include -I/gnu/store/wnw0gv5hgmhlw3jz1pgw4n017bhj9f2z-arpack-ng-3.5.0/lib/../include -I/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/include/libxml2 -I/gnu/store/27jrvwbg5xa9la6jwnqz6ys4k7pfyykl-hdf5-1.8.19/include -I/gnu/store/9hd38bkw8bq8gq6lcv6vd8xjpcsbyzlm-zlib-1.2.11/include -I/gnu/store/77l8sxh9py133cy1p9kypshji4q9wv0w-bzip2-1.0.6/include -I/gnu/store/kgaf671a9a76k0ql1pwwjxjbj80x22mj-xz-5.2.3/include -I/gnu/store/33m86ycak50vh2p0q7qb0byh990hrkjn-lzo-2.10/include -Wall -Wno-unused-parameter -Wformat -Wformat-security -Wparentheses -Wshadow -Wno-unknown-pragmas -Wno-deprecated -O2 -g -DNDEBUG -fPIC -fopenmp -std=c++11 -o CMakeFiles/libshogun.dir/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp.o -c /tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src/shogun/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp
/tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src/shogun/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp:15:45: fatal error: unsupported/Eigen/MatrixFunctions: No such file or directory
compilation terminated.
make[2]: *** [src/shogun/CMakeFiles/libshogun.dir/build.make:11456: src/shogun/CMakeFiles/libshogun.dir/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/tmp/guix-build-shogun-6.1.3.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:126: src/shogun/CMakeFiles/libshogun.dir/all] Error 2
make[1]: Leaving directory '/tmp/guix-build-shogun-6.1.3.drv-0/build'
make: *** [Makefile:153: all] Error 2
phase `build' failed after 493.7 seconds
builder for `/gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv' failed with exit code 1
@ build-failed /gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv - 1 builder for `/gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv' failed with exit code 1
guix build: error: build failed: build of `/gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv' failed
K
K
Kei Kebreau wrote on 18 May 2018 10:08
(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)(address . 31479@debbugs.gnu.org)
87muww6gd2.fsf@posteo.net
Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:

Toggle quote (33 lines)
> On 17/05/2018 13:39, Jonathan Brielmaier wrote:
>> On 17/05/2018 01:24, Kei Kebreau wrote:
>>>
>>> These patches are really just to upgrade Octave, but the old Shogun
>>> couldn't find the new version of Octave. The shogun update patch is a
>>> WIP, but I don't have enough RAM (only 3.8GB) to make it through Shogun's
>>> build process reliably. Could someone else help out with this patch?
>>>
>>
>> I build shogun now, lets see how it goes :)
>
> Unfortunately there was a build error for shogun. I attached the build
> log where it fails. It has something to do with the eigen library...
>
>
>
> $ /pre-inst-env guix build shogun
> [...]
> [ 50%] Building CXX object src/shogun/CMakeFiles/libshogun.dir/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp.o
> cd /tmp/guix-build-shogun-6.1.3.drv-0/build/src/shogun && /gnu/store/cfdn69spjc44x4sd0acrwhxq6yay3rbc-gcc-5.5.0/bin/c++ -I/tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src -I/tmp/guix-build-shogun-6.1.3.drv-0/build/src -I/tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src/gpl -isystem /gnu/store/iwzn3vhwmzkvhq7sqs6c4bjp2xld17kc-eigen-3.3.4/include/eigen3 -isystem /gnu/store/5s9am1dgn83wj5q5kwfcasqws8zd85zz-rxcpp-4.0.0 -I/gnu/store/mllyvfy39npzra984jsmcm8ksn3x8094-glpk-4.65/include -I/gnu/store/wnw0gv5hgmhlw3jz1pgw4n017bhj9f2z-arpack-ng-3.5.0/lib/../include -I/gnu/store/mv9m6bxdhijhlfvxpja3km6v599b4pv5-libxml2-2.9.7/include/libxml2 -I/gnu/store/27jrvwbg5xa9la6jwnqz6ys4k7pfyykl-hdf5-1.8.19/include -I/gnu/store/9hd38bkw8bq8gq6lcv6vd8xjpcsbyzlm-zlib-1.2.11/include -I/gnu/store/77l8sxh9py133cy1p9kypshji4q9wv0w-bzip2-1.0.6/include -I/gnu/store/kgaf671a9a76k0ql1pwwjxjbj80x22mj-xz-5.2.3/include -I/gnu/store/33m86ycak50vh2p0q7qb0byh990hrkjn-lzo-2.10/include -Wall -Wno-unused-parameter -Wformat -Wformat-security -Wparentheses -Wshadow -Wno-unknown-pragmas -Wno-deprecated -O2 -g -DNDEBUG -fPIC -fopenmp -std=c++11 -o CMakeFiles/libshogun.dir/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp.o -c /tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src/shogun/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp
> /tmp/guix-build-shogun-6.1.3.drv-0/shogun-6.1.3/src/shogun/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp:15:45: fatal error: unsupported/Eigen/MatrixFunctions: No such file or directory
> compilation terminated.
> make[2]: *** [src/shogun/CMakeFiles/libshogun.dir/build.make:11456: src/shogun/CMakeFiles/libshogun.dir/mathematics/linalg/ratapprox/logdet/opfunc/DenseMatrixExactLog.cpp.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[2]: Leaving directory '/tmp/guix-build-shogun-6.1.3.drv-0/build'
> make[1]: *** [CMakeFiles/Makefile2:126: src/shogun/CMakeFiles/libshogun.dir/all] Error 2
> make[1]: Leaving directory '/tmp/guix-build-shogun-6.1.3.drv-0/build'
> make: *** [Makefile:153: all] Error 2
> phase `build' failed after 493.7 seconds
> builder for `/gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv' failed with exit code 1
> @ build-failed /gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv - 1 builder for `/gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv' failed with exit code 1
> guix build: error: build failed: build of `/gnu/store/mjnmhzdx6zmwcvspmljsrjw2aazfvnv7-shogun-6.1.3.drv' failed

So it turns out that Eigen's source code comes with some functions that
are officially unsupported by the developers but still available for
use. Guix just doesn't install them. I've attached a patch that *should*
properly install the unsupported files to Eigen's include path.

Also, thanks for helping with this shogun patch!
From eed3dcce3714bc16ccb378d261d9e1bd8db3c249 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kkebreau@posteo.net>
Date: Fri, 18 May 2018 12:46:57 -0400
Subject: [PATCH 3/4] gnu: eigen: Install unsupported header files.

* gnu/packages/algebra.scm (eigen)[arguments]: Add 'install-unsupported' phase.
Use invoke instead of system*.
---
gnu/packages/algebra.scm | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

Toggle diff (35 lines)
diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index 03a61be47..51be58ee2 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -750,6 +750,14 @@ Sine Transform} (DST) and @dfn{Discrete Hartley Transform} (DHT).")
#:build-type "Release"
#:phases (modify-phases %standard-phases
+ (add-after 'install 'install-unsupported
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (include (string-append out "/include/eigen3")))
+ (copy-recursively "unsupported"
+ (string-append include
+ "/unsupported"))
+ #t)))
(replace 'check
(lambda _
(let* ((cores (parallel-job-count))
@@ -757,11 +765,11 @@ Sine Transform} (DST) and @dfn{Discrete Hartley Transform} (DHT).")
(setenv "EIGEN_SEED" "1") ;for reproducibility
;; First build the tests, in parallel. See
;; <http://eigen.tuxfamily.org/index.php?title=Tests>.
- (and (zero? (system* "make" "buildtests" dash-j))
+ (and (invoke "make" "buildtests" dash-j)
;; Then run 'CTest' with -V so we get more
;; details upon failure.
- (zero? (system* "ctest" "-V" dash-j)))))))))
+ (invoke "ctest" "-V" dash-j))))))))
(home-page "http://eigen.tuxfamily.org")
(synopsis "C++ template library for linear algebra")
(description
--
2.17.0
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlr/CKoACgkQ5qXuPBlG
eg2V7RAAmVC+dENQkqavr41b3GDjdkFiA2hqaphm8st2mG6KphgnlXbTHM8x7MIB
vnvo+PIKoRRZu9pieGY9pYVQxkaByRM+SaLw9ip4dc8aJ8bCmYJbYCUzsmdFM9Qx
MdOXc7wGm/jnbsxMmiiWicfEXm2ZCm7pAYIBgjJomy2YPFJoId3F64YhBYmLNyzg
U1S3JGMjtaZzVDK1Oyl88OscQJwKgM0RPLFwvXHP8WzVvSPLM7OoKRGAtR8nK6fB
hVc7LwAMVqYCtN1VPaeEbeAWnVMMjinFwlETsXRfWrHbUkrWjP0er3VyEK+oQWef
rc1Z3RbElhgakSt8g3gFq//JH4Sfl0WiKvf7szk9XGcqAp7fsLGQ6Ny6NxAu8Z4D
vFfO6XPrPkkStL2yAN83vqFQrzoLho79VxfZ2KAUJePjXXYmqnJR1k2KJ9ZRfP2/
oLqrHfkw1EIdZydRlUzf3qGpJ2EW6tS0BLOj6tHqxNQHr1i8cWoCXee4WVlgTtno
OCmgIy/ro4KNv8ftYH13Tp99RiR78i6LJNuXyJldt5C1M/ri6V+mUzHPl9p5NSbd
MF+Hmf7YNXjB1K2jcP8Tx49ghUnOUcL/vNx4XDEn8rYOkvZWVdkV4Pgjoo8Kp2Ks
Ov+msIBtLaCqjSZJnsmK9avmTxau4xr+tmgK2WLOSCXImsVruPI=
=D7iJ
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 19 May 2018 13:18
(name . Kei Kebreau)(address . kkebreau@posteo.net)
87fu2npfgl.fsf@gnu.org
Hello,

Kei Kebreau <kkebreau@posteo.net> skribis:

Toggle quote (5 lines)
> So it turns out that Eigen's source code comes with some functions that
> are officially unsupported by the developers but still available for
> use. Guix just doesn't install them. I've attached a patch that *should*
> properly install the unsupported files to Eigen's include path.

Ricardo has a similar patch in the Tensorflow series:


Could the two of you see how the two patches should be merged? :-)

Thanks,
Ludo’.
K
K
Kei Kebreau wrote on 20 May 2018 11:31
(name . Ludovic Courtès)(address . ludo@gnu.org)
87h8n25gbv.fsf@posteo.net
ludo@gnu.org (Ludovic Courtès) writes:

Toggle quote (18 lines)
> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> So it turns out that Eigen's source code comes with some functions that
>> are officially unsupported by the developers but still available for
>> use. Guix just doesn't install them. I've attached a patch that *should*
>> properly install the unsupported files to Eigen's include path.
>
> Ricardo has a similar patch in the Tensorflow series:
>
> https://bugs.gnu.org/31386
>
> Could the two of you see how the two patches should be merged? :-)
>
> Thanks,
> Ludo’.

Hi,

Thanks for the heads up! Looking at Ricardo's patch, it looks like the
same goal is accomplished in a cleaner fashion. I'll test it today and
report back results. I've been working on shogun during the past few
days and it may soon be finished.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlsBvxUACgkQ5qXuPBlG
eg29kQ//fTcqbia8NUMLQiEM2Qz8LxwFQotOdpDTsFWGRXnDr5ErL/VSaTrYLgqt
mW4vuFOYLrcKqpHoPOLEz5TrTnBVgX0yptd2AnfwuLoHRXU+Owf9zvcdrRi275tK
CGFSPM43v2AZHspCkODZPUk25tSHAFuSEMOQi3XnVRGs9S3S0xFqo+9+Ej3rQaxu
5tKwDo84K8YE5aCJln/KzvV9i0AtJQLDmNbGaZ/Xz+B6ni7T1EpnDjW8r1VKMdwU
EyPZEaF6fBeFiEKittDH8akT5p4YmitXyZLQQuqfXk3acSypSdhXfEDeBLyXp07s
15E4yFBEAq4exFMxvhQdrtqi2m2MrLXVjRWYNG/0RYmIxylMTeaW9HRHLWsKUJz5
5JareUfcbzdEfyy4Cv9XkVclUGe9wEwGc07jBevafq5oEx7OiqkEwe8sWLzNFDup
Ox+l3Abt1Scxl3GaR+RzebKNgwl/JLjKvHZks9r1Hm0iHDKxF2fh0mfKd9avyvP1
84Z6btBp/8sil0yxm8Pq/DF4LYaKriErMXfgmPw/5l/1G4emwkFrQFEo+9woSwga
5tGfjWy6vcVW9fRfpG0g5WMXqDGK0bnfKJD+Vprg8d4aLrcShNrVQrn1GFr8Liyn
o3makzJSu1WFMU4JR7flzVEY/QBWy7uHTNTklJF6bB0DtVOUQ7s=
=p2Pj
-----END PGP SIGNATURE-----

R
R
Ricardo Wurmus wrote on 24 May 2018 02:09
(name . Kei Kebreau)(address . kkebreau@posteo.net)(address . 31479@debbugs.gnu.org)
87a7spcte2.fsf@mdc-berlin.de
Hi Kei,

please also note that Shogun contains references to proprietary
software. It has support for SVMLight, which is non-free software. It
includes a script to remove all references to and adapters for SVMLight,
but unfortunately we cannot run shell scripts in a snippet. Changing
this requires changing the “package” syntax to delay evaluation more.

Until then we need to remove the non-free bits in code, which is what
the current snippet does, but the code would need to be adjusted for
version 6.1.3.

Thanks for taking this on!

--
Ricardo
K
K
Kei Kebreau wrote on 26 May 2018 18:21
(name . Ricardo Wurmus)(address . ricardo.wurmus@mdc-berlin.de)
87po1hnba0.fsf@posteo.net
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

Toggle quote (17 lines)
> Hi Kei,
>
> please also note that Shogun contains references to proprietary
> software. It has support for SVMLight, which is non-free software. It
> includes a script to remove all references to and adapters for SVMLight,
> but unfortunately we cannot run shell scripts in a snippet. Changing
> this requires changing the “package” syntax to delay evaluation more.
>
> Until then we need to remove the non-free bits in code, which is what
> the current snippet does, but the code would need to be adjusted for
> version 6.1.3.
>
> Thanks for taking this on!
>
> --
> Ricardo

Thank you for the tip!

I've attached the four patches that make it possible to build Shogun
6.1.3 successfully, and I'm just looking through the source code to
remove the proprietary bits.

P.S. Ricardo, you'll notice the eigen patch is actually yours from
another patchset! I verified that it works as expected.
From 0243faa33cc2c33ed7160ab754ad45ceff626eb2 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kkebreau@posteo.net>
Date: Sat, 5 May 2018 10:21:38 -0400
Subject: [PATCH 1/5] gnu: octave: Update to 4.4.0.

* gnu/packages/maths.scm (octave): Update to 4.4.0.
---
gnu/packages/maths.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index a36d2333e..97f847665 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1332,7 +1332,7 @@ can solve two kinds of problems:
(define-public octave
(package
(name "octave")
- (version "4.2.2")
+ (version "4.4.0")
(source
(origin
(method url-fetch)
@@ -1340,7 +1340,7 @@ can solve two kinds of problems:
version ".tar.lz"))
(sha256
(base32
- "0pkkz1vazsh7ipffb09q0nc2jgx6q27pkkngygjij6jrpcly5zsp"))))
+ "0nm766737gbkq9wqry54a026k3dg7rb1065kngfpwgjz8b544xbp"))))
(build-system gnu-build-system)
(inputs
`(("lapack" ,lapack)
--
2.17.0
From 50b6630e06f434237c1014765444d01a38f40e61 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kkebreau@posteo.net>
Date: Wed, 9 May 2018 10:01:40 -0400
Subject: [PATCH 2/5] gnu: Add rxcpp.

* gnu/packages/machine-learning.scm (rxcpp): New variable.
---
gnu/packages/machine-learning.scm | 42 +++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)

Toggle diff (62 lines)
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index f0d35484e..6536d861e 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -4,6 +4,7 @@
;;; Copyright © 2016, 2017 Marius Bakke <mbakke@fastmail.com>
;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Kei Kebreau <kkebreau@posteo.net>
;;; Copyright © 2018 Mark Meyer <mark@ofosos.org>
;;; Copyright © 2018 Ben Woodcroft <donttrustben@gmail.com>
;;; Copyright © 2018 Fis Trivial <ybbs.daans@hotmail.com>
@@ -501,6 +502,47 @@ tools. This enables both rapid prototyping of data pipelines and extensibility
in terms of new algorithms.")
(license license:gpl3+)))
+(define-public rxcpp
+ (package
+ (name "rxcpp")
+ (version "4.0.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/ReactiveX/RxCpp/archive/v"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "0y2isr8dy2n1yjr9c5570kpc9lvdlch6jv0jvw000amwn5d3krsh"))
+ (file-name (string-append name "-" version ".tar.gz"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'remove-werror
+ (lambda _
+ (substitute* (find-files ".")
+ (("-Werror") ""))
+ #t))
+ (replace 'check
+ (lambda _
+ (invoke "ctest"))))))
+ (native-inputs
+ `(("catch" ,catch-framework)))
+ (home-page "http://reactivex.io/")
+ (synopsis "Reactive Extensions for C++")
+ (description
+ "The Reactive Extensions for C++ (RxCpp) is a library of algorithms for
+values-distributed-in-time. ReactiveX is a library for composing asynchronous
+and event-based programs by using observable sequences.
+
+It extends the observer pattern to support sequences of data and/or events and
+adds operators that allow you to compose sequences together declaratively while
+abstracting away concerns about things like low-level threading,
+synchronization, thread-safety, concurrent data structures, and non-blocking
+I/O.")
+ (license license:asl2.0)))
+
(define-public r-adaptivesparsity
(package
(name "r-adaptivesparsity")
--
2.17.0
From 593edb81de8b6ad064d388aa39896ef8667e06bd Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus at>
Date: Tue, 8 May 2018 16:59:07 +0200
Subject: [PATCH 3/5] gnu: eigen: Include unsupported features.

* gnu/packages/algebra.scm (eigen)[source]: Do not build the tests for
unsupported features, but include the files.

Signed-off-by: Kei Kebreau <kkebreau@posteo.net>
---
gnu/packages/algebra.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index 210b734b9..ff8478c50 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -732,9 +732,10 @@ Sine Transform} (DST) and @dfn{Discrete Hartley Transform} (DHT).")
;; but maintainers say it's a known issue and it's unsupported
;; anyway, so just skip them.
'(begin
+ (substitute* "unsupported/CMakeLists.txt"
+ (("add_subdirectory\\(test.*")
+ "# Do not build the tests for unsupported features.\n"))
(substitute* "CMakeLists.txt"
- (("add_subdirectory\\(unsupported\\)")
- "# Do not build the tests for unsupported features.\n")
;; Work around
;; <http://eigen.tuxfamily.org/bz/show_bug.cgi?id=1114>.
(("\"include/eigen3\"")
--
2.17.0
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlsKCCcACgkQ5qXuPBlG
eg3OeA//f+i6/J61ZaI2Me3kRqRp973nnM5hUkSLitdNinqA/pLUEWqB2+NeSysm
h+32d32eZInx+KIEtg2x+isxSGln8I0l2N+CbhHKhWQyXtC7deaXjqlCP9gMhxUT
BUSWVe325M+3AS7nlw2Q0S8yo/zXGu86o7cbYd6I0uqSsU+KfuACIuVEmvPlFP1g
8mKEolhLyEsULp+Ag0cXxTYEKihCfXtlBEH1TbtikB3UmfZylouFerYk4TcfFfZE
2DLTH1GH6rWKwuG/BXBV0Za5cICL81tes7EsiV0WvKQj5vgP7gIBoG7L2nv4hCaG
wUsHeZAbDMqfS2gs0wh8F+qiXz8cDjABJGQJG6lDPgTZSs11Rp0JCU88y94/R9uL
8RwKM0wPIBWUMqkl8HHfmSp3yjq8vdnR0OH4EgVyI2DYEtoDcJOiTvLm+CEyx/zU
oULp59qnkIz+8sZCEFWmzjh8knyRvGK3Dr4p4tImihsz//dN6WCi9nIPXF54Rl3m
fC9cQV39iVKgviI+wBtyMD6x2B4+HyeOdy+DE/ruonswYfJ/ZqMPFSEzk6vhuhMZ
3yJQhNhFRrBzuy4n/g/WFYZ9aqNF0FfGvp8mJF7iJQd//76jvIb1IqjxDnFWMZ/r
wKgw8rsTNCjG/OqkvCdUlAy1ZU5ApukPOn0cpUhPfIIVDUsEsxQ=
=YbBO
-----END PGP SIGNATURE-----

K
K
Kei Kebreau wrote on 29 May 2018 13:55
(name . Ricardo Wurmus)(address . ricardo.wurmus@mdc-berlin.de)
87h8mqkwq0.fsf@posteo.net
Kei Kebreau <kkebreau@posteo.net> writes:

Toggle quote (28 lines)
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> Hi Kei,
>>
>> please also note that Shogun contains references to proprietary
>> software. It has support for SVMLight, which is non-free software. It
>> includes a script to remove all references to and adapters for SVMLight,
>> but unfortunately we cannot run shell scripts in a snippet. Changing
>> this requires changing the “package” syntax to delay evaluation more.
>>
>> Until then we need to remove the non-free bits in code, which is what
>> the current snippet does, but the code would need to be adjusted for
>> version 6.1.3.
>>
>> Thanks for taking this on!
>>
>> --
>> Ricardo
>
> Thank you for the tip!
>
> I've attached the four patches that make it possible to build Shogun
> 6.1.3 successfully, and I'm just looking through the source code to
> remove the proprietary bits.
>
> P.S. Ricardo, you'll notice the eigen patch is actually yours from
> another patchset! I verified that it works as expected.

The shogun patch below builds successfully for me! If no corrections
need to be made, I'll push this patch series to master!
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlsNvlcACgkQ5qXuPBlG
eg1rZw//bm2jCNudExPJf4j72lym63blW+GCX7HapP/AyaNxqYjTi3JEtrHulYWv
y45nTFFLJb9NtQ1BJTIrTxYTDn8/9GEqseSrrQ6ucqpdcCsxrACKOA95HNv/tSAd
Kr4zOouBXsJtYt+VpCsdKl4vhKeTZREZIjpdvbTmuujY+v2GKgJ/UWYr0mwZK8Ly
70SrA5IRpzMbqb4Frx5ccpKGLERBakt7Cgjc2xLeDIpmRFJw82i6rv7+4NgWO6QT
stEyCd5d30fZ+X4Ew/DxphBIHlgEtBO6IcFsN+eKQMYKLTVV1vo/QF0YCyUrr+Co
U61Z9g4KRB4sarMGOMOg60lwPdLGl8MR6SFA3yPKuoTabaWgC5/y9nu0/vw66Ike
gujm9dxftRMZ8jZzLUbICt0KS3NN5W3ZxwVxeZFGs4pGfGGALU06uB9aSmSSYCQR
VeEy0/QNpi1dwbtPTOFcwEkuZ8sFGKznC3WqobEsTsSR/LpWavtpojE8zOd09Jly
DCgaSWo1mVjQY62I4UTiGNaBLGddkwWpK0b55XAnlFY9Hs4fX5uzpGCTOUd/saaI
f6XClyn96PybbO2INSm6ym6cpYKbokvZUErYzvA8FBhwG1+x4Vz6c+EgtBMA6lMy
TBttoZZpjDf84ge3KZpNk5cdy8i++zNOfiQ5QpejRDRWe0G8/Zs=
=gd9t
-----END PGP SIGNATURE-----

R
R
Ricardo Wurmus wrote on 29 May 2018 14:32
(name . Kei Kebreau)(address . kkebreau@posteo.net)
878t82qhai.fsf@mdc-berlin.de
Kei Kebreau <kkebreau@posteo.net> writes:
Toggle quote (3 lines)
> The shogun patch below builds successfully for me! If no corrections
> need to be made, I'll push this patch series to master!

Beautiful! This looks good to me.

Thank you for making the extra effort even though you just wanted to
update Octave!

--
Ricardo
K
K
Kei Kebreau wrote on 29 May 2018 15:34
(name . Ricardo Wurmus)(address . ricardo.wurmus@mdc-berlin.de)
87d0xeks4x.fsf@posteo.net
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

Toggle quote (9 lines)
> Kei Kebreau <kkebreau@posteo.net> writes:
>> The shogun patch below builds successfully for me! If no corrections
>> need to be made, I'll push this patch series to master!
>
> Beautiful! This looks good to me.
>
> Thank you for making the extra effort even though you just wanted to
> update Octave!

Packaging things like this makes for a great puzzle, and I love puzzles.

Pushed to master! Thanks to everyone involved in the review!
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlsN1Y4ACgkQ5qXuPBlG
eg3L7xAAszaV7MY10bENzYWccoqdRiscIAdp+iELRuyEZaN/GSnEnfGMXYlaZDp5
eL7e7u0K727Ntm8fevfMoER68X20dgWo4LcckVz5S56kb8G4AY2K6Njk78Ar3h5Q
qp4MNNaSjMt/9V+7+0BUFpY8oKLpnJrOJI0yF8aGKBZMV+6cVMqs2Yg8Mxh7UvWs
uW3RrJr03vdUkFr8/jlF17ryhAS/4KylSFFW3mFcrukfnctotpSrVoBzDhHKcaJi
ylXAtkLlA2BExbNrAreVQ4A1ZhBOmwGcEsSBgvGuyAwphtOXvfjK6j9e5aum+J3k
7aPXrshuq5DIMvnnZvsVXudgd/kFVuHjQZOfHo80A4nyuirMhYD05CB5uRy8Of7r
LfAL402kouuhwH8s85l8iokyCHMaNru85oVTRP4aK/FhoQ3knFLdkYyYplUgFr0C
lDAFb7r0WiDwUtBaGoPAhqcZpDc3kHYH1iYuFWzfcqWNRX2+F1Iv5i3xdaM8pZmH
P/hp7nQs7jDUB07cWEFNog+sNiZtxsrBa7q4deht9NmPGudAR35svbhHTIegt/Kt
eqV/kpkaLjV2b4aUtcp+cgB0YGZEduVEJ6plYHuGUkL3bvCT0/ezMijeU67RnJ1Z
0tmteqd+AJ2oEdCMSnQXxY93zAjITERdBkDRb+0iWi+O0rrVxAI=
=ptLd
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 31 May 2018 08:41
control message for bug #31479
(address . control@debbugs.gnu.org)
876033omru.fsf@gnu.org
tags 31479 fixed
close 31479
?
Your comment

This issue is archived.

To comment on this conversation send an email to 31479@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 31479
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch