[PATCH] Add cloud-foundry-cli.

Open

Details

2 participants

Christopher Baines
Marius Bakke

Owner: unassigned

Submitted by: Christopher Baines

Severity: normal

Debbugs page

Christopher Baines wrote on 24 Mar 2018 08:05

Recipients:(address . guix-patches@gnu.org)

Message-ID:87vadl344t.fsf@cbaines.net

Tags: moreinfo

I had a need to use the cloud-foundry-cli recently, so I made a Guix

package. Unfortunately even though this builds, it needs a bit more work

to strip out the third party source code, and package this separately.

Christopher Baines (1):

gnu: Add cloud-foundry-cli.

gnu/packages/cloud-foundry.scm | 61 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 61 insertions(+)

create mode 100644 gnu/packages/cloud-foundry.scm

Christopher Baines wrote on 24 Mar 2018 09:04

[PATCH] gnu: Add cloud-foundry-cli.

Recipients:(address . 30924@debbugs.gnu.org)

Message-ID:20180324160404.1759-1-mail@cbaines.net

* gnu/packages/cloud-foundry.scm: New file.
---
 gnu/packages/cloud-foundry.scm | 61 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)
 create mode 100644 gnu/packages/cloud-foundry.scm

Toggle diff (69 lines)diff --git a/gnu/packages/cloud-foundry.scm b/gnu/packages/cloud-foundry.scm
new file mode 100644
index 000000000..b1327a6dc
--- /dev/null
+++ b/gnu/packages/cloud-foundry.scm
@@ -0,0 +1,61 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2018 Christopher Baines <mail@cbaines.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages cloud-foundry)
+  #:use-module (guix build-system go)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix git-download)
+  #:use-module (guix licenses))
+
+(define-public cloud-foundry-cli
+  (package
+    (name "cloud-foundry-cli")
+    (version "6.34.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/cloudfoundry/cli.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "1kq6d0sysi4r7wz9zjgbyj7m5a4lkybgj8a91q1vxs7r44yns8y6"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "code.cloudfoundry.org/cli"
+       #:phases
+       (modify-phases %standard-phases
+         ;; This should be redundant once the vendor directory is removed from
+         ;; this package
+         (add-before 'reset-gzip-timestamps 'remove-readonly-gzip-files
+           (lambda* (#:key outputs #:allow-other-keys)
+             (for-each delete-file
+                       (find-files
+                        (assoc-ref outputs "out")
+                        ".*\\.gz"))))
+         (add-after 'install 'rename-binary
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (rename-file (string-append out "/bin/cli")
+                            (string-append out "/bin/cf"))))))))
+    (synopsis "Client for the Cloud Foundry application platform")
+    (description
+     "This package contains the official command line client for Cloud Foundry
+application platform.")
+    (home-page "https://github.com/cloudfoundry/cli")
+    (license asl2.0)))
-- 
2.16.2

Marius Bakke wrote on 26 Mar 2018 10:55

Recipients:

Message-ID:87zi2uiuvp.fsf@fastmail.com

Christopher Baines <mail@cbaines.net> writes:

Toggle quote (2 lines)

> * gnu/packages/cloud-foundry.scm: New file.

[...]

Toggle quote (14 lines)> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "code.cloudfoundry.org/cli"
> +       #:phases
> +       (modify-phases %standard-phases
> +         ;; This should be redundant once the vendor directory is removed from
> +         ;; this package
> +         (add-before 'reset-gzip-timestamps 'remove-readonly-gzip-files
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (for-each delete-file
> +                       (find-files
> +                        (assoc-ref outputs "out")
> +                        ".*\\.gz"))))

'for-each' has an unspecified return value, so please add #t here.

Toggle quote (6 lines)

> + (add-after 'install 'rename-binary

> + (lambda* (#:key outputs #:allow-other-keys)

> + (let ((out (assoc-ref outputs "out")))

> + (rename-file (string-append out "/bin/cli")

> + (string-append out "/bin/cf"))))))))

Ditto for 'rename-file'.

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 30924@patchwise.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 30924

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date